61583 2011-05-26 16:46:09 -0700 [chromium] drop unused WebFrame parameter to WebStorageArea::setItem 2011-05-27 11:11:45 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jochen jochen commit-queue fishd jam oldest_to_newest 411001 0 jochen 2011-05-26 16:46:09 -0700 [chromium] drop unused WebFrame parameter to WebStorageArea::setItem 411003 1 95076 jochen 2011-05-26 16:46:30 -0700 Created attachment 95076 Patch 411025 2 jochen 2011-05-26 17:06:16 -0700 This is pending http://codereview.chromium.org/7074022/ 411553 3 commit-queue 2011-05-27 11:10:17 -0700 The commit-queue encountered the following flaky tests while processing attachment 95076: http/tests/websocket/tests/url-with-credential.html bug 61650 (author: abarth@webkit.org) The commit-queue is continuing to process your patch. 411554 4 95076 commit-queue 2011-05-27 11:11:40 -0700 Comment on attachment 95076 Patch Clearing flags on attachment: 95076 Committed r87525: <http://trac.webkit.org/changeset/87525> 411555 5 commit-queue 2011-05-27 11:11:45 -0700 All reviewed patches have been landed. Closing bug. 95076 2011-05-26 16:46:30 -0700 2011-05-27 11:11:40 -0700 Patch bug-61583-20110527014628.patch text/plain 4979 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogODczMDUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg ZTEyMjliNDhmM2E5MTFiMDRlNThmNjFhMDUxMDRjNDkyMDE0ZmNkYy4uODk3MzdiNmQ4NzdjNmM3 NjE4N2M2ZmU0Njc1M2U3YjdhYzk4OGExNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNyBAQAorMjAxMS0wNS0yNiAgSm9jaGVuIEVpc2luZ2VyICA8am9jaGVuQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbY2hyb21pdW1dIGRyb3AgdW51c2VkIFdlYkZyYW1lIHBhcmFtZXRlciB0byBXZWJTdG9yYWdl QXJlYTo6c2V0SXRlbQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NjE1ODMKKworICAgICAgICAqIHB1YmxpYy9XZWJTdG9yYWdlQXJlYS5oOgorICAgICAg ICAqIHNyYy9TdG9yYWdlQXJlYVByb3h5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlN0b3JhZ2VB cmVhUHJveHk6OnNldEl0ZW0pOgorICAgICAgICAqIHNyYy9XZWJTdG9yYWdlQXJlYUltcGwuY3Bw OgorICAgICAgICAoV2ViS2l0OjpXZWJTdG9yYWdlQXJlYUltcGw6OnNldEl0ZW0pOgorICAgICAg ICAqIHNyYy9XZWJTdG9yYWdlQXJlYUltcGwuaDoKKwogMjAxMS0wNS0yNCAgS2Vpc2hpIEhhdHRv cmkgIDxrZWlzaGlAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW50IFRhbXVy YS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlN0b3JhZ2VB cmVhLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTdG9yYWdlQXJlYS5oCmlu ZGV4IGY5OWNlZmE5ZDhiZDA4YzFiMjdjOGE3ZjAwZDJiMzY5ZDg5MzQ0OTAuLmI3ZTJjNTQyN2Q2 NmM4ZWZhM2JmZmE4ZmQ1YTY2ZDg5NWU1NDY1YjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYlN0b3JhZ2VBcmVhLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJv bWl1bS9wdWJsaWMvV2ViU3RvcmFnZUFyZWEuaApAQCAtMzYsNyArMzYsNiBAQAogCiBuYW1lc3Bh Y2UgV2ViS2l0IHsKIAotY2xhc3MgV2ViRnJhbWU7CiBjbGFzcyBXZWJVUkw7CiAKIC8vIEluIFdl YkNvcmUsIHRoZXJlJ3Mgb25lIGRpc3RpbmN0IFN0b3JhZ2VBcmVhIHBlciBvcmlnaW4gcGVyIFN0 b3JhZ2VOYW1lc3BhY2UuIFRoaXMKQEAgLTY2LDE1ICs2NSw3IEBAIHB1YmxpYzoKICAgICAvLyBT ZXQgdGhlIHZhbHVlIHRoYXQgY29ycmVzcG9uZHMgdG8gYSBzcGVjaWZpYyBrZXkuIFJlc3VsdCB3 aWxsIGVpdGhlciBiZSBSZXN1bHRPSwogICAgIC8vIG9yIHNvbWUgcGFydGljdWxhciBlcnJvci4g VGhlIHZhbHVlIGlzIE5PVCBzZXQgd2hlbiB0aGVyZSdzIGFuIGVycm9yLiAgdXJsIGlzIHRoZQog ICAgIC8vIHVybCB0aGF0IHNob3VsZCBiZSB1c2VkIGlmIGEgc3RvcmFnZSBldmVudCBmaXJlcy4K LSAgICB2aXJ0dWFsIHZvaWQgc2V0SXRlbShjb25zdCBXZWJTdHJpbmcmIGtleSwgY29uc3QgV2Vi U3RyaW5nJiBuZXdWYWx1ZSwgY29uc3QgV2ViVVJMJiB1cmwsIFJlc3VsdCYgcmVzdWx0LCBXZWJT dHJpbmcmIG9sZFZhbHVlLCBXZWJGcmFtZSopCi0gICAgewotICAgICAgICBzZXRJdGVtKGtleSwg bmV3VmFsdWUsIHVybCwgcmVzdWx0LCBvbGRWYWx1ZSk7Ci0gICAgfQotICAgIC8vIEZJWE1FOiBS ZW1vdmUgc29vbiAob25jZSBDaHJvbWUgaGFzIHJvbGxlZCBwYXN0IHRoaXMgcmV2aXNpb24pLgot ICAgIHZpcnR1YWwgdm9pZCBzZXRJdGVtKGNvbnN0IFdlYlN0cmluZyYga2V5LCBjb25zdCBXZWJT dHJpbmcmIG5ld1ZhbHVlLCBjb25zdCBXZWJVUkwmIHVybCwgUmVzdWx0JiByZXN1bHQsIFdlYlN0 cmluZyYgb2xkVmFsdWUpCi0gICAgewotICAgICAgICBzZXRJdGVtKGtleSwgbmV3VmFsdWUsIHVy bCwgcmVzdWx0LCBvbGRWYWx1ZSwgMCk7Ci0gICAgfQorICAgIHZpcnR1YWwgdm9pZCBzZXRJdGVt KGNvbnN0IFdlYlN0cmluZyYga2V5LCBjb25zdCBXZWJTdHJpbmcmIG5ld1ZhbHVlLCBjb25zdCBX ZWJVUkwmLCBSZXN1bHQmLCBXZWJTdHJpbmcmIG9sZFZhbHVlKSA9IDA7CiAKICAgICAvLyBSZW1v dmUgdGhlIHZhbHVlIGFzc29jaWF0ZWQgd2l0aCBhIHBhcnRpY3VsYXIga2V5LiAgdXJsIGlzIHRo ZSB1cmwgdGhhdCBzaG91bGQgYmUgdXNlZAogICAgIC8vIGlmIGEgc3RvcmFnZSBldmVudCBmaXJl cy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1N0b3JhZ2VBcmVhUHJv eHkuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvU3RvcmFnZUFyZWFQcm94eS5jcHAK aW5kZXggZGMzZmFkNDEwZDFkZGVhZWYwNjlhMGRlODNjNzkyNDIyMzE0MWExNS4uNGUyODE3ZjJk YjU0ZmFiZGI0MGU4N2FmNTM2ZWNkMzgwNDFkZDg1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvU3RvcmFnZUFyZWFQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvU3RvcmFnZUFyZWFQcm94eS5jcHAKQEAgLTg3LDcgKzg3LDcgQEAgU3RyaW5n IFN0b3JhZ2VBcmVhUHJveHk6OnNldEl0ZW0oY29uc3QgU3RyaW5nJiBrZXksIGNvbnN0IFN0cmlu ZyYgdmFsdWUsIEV4Y2VwdGkKICAgICBpZiAod2ViVmlldy0+cGVybWlzc2lvbkNsaWVudCgpICYm ICF3ZWJWaWV3LT5wZXJtaXNzaW9uQ2xpZW50KCktPmFsbG93U3RvcmFnZSh3ZWJGcmFtZSwgbV9z dG9yYWdlVHlwZSA9PSBMb2NhbFN0b3JhZ2UpKQogICAgICAgICBlYyA9IFFVT1RBX0VYQ0VFREVE X0VSUjsKICAgICBlbHNlIHsKLSAgICAgICAgbV9zdG9yYWdlQXJlYS0+c2V0SXRlbShrZXksIHZh bHVlLCBmcmFtZS0+ZG9jdW1lbnQoKS0+dXJsKCksIHJlc3VsdCwgb2xkVmFsdWUsIHdlYkZyYW1l KTsKKyAgICAgICAgbV9zdG9yYWdlQXJlYS0+c2V0SXRlbShrZXksIHZhbHVlLCBmcmFtZS0+ZG9j dW1lbnQoKS0+dXJsKCksIHJlc3VsdCwgb2xkVmFsdWUpOwogICAgICAgICBlYyA9IChyZXN1bHQg PT0gV2ViS2l0OjpXZWJTdG9yYWdlQXJlYTo6UmVzdWx0T0spID8gMCA6IFFVT1RBX0VYQ0VFREVE X0VSUjsKICAgICAgICAgU3RyaW5nIG9sZFZhbHVlU3RyaW5nID0gb2xkVmFsdWU7CiAgICAgICAg IGlmIChvbGRWYWx1ZVN0cmluZyAhPSB2YWx1ZSAmJiByZXN1bHQgPT0gV2ViS2l0OjpXZWJTdG9y YWdlQXJlYTo6UmVzdWx0T0spCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJTdG9yYWdlQXJlYUltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2Vi U3RvcmFnZUFyZWFJbXBsLmNwcAppbmRleCAyY2VjZmU5ZTdjYTEyNDc0YzMxMTNkM2I5NjQ5Njgw NDc0Y2M0OTg2Li45YTdmZDVjNzZlODE5MDQ2ODExNGJlMDI2NTdlMWExOGRmMDE5OGE2IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTdG9yYWdlQXJlYUltcGwuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlN0b3JhZ2VBcmVhSW1wbC5jcHAK QEAgLTY2LDcgKzY2LDcgQEAgV2ViU3RyaW5nIFdlYlN0b3JhZ2VBcmVhSW1wbDo6Z2V0SXRlbShj b25zdCBXZWJTdHJpbmcmIGtleSkKICAgICByZXR1cm4gbV9zdG9yYWdlQXJlYS0+Z2V0SXRlbShr ZXkpOwogfQogCi12b2lkIFdlYlN0b3JhZ2VBcmVhSW1wbDo6c2V0SXRlbShjb25zdCBXZWJTdHJp bmcmIGtleSwgY29uc3QgV2ViU3RyaW5nJiB2YWx1ZSwgY29uc3QgV2ViVVJMJiB1cmwsIFJlc3Vs dCYgcmVzdWx0LCBXZWJTdHJpbmcmIG9sZFZhbHVlLCBXZWJGcmFtZSopCit2b2lkIFdlYlN0b3Jh Z2VBcmVhSW1wbDo6c2V0SXRlbShjb25zdCBXZWJTdHJpbmcmIGtleSwgY29uc3QgV2ViU3RyaW5n JiB2YWx1ZSwgY29uc3QgV2ViVVJMJiB1cmwsIFJlc3VsdCYgcmVzdWx0LCBXZWJTdHJpbmcmIG9s ZFZhbHVlKQogewogICAgIGludCBleGNlcHRpb25Db2RlID0gMDsKIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU3RvcmFnZUFyZWFJbXBsLmggYi9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJTdG9yYWdlQXJlYUltcGwuaAppbmRleCAyODY5ZmM5MmQ2MjA2 YTRiOGY3OTQzZDVjMGFjNmFiNTVjMzFkODI3Li43MWY5OGIyODg2ZjNhY2FlZThkYjQ4ZmJjYmYz YjQ5ZmM4YjIxODE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJT dG9yYWdlQXJlYUltcGwuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTdG9y YWdlQXJlYUltcGwuaApAQCAtNDUsNyArNDUsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB1bnNp Z25lZCBsZW5ndGgoKTsKICAgICB2aXJ0dWFsIFdlYlN0cmluZyBrZXkodW5zaWduZWQgaW5kZXgp OwogICAgIHZpcnR1YWwgV2ViU3RyaW5nIGdldEl0ZW0oY29uc3QgV2ViU3RyaW5nJiBrZXkpOwot ICAgIHZpcnR1YWwgdm9pZCBzZXRJdGVtKGNvbnN0IFdlYlN0cmluZyYga2V5LCBjb25zdCBXZWJT dHJpbmcmIHZhbHVlLCBjb25zdCBXZWJVUkwmIHVybCwgUmVzdWx0JiByZXN1bHQsIFdlYlN0cmlu ZyYgb2xkVmFsdWUsIFdlYkZyYW1lKik7CisgICAgdmlydHVhbCB2b2lkIHNldEl0ZW0oY29uc3Qg V2ViU3RyaW5nJiBrZXksIGNvbnN0IFdlYlN0cmluZyYgdmFsdWUsIGNvbnN0IFdlYlVSTCYsIFJl c3VsdCYsIFdlYlN0cmluZyYgb2xkVmFsdWUpOwogICAgIHZpcnR1YWwgdm9pZCByZW1vdmVJdGVt KGNvbnN0IFdlYlN0cmluZyYga2V5LCBjb25zdCBXZWJVUkwmIHVybCwgV2ViU3RyaW5nJiBvbGRW YWx1ZSk7CiAgICAgdmlydHVhbCB2b2lkIGNsZWFyKGNvbnN0IFdlYlVSTCYgdXJsLCBib29sJiBz b21ldGhpbmdDbGVhcmVkKTsKIAo=