61580 2011-05-26 16:35:40 -0700 Switch paintFocusRing to IntPoint 2011-05-31 10:12:48 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60318 1 leviw leviw eae eric leviw simon.fraser oldest_to_newest 410986 0 leviw 2011-05-26 16:35:40 -0700 Continuing to hate on tx/ty. 410994 1 95073 leviw 2011-05-26 16:42:09 -0700 Created attachment 95073 Patch 411047 2 95073 eric 2011-05-26 17:39:34 -0700 Comment on attachment 95073 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95073&action=review > Source/WebCore/rendering/RenderObject.cpp:1000 > +void RenderObject::paintFocusRing(GraphicsContext* context, const IntPoint& paintOffset, RenderStyle* style) Seems like this is the origin the renderObject in question, with relation to its paint container? I guess that's a paintOffset? 412725 3 95073 leviw 2011-05-31 10:12:43 -0700 Comment on attachment 95073 Patch Clearing flags on attachment: 95073 Committed r87738: <http://trac.webkit.org/changeset/87738> 412726 4 leviw 2011-05-31 10:12:48 -0700 All reviewed patches have been landed. Closing bug. 95073 2011-05-26 16:42:09 -0700 2011-05-31 10:12:43 -0700 Patch bug-61580-20110526164208.patch text/plain 3688 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg3NDQ3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDUtMjYgIExldmkgV2Vp bnRyYXViICA8bGV2aXdAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFN3aXRjaCBwYWludEZvY3VzUmluZyB0byBJbnRQb2ludAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjE1ODAKKwor ICAgICAgICBTd2l0Y2hpbmcgcGFpbnRGb2N1c1JpbmcgdG8gdGFrZSBhbiBJbnRQb2ludCByZXBy ZXNlbnRpbmcgdGhlIHBhaW50IG9mZnNldAorICAgICAgICBpbnN0ZWFkIG9mIGEgcGFpciBvZiBp bnRzLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBhcyB0aGlzIGlzIGp1c3QgcmVmYWN0b3Jpbmcu CisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVySW5saW5lLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlJlbmRlcklubGluZTo6cGFpbnRPdXRsaW5lKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVu ZGVyT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlck9iamVjdDo6cGFpbnRGb2N1 c1JpbmcpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyT2JqZWN0OjpwYWludE91dGxpbmUpOgor ICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJPYmplY3QuaDoKKwogMjAxMS0wNS0yNiAgRGF2aWQg TGV2aW4gIDxsZXZpbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4g RmlzaGVyLgpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlcklubGluZS5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlcklubGluZS5jcHAJ KHJldmlzaW9uIDg3NDQ3KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlcklubGlu ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEzNzUsNyArMTM3NSw3IEBAIHZvaWQgUmVuZGVySW5s aW5lOjpwYWludE91dGxpbmUoR3JhcGhpY3MKICAgICBpZiAoc3R5bGVUb1VzZS0+b3V0bGluZVN0 eWxlSXNBdXRvKCkgfHwgaGFzT3V0bGluZUFubm90YXRpb24oKSkgewogICAgICAgICBpZiAoIXRo ZW1lKCktPnN1cHBvcnRzRm9jdXNSaW5nKHN0eWxlVG9Vc2UpKSB7CiAgICAgICAgICAgICAvLyBP bmx5IHBhaW50IHRoZSBmb2N1cyByaW5nIGJ5IGhhbmQgaWYgdGhlIHRoZW1lIGlzbid0IGFibGUg dG8gZHJhdyB0aGUgZm9jdXMgcmluZy4KLSAgICAgICAgICAgIHBhaW50Rm9jdXNSaW5nKGdyYXBo aWNzQ29udGV4dCwgdHgsIHR5LCBzdHlsZVRvVXNlKTsKKyAgICAgICAgICAgIHBhaW50Rm9jdXNS aW5nKGdyYXBoaWNzQ29udGV4dCwgSW50UG9pbnQodHgsIHR5KSwgc3R5bGVUb1VzZSk7CiAgICAg ICAgIH0KICAgICB9CiAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmpl Y3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmpl Y3QuY3BwCShyZXZpc2lvbiA4NzQ0NykKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJPYmplY3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05OTcsMTAgKzk5NywxMCBAQCB2b2lkIFJl bmRlck9iamVjdDo6ZHJhd0FyY0ZvckJveFNpZGUoR3JhCiB9CiAjZW5kaWYKICAgICAKLXZvaWQg UmVuZGVyT2JqZWN0OjpwYWludEZvY3VzUmluZyhHcmFwaGljc0NvbnRleHQqIGNvbnRleHQsIGlu dCB0eCwgaW50IHR5LCBSZW5kZXJTdHlsZSogc3R5bGUpCit2b2lkIFJlbmRlck9iamVjdDo6cGFp bnRGb2N1c1JpbmcoR3JhcGhpY3NDb250ZXh0KiBjb250ZXh0LCBjb25zdCBJbnRQb2ludCYgcGFp bnRPZmZzZXQsIFJlbmRlclN0eWxlKiBzdHlsZSkKIHsKICAgICBWZWN0b3I8SW50UmVjdD4gZm9j dXNSaW5nUmVjdHM7Ci0gICAgYWRkRm9jdXNSaW5nUmVjdHMoZm9jdXNSaW5nUmVjdHMsIEludFBv aW50KHR4LCB0eSkpOworICAgIGFkZEZvY3VzUmluZ1JlY3RzKGZvY3VzUmluZ1JlY3RzLCBwYWlu dE9mZnNldCk7CiAgICAgaWYgKHN0eWxlLT5vdXRsaW5lU3R5bGVJc0F1dG8oKSkKICAgICAgICAg Y29udGV4dC0+ZHJhd0ZvY3VzUmluZyhmb2N1c1JpbmdSZWN0cywgc3R5bGUtPm91dGxpbmVXaWR0 aCgpLCBzdHlsZS0+b3V0bGluZU9mZnNldCgpLCBzdHlsZS0+dmlzaXRlZERlcGVuZGVudENvbG9y KENTU1Byb3BlcnR5T3V0bGluZUNvbG9yKSk7CiAgICAgZWxzZQpAQCAtMTAzNiw3ICsxMDM2LDcg QEAgdm9pZCBSZW5kZXJPYmplY3Q6OnBhaW50T3V0bGluZShHcmFwaGljcwogICAgIGlmIChzdHls ZVRvVXNlLT5vdXRsaW5lU3R5bGVJc0F1dG8oKSB8fCBoYXNPdXRsaW5lQW5ub3RhdGlvbigpKSB7 CiAgICAgICAgIGlmICghdGhlbWUoKS0+c3VwcG9ydHNGb2N1c1Jpbmcoc3R5bGVUb1VzZSkpIHsK ICAgICAgICAgICAgIC8vIE9ubHkgcGFpbnQgdGhlIGZvY3VzIHJpbmcgYnkgaGFuZCBpZiB0aGUg dGhlbWUgaXNuJ3QgYWJsZSB0byBkcmF3IHRoZSBmb2N1cyByaW5nLgotICAgICAgICAgICAgcGFp bnRGb2N1c1JpbmcoZ3JhcGhpY3NDb250ZXh0LCBwYWludFJlY3QueCgpLCBwYWludFJlY3QueSgp LCBzdHlsZVRvVXNlKTsKKyAgICAgICAgICAgIHBhaW50Rm9jdXNSaW5nKGdyYXBoaWNzQ29udGV4 dCwgcGFpbnRSZWN0LmxvY2F0aW9uKCksIHN0eWxlVG9Vc2UpOwogICAgICAgICB9CiAgICAgfQog CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5oCShyZXZpc2lvbiA4 NzQ0NykKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuaAkod29ya2lu ZyBjb3B5KQpAQCAtNzkxLDcgKzc5MSw3IEBAIHByb3RlY3RlZDoKICAgICB2b2lkIGRyYXdMaW5l Rm9yQm94U2lkZShHcmFwaGljc0NvbnRleHQqLCBpbnQgeDEsIGludCB5MSwgaW50IHgyLCBpbnQg eTIsIEJveFNpZGUsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgQ29sb3IsIEVCb3JkZXJT dHlsZSwgaW50IGFkamJ3MSwgaW50IGFkamJ3MiwgYm9vbCBhbnRpYWxpYXMgPSBmYWxzZSk7CiAK LSAgICB2b2lkIHBhaW50Rm9jdXNSaW5nKEdyYXBoaWNzQ29udGV4dCosIGludCB0eCwgaW50IHR5 LCBSZW5kZXJTdHlsZSopOworICAgIHZvaWQgcGFpbnRGb2N1c1JpbmcoR3JhcGhpY3NDb250ZXh0 KiwgY29uc3QgSW50UG9pbnQmLCBSZW5kZXJTdHlsZSopOwogICAgIHZvaWQgcGFpbnRPdXRsaW5l KEdyYXBoaWNzQ29udGV4dCosIGNvbnN0IEludFJlY3QmKTsKICAgICB2b2lkIGFkZFBERlVSTFJl Y3QoR3JhcGhpY3NDb250ZXh0KiwgY29uc3QgSW50UmVjdCYpOwogCg==