61472 2011-05-25 14:49:47 -0700 JSC DOM bindings: Use isUndefinedOrNull() instead of (isNull() || isUndefined()). 2011-05-26 06:03:41 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling commit-queue oldest_to_newest 409948 0 kling 2011-05-25 14:49:47 -0700 SSIA. 409949 1 94866 kling 2011-05-25 14:50:41 -0700 Created attachment 94866 Proposed patch 410354 2 94866 commit-queue 2011-05-26 04:47:01 -0700 Comment on attachment 94866 Proposed patch Clearing flags on attachment: 94866 Committed r87374: <http://trac.webkit.org/changeset/87374> 410355 3 commit-queue 2011-05-26 04:47:05 -0700 All reviewed patches have been landed. Closing bug. 410376 4 commit-queue 2011-05-26 06:03:41 -0700 The commit-queue encountered the following flaky tests while processing attachment 94866: http/tests/misc/uncacheable-script-repeated.html bug 51009 (author: koivisto@iki.fi) The commit-queue is continuing to process your patch. 94866 2011-05-25 14:50:41 -0700 2011-05-26 04:47:01 -0700 Proposed patch bug-61472.diff text/plain 5334 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhMjQ0YWY5Li42MGJjM2RmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMTgg QEAKIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBKU0Mg RE9NIGJpbmRpbmdzOiBVc2UgaXNVbmRlZmluZWRPck51bGwoKSBpbnN0ZWFkIG9mIChpc051bGwo KSB8fCBpc1VuZGVmaW5lZCgpKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTYxNDcyCisKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5l cmF0b3JKUy5wbToKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0T2Jq LmNwcDogUmViYXNlbGluZWQuCisgICAgICAgIChXZWJDb3JlOjpqc1Rlc3RPYmpQcm90b3R5cGVG dW5jdGlvbk1ldGhvZFdpdGhDYWxsYmFja0FuZE9wdGlvbmFsQXJnKToKKyAgICAgICAgKFdlYkNv cmU6OmpzVGVzdE9ialByb3RvdHlwZUZ1bmN0aW9uT3ZlcmxvYWRlZE1ldGhvZCk6CisKKzIwMTEt MDUtMjUgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCiAgICAgICAgIFJlYmFzZWxpbmUgcnVuLWJpbmRpbmdz LXRlc3RzLgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NjE0NjkKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2Rl R2VuZXJhdG9ySlMucG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5l cmF0b3JKUy5wbQppbmRleCBkOTIzZmNkLi40ZTY0OTYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQorKysgYi9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQpAQCAtMTE1MSw3ICsxMTUx LDcgQEAgc3ViIEdlbmVyYXRlUGFyYW1ldGVyc0NoZWNrRXhwcmVzc2lvbgogICAgICAgICAjIHRo ZXNlIGFyZSBhY2NlcHRhYmxlIHZhbHVlcyBmb3IgYSBET01TdHJpbmcgYXJndW1lbnQgKGFueSBP YmplY3QgY2FuCiAgICAgICAgICMgYmUgY29udmVydGVkIHRvIGEgc3RyaW5nIHZpYSAudG9TdHJp bmcpLgogICAgICAgICBpZiAoJGNvZGVHZW5lcmF0b3ItPklzU3RyaW5nVHlwZSgkdHlwZSkpIHsK LSAgICAgICAgICAgIHB1c2goQGFuZEV4cHJlc3Npb24sICIoJHt2YWx1ZX0uaXNOdWxsKCkgfHwg JHt2YWx1ZX0uaXNVbmRlZmluZWQoKSB8fCAke3ZhbHVlfS5pc1N0cmluZygpIHx8ICR7dmFsdWV9 LmlzT2JqZWN0KCkpIik7CisgICAgICAgICAgICBwdXNoKEBhbmRFeHByZXNzaW9uLCAiKCR7dmFs dWV9LmlzVW5kZWZpbmVkT3JOdWxsKCkgfHwgJHt2YWx1ZX0uaXNTdHJpbmcoKSB8fCAke3ZhbHVl fS5pc09iamVjdCgpKSIpOwogICAgICAgICB9IGVsc2lmICgkcGFyYW1ldGVyLT5leHRlbmRlZEF0 dHJpYnV0ZXMtPnsiQ2FsbGJhY2sifSkgewogICAgICAgICAgICAgIyBGb3IgQ2FsbGJhY2tzIG9u bHkgY2hlY2tzIGlmIHRoZSB2YWx1ZSBpcyBudWxsIG9yIG9iamVjdC4KICAgICAgICAgICAgIHB1 c2goQGFuZEV4cHJlc3Npb24sICIoJHt2YWx1ZX0uaXNOdWxsKCkgfHwgJHt2YWx1ZX0uaXNPYmpl Y3QoKSkiKTsKQEAgLTIwMDksNyArMjAwOSw3IEBAIHN1YiBHZW5lcmF0ZUltcGxlbWVudGF0aW9u CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJGltcGxJbmNsdWRlc3siJGNhbGxiYWNrQ2xh c3NOYW1lLmgifSA9IDE7CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaWYgKCRwYXJhbWV0 ZXItPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJPcHRpb25hbCJ9KSB7CiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAiICAgIFJlZlB0cjwkYXJnVHlwZT4g JG5hbWU7XG4iKTsKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcHVzaChAaW1wbENv bnRlbnQsICIgICAgaWYgKGV4ZWMtPmFyZ3VtZW50Q291bnQoKSA+ICRhcmdzSW5kZXggJiYgIWV4 ZWMtPmFyZ3VtZW50KCRhcmdzSW5kZXgpLmlzTnVsbCgpICYmICFleGVjLT5hcmd1bWVudCgkYXJn c0luZGV4KS5pc1VuZGVmaW5lZCgpKSB7XG4iKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgcHVzaChAaW1wbENvbnRlbnQsICIgICAgaWYgKGV4ZWMtPmFyZ3VtZW50Q291bnQoKSA+ ICRhcmdzSW5kZXggJiYgIWV4ZWMtPmFyZ3VtZW50KCRhcmdzSW5kZXgpLmlzVW5kZWZpbmVkT3JO dWxsKCkpIHtcbiIpOwogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwdXNoKEBpbXBs Q29udGVudCwgIiAgICAgICAgaWYgKCFleGVjLT5hcmd1bWVudCgkYXJnc0luZGV4KS5pc09iamVj dCgpKSB7XG4iKTsKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcHVzaChAaW1wbENv bnRlbnQsICIgICAgICAgICAgICBzZXRET01FeGNlcHRpb24oZXhlYywgVFlQRV9NSVNNQVRDSF9F UlIpO1xuIik7CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHB1c2goQGltcGxDb250 ZW50LCAiICAgICAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc1VuZGVmaW5lZCgpKTtc biIpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pT L0pTVGVzdE9iai5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMv SlNUZXN0T2JqLmNwcAppbmRleCA2MGNkNmEwLi41Y2NlYTc3IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0T2JqLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0T2JqLmNwcApAQCAtMTUx MCw3ICsxNTEwLDcgQEAgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBqc1Rlc3RPYmpQcm90 b3R5cGVGdW5jdGlvbk1ldGhvZFdpdGhDYWxsYmFja0FuZE9wdGkKICAgICBBU1NFUlRfR0NfT0JK RUNUX0lOSEVSSVRTKGNhc3RlZFRoaXMsICZKU1Rlc3RPYmo6OnNfaW5mbyk7CiAgICAgVGVzdE9i aiogaW1wID0gc3RhdGljX2Nhc3Q8VGVzdE9iaio+KGNhc3RlZFRoaXMtPmltcGwoKSk7CiAgICAg UmVmUHRyPFRlc3RDYWxsYmFjaz4gY2FsbGJhY2s7Ci0gICAgaWYgKGV4ZWMtPmFyZ3VtZW50Q291 bnQoKSA+IDAgJiYgIWV4ZWMtPmFyZ3VtZW50KDApLmlzTnVsbCgpICYmICFleGVjLT5hcmd1bWVu dCgwKS5pc1VuZGVmaW5lZCgpKSB7CisgICAgaWYgKGV4ZWMtPmFyZ3VtZW50Q291bnQoKSA+IDAg JiYgIWV4ZWMtPmFyZ3VtZW50KDApLmlzVW5kZWZpbmVkT3JOdWxsKCkpIHsKICAgICAgICAgaWYg KCFleGVjLT5hcmd1bWVudCgwKS5pc09iamVjdCgpKSB7CiAgICAgICAgICAgICBzZXRET01FeGNl cHRpb24oZXhlYywgVFlQRV9NSVNNQVRDSF9FUlIpOwogICAgICAgICAgICAgcmV0dXJuIEpTVmFs dWU6OmVuY29kZShqc1VuZGVmaW5lZCgpKTsKQEAgLTE2MTksMTEgKzE2MTksMTEgQEAgc3RhdGlj IEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwganNUZXN0T2JqUHJvdG90eXBlRnVuY3Rpb25P dmVybG9hZGVkTWV0aG9kNSgKIAogRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBqc1Rlc3RP YmpQcm90b3R5cGVGdW5jdGlvbk92ZXJsb2FkZWRNZXRob2QoRXhlY1N0YXRlKiBleGVjKQogewot ICAgIGlmICgoZXhlYy0+YXJndW1lbnRDb3VudCgpID09IDIgJiYgKGV4ZWMtPmFyZ3VtZW50KDAp LmlzTnVsbCgpIHx8IChleGVjLT5hcmd1bWVudCgwKS5pc09iamVjdCgpICYmIGFzT2JqZWN0KGV4 ZWMtPmFyZ3VtZW50KDApKS0+aW5oZXJpdHMoJkpTVGVzdE9iajo6c19pbmZvKSkpICYmIChleGVj LT5hcmd1bWVudCgxKS5pc051bGwoKSB8fCBleGVjLT5hcmd1bWVudCgxKS5pc1VuZGVmaW5lZCgp IHx8IGV4ZWMtPmFyZ3VtZW50KDEpLmlzU3RyaW5nKCkgfHwgZXhlYy0+YXJndW1lbnQoMSkuaXNP YmplY3QoKSkpKQorICAgIGlmICgoZXhlYy0+YXJndW1lbnRDb3VudCgpID09IDIgJiYgKGV4ZWMt PmFyZ3VtZW50KDApLmlzTnVsbCgpIHx8IChleGVjLT5hcmd1bWVudCgwKS5pc09iamVjdCgpICYm IGFzT2JqZWN0KGV4ZWMtPmFyZ3VtZW50KDApKS0+aW5oZXJpdHMoJkpTVGVzdE9iajo6c19pbmZv KSkpICYmIChleGVjLT5hcmd1bWVudCgxKS5pc1VuZGVmaW5lZE9yTnVsbCgpIHx8IGV4ZWMtPmFy Z3VtZW50KDEpLmlzU3RyaW5nKCkgfHwgZXhlYy0+YXJndW1lbnQoMSkuaXNPYmplY3QoKSkpKQog ICAgICAgICByZXR1cm4ganNUZXN0T2JqUHJvdG90eXBlRnVuY3Rpb25PdmVybG9hZGVkTWV0aG9k MShleGVjKTsKICAgICBpZiAoKGV4ZWMtPmFyZ3VtZW50Q291bnQoKSA9PSAxICYmIChleGVjLT5h cmd1bWVudCgwKS5pc051bGwoKSB8fCAoZXhlYy0+YXJndW1lbnQoMCkuaXNPYmplY3QoKSAmJiBh c09iamVjdChleGVjLT5hcmd1bWVudCgwKSktPmluaGVyaXRzKCZKU1Rlc3RPYmo6OnNfaW5mbykp KSkgfHwgKGV4ZWMtPmFyZ3VtZW50Q291bnQoKSA9PSAyICYmIChleGVjLT5hcmd1bWVudCgwKS5p c051bGwoKSB8fCAoZXhlYy0+YXJndW1lbnQoMCkuaXNPYmplY3QoKSAmJiBhc09iamVjdChleGVj LT5hcmd1bWVudCgwKSktPmluaGVyaXRzKCZKU1Rlc3RPYmo6OnNfaW5mbykpKSkpCiAgICAgICAg IHJldHVybiBqc1Rlc3RPYmpQcm90b3R5cGVGdW5jdGlvbk92ZXJsb2FkZWRNZXRob2QyKGV4ZWMp OwotICAgIGlmICgoZXhlYy0+YXJndW1lbnRDb3VudCgpID09IDEgJiYgKGV4ZWMtPmFyZ3VtZW50 KDApLmlzTnVsbCgpIHx8IGV4ZWMtPmFyZ3VtZW50KDApLmlzVW5kZWZpbmVkKCkgfHwgZXhlYy0+ YXJndW1lbnQoMCkuaXNTdHJpbmcoKSB8fCBleGVjLT5hcmd1bWVudCgwKS5pc09iamVjdCgpKSkp CisgICAgaWYgKChleGVjLT5hcmd1bWVudENvdW50KCkgPT0gMSAmJiAoZXhlYy0+YXJndW1lbnQo MCkuaXNVbmRlZmluZWRPck51bGwoKSB8fCBleGVjLT5hcmd1bWVudCgwKS5pc1N0cmluZygpIHx8 IGV4ZWMtPmFyZ3VtZW50KDApLmlzT2JqZWN0KCkpKSkKICAgICAgICAgcmV0dXJuIGpzVGVzdE9i alByb3RvdHlwZUZ1bmN0aW9uT3ZlcmxvYWRlZE1ldGhvZDMoZXhlYyk7CiAgICAgaWYgKGV4ZWMt PmFyZ3VtZW50Q291bnQoKSA9PSAxKQogICAgICAgICByZXR1cm4ganNUZXN0T2JqUHJvdG90eXBl RnVuY3Rpb25PdmVybG9hZGVkTWV0aG9kNChleGVjKTsK