61451 2011-05-25 11:30:12 -0700 Fix crash in Chromium memory test. 2011-05-25 18:00:03 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 61397 0 shishir webkit-unassigned commit-queue oldest_to_newest 409772 0 shishir 2011-05-25 11:30:12 -0700 Chromium stack trace: InvalidRead Invalid read of size 4 WebKit::WebViewImpl::WebViewImpl(WebKit::WebViewClient*) (third_party/WebKit/Source/WebKit/chromium/src/WebViewImpl.cpp:371) WebKit::WebView::create(WebKit::WebViewClient*) (third_party/WebKit/Source/WebKit/chromium/src/WebViewImpl.cpp:225) WebKit::WebWorkerBase::initializeLoader(WebKit::WebURL const&) (third_party/WebKit/Source/WebKit/chromium/src/WebWorkerBase.cpp:240) WebKit::WebWorkerImpl::startWorkerContext(WebKit::WebURL const&, WebKit::WebString const&, WebKit::WebString const&) (third_party/WebKit/Source/WebKit/chromium/src/WebWorkerImpl.cpp:105) void DispatchToMethod<WebKit::WebWorker, void (WebKit::WebWorker::*)(WebKit::WebURL const&, WebKit::WebString const&, WebKit::WebString const&), GURL, std::basic_string<unsigned short, base::string16_char_traits, std::allocator<unsigned short> >, std::basic_string<unsigned short, base::string16_char_traits, std::allocator<unsigned short> > >(WebKit::WebWorker*, void (WebKit::WebWorker::*)(WebKit::WebURL const&, WebKit::WebString const&, WebKit::WebString const&), Tuple3<GURL, std::basic_string<unsigned short, base::string16_char_traits, std::allocator<unsigned short> >, std::basic_string<unsigned short, base::string16_char_traits, std::allocator<unsigned short> > > const&) (./base/tuple.h:564) bool IPC::MessageWithTuple<Tuple3<GURL, std::basic_string<unsigned short, base::string16_char_traits, std::allocator<unsigned short> >, std::basic_string<unsigned short, base::string16_char_traits, std::allocator<unsigned short> > > >::Dispatch<WebKit::WebWorker, WebWorkerStub, void (WebKit::WebWorker::*)(WebKit::WebURL const&, WebKit::WebString const&, WebKit::WebString const&)>(IPC::Message const*, WebKit::WebWorker*, WebWorkerStub*, void (WebKit::WebWorker::*)(WebKit::WebURL const&, WebKit::WebString const&, WebKit::WebString const&)) (./ipc/ipc_message_utils.h:963) WebWorkerStub::OnMessageReceived(IPC::Message const&) (content/worker/webworker_stub.cc:43) MessageRouter::RouteMessage(IPC::Message const&) (content/common/message_router.cc:46) MessageRouter::OnMessageReceived(IPC::Message const&) (content/common/message_router.cc:38) ChildThread::OnMessageReceived(IPC::Message const&) (content/common/child_thread.cc:175) IPC::ChannelProxy::Context::OnDispatchMessage(IPC::Message const&) (ipc/ipc_channel_proxy.cc:256) void DispatchToMethod<IPC::ChannelProxy::Context, void (IPC::ChannelProxy::Context::*)(IPC::Message const&), IPC::Message>(IPC::ChannelProxy::Context*, void (IPC::ChannelProxy::Context::*)(IPC::Message const&), Tuple1<IPC::Message> const&) (./base/tuple.h:551) RunnableMethod<IPC::ChannelProxy::Context, void (IPC::ChannelProxy::Context::*)(IPC::Message const&), Tuple1<IPC::Message> >::Run() (./base/task.h:338) (anonymous namespace)::TaskClosureAdapter::Run() (base/message_loop.cc:102) base::internal::Invoker1<false, base::internal::InvokerStorage1<void ((anonymous namespace)::TaskClosureAdapter::*)(), (anonymous namespace)::TaskClosureAdapter*>, void ((anonymous namespace)::TaskClosureAdapter::*)()>::DoInvoke(base::internal::InvokerStorageBase*) (./base/bind_internal.h:547) base::Callback<void ()()>::Run() const (./base/callback.h:261) MessageLoop::RunTask(MessageLoop::PendingTask const&) (base/message_loop.cc:482) MessageLoop::DeferOrRunPendingTask(MessageLoop::PendingTask const&) (base/message_loop.cc:500) MessageLoop::DoWork() (base/message_loop.cc:691) base::MessagePumpDefault::Run(base::MessagePump::Delegate*) (base/message_pump_default.cc:23) MessageLoop::RunInternal() (base/message_loop.cc:449) MessageLoop::RunHandler() (base/message_loop.cc:422) MessageLoop::Run() (base/message_loop.cc:346) WorkerMain(MainFunctionParams const&) (content/worker/worker_main.cc:52) (anonymous namespace)::RunZygote(MainFunctionParams const&) (chrome/app/chrome_main.cc:448) (anonymous namespace)::RunNamedProcessTypeMain(std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, MainFunctionParams const&) (chrome/app/chrome_main.cc:494) ChromeMain (chrome/app/chrome_main.cc:815) main (chrome/app/chrome_exe_main_gtk.cc:46) This is likely due to the client being null at the WebViewImpl constructor. 409775 1 94814 shishir 2011-05-25 11:31:45 -0700 Created attachment 94814 Patch 409777 2 94815 shishir 2011-05-25 11:33:45 -0700 Created attachment 94815 Patch Minor style fix. 409821 3 94815 dglazkov 2011-05-25 12:20:53 -0700 Comment on attachment 94815 Patch no changelog! 409835 4 94835 shishir 2011-05-25 12:25:56 -0700 Created attachment 94835 Patch Added changelog. 409842 5 94835 dglazkov 2011-05-25 12:31:22 -0700 Comment on attachment 94835 Patch How can we write a regression test for this? 409848 6 shishir 2011-05-25 12:37:56 -0700 I am not sure what we want to test in the regression. Should we test that passing in a null client will not cause failures in the constructor of WebViewClient? Also there is already other code that does m_client checks before using it so this should get caught by existing tests? 410086 7 94835 commit-queue 2011-05-25 17:59:59 -0700 Comment on attachment 94835 Patch Clearing flags on attachment: 94835 Committed r87342: <http://trac.webkit.org/changeset/87342> 410087 8 commit-queue 2011-05-25 18:00:03 -0700 All reviewed patches have been landed. Closing bug. 94814 2011-05-25 11:31:45 -0700 2011-05-25 11:33:45 -0700 Patch m_client_fix.patch text/plain 582 shishir ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcCBi L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAppbmRleCAyMDk3M2Nj Li42ZTEzZTA2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3 SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3Bw CkBAIC0zNjgsNyArMzY4LDggQEAgV2ViVmlld0ltcGw6OldlYlZpZXdJbXBsKFdlYlZpZXdDbGll bnQqIGNsaWVudCkKICAgICBtX3BhZ2UtPnNldEdyb3VwTmFtZShwYWdlR3JvdXBOYW1lKTsKIAog I2lmIEVOQUJMRShQQUdFX1ZJU0lCSUxJVFlfQVBJKQotICAgIHNldFZpc2liaWxpdHlTdGF0ZSht X2NsaWVudC0+dmlzaWJpbGl0eVN0YXRlKCksIHRydWUpOworICAgIGlmIChtX2NsaWVudCkKKyAg ICAgIHNldFZpc2liaWxpdHlTdGF0ZShtX2NsaWVudC0+dmlzaWJpbGl0eVN0YXRlKCksIHRydWUp OwogI2VuZGlmCiAKICAgICBtX2luc3BlY3RvclNldHRpbmdzTWFwID0gYWRvcHRQdHIobmV3IFNl dHRpbmdzTWFwKTsK 94815 2011-05-25 11:33:45 -0700 2011-05-25 12:26:08 -0700 Patch m_client_fix.patch text/plain 584 shishir ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcCBi L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAppbmRleCAyMDk3M2Nj Li4wYjBlMjNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3 SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3Bw CkBAIC0zNjgsNyArMzY4LDggQEAgV2ViVmlld0ltcGw6OldlYlZpZXdJbXBsKFdlYlZpZXdDbGll bnQqIGNsaWVudCkKICAgICBtX3BhZ2UtPnNldEdyb3VwTmFtZShwYWdlR3JvdXBOYW1lKTsKIAog I2lmIEVOQUJMRShQQUdFX1ZJU0lCSUxJVFlfQVBJKQotICAgIHNldFZpc2liaWxpdHlTdGF0ZSht X2NsaWVudC0+dmlzaWJpbGl0eVN0YXRlKCksIHRydWUpOworICAgIGlmIChtX2NsaWVudCkKKyAg ICAgICAgc2V0VmlzaWJpbGl0eVN0YXRlKG1fY2xpZW50LT52aXNpYmlsaXR5U3RhdGUoKSwgdHJ1 ZSk7CiAjZW5kaWYKIAogICAgIG1faW5zcGVjdG9yU2V0dGluZ3NNYXAgPSBhZG9wdFB0cihuZXcg U2V0dGluZ3NNYXApOwo= 94835 2011-05-25 12:25:56 -0700 2011-05-25 17:59:59 -0700 Patch m_client_fix.patch text/plain 1149 shishir ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggZTEyMjliNC4uYjZhZDk0NCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMS0wNS0yNSAgU2hpc2hpciBB Z3Jhd2FsICA8c2hpc2hpckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGNyYXNoIGluIENocm9taXVtIG1lbW9yeSB0ZXN0 LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjE0NTEK KworICAgICAgICAqIHNyYy9XZWJWaWV3SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlZp ZXdJbXBsOjpXZWJWaWV3SW1wbCk6CisKIDIwMTEtMDUtMjQgIEtlaXNoaSBIYXR0b3JpICA8a2Vp c2hpQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VudCBUYW11cmEuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAgYi9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKaW5kZXggMjA5NzNjYy4uMGIw ZTIzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcApAQCAt MzY4LDcgKzM2OCw4IEBAIFdlYlZpZXdJbXBsOjpXZWJWaWV3SW1wbChXZWJWaWV3Q2xpZW50KiBj bGllbnQpCiAgICAgbV9wYWdlLT5zZXRHcm91cE5hbWUocGFnZUdyb3VwTmFtZSk7CiAKICNpZiBF TkFCTEUoUEFHRV9WSVNJQklMSVRZX0FQSSkKLSAgICBzZXRWaXNpYmlsaXR5U3RhdGUobV9jbGll bnQtPnZpc2liaWxpdHlTdGF0ZSgpLCB0cnVlKTsKKyAgICBpZiAobV9jbGllbnQpCisgICAgICAg IHNldFZpc2liaWxpdHlTdGF0ZShtX2NsaWVudC0+dmlzaWJpbGl0eVN0YXRlKCksIHRydWUpOwog I2VuZGlmCiAKICAgICBtX2luc3BlY3RvclNldHRpbmdzTWFwID0gYWRvcHRQdHIobmV3IFNldHRp bmdzTWFwKTsK