61297 2011-05-23 12:23:11 -0700 fix rel=prerender target types 2011-05-23 16:50:38 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 gavinp webkit-unassigned abarth ap commit-queue gavinp tonyg webkit.review.bot oldest_to_newest 408142 0 gavinp 2011-05-23 12:23:11 -0700 fix rel=prerender target types 408146 1 94459 gavinp 2011-05-23 12:26:32 -0700 Created attachment 94459 Patch 408148 2 94459 gavinp 2011-05-23 12:28:16 -0700 Comment on attachment 94459 Patch I have learned a valuable lesson; always test the chrome side of a webkit patch that has chrome implication before uploading to WebKit. 408152 3 94459 abarth 2011-05-23 12:30:10 -0700 Comment on attachment 94459 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=94459&action=review > Source/WebCore/ChangeLog:10 > + The original fix in https://bugs.webkit.org/show_bug.cgi?id=61079 > + didn't properly map the target type, and didn't carry the target > + types through to chromium properly. Fixed. Bad indent. > Source/WebCore/ChangeLog:12 > + No new tests. How come? 408153 4 webkit.review.bot 2011-05-23 12:30:39 -0700 Attachment 94459 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit/chromium/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Source/WebKit/chromium/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Source/WebKit/chromium/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] Total errors found: 6 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 408158 5 94463 gavinp 2011-05-23 12:35:54 -0700 Created attachment 94463 Patch 408159 6 94463 gavinp 2011-05-23 12:36:19 -0700 Comment on attachment 94463 Patch tabsbegone, explanation about testing. 408468 7 94463 commit-queue 2011-05-23 16:50:32 -0700 Comment on attachment 94463 Patch Clearing flags on attachment: 94463 Committed r87106: <http://trac.webkit.org/changeset/87106> 408469 8 commit-queue 2011-05-23 16:50:38 -0700 All reviewed patches have been landed. Closing bug. 94459 2011-05-23 12:26:32 -0700 2011-05-23 12:35:47 -0700 Patch bug-61297-20110523152630.patch text/plain 2951 gavinp U3VidmVyc2lvbiBSZXZpc2lvbjogODcwODkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0MDdkZGM3OTVjNDcyZTA5 MjczZWE5ZDNlYmUwMWMwMWQ0ZGVjMjRhLi4xNDQ1ZmQwM2Q1OGJhMTQzYTFjNGQ2OTVlMDNjOGI1 YWYyMjU0YzYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDUtMjMgIEdhdmlu IFBldGVycyAgPGdhdmlucEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgZml4IHJlbD1wcmVyZW5kZXIgdGFyZ2V0IHR5cGVzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTI5NworCisJ VGhlIG9yaWdpbmFsIGZpeCBpbiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NjEwNzkKKwlkaWRuJ3QgcHJvcGVybHkgbWFwIHRoZSB0YXJnZXQgdHlwZSwgYW5kIGRpZG4n dCBjYXJyeSB0aGUgdGFyZ2V0CisJdHlwZXMgdGhyb3VnaCB0byBjaHJvbWl1bSBwcm9wZXJseS4g IEZpeGVkLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4KKworICAgICAgICAqIGxvYWRlci9jYWNo ZS9DYWNoZWRSZXNvdXJjZVJlcXVlc3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y2FjaGVkUmVz b3VyY2VUeXBlVG9UYXJnZXRUeXBlKToKKwogMjAxMS0wNS0yMyAgUnViZW4gIDxjaHJvbWl1bUBo eWJyaWRzb3VyY2Uub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRvbnkgQ2hhbmcuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2VSZXF1ZXN0 LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZVJlcXVlc3Qu Y3BwCmluZGV4IDI5OTBiODU4NDVhYmYwNzk4ODI0Nzc1OTljNjQ0NDQxNTM1MTFjNGMuLmIzZTNm N2JlMDk5N2RjZjcwZjVhNjk0OTU5NzI3NTk3NmZkYmQxZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZVJlcXVlc3QuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZVJlcXVlc3QuY3BwCkBAIC02Myw3 ICs2Myw3IEBAIHN0YXRpYyBSZXNvdXJjZVJlcXVlc3Q6OlRhcmdldFR5cGUgY2FjaGVkUmVzb3Vy Y2VUeXBlVG9UYXJnZXRUeXBlKENhY2hlZFJlc291cmNlCiAgICAgY2FzZSBDYWNoZWRSZXNvdXJj ZTo6TGlua1ByZWZldGNoOgogICAgICAgICByZXR1cm4gUmVzb3VyY2VSZXF1ZXN0OjpUYXJnZXRJ c1ByZWZldGNoOwogICAgIGNhc2UgQ2FjaGVkUmVzb3VyY2U6OkxpbmtQcmVyZW5kZXI6Ci0gICAg ICAgIHJldHVybiBSZXNvdXJjZVJlcXVlc3Q6OlRhcmdldElzU3VicmVzb3VyY2U7CisgICAgICAg IHJldHVybiBSZXNvdXJjZVJlcXVlc3Q6OlRhcmdldElzUHJlcmVuZGVyOwogICAgIGNhc2UgQ2Fj aGVkUmVzb3VyY2U6OkxpbmtTdWJyZXNvdXJjZToKICAgICAgICAgcmV0dXJuIFJlc291cmNlUmVx dWVzdDo6VGFyZ2V0SXNTdWJyZXNvdXJjZTsKICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxv ZwppbmRleCA2MjQ4ZjliNjNlYjZlZDMwOWFkMjI0N2RhZWE0YjkwZGIyYjg4NGQyLi5iY2M5YjM5 NjBkMjdhNTU5MGNhZTU5ZDI1MTZlZjIyMmJjYjdmMjhlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDExLTA1LTIzICBHYXZpbiBQZXRlcnMgIDxnYXZpbnBA Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIGZpeCByZWw9cHJlcmVuZGVyIHRhcmdldCB0eXBlcworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjEyOTcKKworCVRoZSBvcmlnaW5hbCBmaXgg aW4gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYxMDc5CisJZGlkbid0 IHByb3Blcmx5IG1hcCB0aGUgdGFyZ2V0IHR5cGUsIGFuZCBkaWRuJ3QgY2FycnkgdGhlIHRhcmdl dAorCXR5cGVzIHRocm91Z2ggdG8gY2hyb21pdW0gcHJvcGVybHkuICBGaXhlZC4KKworICAgICAg ICAqIHB1YmxpYy9XZWJVUkxSZXF1ZXN0Lmg6CisKIDIwMTEtMDUtMjMgIFJ1YmVuICA8Y2hyb21p dW1AaHlicmlkc291cmNlLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBUb255IENoYW5nLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVVJMUmVxdWVzdC5o IGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVVJMUmVxdWVzdC5oCmluZGV4IDU3 MTgyZjZmYjQzMzU2ZjhhMzA2NTIyODJhMjAxY2NhMWJlNjI1ZjguLjc1YTUxYzI5MzdkMjdmNjI3 MjNmYTAzMmE3ZTlmNjNjNDNjNzYzZDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vcHVibGljL1dlYlVSTFJlcXVlc3QuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1 YmxpYy9XZWJVUkxSZXF1ZXN0LmgKQEAgLTY5LDcgKzY5LDggQEAgcHVibGljOgogICAgICAgICBU YXJnZXRJc1dvcmtlciA9IDksCiAgICAgICAgIFRhcmdldElzU2hhcmVkV29ya2VyID0gMTAsCiAg ICAgICAgIFRhcmdldElzUHJlZmV0Y2ggPSAxMSwKLSAgICAgICAgVGFyZ2V0SXNGYXZpY29uID0g MTIsCisgICAgICAgIFRhcmdldElzUHJlcmVuZGVyID0gMTIsCisgICAgICAgIFRhcmdldElzRmF2 aWNvbiA9IDEzLAogICAgIH07CiAKICAgICBjbGFzcyBFeHRyYURhdGEgewo= 94463 2011-05-23 12:35:54 -0700 2011-05-23 16:50:32 -0700 Patch bug-61297-20110523153553.patch text/plain 3390 gavinp U3VidmVyc2lvbiBSZXZpc2lvbjogODcwODkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0MDdkZGM3OTVjNDcyZTA5 MjczZWE5ZDNlYmUwMWMwMWQ0ZGVjMjRhLi4zNDA0NWQ0MmE0OTQ0ZmYyZTlkM2JmM2I2MzQ5NDJj YzQyMjUxOTY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDUtMjMgIEdhdmlu IFBldGVycyAgPGdhdmlucEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgZml4IHJlbD1wcmVyZW5kZXIgdGFyZ2V0IHR5cGVzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTI5NworCisg ICAgICAgIFRoZSBvcmlnaW5hbCBmaXggaW4gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTYxMDc5CisgICAgICAgIGRpZG4ndCBwcm9wZXJseSBtYXAgdGhlIHRhcmdldCB0 eXBlLCBhbmQgZGlkbid0IGNhcnJ5IHRoZSB0YXJnZXQKKyAgICAgICAgdHlwZXMgdGhyb3VnaCB0 byBjaHJvbWl1bSBwcm9wZXJseS4gIEZpeGVkLgorCisgICAgICAgIE5vIG5ldyB0ZXN0czsgaXQn cyB2ZXJ5IGhhcmQgdG8gY2F0Y2ggdGhlc2Ugd2l0aCBhIGxheW91dCB0ZXN0LCBob3dldmVyCisg ICAgICAgIGFsbCBvZiB0aGUgY2hyb21pdW0gUHJlcmVuZGVyIGJyb3dzZXIgdGVzdHMgd2lsbCB0 ZXN0IHRoaXMgZnVuY3Rpb25hbGl0eQorICAgICAgICB3aGVuIEkgbGFuZCBhbiB1cGNvbWluZyBj aHJvbWl1bSBDTC4KKworICAgICAgICAqIGxvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZVJlcXVl c3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y2FjaGVkUmVzb3VyY2VUeXBlVG9UYXJnZXRUeXBl KToKKwogMjAxMS0wNS0yMyAgUnViZW4gIDxjaHJvbWl1bUBoeWJyaWRzb3VyY2Uub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IFRvbnkgQ2hhbmcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2VSZXF1ZXN0LmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2xvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZVJlcXVlc3QuY3BwCmluZGV4IDI5OTBiODU4NDVh YmYwNzk4ODI0Nzc1OTljNjQ0NDQxNTM1MTFjNGMuLmIzZTNmN2JlMDk5N2RjZjcwZjVhNjk0OTU5 NzI3NTk3NmZkYmQxZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9D YWNoZWRSZXNvdXJjZVJlcXVlc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNo ZS9DYWNoZWRSZXNvdXJjZVJlcXVlc3QuY3BwCkBAIC02Myw3ICs2Myw3IEBAIHN0YXRpYyBSZXNv dXJjZVJlcXVlc3Q6OlRhcmdldFR5cGUgY2FjaGVkUmVzb3VyY2VUeXBlVG9UYXJnZXRUeXBlKENh Y2hlZFJlc291cmNlCiAgICAgY2FzZSBDYWNoZWRSZXNvdXJjZTo6TGlua1ByZWZldGNoOgogICAg ICAgICByZXR1cm4gUmVzb3VyY2VSZXF1ZXN0OjpUYXJnZXRJc1ByZWZldGNoOwogICAgIGNhc2Ug Q2FjaGVkUmVzb3VyY2U6OkxpbmtQcmVyZW5kZXI6Ci0gICAgICAgIHJldHVybiBSZXNvdXJjZVJl cXVlc3Q6OlRhcmdldElzU3VicmVzb3VyY2U7CisgICAgICAgIHJldHVybiBSZXNvdXJjZVJlcXVl c3Q6OlRhcmdldElzUHJlcmVuZGVyOwogICAgIGNhc2UgQ2FjaGVkUmVzb3VyY2U6OkxpbmtTdWJy ZXNvdXJjZToKICAgICAgICAgcmV0dXJuIFJlc291cmNlUmVxdWVzdDo6VGFyZ2V0SXNTdWJyZXNv dXJjZTsKICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VM b2cgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwppbmRleCA2MjQ4ZjliNjNlYjZl ZDMwOWFkMjI0N2RhZWE0YjkwZGIyYjg4NGQyLi5lYmI0YThiNmI3MjQxNjQ5YzIyMWFjOTYzYTc0 MWFmNGE4N2NkNmYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxv ZworKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBA CisyMDExLTA1LTIzICBHYXZpbiBQZXRlcnMgIDxnYXZpbnBAY2hyb21pdW0ub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGZpeCByZWw9cHJlcmVu ZGVyIHRhcmdldCB0eXBlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NjEyOTcKKworICAgICAgICBUaGUgb3JpZ2luYWwgZml4IGluIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTA3OQorICAgICAgICBkaWRuJ3QgcHJvcGVy bHkgbWFwIHRoZSB0YXJnZXQgdHlwZSwgYW5kIGRpZG4ndCBjYXJyeSB0aGUgdGFyZ2V0CisgICAg ICAgIHR5cGVzIHRocm91Z2ggdG8gY2hyb21pdW0gcHJvcGVybHkuICBGaXhlZC4KKworICAgICAg ICBObyBuZXcgdGVzdHM7IGl0J3MgdmVyeSBoYXJkIHRvIGNhdGNoIHRoZXNlIHdpdGggYSBsYXlv dXQgdGVzdCwgaG93ZXZlcgorICAgICAgICBhbGwgb2YgdGhlIGNocm9taXVtIFByZXJlbmRlciBi cm93c2VyIHRlc3RzIHdpbGwgdGVzdCB0aGlzIGZ1bmN0aW9uYWxpdHkKKyAgICAgICAgd2hlbiBJ IGxhbmQgYW4gdXBjb21pbmcgY2hyb21pdW0gQ0wuCisKKyAgICAgICAgKiBwdWJsaWMvV2ViVVJM UmVxdWVzdC5oOgorCiAyMDExLTA1LTIzICBSdWJlbiAgPGNocm9taXVtQGh5YnJpZHNvdXJjZS5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgVG9ueSBDaGFuZy4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlVSTFJlcXVlc3QuaCBiL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYlVSTFJlcXVlc3QuaAppbmRleCA1NzE4MmY2ZmI0MzM1NmY4YTMw NjUyMjgyYTIwMWNjYTFiZTYyNWY4Li43NWE1MWMyOTM3ZDI3ZjYyNzIzZmEwMzJhN2U5ZjYzYzQz Yzc2M2Q1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJVUkxS ZXF1ZXN0LmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVVJMUmVxdWVz dC5oCkBAIC02OSw3ICs2OSw4IEBAIHB1YmxpYzoKICAgICAgICAgVGFyZ2V0SXNXb3JrZXIgPSA5 LAogICAgICAgICBUYXJnZXRJc1NoYXJlZFdvcmtlciA9IDEwLAogICAgICAgICBUYXJnZXRJc1By ZWZldGNoID0gMTEsCi0gICAgICAgIFRhcmdldElzRmF2aWNvbiA9IDEyLAorICAgICAgICBUYXJn ZXRJc1ByZXJlbmRlciA9IDEyLAorICAgICAgICBUYXJnZXRJc0Zhdmljb24gPSAxMywKICAgICB9 OwogCiAgICAgY2xhc3MgRXh0cmFEYXRhIHsK