61245 2011-05-22 02:32:01 -0700 When removing a shadow root from DOM, also remove it from the render tree 2011-05-22 08:56:21 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 59571 1 dominicc dominicc commit-queue dglazkov oldest_to_newest 407610 0 dominicc 2011-05-22 02:32:01 -0700 I have diagnosed the cause of the crashes discussed in bug 59571 as a shadow root remaining in the render tree after it is removed from the DOM. When a shadow root is removed from the DOM, it should also be removed from the render tree. 407611 1 94338 dominicc 2011-05-22 02:40:49 -0700 Created attachment 94338 Patch 407632 2 94338 dglazkov 2011-05-22 07:51:04 -0700 Comment on attachment 94338 Patch OMG. Good find. 407642 3 94338 commit-queue 2011-05-22 08:56:16 -0700 Comment on attachment 94338 Patch Clearing flags on attachment: 94338 Committed r87029: <http://trac.webkit.org/changeset/87029> 407643 4 commit-queue 2011-05-22 08:56:21 -0700 All reviewed patches have been landed. Closing bug. 94338 2011-05-22 02:40:49 -0700 2011-05-22 08:56:16 -0700 Patch bug-61245-20110522184045.patch text/plain 2627 dominicc U3VidmVyc2lvbiBSZXZpc2lvbjogODcwMjcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAzYTRlODAxNWQ0MmUyOTA0YzJjNjdk NjRmNzZlMWE1NGRhZmI5ODViLi4wZjYyZDc3MjcxOTRiOGRjN2FlZTU0NWQyYzA1YmQyYTdhYzY3 ZmZjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDUtMjIgIERvbWluaWMgQ29vbmV5ICA8 ZG9taW5pY2NAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFdoZW4gcmVtb3ZpbmcgYSBzaGFkb3cgcm9vdCwgYWxzbyByZW1vdmUg aXQgZnJvbSB0aGUgcmVuZGVyIHRyZWUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD02MTI0NQorCisgICAgICAgICogcGxhdGZvcm0vbWFjL1NraXBwZWQ6 IFVuc2tpcCBzaGFkb3cgdGVzdHMuCisKIDIwMTEtMDUtMjEgIERpcmsgU2NodWx6ZSAgPGtyaXRA d2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZv cm0vbWFjL1NraXBwZWQKaW5kZXggMzcxYjVjN2Q0MDRmNTYyOGEzMjNhYmMwNmJlMjcxNDc0MzZj OTdjMy4uZjcxZTNmNGZjZTQ1ZGJlOTVkYzg1YzdiN2U0ZWQ0OGZmYzUxZDA3YSAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vbWFjL1NraXBwZWQKQEAgLTM0NCw5ICszNDQsNiBAQCBmYXN0L2RvbS90aXRsZS1kaXJl Y3Rpb25hbGl0eS5odG1sCiAjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01ODkyNAogcGx1Z2lucy9tb3VzZS1jbGljay1pZnJhbWUtdG8tcGx1Z2luLmh0bWwKIAotIyBV bnNraXAgd2hlbiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTk1NzEg aXMgZml4ZWQKLWZhc3QvZG9tL3NoYWRvdwotCiAjIEFuaW1hdGlvbiBBUEkgaXMgZGlzYWJsZWQg YnkgZGVmYXVsdAogYW5pbWF0aW9ucy9hbmltYXRpb24tYXBpLTEuaHRtbAogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5k ZXggOGVlZmM1ODkzYmQzNzk1ZjBmM2UzZDRhMmJmMTRmZjc5OTU1ZTVkNy4uMmE0ZmI1MzgxM2Fk YjVlNTcyZTU3NzYwZTZlYTcwZDYxNWIzNzMyNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBA CisyMDExLTA1LTIyICBEb21pbmljIENvb25leSAgPGRvbWluaWNjQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIHJlbW92 aW5nIGEgc2hhZG93IHJvb3QsIGFsc28gcmVtb3ZlIGl0IGZyb20gdGhlIHJlbmRlciB0cmVlLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjEyNDUKKwor ICAgICAgICBUZXN0OiBleGlzdGluZyBmYXN0L2RvbS9zaGFkb3cvbGF5b3V0LXRlc3RzLWNhbi1h Y2Nlc3Mtc2hhZG93Lmh0bWwKKworICAgICAgICAqIGRvbS9FbGVtZW50LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkVsZW1lbnQ6OnJlbW92ZVNoYWRvd1Jvb3QpOiBDYWxsIGRldGFjaCBpZiBhdHRh Y2hlZC4KKwogMjAxMS0wNS0yMSAgRGlyayBTY2h1bHplICA8a3JpdEB3ZWJraXQub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvZG9tL0VsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCmluZGV4 IDI2MGQ2NTZmZjZmZGRmZDMyYmNmOTFkODU5YmU3YTY4ODA4ZDAyMDcuLmI5MmY5ZDViMzFiZWM2 MmVlYjAyMDUxOTE4NTk5MDU2OWI3YjFkMTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Rv bS9FbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKQEAgLTEy MDIsNyArMTIwMiwxMyBAQCB2b2lkIEVsZW1lbnQ6OnJlbW92ZVNoYWRvd1Jvb3QoKQogICAgICAg ICBJbnNwZWN0b3JJbnN0cnVtZW50YXRpb246OndpbGxSZW1vdmVET01Ob2RlKGRvY3VtZW50KCks IHRoaXMpOwogICAgICAgICBkYXRhLT5tX3NoYWRvd1Jvb3QgPSAwOwogICAgICAgICBkb2N1bWVu dCgpLT5yZW1vdmVGb2N1c2VkTm9kZU9mU3VidHJlZShvbGRSb290LmdldCgpKTsKKworICAgICAg ICAvLyBSZW1vdmUgZnJvbSByZW5kZXJpbmcgdHJlZQorICAgICAgICBpZiAob2xkUm9vdC0+YXR0 YWNoZWQoKSkKKyAgICAgICAgICAgIG9sZFJvb3QtPmRldGFjaCgpOworCiAgICAgICAgIG9sZFJv b3QtPnNldFNoYWRvd0hvc3QoMCk7CisKICAgICAgICAgaWYgKG9sZFJvb3QtPmluRG9jdW1lbnQo KSkKICAgICAgICAgICAgIG9sZFJvb3QtPnJlbW92ZWRGcm9tRG9jdW1lbnQoKTsKICAgICAgICAg ZWxzZQo=