<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>61042</bug_id>
          
          <creation_ts>2011-05-18 05:06:59 -0700</creation_ts>
          <short_desc>[Qt] Fix tst_QDeclarativeWebView::basicProperties() and historyNav() autotests</short_desc>
          <delta_ts>2011-11-03 13:37:45 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt, QtTriaged</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>38654</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Csaba Osztrogonác">ossy</reporter>
          <assigned_to name="Rafael Brandao">rafael.lobo</assigned_to>
          <cc>ademar</cc>
    
    <cc>benjamin</cc>
    
    <cc>cmarcelo</cc>
    
    <cc>commit-queue</cc>
    
    <cc>menard</cc>
    
    <cc>ossy</cc>
    
    <cc>rafael.lobo</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>405654</commentid>
    <comment_count>0</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-05-18 05:06:59 -0700</bug_when>
    <thetext>Error message with r86748:

FAIL!  : tst_QDeclarativeWebView::basicProperties() Compared values are not the same
   Actual (qvariant_cast&lt;QPixmap&gt;(wv-&gt;property(&quot;icon&quot;)).width()): 16
   Expected (48): 48
   Loc: [/ramdisk/qt-linux-release/build/Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp(104)]</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>407023</commentid>
    <comment_count>1</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-05-20 06:11:43 -0700</bug_when>
    <thetext>*** Bug 61043 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>407026</commentid>
    <comment_count>2</comment_count>
      <attachid>94205</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-05-20 06:15:31 -0700</bug_when>
    <thetext>Created attachment 94205
mark failing test cases as expected fail</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>407081</commentid>
    <comment_count>3</comment_count>
      <attachid>94205</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-05-20 07:27:59 -0700</bug_when>
    <thetext>Comment on attachment 94205
mark failing test cases as expected fail

Clearing flags on attachment: 94205

Committed r86952: &lt;http://trac.webkit.org/changeset/86952&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>407082</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-05-20 07:28:03 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>407083</commentid>
    <comment_count>5</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-05-20 07:28:41 -0700</bug_when>
    <thetext>Reopen to fix the bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>413582</commentid>
    <comment_count>6</comment_count>
    <who name="Ademar Reis">ademar</who>
    <bug_when>2011-06-01 12:32:44 -0700</bug_when>
    <thetext>Revision r86952 cherry-picked into qtwebkit-2.2 with commit fbde563 &lt;http://gitorious.org/webkit/qtwebkit/commit/fbde563&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>418220</commentid>
    <comment_count>7</comment_count>
    <who name="Rafael Brandao">rafael.lobo</who>
    <bug_when>2011-06-09 13:16:19 -0700</bug_when>
    <thetext>I think I&apos;ve almost solved this.

First, this test should expect the iconChanged signal before checking icon size. And then we also have a problem loading the icon for local files.

The problem lies on IconDatabase. It is defined there this static function called pageCanHaveIcon, and it only accepts pages whose protocol is part of http family (http or https), so if we load a local file, our page cannot have an icon, and then a default icon is loaded instead (whose size is 16x16), thus causing the test fail.

This function was added at r85056, but the patch does not describe very well why this decision was made, so I&apos;ve just tried to contact the author and ask more about it. 

I&apos;ve also added to the test QWebSettings::setIconDatabasePath, so I could clean the file where the icon is stored after the test, forcing the page to always load the icon.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>419524</commentid>
    <comment_count>8</comment_count>
    <who name="Alexis Menard (darktears)">menard</who>
    <bug_when>2011-06-13 06:16:21 -0700</bug_when>
    <thetext>(In reply to comment #7)
&gt; I think I&apos;ve almost solved this.
&gt; 
&gt; First, this test should expect the iconChanged signal before checking icon size. And then we also have a problem loading the icon for local files.
&gt; 
&gt; The problem lies on IconDatabase. It is defined there this static function called pageCanHaveIcon, and it only accepts pages whose protocol is part of http family (http or https), so if we load a local file, our page cannot have an icon, and then a default icon is loaded instead (whose size is 16x16), thus causing the test fail.
&gt; 
&gt; This function was added at r85056, but the patch does not describe very well why this decision was made, so I&apos;ve just tried to contact the author and ask more about it. 
&gt; 
&gt; I&apos;ve also added to the test QWebSettings::setIconDatabasePath, so I could clean the file where the icon is stored after the test, forcing the page to always load the icon.

Send the patch for review :D.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>422200</commentid>
    <comment_count>9</comment_count>
      <attachid>97491</attachid>
    <who name="Rafael Brandao">rafael.lobo</who>
    <bug_when>2011-06-16 14:05:38 -0700</bug_when>
    <thetext>Created attachment 97491
Forces icon to be loaded on each test by setting a temporary path for them, and making test to wait for the iconChange signal.

The change on IconDatabase is still being discussed (https://bugs.webkit.org/show_bug.cgi?id=62459), but I&apos;ll have to add a layout test for it anyway, so I don&apos;t expect this to be landed. I would like it to be reviewed on my changes related to tst_qdeclarativewebview, because as soon as I get it working on webkit, this could be easily landed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>422205</commentid>
    <comment_count>10</comment_count>
      <attachid>97491</attachid>
    <who name="Alexis Menard (darktears)">menard</who>
    <bug_when>2011-06-16 14:13:05 -0700</bug_when>
    <thetext>Comment on attachment 97491
Forces icon to be loaded on each test by setting a temporary path for them, and making test to wait for the iconChange signal.

View in context: https://bugs.webkit.org/attachment.cgi?id=97491&amp;action=review

You posted an unrelated patch :D.

&gt; Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:-165
&gt; -    QWebSettings::enablePersistentStorage(tmpDir());

Why this move?

&gt; Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:172
&gt; +    ::waitForSignal(wv, SIGNAL(iconChanged()), 15000);

By curiosity why ::?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>422258</commentid>
    <comment_count>11</comment_count>
    <who name="Rafael Brandao">rafael.lobo</who>
    <bug_when>2011-06-16 14:51:07 -0700</bug_when>
    <thetext>(In reply to comment #10)
&gt; (From update of attachment 97491 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=97491&amp;action=review
&gt; 
&gt; You posted an unrelated patch :D.
&gt; 
&gt; &gt; Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:-165
&gt; &gt; -    QWebSettings::enablePersistentStorage(tmpDir());
&gt; 
&gt; Why this move?

When I added QWebSettings::setIconDatabasePath in the beginning of the test, it felt like the another one was a bit late already, because it is called just after creating the QDeclarativeComponent. Thus, it seems more logical to me that we should adjust settings before doing (or possibly doing) anything on the test.

&gt; 
&gt; &gt; Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:172
&gt; &gt; +    ::waitForSignal(wv, SIGNAL(iconChanged()), 15000);
&gt; 
&gt; By curiosity why ::?

Nevermind... I&apos;ve found that being used that way so many times on tst_qwebpage before, that it felt like it was the preferred way to use it. :/</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>422313</commentid>
    <comment_count>12</comment_count>
      <attachid>97518</attachid>
    <who name="Rafael Brandao">rafael.lobo</who>
    <bug_when>2011-06-16 16:26:14 -0700</bug_when>
    <thetext>Created attachment 97518
Same as before, but without the unrelated patch and the annoying ::

If changing the order of QWebSettings is not a problem, I&apos;m confident this will fix the test fail. But as I said in the previous comment, this is not supposed to land until the other bug is fixed.

I should add that I&apos;ve modified the QTRY_COMPARE to COMPARE on those cases because I already wait 15 seconds for the icon to change, so if I get to the check and the icon is not already there, then it means something went wrong, and testing it more times may be pointless. If this is a problem I could put QTRY_COMPARE again.

Thanks for the feedback! :D</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>429043</commentid>
    <comment_count>13</comment_count>
      <attachid>97518</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2011-06-28 11:43:02 -0700</bug_when>
    <thetext>Comment on attachment 97518
Same as before, but without the unrelated patch and the annoying ::

View in context: https://bugs.webkit.org/attachment.cgi?id=97518&amp;action=review

&gt; Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:96
&gt; +    QWebSettings::setIconDatabasePath(tmpDir());
&gt; +    QWebSettings::enablePersistentStorage(tmpDir());

Unless you actually need to redo this multiple times, these should go in initTestCase() instead.

&gt; Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:103
&gt; +    waitForSignal(wv, SIGNAL(iconChanged()), 15000);

Any way we can avoid the 15 second timeout? ;(</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>434488</commentid>
    <comment_count>14</comment_count>
      <attachid>97518</attachid>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2011-07-09 06:20:57 -0700</bug_when>
    <thetext>Comment on attachment 97518
Same as before, but without the unrelated patch and the annoying ::

The patch makes sense. Please fix the code from Andreas&apos; comments
Wha about the others &quot;QEXPECT_FAIL(&quot;&quot;, &quot;&apos;icon&apos; property isn&apos;t working&quot;, Continue);&quot; ???</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>440937</commentid>
    <comment_count>15</comment_count>
    <who name="Rafael Brandao">rafael.lobo</who>
    <bug_when>2011-07-22 07:12:21 -0700</bug_when>
    <thetext>Thanks Benjamin, I really forgot to check the other XFAIL that was already there. I could fix the ones that complain about the &apos;icon&apos; property. But it has been a bit of time that I didn&apos;t come back to this, and now I see that was other tests failing there as well. I&apos;ve filed another bug report (https://bugs.webkit.org/show_bug.cgi?id=64989) and I wonder if I should wait to get it resolved first. If you&apos;re around, feel free to look into it as well! :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>445230</commentid>
    <comment_count>16</comment_count>
      <attachid>102642</attachid>
    <who name="Kristóf Kosztyó">kkristof</who>
    <bug_when>2011-08-02 06:25:48 -0700</bug_when>
    <thetext>Created attachment 102642
remove mark as expected fail where XPASS and mark failing test cases as expected fail</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>445238</commentid>
    <comment_count>17</comment_count>
      <attachid>102642</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-08-02 06:50:19 -0700</bug_when>
    <thetext>Comment on attachment 102642
remove mark as expected fail where XPASS and mark failing test cases as expected fail

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>445239</commentid>
    <comment_count>18</comment_count>
      <attachid>102642</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-08-02 06:59:31 -0700</bug_when>
    <thetext>Comment on attachment 102642
remove mark as expected fail where XPASS and mark failing test cases as expected fail

landed in https://trac.webkit.org/changeset/92186</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>447599</commentid>
    <comment_count>19</comment_count>
      <attachid>103147</attachid>
    <who name="Rafael Brandao">rafael.lobo</who>
    <bug_when>2011-08-06 05:06:24 -0700</bug_when>
    <thetext>Created attachment 103147
Following kling&apos;s advices, and solving some issues around comparison of bitmaps in this test.

According to Qt doc, instead of &quot;qrc://&quot;, for a QDir you must use &quot;:/&quot;. As QPixmap was expecting a file path, it wouldn&apos;t resolve the file with the url format. As the icon and this not retrieved image were both empty QPixmaps, the test was presenting a false positive.

For the issues around QActions on historyNav() test case, there is a small patch pending for review on https://bugs.webkit.org/show_bug.cgi?id=64989 with a quick solution. If anyone else wants to investigate those errors, go ahead. :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>495747</commentid>
    <comment_count>20</comment_count>
      <attachid>103147</attachid>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2011-11-03 13:24:53 -0700</bug_when>
    <thetext>Comment on attachment 103147
Following kling&apos;s advices, and solving some issues around comparison of bitmaps in this test.

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>495759</commentid>
    <comment_count>21</comment_count>
      <attachid>103147</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-11-03 13:37:35 -0700</bug_when>
    <thetext>Comment on attachment 103147
Following kling&apos;s advices, and solving some issues around comparison of bitmaps in this test.

Clearing flags on attachment: 103147

Committed r99235: &lt;http://trac.webkit.org/changeset/99235&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>495760</commentid>
    <comment_count>22</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-11-03 13:37:45 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>94205</attachid>
            <date>2011-05-20 06:15:31 -0700</date>
            <delta_ts>2011-05-20 07:29:16 -0700</delta_ts>
            <desc>mark failing test cases as expected fail</desc>
            <filename>1.patch</filename>
            <type>text/plain</type>
            <size>2785</size>
            <attacher name="Csaba Osztrogonác">ossy</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9x
dC9DaGFuZ2VMb2cKaW5kZXggMzNkOTM0YS4uMWRlNjIwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dl
YktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxNCBAQAorMjAxMS0wNS0yMCAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu
b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtR
dF0gRml4IHRzdF9RRGVjbGFyYXRpdmVXZWJWaWV3OjpiYXNpY1Byb3BlcnRpZXMoKSBhbmQgaGlz
dG9yeU5hdigpIGF1dG90ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9NjEwNDIKKworICAgICAgICAqIHRlc3RzL3FkZWNsYXJhdGl2ZXdlYnZpZXcv
dHN0X3FkZWNsYXJhdGl2ZXdlYnZpZXcuY3BwOiBNYXJrIGZhaWxpbmcgdGVzdCBjYXNlcyBhcyBl
eHBlY3RlZCBmYWlscy4KKyAgICAgICAgKHRzdF9RRGVjbGFyYXRpdmVXZWJWaWV3OjpiYXNpY1By
b3BlcnRpZXMpOgorICAgICAgICAodHN0X1FEZWNsYXJhdGl2ZVdlYlZpZXc6Omhpc3RvcnlOYXYp
OgorCiAyMDExLTA1LTE5ICBac29sdCBGZWjDqXIgIDxoNDkwMjY3QHN0dWQudS1zemVnZWQuaHU+
CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQ3NhYmEgT3N6dHJvZ29uw6FjLgpkaWZmIC0tZ2l0IGEv
U291cmNlL1dlYktpdC9xdC90ZXN0cy9xZGVjbGFyYXRpdmV3ZWJ2aWV3L3RzdF9xZGVjbGFyYXRp
dmV3ZWJ2aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcWRlY2xhcmF0aXZld2Vidmll
dy90c3RfcWRlY2xhcmF0aXZld2Vidmlldy5jcHAKaW5kZXggZmZmMWYyZC4uZGEzYjcyZiAxMDA2
NDQKLS0tIGEvU291cmNlL1dlYktpdC9xdC90ZXN0cy9xZGVjbGFyYXRpdmV3ZWJ2aWV3L3RzdF9x
ZGVjbGFyYXRpdmV3ZWJ2aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL3FkZWNs
YXJhdGl2ZXdlYnZpZXcvdHN0X3FkZWNsYXJhdGl2ZXdlYnZpZXcuY3BwCkBAIC0xMDEsNiArMTAx
LDcgQEAgdm9pZCB0c3RfUURlY2xhcmF0aXZlV2ViVmlldzo6YmFzaWNQcm9wZXJ0aWVzKCkKICAg
ICBRVkVSSUZZKHd2KTsKICAgICBRVFJZX0NPTVBBUkUod3YtPnByb3BlcnR5KCJwcm9ncmVzcyIp
LnRvRG91YmxlKCksIDEuMCk7CiAgICAgUUNPTVBBUkUod3YtPnByb3BlcnR5KCJ0aXRsZSIpLnRv
U3RyaW5nKCksIFFMYXRpbjFTdHJpbmcoIkJhc2ljIikpOworICAgIFFFWFBFQ1RfRkFJTCgiIiwg
Imh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTA0MiIsIENvbnRpbnVl
KTsKICAgICBRVFJZX0NPTVBBUkUocXZhcmlhbnRfY2FzdDxRUGl4bWFwPih3di0+cHJvcGVydHko
Imljb24iKSkud2lkdGgoKSwgNDgpOwogICAgIFFFWFBFQ1RfRkFJTCgiIiwgIidpY29uJyBwcm9w
ZXJ0eSBpc24ndCB3b3JraW5nIiwgQ29udGludWUpOwogICAgIFFDT01QQVJFKHF2YXJpYW50X2Nh
c3Q8UVBpeG1hcD4od3YtPnByb3BlcnR5KCJpY29uIikpLCBRUGl4bWFwKCJxcmM6Ly8vcmVzb3Vy
Y2VzL2Jhc2ljLnBuZyIpKTsKQEAgLTE3OCw2ICsxNzksNyBAQCB2b2lkIHRzdF9RRGVjbGFyYXRp
dmVXZWJWaWV3OjpoaXN0b3J5TmF2KCkKICAgICBmb3IgKGludCBpID0gMTsgaSA8PSAyOyArK2kp
IHsKICAgICAgICAgUVRSWV9DT01QQVJFKHd2LT5wcm9wZXJ0eSgicHJvZ3Jlc3MiKS50b0RvdWJs
ZSgpLCAxLjApOwogICAgICAgICBRQ09NUEFSRSh3di0+cHJvcGVydHkoInRpdGxlIikudG9TdHJp
bmcoKSwgUUxhdGluMVN0cmluZygiQmFzaWMiKSk7CisgICAgICAgIFFFWFBFQ1RfRkFJTCgiIiwg
Imh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTA0MiIsIENvbnRpbnVl
KTsKICAgICAgICAgUVRSWV9DT01QQVJFKHF2YXJpYW50X2Nhc3Q8UVBpeG1hcD4od3YtPnByb3Bl
cnR5KCJpY29uIikpLndpZHRoKCksIDQ4KTsKICAgICAgICAgUUVYUEVDVF9GQUlMKCIiLCAiJ2lj
b24nIHByb3BlcnR5IGlzbid0IHdvcmtpbmciLCBDb250aW51ZSk7CiAgICAgICAgIFFDT01QQVJF
KHF2YXJpYW50X2Nhc3Q8UVBpeG1hcD4od3YtPnByb3BlcnR5KCJpY29uIikpLCBRUGl4bWFwKCJx
cmM6Ly8vZGF0YS9iYXNpYy5wbmciKSk7CkBAIC0xOTcsNiArMTk5LDcgQEAgdm9pZCB0c3RfUURl
Y2xhcmF0aXZlV2ViVmlldzo6aGlzdG9yeU5hdigpCiAgICAgd3YtPnNldFByb3BlcnR5KCJ1cmwi
LCBRVXJsKCJxcmM6Ly8vcmVzb3VyY2VzL2ZvcndhcmQuaHRtbCIpKTsKICAgICBRVFJZX0NPTVBB
UkUod3YtPnByb3BlcnR5KCJwcm9ncmVzcyIpLnRvRG91YmxlKCksIDEuMCk7CiAgICAgUUNPTVBB
UkUod3YtPnByb3BlcnR5KCJ0aXRsZSIpLnRvU3RyaW5nKCksIFFMYXRpbjFTdHJpbmcoIkZvcndh
cmQiKSk7CisgICAgUUVYUEVDVF9GQUlMKCIiLCAiaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTYxMDQyIiwgQ29udGludWUpOwogICAgIFFUUllfQ09NUEFSRShxdmFyaWFu
dF9jYXN0PFFQaXhtYXA+KHd2LT5wcm9wZXJ0eSgiaWNvbiIpKS53aWR0aCgpLCAzMik7CiAgICAg
UUVYUEVDVF9GQUlMKCIiLCAiJ2ljb24nIHByb3BlcnR5IGlzbid0IHdvcmtpbmciLCBDb250aW51
ZSk7CiAgICAgUUNPTVBBUkUocXZhcmlhbnRfY2FzdDxRUGl4bWFwPih3di0+cHJvcGVydHkoImlj
b24iKSksIFFQaXhtYXAoInFyYzovLy9yZXNvdXJjZXMvZm9yd2FyZC5wbmciKSk7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>97491</attachid>
            <date>2011-06-16 14:05:38 -0700</date>
            <delta_ts>2011-06-16 16:26:14 -0700</delta_ts>
            <desc>Forces icon to be loaded on each test by setting a temporary path for them, and making test to wait for the iconChange signal.</desc>
            <filename>icon-loading-qtwebkit-wip.diff</filename>
            <type>text/plain</type>
            <size>7091</size>
            <attacher name="Rafael Brandao">rafael.lobo</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCBlZWQxMzAwLi5kNmFiN2FiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg
QEAKKzIwMTEtMDYtMTYgIFJhZmFlbCBCcmFuZGFvICA8cmFmYWVsLmxvYm9Ab3BlbmJvc3NhLm9y
Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRd
IEZpeCB0c3RfUURlY2xhcmF0aXZlV2ViVmlldzo6YmFzaWNQcm9wZXJ0aWVzKCkgYW5kIGhpc3Rv
cnlOYXYoKSBhdXRvdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTYxMDQyCisKKyAgICAgICAgUHJldmlvdXMgcG9saWN5IGRldGVybWluZWQgdGhh
dCBvbmx5IHVybHMgd2hvc2UgcHJvdG9jb2wgd2FzIHBhcnQgb2YgSFRUUCBmYW1pbHkgY291bGQK
KyAgICAgICAgaGF2ZSBpY29ucy4gQ2hhbmdlZCB0byBhbGxvdyB0aGF0IHRvIGFueSB1cmwgdGhh
dCdzIG5vdCBlbXB0eSBhbmQgbm90IGEgYmxhbmsgdXJsLgorCisgICAgICAgICogbG9hZGVyL2lj
b24vSWNvbkRhdGFiYXNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnBhZ2VDYW5IYXZlSWNvbik6
CisgICAgICAgICogcGxhdGZvcm0vS1VSTC5jcHA6CisgICAgICAgICogcGxhdGZvcm0vS1VSTC5o
OgorCiAyMDExLTA2LTEzICBOb2FtIFJvc2VudGhhbCAgPG5vYW0ucm9zZW50aGFsQG5va2lhLmNv
bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4KZGlm
ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9pY29uL0ljb25EYXRhYmFzZS5jcHAgYi9T
b3VyY2UvV2ViQ29yZS9sb2FkZXIvaWNvbi9JY29uRGF0YWJhc2UuY3BwCmluZGV4IDM5ZGIwNjcu
Ljg3ODEyZjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9pY29uL0ljb25EYXRh
YmFzZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2ljb24vSWNvbkRhdGFiYXNlLmNw
cApAQCAtMTAxLDcgKzEwMSw3IEBAIHN0YXRpYyBJY29uRGF0YWJhc2VDbGllbnQqIGRlZmF1bHRD
bGllbnQoKQogCiBzdGF0aWMgaW5saW5lIGJvb2wgcGFnZUNhbkhhdmVJY29uKGNvbnN0IFN0cmlu
ZyYgcGFnZVVSTCkKIHsKLSAgICByZXR1cm4gcHJvdG9jb2xJc0luSFRUUEZhbWlseShwYWdlVVJM
KTsKKyAgICByZXR1cm4gIXBhZ2VVUkwuaXNFbXB0eSgpICYmICFwcm90b2NvbElzKHBhZ2VVUkws
ICJhYm91dCIpOwogfQogCiAvLyAqKioqKioqKioqKioqKioqKioqKioqKioKZGlmZiAtLWdpdCBh
L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0tVUkwuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv
cm0vS1VSTC5jcHAKaW5kZXggODYxMWVkMS4uMWYyYzI4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dl
YkNvcmUvcGxhdGZvcm0vS1VSTC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vS1VS
TC5jcHAKQEAgLTE5NzAsMTcgKzE5NzAsNCBAQCBTdHJpbmcgbWltZVR5cGVGcm9tRGF0YVVSTChj
b25zdCBTdHJpbmcmIHVybCkKICAgICByZXR1cm4gIiI7CiB9CiAKLWJvb2wgcHJvdG9jb2xJc0lu
SFRUUEZhbWlseShjb25zdCBTdHJpbmcmIHVybCkKLXsKLSAgICB1bnNpZ25lZCBsZW5ndGggPSB1
cmwubGVuZ3RoKCk7Ci0gICAgY29uc3QgVUNoYXIqIGNoYXJhY3RlcnMgPSB1cmwuY2hhcmFjdGVy
cygpOwotICAgIHJldHVybiBsZW5ndGggPiA0Ci0gICAgICAgICYmIGlzTGV0dGVyTWF0Y2hJZ25v
cmluZ0Nhc2UoY2hhcmFjdGVyc1swXSwgJ2gnKQotICAgICAgICAmJiBpc0xldHRlck1hdGNoSWdu
b3JpbmdDYXNlKGNoYXJhY3RlcnNbMV0sICd0JykKLSAgICAgICAgJiYgaXNMZXR0ZXJNYXRjaEln
bm9yaW5nQ2FzZShjaGFyYWN0ZXJzWzJdLCAndCcpCi0gICAgICAgICYmIGlzTGV0dGVyTWF0Y2hJ
Z25vcmluZ0Nhc2UoY2hhcmFjdGVyc1szXSwgJ3AnKQotICAgICAgICAmJiAoY2hhcmFjdGVyc1s0
XSA9PSAnOicKLSAgICAgICAgICAgIHx8IChpc0xldHRlck1hdGNoSWdub3JpbmdDYXNlKGNoYXJh
Y3RlcnNbNF0sICdzJykgJiYgbGVuZ3RoID4gNSAmJiBjaGFyYWN0ZXJzWzVdID09ICc6JykpOwot
fQotCiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9LVVJMLmggYi9Tb3Vy
Y2UvV2ViQ29yZS9wbGF0Zm9ybS9LVVJMLmgKaW5kZXggZjYyMTE4MC4uYWFhZDkwYyAxMDA2NDQK
LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vS1VSTC5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl
L3BsYXRmb3JtL0tVUkwuaApAQCAtMjg0LDcgKzI4NCw2IEBAIGNvbnN0IEtVUkwmIGJsYW5rVVJM
KCk7CiAvLyBUaGlzIGlzIGVzcGVjaWFsbHkgaW1wb3J0YW50IGJlY2F1c2UgdmFsaWQgamF2YXNj
cmlwdCBVUkxzIGFyZSBub3QgbmVjZXNzYXJpbHkgY29uc2lkZXJlZCB2YWxpZCBieSBLVVJMLgog
CiBib29sIHByb3RvY29sSXMoY29uc3QgU3RyaW5nJiB1cmwsIGNvbnN0IGNoYXIqIHByb3RvY29s
KTsKLWJvb2wgcHJvdG9jb2xJc0luSFRUUEZhbWlseShjb25zdCBTdHJpbmcmIHVybCk7CiBib29s
IHByb3RvY29sSXNKYXZhU2NyaXB0KGNvbnN0IFN0cmluZyYgdXJsKTsKIAogYm9vbCBpc0RlZmF1
bHRQb3J0Rm9yUHJvdG9jb2wodW5zaWduZWQgc2hvcnQgcG9ydCwgY29uc3QgU3RyaW5nJiBwcm90
b2NvbCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxvZyBiL1NvdXJjZS9X
ZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IGJhNjUxMDkuLjdmZWJhYTggMTAwNjQ0Ci0tLSBhL1Nv
dXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9n
CkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDYtMTYgIFJhZmFlbCBCcmFuZGFvICA8cmFmYWVsLmxv
Ym9Ab3BlbmJvc3NhLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K
KworICAgICAgICBbUXRdIEZpeCB0c3RfUURlY2xhcmF0aXZlV2ViVmlldzo6YmFzaWNQcm9wZXJ0
aWVzKCkgYW5kIGhpc3RvcnlOYXYoKSBhdXRvdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYxMDQyCisgICAgICAgIAorICAgICAgICBUaGlzIHRl
c3QgaGFkIG5vIGd1YXJhbnRlZSB0aGF0IHRoZSBpY29uIHdvdWxkIGxvYWQgYmVmb3JlIGljb24g
Y2hlY2tzLgorCisgICAgICAgICogdGVzdHMvcWRlY2xhcmF0aXZld2Vidmlldy90c3RfcWRlY2xh
cmF0aXZld2Vidmlldy5jcHA6CisgICAgICAgICh0c3RfUURlY2xhcmF0aXZlV2ViVmlldzo6YmFz
aWNQcm9wZXJ0aWVzKToKKyAgICAgICAgKHRzdF9RRGVjbGFyYXRpdmVXZWJWaWV3OjpoaXN0b3J5
TmF2KToKKwogMjAxMS0wNi0xMiAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAg
ICAgICAgIFJldmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCmRpZmYgLS1naXQgYS9Tb3Vy
Y2UvV2ViS2l0L3F0L3Rlc3RzL3FkZWNsYXJhdGl2ZXdlYnZpZXcvdHN0X3FkZWNsYXJhdGl2ZXdl
YnZpZXcuY3BwIGIvU291cmNlL1dlYktpdC9xdC90ZXN0cy9xZGVjbGFyYXRpdmV3ZWJ2aWV3L3Rz
dF9xZGVjbGFyYXRpdmV3ZWJ2aWV3LmNwcAppbmRleCA1Y2UxZWIxLi4zN2VkNDU1IDEwMDY0NAot
LS0gYS9Tb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL3FkZWNsYXJhdGl2ZXdlYnZpZXcvdHN0X3FkZWNs
YXJhdGl2ZXdlYnZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcWRlY2xhcmF0
aXZld2Vidmlldy90c3RfcWRlY2xhcmF0aXZld2Vidmlldy5jcHAKQEAgLTkyLDE2ICs5MiwxOCBA
QCB2b2lkIHRzdF9RRGVjbGFyYXRpdmVXZWJWaWV3OjpjbGVhbnVwVGVzdENhc2UoKQogCiB2b2lk
IHRzdF9RRGVjbGFyYXRpdmVXZWJWaWV3OjpiYXNpY1Byb3BlcnRpZXMoKQogeworICAgIFFXZWJT
ZXR0aW5nczo6c2V0SWNvbkRhdGFiYXNlUGF0aCh0bXBEaXIoKSk7CisgICAgUVdlYlNldHRpbmdz
OjplbmFibGVQZXJzaXN0ZW50U3RvcmFnZSh0bXBEaXIoKSk7CiAgICAgUURlY2xhcmF0aXZlRW5n
aW5lIGVuZ2luZTsKICAgICBRRGVjbGFyYXRpdmVDb21wb25lbnQgY29tcG9uZW50KCZlbmdpbmUs
IFFVcmwoInFyYzovLy9yZXNvdXJjZXMvYmFzaWMucW1sIikpOwogICAgIGNoZWNrTm9FcnJvcnMo
Y29tcG9uZW50KTsKLSAgICBRV2ViU2V0dGluZ3M6OmVuYWJsZVBlcnNpc3RlbnRTdG9yYWdlKHRt
cERpcigpKTsKIAogICAgIFFPYmplY3QqIHd2ID0gY29tcG9uZW50LmNyZWF0ZSgpOwogICAgIFFW
RVJJRlkod3YpOworICAgIDo6d2FpdEZvclNpZ25hbCh3diwgU0lHTkFMKGljb25DaGFuZ2VkKCkp
LCAxNTAwMCk7CisKICAgICBRVFJZX0NPTVBBUkUod3YtPnByb3BlcnR5KCJwcm9ncmVzcyIpLnRv
RG91YmxlKCksIDEuMCk7CiAgICAgUUNPTVBBUkUod3YtPnByb3BlcnR5KCJ0aXRsZSIpLnRvU3Ry
aW5nKCksIFFMYXRpbjFTdHJpbmcoIkJhc2ljIikpOwotICAgIFFFWFBFQ1RfRkFJTCgiIiwgImh0
dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTA0MiIsIENvbnRpbnVlKTsK
ICAgICBRVFJZX0NPTVBBUkUocXZhcmlhbnRfY2FzdDxRUGl4bWFwPih3di0+cHJvcGVydHkoImlj
b24iKSkud2lkdGgoKSwgNDgpOwogICAgIFFFWFBFQ1RfRkFJTCgiIiwgIidpY29uJyBwcm9wZXJ0
eSBpc24ndCB3b3JraW5nIiwgQ29udGludWUpOwogICAgIFFDT01QQVJFKHF2YXJpYW50X2Nhc3Q8
UVBpeG1hcD4od3YtPnByb3BlcnR5KCJpY29uIikpLCBRUGl4bWFwKCJxcmM6Ly8vcmVzb3VyY2Vz
L2Jhc2ljLnBuZyIpKTsKQEAgLTE1OSwxMyArMTYxLDE1IEBAIHZvaWQgdHN0X1FEZWNsYXJhdGl2
ZVdlYlZpZXc6OmVsZW1lbnRBcmVhQXQoKQogCiB2b2lkIHRzdF9RRGVjbGFyYXRpdmVXZWJWaWV3
OjpoaXN0b3J5TmF2KCkKIHsKKyAgICBRV2ViU2V0dGluZ3M6OnNldEljb25EYXRhYmFzZVBhdGgo
dG1wRGlyKCkpOworICAgIFFXZWJTZXR0aW5nczo6ZW5hYmxlUGVyc2lzdGVudFN0b3JhZ2UodG1w
RGlyKCkpOwogICAgIFFEZWNsYXJhdGl2ZUVuZ2luZSBlbmdpbmU7CiAgICAgUURlY2xhcmF0aXZl
Q29tcG9uZW50IGNvbXBvbmVudCgmZW5naW5lLCBRVXJsKCJxcmM6Ly8vcmVzb3VyY2VzL2Jhc2lj
LnFtbCIpKTsKICAgICBjaGVja05vRXJyb3JzKGNvbXBvbmVudCk7Ci0gICAgUVdlYlNldHRpbmdz
OjplbmFibGVQZXJzaXN0ZW50U3RvcmFnZSh0bXBEaXIoKSk7CiAKICAgICBRT2JqZWN0KiB3diA9
IGNvbXBvbmVudC5jcmVhdGUoKTsKICAgICBRVkVSSUZZKHd2KTsKKyAgICA6OndhaXRGb3JTaWdu
YWwod3YsIFNJR05BTChpY29uQ2hhbmdlZCgpKSwgMTUwMDApOwogCiAgICAgUUFjdGlvbiogcmVs
b2FkQWN0aW9uID0gd3YtPnByb3BlcnR5KCJyZWxvYWQiKS52YWx1ZTxRQWN0aW9uKj4oKTsKICAg
ICBRVkVSSUZZKHJlbG9hZEFjdGlvbik7CkBAIC0xNzksOCArMTgzLDcgQEAgdm9pZCB0c3RfUURl
Y2xhcmF0aXZlV2ViVmlldzo6aGlzdG9yeU5hdigpCiAgICAgZm9yIChpbnQgaSA9IDE7IGkgPD0g
MjsgKytpKSB7CiAgICAgICAgIFFUUllfQ09NUEFSRSh3di0+cHJvcGVydHkoInByb2dyZXNzIiku
dG9Eb3VibGUoKSwgMS4wKTsKICAgICAgICAgUUNPTVBBUkUod3YtPnByb3BlcnR5KCJ0aXRsZSIp
LnRvU3RyaW5nKCksIFFMYXRpbjFTdHJpbmcoIkJhc2ljIikpOwotICAgICAgICBRRVhQRUNUX0ZB
SUwoIiIsICJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjEwNDIiLCBD
b250aW51ZSk7Ci0gICAgICAgIFFUUllfQ09NUEFSRShxdmFyaWFudF9jYXN0PFFQaXhtYXA+KHd2
LT5wcm9wZXJ0eSgiaWNvbiIpKS53aWR0aCgpLCA0OCk7CisgICAgICAgIFFDT01QQVJFKHF2YXJp
YW50X2Nhc3Q8UVBpeG1hcD4od3YtPnByb3BlcnR5KCJpY29uIikpLndpZHRoKCksIDQ4KTsKICAg
ICAgICAgUUVYUEVDVF9GQUlMKCIiLCAiJ2ljb24nIHByb3BlcnR5IGlzbid0IHdvcmtpbmciLCBD
b250aW51ZSk7CiAgICAgICAgIFFDT01QQVJFKHF2YXJpYW50X2Nhc3Q8UVBpeG1hcD4od3YtPnBy
b3BlcnR5KCJpY29uIikpLCBRUGl4bWFwKCJxcmM6Ly8vZGF0YS9iYXNpYy5wbmciKSk7CiAgICAg
ICAgIFFDT01QQVJFKHd2LT5wcm9wZXJ0eSgic3RhdHVzVGV4dCIpLnRvU3RyaW5nKCksIFFMYXRp
bjFTdHJpbmcoInN0YXR1cyBoZXJlIikpOwpAQCAtMTk3LDEwICsyMDAsMTAgQEAgdm9pZCB0c3Rf
UURlY2xhcmF0aXZlV2ViVmlldzo6aGlzdG9yeU5hdigpCiAgICAgfQogCiAgICAgd3YtPnNldFBy
b3BlcnR5KCJ1cmwiLCBRVXJsKCJxcmM6Ly8vcmVzb3VyY2VzL2ZvcndhcmQuaHRtbCIpKTsKKyAg
ICA6OndhaXRGb3JTaWduYWwod3YsIFNJR05BTChpY29uQ2hhbmdlZCgpKSwgMTUwMDApOwogICAg
IFFUUllfQ09NUEFSRSh3di0+cHJvcGVydHkoInByb2dyZXNzIikudG9Eb3VibGUoKSwgMS4wKTsK
ICAgICBRQ09NUEFSRSh3di0+cHJvcGVydHkoInRpdGxlIikudG9TdHJpbmcoKSwgUUxhdGluMVN0
cmluZygiRm9yd2FyZCIpKTsKLSAgICBRRVhQRUNUX0ZBSUwoIiIsICJodHRwczovL2J1Z3Mud2Vi
a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjEwNDIiLCBDb250aW51ZSk7Ci0gICAgUVRSWV9DT01Q
QVJFKHF2YXJpYW50X2Nhc3Q8UVBpeG1hcD4od3YtPnByb3BlcnR5KCJpY29uIikpLndpZHRoKCks
IDMyKTsKKyAgICBRQ09NUEFSRShxdmFyaWFudF9jYXN0PFFQaXhtYXA+KHd2LT5wcm9wZXJ0eSgi
aWNvbiIpKS53aWR0aCgpLCAzMik7CiAgICAgUUVYUEVDVF9GQUlMKCIiLCAiJ2ljb24nIHByb3Bl
cnR5IGlzbid0IHdvcmtpbmciLCBDb250aW51ZSk7CiAgICAgUUNPTVBBUkUocXZhcmlhbnRfY2Fz
dDxRUGl4bWFwPih3di0+cHJvcGVydHkoImljb24iKSksIFFQaXhtYXAoInFyYzovLy9yZXNvdXJj
ZXMvZm9yd2FyZC5wbmciKSk7CiAgICAgUUNPTVBBUkUoc3RyaXBwZWRIdG1sKGZpbGVDb250ZW50
cygiOi9yZXNvdXJjZXMvZm9yd2FyZC5odG1sIikpLCBzdHJpcHBlZEh0bWwod3YtPnByb3BlcnR5
KCJodG1sIikudG9TdHJpbmcoKSkpOwo=
</data>
<flag name="review"
          id="91457"
          type_id="1"
          status="-"
          setter="menard"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>97518</attachid>
            <date>2011-06-16 16:26:14 -0700</date>
            <delta_ts>2011-08-02 06:59:47 -0700</delta_ts>
            <desc>Same as before, but without the unrelated patch and the annoying ::</desc>
            <filename>icon-loading-qtwebkit.diff</filename>
            <type>text/plain</type>
            <size>4340</size>
            <attacher name="Rafael Brandao">rafael.lobo</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9x
dC9DaGFuZ2VMb2cKaW5kZXggYmE2NTEwOS4uN2ZlYmFhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dl
YktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxNiBAQAorMjAxMS0wNi0xNiAgUmFmYWVsIEJyYW5kYW8gIDxyYWZhZWwubG9ib0BvcGVu
Ym9zc2Eub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg
ICAgIFtRdF0gRml4IHRzdF9RRGVjbGFyYXRpdmVXZWJWaWV3OjpiYXNpY1Byb3BlcnRpZXMoKSBh
bmQgaGlzdG9yeU5hdigpIGF1dG90ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y
Zy9zaG93X2J1Zy5jZ2k/aWQ9NjEwNDIKKyAgICAgICAgCisgICAgICAgIFRoaXMgdGVzdCBoYWQg
bm8gZ3VhcmFudGVlIHRoYXQgdGhlIGljb24gd291bGQgbG9hZCBiZWZvcmUgaWNvbiBjaGVja3Mu
CisKKyAgICAgICAgKiB0ZXN0cy9xZGVjbGFyYXRpdmV3ZWJ2aWV3L3RzdF9xZGVjbGFyYXRpdmV3
ZWJ2aWV3LmNwcDoKKyAgICAgICAgKHRzdF9RRGVjbGFyYXRpdmVXZWJWaWV3OjpiYXNpY1Byb3Bl
cnRpZXMpOgorICAgICAgICAodHN0X1FEZWNsYXJhdGl2ZVdlYlZpZXc6Omhpc3RvcnlOYXYpOgor
CiAyMDExLTA2LTEyICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAg
UmV2aWV3ZWQgYnkgQWxleGV5IFByb3NrdXJ5YWtvdi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL
aXQvcXQvdGVzdHMvcWRlY2xhcmF0aXZld2Vidmlldy90c3RfcWRlY2xhcmF0aXZld2Vidmlldy5j
cHAgYi9Tb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL3FkZWNsYXJhdGl2ZXdlYnZpZXcvdHN0X3FkZWNs
YXJhdGl2ZXdlYnZpZXcuY3BwCmluZGV4IDVjZTFlYjEuLmE1MTc1MmQgMTAwNjQ0Ci0tLSBhL1Nv
dXJjZS9XZWJLaXQvcXQvdGVzdHMvcWRlY2xhcmF0aXZld2Vidmlldy90c3RfcWRlY2xhcmF0aXZl
d2Vidmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9xdC90ZXN0cy9xZGVjbGFyYXRpdmV3ZWJ2
aWV3L3RzdF9xZGVjbGFyYXRpdmV3ZWJ2aWV3LmNwcApAQCAtOTIsMTYgKzkyLDE3IEBAIHZvaWQg
dHN0X1FEZWNsYXJhdGl2ZVdlYlZpZXc6OmNsZWFudXBUZXN0Q2FzZSgpCiAKIHZvaWQgdHN0X1FE
ZWNsYXJhdGl2ZVdlYlZpZXc6OmJhc2ljUHJvcGVydGllcygpCiB7CisgICAgUVdlYlNldHRpbmdz
OjpzZXRJY29uRGF0YWJhc2VQYXRoKHRtcERpcigpKTsKKyAgICBRV2ViU2V0dGluZ3M6OmVuYWJs
ZVBlcnNpc3RlbnRTdG9yYWdlKHRtcERpcigpKTsKICAgICBRRGVjbGFyYXRpdmVFbmdpbmUgZW5n
aW5lOwogICAgIFFEZWNsYXJhdGl2ZUNvbXBvbmVudCBjb21wb25lbnQoJmVuZ2luZSwgUVVybCgi
cXJjOi8vL3Jlc291cmNlcy9iYXNpYy5xbWwiKSk7CiAgICAgY2hlY2tOb0Vycm9ycyhjb21wb25l
bnQpOwotICAgIFFXZWJTZXR0aW5nczo6ZW5hYmxlUGVyc2lzdGVudFN0b3JhZ2UodG1wRGlyKCkp
OwogCiAgICAgUU9iamVjdCogd3YgPSBjb21wb25lbnQuY3JlYXRlKCk7CiAgICAgUVZFUklGWSh3
dik7CisgICAgd2FpdEZvclNpZ25hbCh3diwgU0lHTkFMKGljb25DaGFuZ2VkKCkpLCAxNTAwMCk7
CiAgICAgUVRSWV9DT01QQVJFKHd2LT5wcm9wZXJ0eSgicHJvZ3Jlc3MiKS50b0RvdWJsZSgpLCAx
LjApOwogICAgIFFDT01QQVJFKHd2LT5wcm9wZXJ0eSgidGl0bGUiKS50b1N0cmluZygpLCBRTGF0
aW4xU3RyaW5nKCJCYXNpYyIpKTsKLSAgICBRRVhQRUNUX0ZBSUwoIiIsICJodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjEwNDIiLCBDb250aW51ZSk7CiAgICAgUVRSWV9D
T01QQVJFKHF2YXJpYW50X2Nhc3Q8UVBpeG1hcD4od3YtPnByb3BlcnR5KCJpY29uIikpLndpZHRo
KCksIDQ4KTsKICAgICBRRVhQRUNUX0ZBSUwoIiIsICInaWNvbicgcHJvcGVydHkgaXNuJ3Qgd29y
a2luZyIsIENvbnRpbnVlKTsKICAgICBRQ09NUEFSRShxdmFyaWFudF9jYXN0PFFQaXhtYXA+KHd2
LT5wcm9wZXJ0eSgiaWNvbiIpKSwgUVBpeG1hcCgicXJjOi8vL3Jlc291cmNlcy9iYXNpYy5wbmci
KSk7CkBAIC0xNTksMTMgKzE2MCwxNSBAQCB2b2lkIHRzdF9RRGVjbGFyYXRpdmVXZWJWaWV3Ojpl
bGVtZW50QXJlYUF0KCkKIAogdm9pZCB0c3RfUURlY2xhcmF0aXZlV2ViVmlldzo6aGlzdG9yeU5h
digpCiB7CisgICAgUVdlYlNldHRpbmdzOjpzZXRJY29uRGF0YWJhc2VQYXRoKHRtcERpcigpKTsK
KyAgICBRV2ViU2V0dGluZ3M6OmVuYWJsZVBlcnNpc3RlbnRTdG9yYWdlKHRtcERpcigpKTsKICAg
ICBRRGVjbGFyYXRpdmVFbmdpbmUgZW5naW5lOwogICAgIFFEZWNsYXJhdGl2ZUNvbXBvbmVudCBj
b21wb25lbnQoJmVuZ2luZSwgUVVybCgicXJjOi8vL3Jlc291cmNlcy9iYXNpYy5xbWwiKSk7CiAg
ICAgY2hlY2tOb0Vycm9ycyhjb21wb25lbnQpOwotICAgIFFXZWJTZXR0aW5nczo6ZW5hYmxlUGVy
c2lzdGVudFN0b3JhZ2UodG1wRGlyKCkpOwogCiAgICAgUU9iamVjdCogd3YgPSBjb21wb25lbnQu
Y3JlYXRlKCk7CiAgICAgUVZFUklGWSh3dik7CisgICAgd2FpdEZvclNpZ25hbCh3diwgU0lHTkFM
KGljb25DaGFuZ2VkKCkpLCAxNTAwMCk7CiAKICAgICBRQWN0aW9uKiByZWxvYWRBY3Rpb24gPSB3
di0+cHJvcGVydHkoInJlbG9hZCIpLnZhbHVlPFFBY3Rpb24qPigpOwogICAgIFFWRVJJRlkocmVs
b2FkQWN0aW9uKTsKQEAgLTE3OSw4ICsxODIsNyBAQCB2b2lkIHRzdF9RRGVjbGFyYXRpdmVXZWJW
aWV3OjpoaXN0b3J5TmF2KCkKICAgICBmb3IgKGludCBpID0gMTsgaSA8PSAyOyArK2kpIHsKICAg
ICAgICAgUVRSWV9DT01QQVJFKHd2LT5wcm9wZXJ0eSgicHJvZ3Jlc3MiKS50b0RvdWJsZSgpLCAx
LjApOwogICAgICAgICBRQ09NUEFSRSh3di0+cHJvcGVydHkoInRpdGxlIikudG9TdHJpbmcoKSwg
UUxhdGluMVN0cmluZygiQmFzaWMiKSk7Ci0gICAgICAgIFFFWFBFQ1RfRkFJTCgiIiwgImh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTA0MiIsIENvbnRpbnVlKTsKLSAg
ICAgICAgUVRSWV9DT01QQVJFKHF2YXJpYW50X2Nhc3Q8UVBpeG1hcD4od3YtPnByb3BlcnR5KCJp
Y29uIikpLndpZHRoKCksIDQ4KTsKKyAgICAgICAgUUNPTVBBUkUocXZhcmlhbnRfY2FzdDxRUGl4
bWFwPih3di0+cHJvcGVydHkoImljb24iKSkud2lkdGgoKSwgNDgpOwogICAgICAgICBRRVhQRUNU
X0ZBSUwoIiIsICInaWNvbicgcHJvcGVydHkgaXNuJ3Qgd29ya2luZyIsIENvbnRpbnVlKTsKICAg
ICAgICAgUUNPTVBBUkUocXZhcmlhbnRfY2FzdDxRUGl4bWFwPih3di0+cHJvcGVydHkoImljb24i
KSksIFFQaXhtYXAoInFyYzovLy9kYXRhL2Jhc2ljLnBuZyIpKTsKICAgICAgICAgUUNPTVBBUkUo
d3YtPnByb3BlcnR5KCJzdGF0dXNUZXh0IikudG9TdHJpbmcoKSwgUUxhdGluMVN0cmluZygic3Rh
dHVzIGhlcmUiKSk7CkBAIC0xOTcsMTAgKzE5OSwxMCBAQCB2b2lkIHRzdF9RRGVjbGFyYXRpdmVX
ZWJWaWV3OjpoaXN0b3J5TmF2KCkKICAgICB9CiAKICAgICB3di0+c2V0UHJvcGVydHkoInVybCIs
IFFVcmwoInFyYzovLy9yZXNvdXJjZXMvZm9yd2FyZC5odG1sIikpOworICAgIHdhaXRGb3JTaWdu
YWwod3YsIFNJR05BTChpY29uQ2hhbmdlZCgpKSwgMTUwMDApOwogICAgIFFUUllfQ09NUEFSRSh3
di0+cHJvcGVydHkoInByb2dyZXNzIikudG9Eb3VibGUoKSwgMS4wKTsKICAgICBRQ09NUEFSRSh3
di0+cHJvcGVydHkoInRpdGxlIikudG9TdHJpbmcoKSwgUUxhdGluMVN0cmluZygiRm9yd2FyZCIp
KTsKLSAgICBRRVhQRUNUX0ZBSUwoIiIsICJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9NjEwNDIiLCBDb250aW51ZSk7Ci0gICAgUVRSWV9DT01QQVJFKHF2YXJpYW50X2Nh
c3Q8UVBpeG1hcD4od3YtPnByb3BlcnR5KCJpY29uIikpLndpZHRoKCksIDMyKTsKKyAgICBRQ09N
UEFSRShxdmFyaWFudF9jYXN0PFFQaXhtYXA+KHd2LT5wcm9wZXJ0eSgiaWNvbiIpKS53aWR0aCgp
LCAzMik7CiAgICAgUUVYUEVDVF9GQUlMKCIiLCAiJ2ljb24nIHByb3BlcnR5IGlzbid0IHdvcmtp
bmciLCBDb250aW51ZSk7CiAgICAgUUNPTVBBUkUocXZhcmlhbnRfY2FzdDxRUGl4bWFwPih3di0+
cHJvcGVydHkoImljb24iKSksIFFQaXhtYXAoInFyYzovLy9yZXNvdXJjZXMvZm9yd2FyZC5wbmci
KSk7CiAgICAgUUNPTVBBUkUoc3RyaXBwZWRIdG1sKGZpbGVDb250ZW50cygiOi9yZXNvdXJjZXMv
Zm9yd2FyZC5odG1sIikpLCBzdHJpcHBlZEh0bWwod3YtPnByb3BlcnR5KCJodG1sIikudG9TdHJp
bmcoKSkpOwo=
</data>
<flag name="commit-queue"
          id="94860"
          type_id="3"
          status="-"
          setter="benjamin"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>102642</attachid>
            <date>2011-08-02 06:25:48 -0700</date>
            <delta_ts>2011-08-02 06:59:31 -0700</delta_ts>
            <desc>remove mark as expected fail where XPASS and mark failing test cases as expected fail</desc>
            <filename>xpass.patch</filename>
            <type>text/plain</type>
            <size>3512</size>
            <attacher name="Kristóf Kosztyó">kkristof</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9x
dC9DaGFuZ2VMb2cKaW5kZXggMDUyNmEwNy4uZjNlNDJiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dl
YktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEs
NSArMSwxNyBAQAogMjAxMS0wOC0wMiAgS3Jpc3TDs2YgS29zenR5w7MgIDxLb3N6dHlvLktyaXN0
b2ZAc3R1ZC51LXN6ZWdlZC5odT4KIAorICAgICAgICBbUXRdIEZpeCB0c3RfUURlY2xhcmF0aXZl
V2ViVmlldzo6YmFzaWNQcm9wZXJ0aWVzKCkgYW5kIGhpc3RvcnlOYXYoKSBhdXRvdGVzdHMKKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYxMDQyCisgICAg
ICAgIFJlbW92ZSBtYXJrIGFzIGV4cGVjdGVkIGZhaWwgd2hlcmUgdW5leHBlY3RlZCBwYXNzIGFu
ZCBtYXJrIGZhaWxpbmcgdGVzdCBjYXNlIGFzIGV4cGVjdGVkIGZhaWwKKworICAgICAgICBSZXZp
ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHRlc3RzL3FkZWNsYXJhdGl2ZXdl
YnZpZXcvdHN0X3FkZWNsYXJhdGl2ZXdlYnZpZXcuY3BwOgorICAgICAgICAodHN0X1FEZWNsYXJh
dGl2ZVdlYlZpZXc6OmJhc2ljUHJvcGVydGllcyk6CisgICAgICAgICh0c3RfUURlY2xhcmF0aXZl
V2ViVmlldzo6aGlzdG9yeU5hdik6CisKKzIwMTEtMDgtMDIgIEtyaXN0w7NmIEtvc3p0ecOzICA8
S29zenR5by5LcmlzdG9mQHN0dWQudS1zemVnZWQuaHU+CisKICAgICAgICAgW1F0XSBGaXggdHN0
X1FXZWJQYWdlOjp2aWV3TW9kZXMoKSBBUEkgdGVzdAogICAgICAgICBodHRwczovL2J1Z3Mud2Vi
a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjU1MzEKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp
dC9xdC90ZXN0cy9xZGVjbGFyYXRpdmV3ZWJ2aWV3L3RzdF9xZGVjbGFyYXRpdmV3ZWJ2aWV3LmNw
cCBiL1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcWRlY2xhcmF0aXZld2Vidmlldy90c3RfcWRlY2xh
cmF0aXZld2Vidmlldy5jcHAKaW5kZXggMjRmYmNlZS4uNDc5ZWNhZSAxMDA2NDQKLS0tIGEvU291
cmNlL1dlYktpdC9xdC90ZXN0cy9xZGVjbGFyYXRpdmV3ZWJ2aWV3L3RzdF9xZGVjbGFyYXRpdmV3
ZWJ2aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL3FkZWNsYXJhdGl2ZXdlYnZp
ZXcvdHN0X3FkZWNsYXJhdGl2ZXdlYnZpZXcuY3BwCkBAIC0xMDQsNyArMTA0LDYgQEAgdm9pZCB0
c3RfUURlY2xhcmF0aXZlV2ViVmlldzo6YmFzaWNQcm9wZXJ0aWVzKCkKICAgICBRVkVSSUZZKHd2
KTsKICAgICBRVFJZX0NPTVBBUkUod3YtPnByb3BlcnR5KCJwcm9ncmVzcyIpLnRvRG91YmxlKCks
IDEuMCk7CiAgICAgUUNPTVBBUkUod3YtPnByb3BlcnR5KCJ0aXRsZSIpLnRvU3RyaW5nKCksIFFM
YXRpbjFTdHJpbmcoIkJhc2ljIikpOwotICAgIFFFWFBFQ1RfRkFJTCgiIiwgImh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTA0MiIsIENvbnRpbnVlKTsKICAgICBRVFJZ
X0NPTVBBUkUocXZhcmlhbnRfY2FzdDxRUGl4bWFwPih3di0+cHJvcGVydHkoImljb24iKSkud2lk
dGgoKSwgNDgpOwogICAgIFFFWFBFQ1RfRkFJTCgiIiwgIidpY29uJyBwcm9wZXJ0eSBpc24ndCB3
b3JraW5nIiwgQ29udGludWUpOwogICAgIFFDT01QQVJFKHF2YXJpYW50X2Nhc3Q8UVBpeG1hcD4o
d3YtPnByb3BlcnR5KCJpY29uIikpLCBRUGl4bWFwKCJxcmM6Ly8vcmVzb3VyY2VzL2Jhc2ljLnBu
ZyIpKTsKQEAgLTE4Miw3ICsxODEsNiBAQCB2b2lkIHRzdF9RRGVjbGFyYXRpdmVXZWJWaWV3Ojpo
aXN0b3J5TmF2KCkKICAgICBmb3IgKGludCBpID0gMTsgaSA8PSAyOyArK2kpIHsKICAgICAgICAg
UVRSWV9DT01QQVJFKHd2LT5wcm9wZXJ0eSgicHJvZ3Jlc3MiKS50b0RvdWJsZSgpLCAxLjApOwog
ICAgICAgICBRQ09NUEFSRSh3di0+cHJvcGVydHkoInRpdGxlIikudG9TdHJpbmcoKSwgUUxhdGlu
MVN0cmluZygiQmFzaWMiKSk7Ci0gICAgICAgIFFFWFBFQ1RfRkFJTCgiIiwgImh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTA0MiIsIENvbnRpbnVlKTsKICAgICAgICAg
UVRSWV9DT01QQVJFKHF2YXJpYW50X2Nhc3Q8UVBpeG1hcD4od3YtPnByb3BlcnR5KCJpY29uIikp
LndpZHRoKCksIDQ4KTsKICAgICAgICAgUUVYUEVDVF9GQUlMKCIiLCAiJ2ljb24nIHByb3BlcnR5
IGlzbid0IHdvcmtpbmciLCBDb250aW51ZSk7CiAgICAgICAgIFFDT01QQVJFKHF2YXJpYW50X2Nh
c3Q8UVBpeG1hcD4od3YtPnByb3BlcnR5KCJpY29uIikpLCBRUGl4bWFwKCJxcmM6Ly8vZGF0YS9i
YXNpYy5wbmciKSk7CkBAIC0yMDIsNyArMjAwLDYgQEAgdm9pZCB0c3RfUURlY2xhcmF0aXZlV2Vi
Vmlldzo6aGlzdG9yeU5hdigpCiAgICAgd3YtPnNldFByb3BlcnR5KCJ1cmwiLCBRVXJsKCJxcmM6
Ly8vcmVzb3VyY2VzL2ZvcndhcmQuaHRtbCIpKTsKICAgICBRVFJZX0NPTVBBUkUod3YtPnByb3Bl
cnR5KCJwcm9ncmVzcyIpLnRvRG91YmxlKCksIDEuMCk7CiAgICAgUUNPTVBBUkUod3YtPnByb3Bl
cnR5KCJ0aXRsZSIpLnRvU3RyaW5nKCksIFFMYXRpbjFTdHJpbmcoIkZvcndhcmQiKSk7Ci0gICAg
UUVYUEVDVF9GQUlMKCIiLCAiaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk
PTYxMDQyIiwgQ29udGludWUpOwogICAgIFFUUllfQ09NUEFSRShxdmFyaWFudF9jYXN0PFFQaXht
YXA+KHd2LT5wcm9wZXJ0eSgiaWNvbiIpKS53aWR0aCgpLCAzMik7CiAgICAgUUVYUEVDVF9GQUlM
KCIiLCAiJ2ljb24nIHByb3BlcnR5IGlzbid0IHdvcmtpbmciLCBDb250aW51ZSk7CiAgICAgUUNP
TVBBUkUocXZhcmlhbnRfY2FzdDxRUGl4bWFwPih3di0+cHJvcGVydHkoImljb24iKSksIFFQaXht
YXAoInFyYzovLy9yZXNvdXJjZXMvZm9yd2FyZC5wbmciKSk7CkBAIC0yMTEsOSArMjA4LDExIEBA
IHZvaWQgdHN0X1FEZWNsYXJhdGl2ZVdlYlZpZXc6Omhpc3RvcnlOYXYoKQogICAgIFFDT01QQVJF
KHd2LT5wcm9wZXJ0eSgic3RhdHVzIikudG9JbnQoKSwgaW50KFFEZWNsYXJhdGl2ZVdlYlZpZXc6
OlJlYWR5KSk7CiAgICAgUUNPTVBBUkUod3YtPnByb3BlcnR5KCJzdGF0dXNUZXh0IikudG9TdHJp
bmcoKSwgUVN0cmluZygpKTsKIAorICAgIFFFWFBFQ1RfRkFJTCgiIiwgImh0dHBzOi8vYnVncy53
ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTA0MiIsIENvbnRpbnVlKTsKICAgICBRVkVSSUZZ
KHJlbG9hZEFjdGlvbi0+aXNFbmFibGVkKCkpOwogICAgIFFWRVJJRlkoYmFja0FjdGlvbi0+aXNF
bmFibGVkKCkpOwogICAgIFFWRVJJRlkoIWZvcndhcmRBY3Rpb24tPmlzRW5hYmxlZCgpKTsKKyAg
ICBRRVhQRUNUX0ZBSUwoIiIsICJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9NjEwNDIiLCBDb250aW51ZSk7CiAgICAgUVZFUklGWSghc3RvcEFjdGlvbi0+aXNFbmFibGVk
KCkpOwogCiAgICAgYmFja0FjdGlvbi0+dHJpZ2dlcigpOwo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>103147</attachid>
            <date>2011-08-06 05:06:24 -0700</date>
            <delta_ts>2011-11-03 13:37:35 -0700</delta_ts>
            <desc>Following kling&apos;s advices, and solving some issues around comparison of bitmaps in this test.</desc>
            <filename>qdeclarativewebview_fixes_01.diff</filename>
            <type>text/plain</type>
            <size>5362</size>
            <attacher name="Rafael Brandao">rafael.lobo</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9x
dC9DaGFuZ2VMb2cKaW5kZXggYzYwZTBhOC4uZjI4MWE4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dl
YktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxOSBAQAorMjAxMS0wOC0wNiAgUmFmYWVsIEJyYW5kYW8gIDxyYWZhZWwubG9ib0BvcGVu
Ym9zc2Eub3JnPgorCisgICAgICAgIEZpeCB0c3RfUURlY2xhcmF0aXZlV2ViVmlldzo6YmFzaWNQ
cm9wZXJ0aWVzKCkgYW5kIGhpc3RvcnlOYXYoKSBhdXRvdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYxMDQyCisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBBdCBzb21lIHBvaW50cyB3ZSBk
aWRuJ3QgaGF2ZSBhbnkgZ3VhcmFudGVlIHRoYXQgYSBmYXZpY29uIGhhcyBiZWVuIGxvYWRlZCwg
c28gbm93CisgICAgICAgIGl0IHN0b3BzIHRvIHdhaXQgZm9yIHRoZSBJY29uQ2hhbmdlZCBzaWdu
YWwuIEl0IGFsc28gaGFkIHNvbWUgZmlsZSBwYXRocyBpbiB3cm9uZyBmb3JtYXQsCisgICAgICAg
IG1ha2luZyBzb21lIGZpbGVzIHRvIG5vdCBiZSByZXNvbHZlZCBhbmQgY29tcGFyaW5nIG1lYW5p
bmdsZXNzIGJpdG1hcHMuCisKKyAgICAgICAgKiB0ZXN0cy9xZGVjbGFyYXRpdmV3ZWJ2aWV3L3Rz
dF9xZGVjbGFyYXRpdmV3ZWJ2aWV3LmNwcDoKKyAgICAgICAgKHRzdF9RRGVjbGFyYXRpdmVXZWJW
aWV3Ojppbml0VGVzdENhc2UpOgorICAgICAgICAodHN0X1FEZWNsYXJhdGl2ZVdlYlZpZXc6OmJh
c2ljUHJvcGVydGllcyk6CisgICAgICAgICh0c3RfUURlY2xhcmF0aXZlV2ViVmlldzo6aGlzdG9y
eU5hdik6CisKIDIwMTEtMDgtMDUgIERhd2l0IEFsZW1heWVodSAgPGFkYXdpdEBrZGUub3JnPgog
CiAgICAgICAgIFJldmlld2VkIGJ5IEFuZHJlYXMgS2xpbmcuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv
V2ViS2l0L3F0L3Rlc3RzL3FkZWNsYXJhdGl2ZXdlYnZpZXcvdHN0X3FkZWNsYXJhdGl2ZXdlYnZp
ZXcuY3BwIGIvU291cmNlL1dlYktpdC9xdC90ZXN0cy9xZGVjbGFyYXRpdmV3ZWJ2aWV3L3RzdF9x
ZGVjbGFyYXRpdmV3ZWJ2aWV3LmNwcAppbmRleCA0NzllY2FlLi5iMzhkYjFkIDEwMDY0NAotLS0g
YS9Tb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL3FkZWNsYXJhdGl2ZXdlYnZpZXcvdHN0X3FkZWNsYXJh
dGl2ZXdlYnZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcWRlY2xhcmF0aXZl
d2Vidmlldy90c3RfcWRlY2xhcmF0aXZld2Vidmlldy5jcHAKQEAgLTI2LDYgKzI2LDcgQEAgcHVi
bGljOgogICAgIHRzdF9RRGVjbGFyYXRpdmVXZWJWaWV3KCk7CiAKIHByaXZhdGUgc2xvdHM6Cisg
ICAgdm9pZCBpbml0VGVzdENhc2UoKTsKICAgICB2b2lkIGNsZWFudXBUZXN0Q2FzZSgpOwogCiAg
ICAgdm9pZCBiYXNpY1Byb3BlcnRpZXMoKTsKQEAgLTg4LDYgKzg5LDEyIEBAIHN0YXRpYyB2b2lk
IHJlbW92ZVJlY3Vyc2l2ZShjb25zdCBRU3RyaW5nJiBkaXJuYW1lKQogICAgIFFEaXIoKS5ybWRp
cihkaXJuYW1lKTsKIH0KIAordm9pZCB0c3RfUURlY2xhcmF0aXZlV2ViVmlldzo6aW5pdFRlc3RD
YXNlKCkKK3sKKyAgICBRV2ViU2V0dGluZ3M6OnNldEljb25EYXRhYmFzZVBhdGgodG1wRGlyKCkp
OworICAgIFFXZWJTZXR0aW5nczo6ZW5hYmxlUGVyc2lzdGVudFN0b3JhZ2UodG1wRGlyKCkpOwor
fQorCiB2b2lkIHRzdF9RRGVjbGFyYXRpdmVXZWJWaWV3OjpjbGVhbnVwVGVzdENhc2UoKQogewog
ICAgIHJlbW92ZVJlY3Vyc2l2ZSh0bXBEaXIoKSk7CkBAIC0xMDIsMTEgKzEwOSwxMSBAQCB2b2lk
IHRzdF9RRGVjbGFyYXRpdmVXZWJWaWV3OjpiYXNpY1Byb3BlcnRpZXMoKQogCiAgICAgUU9iamVj
dCogd3YgPSBjb21wb25lbnQuY3JlYXRlKCk7CiAgICAgUVZFUklGWSh3dik7CisgICAgd2FpdEZv
clNpZ25hbCh3diwgU0lHTkFMKGljb25DaGFuZ2VkKCkpKTsKICAgICBRVFJZX0NPTVBBUkUod3Yt
PnByb3BlcnR5KCJwcm9ncmVzcyIpLnRvRG91YmxlKCksIDEuMCk7CiAgICAgUUNPTVBBUkUod3Yt
PnByb3BlcnR5KCJ0aXRsZSIpLnRvU3RyaW5nKCksIFFMYXRpbjFTdHJpbmcoIkJhc2ljIikpOwog
ICAgIFFUUllfQ09NUEFSRShxdmFyaWFudF9jYXN0PFFQaXhtYXA+KHd2LT5wcm9wZXJ0eSgiaWNv
biIpKS53aWR0aCgpLCA0OCk7Ci0gICAgUUVYUEVDVF9GQUlMKCIiLCAiJ2ljb24nIHByb3BlcnR5
IGlzbid0IHdvcmtpbmciLCBDb250aW51ZSk7Ci0gICAgUUNPTVBBUkUocXZhcmlhbnRfY2FzdDxR
UGl4bWFwPih3di0+cHJvcGVydHkoImljb24iKSksIFFQaXhtYXAoInFyYzovLy9yZXNvdXJjZXMv
YmFzaWMucG5nIikpOworICAgIFFDT01QQVJFKHF2YXJpYW50X2Nhc3Q8UVBpeG1hcD4od3YtPnBy
b3BlcnR5KCJpY29uIikpLCBRUGl4bWFwKCI6L3Jlc291cmNlcy9iYXNpYy5wbmciKSk7CiAgICAg
UUNPTVBBUkUod3YtPnByb3BlcnR5KCJzdGF0dXNUZXh0IikudG9TdHJpbmcoKSwgUUxhdGluMVN0
cmluZygic3RhdHVzIGhlcmUiKSk7CiAgICAgUUNPTVBBUkUoc3RyaXBwZWRIdG1sKGZpbGVDb250
ZW50cygiOi9yZXNvdXJjZXMvYmFzaWMuaHRtbCIpKSwgc3RyaXBwZWRIdG1sKHd2LT5wcm9wZXJ0
eSgiaHRtbCIpLnRvU3RyaW5nKCkpKTsKICAgICBRRVhQRUNUX0ZBSUwoIiIsICJUT0RPOiBnZXQg
cHJlZmVycmVkIHdpZHRoIGZyb20gUUdyYXBoaWNzV2ViVmlldyByZXN1bHQiLCBDb250aW51ZSk7
CkBAIC0xNjgsNiArMTc1LDcgQEAgdm9pZCB0c3RfUURlY2xhcmF0aXZlV2ViVmlldzo6aGlzdG9y
eU5hdigpCiAKICAgICBRT2JqZWN0KiB3diA9IGNvbXBvbmVudC5jcmVhdGUoKTsKICAgICBRVkVS
SUZZKHd2KTsKKyAgICB3YWl0Rm9yU2lnbmFsKHd2LCBTSUdOQUwoaWNvbkNoYW5nZWQoKSkpOwog
CiAgICAgUUFjdGlvbiogcmVsb2FkQWN0aW9uID0gd3YtPnByb3BlcnR5KCJyZWxvYWQiKS52YWx1
ZTxRQWN0aW9uKj4oKTsKICAgICBRVkVSSUZZKHJlbG9hZEFjdGlvbik7CkBAIC0xODIsOCArMTkw
LDcgQEAgdm9pZCB0c3RfUURlY2xhcmF0aXZlV2ViVmlldzo6aGlzdG9yeU5hdigpCiAgICAgICAg
IFFUUllfQ09NUEFSRSh3di0+cHJvcGVydHkoInByb2dyZXNzIikudG9Eb3VibGUoKSwgMS4wKTsK
ICAgICAgICAgUUNPTVBBUkUod3YtPnByb3BlcnR5KCJ0aXRsZSIpLnRvU3RyaW5nKCksIFFMYXRp
bjFTdHJpbmcoIkJhc2ljIikpOwogICAgICAgICBRVFJZX0NPTVBBUkUocXZhcmlhbnRfY2FzdDxR
UGl4bWFwPih3di0+cHJvcGVydHkoImljb24iKSkud2lkdGgoKSwgNDgpOwotICAgICAgICBRRVhQ
RUNUX0ZBSUwoIiIsICInaWNvbicgcHJvcGVydHkgaXNuJ3Qgd29ya2luZyIsIENvbnRpbnVlKTsK
LSAgICAgICAgUUNPTVBBUkUocXZhcmlhbnRfY2FzdDxRUGl4bWFwPih3di0+cHJvcGVydHkoImlj
b24iKSksIFFQaXhtYXAoInFyYzovLy9kYXRhL2Jhc2ljLnBuZyIpKTsKKyAgICAgICAgUUNPTVBB
UkUocXZhcmlhbnRfY2FzdDxRUGl4bWFwPih3di0+cHJvcGVydHkoImljb24iKSksIFFQaXhtYXAo
IjovcmVzb3VyY2VzL2Jhc2ljLnBuZyIpKTsKICAgICAgICAgUUNPTVBBUkUod3YtPnByb3BlcnR5
KCJzdGF0dXNUZXh0IikudG9TdHJpbmcoKSwgUUxhdGluMVN0cmluZygic3RhdHVzIGhlcmUiKSk7
CiAgICAgICAgIFFDT01QQVJFKHN0cmlwcGVkSHRtbChmaWxlQ29udGVudHMoIjovcmVzb3VyY2Vz
L2Jhc2ljLmh0bWwiKSksIHN0cmlwcGVkSHRtbCh3di0+cHJvcGVydHkoImh0bWwiKS50b1N0cmlu
ZygpKSk7CiAgICAgICAgIFFFWFBFQ1RfRkFJTCgiIiwgIlRPRE86IGdldCBwcmVmZXJyZWQgd2lk
dGggZnJvbSBRR3JhcGhpY3NXZWJWaWV3IHJlc3VsdCIsIENvbnRpbnVlKTsKQEAgLTE5NSwxNCAr
MjAyLDE1IEBAIHZvaWQgdHN0X1FEZWNsYXJhdGl2ZVdlYlZpZXc6Omhpc3RvcnlOYXYoKQogICAg
ICAgICBRVkVSSUZZKCFmb3J3YXJkQWN0aW9uLT5pc0VuYWJsZWQoKSk7CiAgICAgICAgIFFWRVJJ
RlkoIXN0b3BBY3Rpb24tPmlzRW5hYmxlZCgpKTsKICAgICAgICAgcmVsb2FkQWN0aW9uLT50cmln
Z2VyKCk7CisgICAgICAgIHdhaXRGb3JTaWduYWwod3YsIFNJR05BTChpY29uQ2hhbmdlZCgpKSk7
CiAgICAgfQogCiAgICAgd3YtPnNldFByb3BlcnR5KCJ1cmwiLCBRVXJsKCJxcmM6Ly8vcmVzb3Vy
Y2VzL2ZvcndhcmQuaHRtbCIpKTsKKyAgICB3YWl0Rm9yU2lnbmFsKHd2LCBTSUdOQUwoaWNvbkNo
YW5nZWQoKSkpOwogICAgIFFUUllfQ09NUEFSRSh3di0+cHJvcGVydHkoInByb2dyZXNzIikudG9E
b3VibGUoKSwgMS4wKTsKICAgICBRQ09NUEFSRSh3di0+cHJvcGVydHkoInRpdGxlIikudG9TdHJp
bmcoKSwgUUxhdGluMVN0cmluZygiRm9yd2FyZCIpKTsKICAgICBRVFJZX0NPTVBBUkUocXZhcmlh
bnRfY2FzdDxRUGl4bWFwPih3di0+cHJvcGVydHkoImljb24iKSkud2lkdGgoKSwgMzIpOwotICAg
IFFFWFBFQ1RfRkFJTCgiIiwgIidpY29uJyBwcm9wZXJ0eSBpc24ndCB3b3JraW5nIiwgQ29udGlu
dWUpOwotICAgIFFDT01QQVJFKHF2YXJpYW50X2Nhc3Q8UVBpeG1hcD4od3YtPnByb3BlcnR5KCJp
Y29uIikpLCBRUGl4bWFwKCJxcmM6Ly8vcmVzb3VyY2VzL2ZvcndhcmQucG5nIikpOworICAgIFFD
T01QQVJFKHF2YXJpYW50X2Nhc3Q8UVBpeG1hcD4od3YtPnByb3BlcnR5KCJpY29uIikpLCBRUGl4
bWFwKCI6L3Jlc291cmNlcy9mb3J3YXJkLnBuZyIpKTsKICAgICBRQ09NUEFSRShzdHJpcHBlZEh0
bWwoZmlsZUNvbnRlbnRzKCI6L3Jlc291cmNlcy9mb3J3YXJkLmh0bWwiKSksIHN0cmlwcGVkSHRt
bCh3di0+cHJvcGVydHkoImh0bWwiKS50b1N0cmluZygpKSk7CiAgICAgUUNPTVBBUkUod3YtPnBy
b3BlcnR5KCJ1cmwiKS50b1VybCgpLCBRVXJsKCJxcmM6Ly8vcmVzb3VyY2VzL2ZvcndhcmQuaHRt
bCIpKTsKICAgICBRQ09NUEFSRSh3di0+cHJvcGVydHkoInN0YXR1cyIpLnRvSW50KCksIGludChR
RGVjbGFyYXRpdmVXZWJWaWV3OjpSZWFkeSkpOwpAQCAtMjE2LDYgKzIyNCw3IEBAIHZvaWQgdHN0
X1FEZWNsYXJhdGl2ZVdlYlZpZXc6Omhpc3RvcnlOYXYoKQogICAgIFFWRVJJRlkoIXN0b3BBY3Rp
b24tPmlzRW5hYmxlZCgpKTsKIAogICAgIGJhY2tBY3Rpb24tPnRyaWdnZXIoKTsKKyAgICB3YWl0
Rm9yU2lnbmFsKHd2LCBTSUdOQUwobG9hZEZpbmlzaGVkKCkpKTsKIAogICAgIFFUUllfQ09NUEFS
RSh3di0+cHJvcGVydHkoInByb2dyZXNzIikudG9Eb3VibGUoKSwgMS4wKTsKICAgICBRQ09NUEFS
RSh3di0+cHJvcGVydHkoInRpdGxlIikudG9TdHJpbmcoKSwgUUxhdGluMVN0cmluZygiQmFzaWMi
KSk7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>