60925 2011-05-16 14:51:22 -0700 Document why RenderBlockLineLayout has its own deleteLineBoxTree implementation 2011-05-16 16:11:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60113 60729 1 eric eric abarth commit-queue hyatt leviw mitz rniwa oldest_to_newest 404730 0 eric 2011-05-16 14:51:22 -0700 Document why RenderBlockLineLayout has its own deleteLineBoxTree implementation 404731 1 93697 eric 2011-05-16 14:53:25 -0700 Created attachment 93697 Patch 404736 2 eric 2011-05-16 14:57:13 -0700 I tried to change this to deleteLineBoxTree in multiple different patches, and then was confused when things started crashing. I suspect that this code as-is is just papering over other bugs, but I'm leaving it as-is for now and documenting why it is that way. 404750 3 93697 abarth 2011-05-16 15:09:22 -0700 Comment on attachment 93697 Patch Ok... 404799 4 93697 commit-queue 2011-05-16 16:11:01 -0700 Comment on attachment 93697 Patch Clearing flags on attachment: 93697 Committed r86628: <http://trac.webkit.org/changeset/86628> 404800 5 commit-queue 2011-05-16 16:11:08 -0700 All reviewed patches have been landed. Closing bug. 93697 2011-05-16 14:53:25 -0700 2011-05-16 16:11:01 -0700 Patch bug-60925-20110516145323.patch text/plain 3082 eric U3VidmVyc2lvbiBSZXZpc2lvbjogODY1OTgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4N2UzMjdjMDk2YjRlMzEz YzM0OGI5MGU4ODkyZTA5OGFiOTBhMzMyLi40ODczZjhjNmQwYWYxM2EwM2JlOTZmZTYzNDI4MmQy M2EyNjg5ZjZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDUtMTYgIEVyaWMg U2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIERvY3VtZW50IHdoeSBSZW5kZXJCbG9ja0xpbmVMYXlvdXQgaGFz IGl0cyBvd24gZGVsZXRlTGluZUJveFRyZWUgaW1wbGVtZW50YXRpb24KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYwOTI1CisKKyAgICAgICAgSSBzdXNw ZWN0IHRoaXMgZGlmZmVyZW5jZSBpcyByZWFsbHkganVzdCBwYXBlcmluZyBvdmVyIG90aGVyIGJ1 Z3MKKyAgICAgICAgYnV0IG5vdyB0aGF0IEkgZmluYWxseSB1bmRlcnN0YW5kIHRoZSBkaWZmZXJl bmNlLCBJIHNob3VsZCBhdCBsZWFzdAorICAgICAgICBkb2N1bWVudCBpdCBmb3Igb3RoZXJzLgor CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpkZWxldGVMaW5lUmFuZ2UpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxv Y2s6OmRldGVybWluZVN0YXJ0UG9zaXRpb24pOgorCiAyMDExLTA1LTE2ICBEYXZpZCBLaWx6ZXIg IDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAgICAgPGh0dHA6Ly93ZWJraXQub3JnL2IvNjA5 MTM+IEMrKyBleGNlcHRpb25zIHNob3VsZCBub3QgYmUgZW5hYmxlZCB3aGVuIGJ1aWxkaW5nIHdp dGggbGx2bS1nY2MtNC4yCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyQmxvY2tMaW5lTGF5b3V0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJC bG9ja0xpbmVMYXlvdXQuY3BwCmluZGV4IDVjMTIxNjY5OGIxZmY4ZGExY2JkYTM4MDk1Yzg5OGNk ZDY2OGE4NzYuLjU3ZjMxN2U1MGE0MjU2YjA4YmY0YjRjYjJjMWM0YWIyOWNlMDZiNDYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3Bw CkBAIC04MjIsNiArODIyLDggQEAgc3RhdGljIHZvaWQgZGVsZXRlTGluZVJhbmdlKFJlbmRlckFy ZW5hKiBhcmVuYSwgUm9vdElubGluZUJveCogc3RhcnRMaW5lLCBpbnQmIHIKICAgICB3aGlsZSAo Ym94VG9EZWxldGUgJiYgYm94VG9EZWxldGUgIT0gc3RvcExpbmUpIHsKICAgICAgICAgcmVwYWlu dExvZ2ljYWxUb3AgPSBtaW4ocmVwYWludExvZ2ljYWxUb3AsIGJveFRvRGVsZXRlLT5sb2dpY2Fs VG9wVmlzdWFsT3ZlcmZsb3coKSk7CiAgICAgICAgIHJlcGFpbnRMb2dpY2FsQm90dG9tID0gbWF4 KHJlcGFpbnRMb2dpY2FsQm90dG9tLCBib3hUb0RlbGV0ZS0+bG9naWNhbEJvdHRvbVZpc3VhbE92 ZXJmbG93KCkpOworICAgICAgICAvLyBOb3RlOiBkZWxldGVMaW5lUmFuZ2UocmVuZGVyQXJlbmEo KSwgZmlyc3RSb290Qm94KCkpIGlzIG5vdCBpZGVudGljYWwgdG8gZGVsZXRlTGluZUJveFRyZWUo KS4KKyAgICAgICAgLy8gZGVsZXRlTGluZUJveFRyZWUgdXNlcyBuZXh0TGluZUJveCgpIGluc3Rl YWQgb2YgbmV4dFJvb3RCb3goKSB3aGVuIHRyYXZlcnNpbmcuCiAgICAgICAgIFJvb3RJbmxpbmVC b3gqIG5leHQgPSBib3hUb0RlbGV0ZS0+bmV4dFJvb3RCb3goKTsKICAgICAgICAgYm94VG9EZWxl dGUtPmRlbGV0ZUxpbmUoYXJlbmEpOwogICAgICAgICBib3hUb0RlbGV0ZSA9IG5leHQ7CkBAIC0x MjU1LDE3ICsxMjU3LDE3IEBAIFJvb3RJbmxpbmVCb3gqIFJlbmRlckJsb2NrOjpkZXRlcm1pbmVT dGFydFBvc2l0aW9uKExpbmVJbmZvJiBsaW5lSW5mbywgYm9vbCYgZnVsCiAgICAgfQogCiAgICAg aWYgKGZ1bGxMYXlvdXQpIHsKLSAgICAgICAgLy8gTnVrZSBhbGwgb3VyIGxpbmVzLgotICAgICAg ICBpZiAoZmlyc3RSb290Qm94KCkpIHsKLSAgICAgICAgICAgIFJlbmRlckFyZW5hKiBhcmVuYSA9 IHJlbmRlckFyZW5hKCk7Ci0gICAgICAgICAgICBjdXJyID0gZmlyc3RSb290Qm94KCk7Ci0gICAg ICAgICAgICB3aGlsZSAoY3VycikgewotICAgICAgICAgICAgICAgIFJvb3RJbmxpbmVCb3gqIG5l eHQgPSBjdXJyLT5uZXh0Um9vdEJveCgpOwotICAgICAgICAgICAgICAgIGN1cnItPmRlbGV0ZUxp bmUoYXJlbmEpOwotICAgICAgICAgICAgICAgIGN1cnIgPSBuZXh0OwotICAgICAgICAgICAgfQot ICAgICAgICAgICAgQVNTRVJUKCFmaXJzdExpbmVCb3goKSAmJiAhbGFzdExpbmVCb3goKSk7Cisg ICAgICAgIC8vIEZJWE1FOiBUaGlzIHNob3VsZCBqdXN0IGNhbGwgZGVsZXRlTGluZUJveFRyZWUs IGJ1dCB0aGF0IGNhdXNlcworICAgICAgICAvLyBjcmFzaGVzIGZvciBmYXN0L3JlcGFpbnQgdGVz dHMuCisgICAgICAgIFJlbmRlckFyZW5hKiBhcmVuYSA9IHJlbmRlckFyZW5hKCk7CisgICAgICAg IGN1cnIgPSBmaXJzdFJvb3RCb3goKTsKKyAgICAgICAgd2hpbGUgKGN1cnIpIHsKKyAgICAgICAg ICAgIC8vIE5vdGU6IFRoaXMgdXNlcyBuZXh0Um9vdEJveCgpIGluc3RlZCBvZiBuZXh0TGluZUJv eCgpIGxpa2UgZGVsZXRlTGluZUJveFRyZWUgZG9lcy4KKyAgICAgICAgICAgIFJvb3RJbmxpbmVC b3gqIG5leHQgPSBjdXJyLT5uZXh0Um9vdEJveCgpOworICAgICAgICAgICAgY3Vyci0+ZGVsZXRl TGluZShhcmVuYSk7CisgICAgICAgICAgICBjdXJyID0gbmV4dDsKICAgICAgICAgfQorICAgICAg ICBBU1NFUlQoIWZpcnN0TGluZUJveCgpICYmICFsYXN0TGluZUJveCgpKTsKICAgICB9IGVsc2Ug ewogICAgICAgICBpZiAoY3VycikgewogICAgICAgICAgICAgLy8gV2UgaGF2ZSBhIGRpcnR5IGxp bmUuCg==