60846 2011-05-14 13:50:20 -0700 ASSERT(isMainThread()) when using single threaded jsc executable 2011-05-26 13:33:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 55728 1 paroga paroga abarth ademar ap barraclough commit-queue ggaren levin michaeln oliver sam oldest_to_newest 404113 0 paroga 2011-05-14 13:50:20 -0700 When I run ./jsc i get the following stack trace: #0 0x00000000005a6b2f in WTF::(anonymous namespace)::ARC4RandomNumberGenerator::randomNumber (this=0xa23910) at ../Source/JavaScriptCore/wtf/CryptographicallyRandomNumber.cpp:146 #1 0x00000000005a6cca in WTF::cryptographicallyRandomNumber () at ../Source/JavaScriptCore/wtf/CryptographicallyRandomNumber.cpp:181 #2 0x00000000004fa709 in WTF::randomNumber () at ../Source/JavaScriptCore/wtf/RandomNumber.cpp:57 #3 0x0000000000415531 in JSC::JSGlobalObject::JSGlobalObject (this=0x7fffad8cc150, globalData=...) at ../Source/JavaScriptCore/runtime/JSGlobalObject.h:124 #4 0x000000000040e4b0 in GlobalObject::GlobalObject (this=0x7fffad8cc150, globalData=..., arguments=...) at ../Source/JavaScriptCore/jsc.cpp:151 #5 0x00000000004109f2 in jscmain (argc=1, argv=0x7fffffffe218, globalData=0xa1be20) at ../Source/JavaScriptCore/jsc.cpp:540 #6 0x000000000040fb27 in main (argc=1, argv=0x7fffffffe218) at ../Source/JavaScriptCore/jsc.cpp:359 404144 1 ap 2011-05-14 22:12:43 -0700 Main thread is largely a WebCore concept, and the few instances of it in WTF are strictly for WebCore use. This is a unique use of it in JSC, and should probably be eliminated. Thoughts? Different ports have different requirements on how JavaScriptCore API can be used. On Mac OS X, there is no requirement that the main thread is registered somehow, or that the first use of the API is from main thread. Also on Mac OS X, there is a system notion of main thread anyway, exposed via pthread_main_np(). 404147 2 abarth 2011-05-14 23:23:32 -0700 Why does the API exist in wtf if it doesn't make sense? In any case, feel free to remove the assert. 404148 3 paroga 2011-05-15 00:05:16 -0700 (In reply to comment #2) > Why does the API exist in wtf if it doesn't make sense? BTW: this the only dependency of JSC on linux to a window framework. When we remove MainThread from WTF/JSC libjavascriptcore.so can be compiled for "linux" and not for e.g. "gtk linux", "qt linux". > In any case, feel free to remove the assert. Are you sure it's safe to remove only the assert??? IMHO we need to use the Mutex all the time. 404149 4 93575 paroga 2011-05-15 00:20:01 -0700 Created attachment 93575 Patch 404169 5 93575 abarth 2011-05-15 08:23:17 -0700 Comment on attachment 93575 Patch We don't need the mutex if WTF_MULTIPLE_THREADS isn't defined. 404170 6 paroga 2011-05-15 08:25:09 -0700 (In reply to comment #5) > (From update of attachment 93575 [details]) > We don't need the mutex if WTF_MULTIPLE_THREADS isn't defined. Can we ensure that the embedding app don't call randomNumber() while running JSC? Does the API forbid such calls? 404171 7 93580 paroga 2011-05-15 08:29:11 -0700 Created attachment 93580 Patch 404173 8 93580 abarth 2011-05-15 08:47:06 -0700 Comment on attachment 93580 Patch Lots of stuff in WTF requires WTF_MULTIPLE_THREADS to be thread-safe. 410120 9 michaeln 2011-05-25 19:04:06 -0700 Is there a reason to not land this patch? There's a case where we trip on this assertion w/o it being a real problem. https://bugs.webkit.org/show_bug.cgi?id=55728 After seeing the r+ on Patrick's patch here, I thought that problem was solved, but this is not committed yet. Is there a reason for that or would it be OK if I land it? 410278 10 93580 commit-queue 2011-05-26 01:08:44 -0700 Comment on attachment 93580 Patch Clearing flags on attachment: 93580 Committed r87369: <http://trac.webkit.org/changeset/87369> 410279 11 commit-queue 2011-05-26 01:08:49 -0700 All reviewed patches have been landed. Closing bug. 410476 12 ademar 2011-05-26 08:58:20 -0700 Revision r87369 cherry-picked into qtwebkit-2.2 with commit ef13621 <http://gitorious.org/webkit/qtwebkit/commit/ef13621> 410780 13 michaeln 2011-05-26 13:33:18 -0700 Thank you! 93575 2011-05-15 00:20:01 -0700 2011-05-15 08:29:02 -0700 Patch bug-60846-20110515091958.patch text/plain 2089 paroga U3VidmVyc2lvbiBSZXZpc2lvbjogODY1MDIKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDcw YzFkNzFiMjRmN2I1ZDNmMDFiZGM2MjNjNWYyYzRlMGY4NzM5NTIuLjYyMWIzY2I1MWIxYzQ3MDFi ZmExMjlhYTVhYzdmMDU1Mzc4NjEyYzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE3IEBACisyMDExLTA1LTE1ICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9nYUB3ZWJraXQu b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFT U0VSVChpc01haW5UaHJlYWQoKSkgd2hlbiB1c2luZyBzaW5nbGUgdGhyZWFkZWQganNjIGV4ZWN1 dGFibGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYw ODQ2CisKKyAgICAgICAgUmVtb3ZlIHRoZSBBU1NFUlQgYW5kIHVzZSBhIE11dGV4IGFsbCB0aGUg dGltZS4KKyAgICAgICAgVGhlcmUgaXMgbm8gcmVhc29uIHRvIHVzZSByYW5kb21OdW1lcigpIG9u bHkgZnJvbSBNYWluVGhyZWFkLgorCisgICAgICAgICogd3RmL0NyeXB0b2dyYXBoaWNhbGx5UmFu ZG9tTnVtYmVyLmNwcDoKKyAgICAgICAgKFdURjo6QVJDNFN0cmVhbTo6QVJDNFJhbmRvbU51bWJl ckdlbmVyYXRvcjo6cmFuZG9tTnVtYmVyKToKKyAgICAgICAgKFdURjo6QVJDNFN0cmVhbTo6QVJD NFJhbmRvbU51bWJlckdlbmVyYXRvcjo6cmFuZG9tVmFsdWVzKToKKwogMjAxMS0wNS0xMyAgT2xp dmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEdlb2Zm cmV5IEdhcmVuLgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9DcnlwdG9n cmFwaGljYWxseVJhbmRvbU51bWJlci5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0Ny eXB0b2dyYXBoaWNhbGx5UmFuZG9tTnVtYmVyLmNwcAppbmRleCBlZjA5N2FiMDljNDczYTY3NTEw NDZhNzE4Njk1ODNiZTllZjVkYTU4Li4zYzQxZTUwNDc0ODJlZTNhNjk3MGQzNDdkOWIwZWQxMjNk ZGQ0Y2IwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0NyeXB0b2dyYXBo aWNhbGx5UmFuZG9tTnVtYmVyLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0Ny eXB0b2dyYXBoaWNhbGx5UmFuZG9tTnVtYmVyLmNwcApAQCAtNjYsOSArNjYsNyBAQCBwcml2YXRl OgogCiAgICAgQVJDNFN0cmVhbSBtX3N0cmVhbTsKICAgICBpbnQgbV9jb3VudDsKLSNpZiBFTkFC TEUoV1RGX01VTFRJUExFX1RIUkVBRFMpCiAgICAgTXV0ZXggbV9tdXRleDsKLSNlbmRpZgogfTsK IAogQVJDNFN0cmVhbTo6QVJDNFN0cmVhbSgpCkBAIC0xNDAsMTEgKzEzOCw3IEBAIHVpbnQzMl90 IEFSQzRSYW5kb21OdW1iZXJHZW5lcmF0b3I6OmdldFdvcmQoKQogCiB1aW50MzJfdCBBUkM0UmFu ZG9tTnVtYmVyR2VuZXJhdG9yOjpyYW5kb21OdW1iZXIoKQogewotI2lmIEVOQUJMRShXVEZfTVVM VElQTEVfVEhSRUFEUykKICAgICBNdXRleExvY2tlciBsb2NrZXIobV9tdXRleCk7Ci0jZWxzZQot ICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7Ci0jZW5kaWYKIAogICAgIG1fY291bnQgLT0gNDsK ICAgICBzdGlySWZOZWVkZWQoKTsKQEAgLTE1MywxMSArMTQ3LDcgQEAgdWludDMyX3QgQVJDNFJh bmRvbU51bWJlckdlbmVyYXRvcjo6cmFuZG9tTnVtYmVyKCkKIAogdm9pZCBBUkM0UmFuZG9tTnVt YmVyR2VuZXJhdG9yOjpyYW5kb21WYWx1ZXModm9pZCogYnVmZmVyLCBzaXplX3QgbGVuZ3RoKQog ewotI2lmIEVOQUJMRShXVEZfTVVMVElQTEVfVEhSRUFEUykKICAgICBNdXRleExvY2tlciBsb2Nr ZXIobV9tdXRleCk7Ci0jZWxzZQotICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7Ci0jZW5kaWYK IAogICAgIHVuc2lnbmVkIGNoYXIqIHJlc3VsdCA9IHJlaW50ZXJwcmV0X2Nhc3Q8dW5zaWduZWQg Y2hhcio+KGJ1ZmZlcik7CiAgICAgc3RpcklmTmVlZGVkKCk7Cg== 93580 2011-05-15 08:29:11 -0700 2011-05-26 01:08:43 -0700 Patch bug-60846-20110515172908.patch text/plain 1729 paroga U3VidmVyc2lvbiBSZXZpc2lvbjogODY1MDIKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDcw YzFkNzFiMjRmN2I1ZDNmMDFiZGM2MjNjNWYyYzRlMGY4NzM5NTIuLjUxODAwYjM2MTlhZWIyYzU2 ZWUwMjFkNGJkNzM5MGYwYjc1NmQxMjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE2IEBACisyMDExLTA1LTE1ICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9nYUB3ZWJraXQu b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFT U0VSVChpc01haW5UaHJlYWQoKSkgd2hlbiB1c2luZyBzaW5nbGUgdGhyZWFkZWQganNjIGV4ZWN1 dGFibGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYw ODQ2CisKKyAgICAgICAgUmVtb3ZlIHRoZSBBU1NFUlQgc2luY2Ugd2UgZG8gbm90IGhhdmUgdGhl IGNvbmNlcHQgb2YgTWFpblRocmVhZCBpbiBKU0MuCisKKyAgICAgICAgKiB3dGYvQ3J5cHRvZ3Jh cGhpY2FsbHlSYW5kb21OdW1iZXIuY3BwOgorICAgICAgICAoV1RGOjpBUkM0U3RyZWFtOjpBUkM0 UmFuZG9tTnVtYmVyR2VuZXJhdG9yOjpyYW5kb21OdW1iZXIpOgorICAgICAgICAoV1RGOjpBUkM0 U3RyZWFtOjpBUkM0UmFuZG9tTnVtYmVyR2VuZXJhdG9yOjpyYW5kb21WYWx1ZXMpOgorCiAyMDEx LTA1LTEzICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgR2VvZmZyZXkgR2FyZW4uCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv d3RmL0NyeXB0b2dyYXBoaWNhbGx5UmFuZG9tTnVtYmVyLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS93dGYvQ3J5cHRvZ3JhcGhpY2FsbHlSYW5kb21OdW1iZXIuY3BwCmluZGV4IGVmMDk3YWIw OWM0NzNhNjc1MTA0NmE3MTg2OTU4M2JlOWVmNWRhNTguLmFkOGU3MTZjNTEyYjE2ODM5MjMxZDIz ODMyYzI2MDdiOWY0MmQzMGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYv Q3J5cHRvZ3JhcGhpY2FsbHlSYW5kb21OdW1iZXIuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS93dGYvQ3J5cHRvZ3JhcGhpY2FsbHlSYW5kb21OdW1iZXIuY3BwCkBAIC0xNDIsOCArMTQy LDYgQEAgdWludDMyX3QgQVJDNFJhbmRvbU51bWJlckdlbmVyYXRvcjo6cmFuZG9tTnVtYmVyKCkK IHsKICNpZiBFTkFCTEUoV1RGX01VTFRJUExFX1RIUkVBRFMpCiAgICAgTXV0ZXhMb2NrZXIgbG9j a2VyKG1fbXV0ZXgpOwotI2Vsc2UKLSAgICBBU1NFUlQoaXNNYWluVGhyZWFkKCkpOwogI2VuZGlm CiAKICAgICBtX2NvdW50IC09IDQ7CkBAIC0xNTUsOCArMTUzLDYgQEAgdm9pZCBBUkM0UmFuZG9t TnVtYmVyR2VuZXJhdG9yOjpyYW5kb21WYWx1ZXModm9pZCogYnVmZmVyLCBzaXplX3QgbGVuZ3Ro KQogewogI2lmIEVOQUJMRShXVEZfTVVMVElQTEVfVEhSRUFEUykKICAgICBNdXRleExvY2tlciBs b2NrZXIobV9tdXRleCk7Ci0jZWxzZQotICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7CiAjZW5k aWYKIAogICAgIHVuc2lnbmVkIGNoYXIqIHJlc3VsdCA9IHJlaW50ZXJwcmV0X2Nhc3Q8dW5zaWdu ZWQgY2hhcio+KGJ1ZmZlcik7Cg==