60827 2011-05-13 20:33:21 -0700 [GTK] Implement GraphicsContextCairo::imageInterpolationQuality(). 2011-05-24 08:13:33 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 ryuan.choi webkit-unassigned commit-queue kling mrobinson xan.lopez oldest_to_newest 404018 0 ryuan.choi 2011-05-13 20:33:21 -0700 imageInterpolationQuality() make image rendering faster in some special case. But, GraphicsContextCairo doesn't implement it. 404271 1 93601 ryuan.choi 2011-05-15 21:51:23 -0700 Created attachment 93601 Patch 404655 2 93601 mrobinson 2011-05-16 12:27:03 -0700 Comment on attachment 93601 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=93601&action=review Nice! I have a few comments below. In general, I think this patch needs a bit more context either in the ChangeLog or in the bug report. Are you just filling out a stub here? > Source/WebCore/ChangeLog:8 > + Implement GraphicsContextCairo::imageInterpolationQuality. Might make sense to describe how this affects drawing performance or give more information about what prompted this change. > Source/WebCore/ChangeLog:16 > + * platform/graphics/cairo/GraphicsContextCairo.cpp: > + (WebCore::GraphicsContext::setImageInterpolationQuality): > + (WebCore::GraphicsContext::imageInterpolationQuality): > + * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: > + * platform/graphics/cairo/PlatformContextCairo.cpp: > + (WebCore::PlatformContextCairo::drawSurfaceToContext): > + Please fill these out. > Source/WebCore/platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:105 > + InterpolationQuality imageInterpolationQuality; It makes more sense to have this as a member of PlatformContextCairo, don't you think? 406873 3 94172 ryuan.choi 2011-05-19 21:57:52 -0700 Created attachment 94172 Patch 406874 4 ryuan.choi 2011-05-19 21:59:42 -0700 (In reply to comment #2) > (From update of attachment 93601 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=93601&action=review > > Nice! I have a few comments below. In general, I think this patch needs a bit more context either in the ChangeLog or in the bug report. Are you just filling out a stub here? > > > Source/WebCore/ChangeLog:8 > > + Implement GraphicsContextCairo::imageInterpolationQuality. > > Might make sense to describe how this affects drawing performance or give more information about what prompted this change. > > > Source/WebCore/ChangeLog:16 > > + * platform/graphics/cairo/GraphicsContextCairo.cpp: > > + (WebCore::GraphicsContext::setImageInterpolationQuality): > > + (WebCore::GraphicsContext::imageInterpolationQuality): > > + * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: > > + * platform/graphics/cairo/PlatformContextCairo.cpp: > > + (WebCore::PlatformContextCairo::drawSurfaceToContext): > > + > > Please fill these out. > > > Source/WebCore/platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:105 > > + InterpolationQuality imageInterpolationQuality; > > It makes more sense to have this as a member of PlatformContextCairo, don't you think? Thank you for your review. I prepared patch like you mentioned. 408106 5 94172 mrobinson 2011-05-23 11:38:04 -0700 Comment on attachment 94172 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=94172&action=review Looks good, I think the ChangeLog just lacks a bit of context. > Source/WebCore/ChangeLog:12 > + Implement getter/setter of imageInterpolationQuality and logic to change > + interpolation algorithm when drawing image. > + WebCore control image quality using ImageQualityController so GraphicsContext > + can draw image faster using proper interpolation. > + Mac and Qt already implemented it. I guess I was wondering if there are particular cases where things will speed up. When does WebCore change the interpolation quality of an image? Please either even out these line or split them into separate paragraphs. :) 408720 6 94583 ryuan.choi 2011-05-24 01:26:34 -0700 Created attachment 94583 Patch 408722 7 ryuan.choi 2011-05-24 01:33:53 -0700 (In reply to comment #5) > (From update of attachment 94172 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=94172&action=review > > Looks good, I think the ChangeLog just lacks a bit of context. > > > Source/WebCore/ChangeLog:12 > > + Implement getter/setter of imageInterpolationQuality and logic to change > > + interpolation algorithm when drawing image. > > + WebCore control image quality using ImageQualityController so GraphicsContext > > + can draw image faster using proper interpolation. > > + Mac and Qt already implemented it. > > I guess I was wondering if there are particular cases where things will speed up. When does WebCore change the interpolation quality of an image? Please either even out these line or split them into separate paragraphs. :) I removed poor explanation. And I didn't explain all of conditions but RenderBoxModelObject check it When panning or scaling maps.google.com, it will work. Thank you. 408792 8 94583 kling 2011-05-24 06:02:40 -0700 Comment on attachment 94583 Patch Nice, r=me. A little about this setting, for anyone who is interested: The most common use case for GC's imageInterpolationQuality is indeed the ImageQualityController which is a mechanism that ensures that we don't waste time painting an image with high-quality scaling when it's likely to be repainted very soon again. For example, when the page is being scrolled, an image may be repainted over and over (with a primitive drawing model) and WebCore then tells the GC to draw it with low quality scaling until it sits in the same place for 0.5s (cLowQualityTimeThreshold in RenderBoxModelObject.cpp.) It's also used when animating images via JavaScript, e.g by dynamically altering the width/height attributes. 408857 9 commit-queue 2011-05-24 08:11:11 -0700 The commit-queue encountered the following flaky tests while processing attachment 94583: animations/suspend-resume-animation.html bug 48161 (authors: cmarrin@apple.com and simon.fraser@apple.com) The commit-queue is continuing to process your patch. 408862 10 94583 commit-queue 2011-05-24 08:13:28 -0700 Comment on attachment 94583 Patch Clearing flags on attachment: 94583 Committed r87151: <http://trac.webkit.org/changeset/87151> 408863 11 commit-queue 2011-05-24 08:13:33 -0700 All reviewed patches have been landed. Closing bug. 93601 2011-05-15 21:51:23 -0700 2011-05-19 21:57:44 -0700 Patch bug-60827-20110516135148.patch text/plain 3667 ryuan.choi SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg2NDc4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDUtMTMgIFJ5dWFuIENo b2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIEltcGxlbWVudCBHcmFwaGljc0NvbnRleHRDYWly bzo6aW1hZ2VJbnRlcnBvbGF0aW9uUXVhbGl0eSgpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjA4MjcKKworICAgICAgICBJbXBsZW1lbnQgR3JhcGhp Y3NDb250ZXh0Q2Fpcm86OmltYWdlSW50ZXJwb2xhdGlvblF1YWxpdHkuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRDYWlyby5jcHA6CisgICAgICAg IChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQ6OnNldEltYWdlSW50ZXJwb2xhdGlvblF1YWxpdHkp OgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0OjppbWFnZUludGVycG9sYXRpb25R dWFsaXR5KToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRl eHRQbGF0Zm9ybVByaXZhdGVDYWlyby5oOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nh aXJvL1BsYXRmb3JtQ29udGV4dENhaXJvLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBsYXRmb3Jt Q29udGV4dENhaXJvOjpkcmF3U3VyZmFjZVRvQ29udGV4dCk6CisKIDIwMTEtMDUtMTMgIEFsZXhl eSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFy aW4gQWRsZXIuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9H cmFwaGljc0NvbnRleHRDYWlyby5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0Q2Fpcm8uY3BwCShyZXZpc2lvbiA4 NjQ3NykKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNz Q29udGV4dENhaXJvLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTE1NCwxMyArMTE1NCwxNCBAQCB2 b2lkIEdyYXBoaWNzQ29udGV4dDo6c2V0UGxhdGZvcm1TaG91bGRBCiAgICAgY2Fpcm9fc2V0X2Fu dGlhbGlhcyhwbGF0Zm9ybUNvbnRleHQoKS0+Y3IoKSwgZW5hYmxlID8gQ0FJUk9fQU5USUFMSUFT X0RFRkFVTFQgOiBDQUlST19BTlRJQUxJQVNfTk9ORSk7CiB9CiAKLXZvaWQgR3JhcGhpY3NDb250 ZXh0OjpzZXRJbWFnZUludGVycG9sYXRpb25RdWFsaXR5KEludGVycG9sYXRpb25RdWFsaXR5KQor dm9pZCBHcmFwaGljc0NvbnRleHQ6OnNldEltYWdlSW50ZXJwb2xhdGlvblF1YWxpdHkoSW50ZXJw b2xhdGlvblF1YWxpdHkgcXVhbGl0eSkKIHsKKyAgICBtX2RhdGEtPmltYWdlSW50ZXJwb2xhdGlv blF1YWxpdHkgPSBxdWFsaXR5OwogfQogCiBJbnRlcnBvbGF0aW9uUXVhbGl0eSBHcmFwaGljc0Nv bnRleHQ6OmltYWdlSW50ZXJwb2xhdGlvblF1YWxpdHkoKSBjb25zdAogewotICAgIHJldHVybiBJ bnRlcnBvbGF0aW9uRGVmYXVsdDsKKyAgICByZXR1cm4gbV9kYXRhLT5pbWFnZUludGVycG9sYXRp b25RdWFsaXR5OwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRQbGF0Zm9ybVByaXZh dGVDYWlyby5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2NhaXJvL0dyYXBoaWNzQ29udGV4dFBsYXRmb3JtUHJpdmF0ZUNhaXJvLmgJKHJldmlzaW9uIDg2 NDc3KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3ND b250ZXh0UGxhdGZvcm1Qcml2YXRlQ2Fpcm8uaAkod29ya2luZyBjb3B5KQpAQCAtMTAyLDYgKzEw Miw3IEBAIHB1YmxpYzoKICAgICBWZWN0b3I8ZmxvYXQ+IGxheWVyczsKICAgICBDb250ZXh0U2hh ZG93IHNoYWRvdzsKICAgICBWZWN0b3I8Q29udGV4dFNoYWRvdz4gc2hhZG93U3RhY2s7CisgICAg SW50ZXJwb2xhdGlvblF1YWxpdHkgaW1hZ2VJbnRlcnBvbGF0aW9uUXVhbGl0eTsKIAogI2lmIFBM QVRGT1JNKEdUSykKICAgICBHZGtFdmVudEV4cG9zZSogZXhwb3NlOwpJbmRleDogU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vUGxhdGZvcm1Db250ZXh0Q2Fpcm8uY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL1BsYXRm b3JtQ29udGV4dENhaXJvLmNwcAkocmV2aXNpb24gODY0NzcpCisrKyBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jYWlyby9QbGF0Zm9ybUNvbnRleHRDYWlyby5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTk3LDYgKzk3LDIwIEBAIHZvaWQgUGxhdGZvcm1Db250ZXh0Q2Fpcm86OmRyYXdT dXJmYWNlVG8KICAgICAvLyBhIHBhdHRlcm4gdHJhbnNmb3JtYXRpb24gb24gdGhlIGltYWdlIGFu ZCBkcmF3IHRoZSB0cmFuc2Zvcm1lZCBwYXR0ZXJuLgogICAgIC8vIFRlc3QgdXNpbmcgZXhhbXBs ZSBzaXRlIGF0IGh0dHA6Ly93d3cubWV5ZXJ3ZWIuY29tL2VyaWMvY3NzL2VkZ2UvY29tcGxleHNw aXJhbC9kZW1vLmh0bWwKICAgICBSZWZQdHI8Y2Fpcm9fcGF0dGVybl90PiBwYXR0ZXJuID0gYWRv cHRSZWYoY2Fpcm9fcGF0dGVybl9jcmVhdGVfZm9yX3N1cmZhY2Uoc3VyZmFjZSkpOworCisgICAg c3dpdGNoIChjb250ZXh0LT5pbWFnZUludGVycG9sYXRpb25RdWFsaXR5KCkpIHsKKyAgICBjYXNl IEludGVycG9sYXRpb25Ob25lOgorICAgIGNhc2UgSW50ZXJwb2xhdGlvbkxvdzoKKyAgICAgICAg Y2Fpcm9fcGF0dGVybl9zZXRfZmlsdGVyKHBhdHRlcm4uZ2V0KCksIENBSVJPX0ZJTFRFUl9GQVNU KTsKKyAgICAgICAgYnJlYWs7CisgICAgY2FzZSBJbnRlcnBvbGF0aW9uTWVkaXVtOgorICAgIGNh c2UgSW50ZXJwb2xhdGlvbkhpZ2g6CisgICAgICAgIGNhaXJvX3BhdHRlcm5fc2V0X2ZpbHRlcihw YXR0ZXJuLmdldCgpLCBDQUlST19GSUxURVJfQklMSU5FQVIpOworICAgICAgICBicmVhazsKKyAg ICBjYXNlIEludGVycG9sYXRpb25EZWZhdWx0OgorICAgICAgICBjYWlyb19wYXR0ZXJuX3NldF9m aWx0ZXIocGF0dGVybi5nZXQoKSwgQ0FJUk9fRklMVEVSX0JJTElORUFSKTsKKyAgICAgICAgYnJl YWs7CisgICAgfQogICAgIGNhaXJvX3BhdHRlcm5fc2V0X2V4dGVuZChwYXR0ZXJuLmdldCgpLCBD QUlST19FWFRFTkRfUEFEKTsKIAogICAgIGZsb2F0IHNjYWxlWCA9IHNyY1JlY3Qud2lkdGgoKSAv IGRlc3RSZWN0LndpZHRoKCk7Cg== 94172 2011-05-19 21:57:52 -0700 2011-05-24 01:26:26 -0700 Patch bug-60827-20110520135906.patch text/plain 5223 ryuan.choi SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg2OTIyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTEtMDUtMTkgIFJ5dWFuIENo b2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIEltcGxlbWVudCBHcmFwaGljc0NvbnRleHRDYWly bzo6aW1hZ2VJbnRlcnBvbGF0aW9uUXVhbGl0eSgpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjA4MjcKKworICAgICAgICBJbXBsZW1lbnQgZ2V0dGVy L3NldHRlciBvZiBpbWFnZUludGVycG9sYXRpb25RdWFsaXR5IGFuZCBsb2dpYyB0byBjaGFuZ2UK KyAgICAgICAgaW50ZXJwb2xhdGlvbiBhbGdvcml0aG0gd2hlbiBkcmF3aW5nIGltYWdlLgorICAg ICAgICBXZWJDb3JlIGNvbnRyb2wgaW1hZ2UgcXVhbGl0eSB1c2luZyBJbWFnZVF1YWxpdHlDb250 cm9sbGVyIHNvIEdyYXBoaWNzQ29udGV4dAorICAgICAgICBjYW4gZHJhdyBpbWFnZSBmYXN0ZXIg dXNpbmcgcHJvcGVyIGludGVycG9sYXRpb24uCisgICAgICAgIE1hYyBhbmQgUXQgYWxyZWFkeSBp bXBsZW1lbnRlZCBpdC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBo aWNzQ29udGV4dENhaXJvLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDo6 c2V0SW1hZ2VJbnRlcnBvbGF0aW9uUXVhbGl0eSk6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGlj c0NvbnRleHQ6OmltYWdlSW50ZXJwb2xhdGlvblF1YWxpdHkpOgorICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dFBsYXRmb3JtUHJpdmF0ZUNhaXJvLmg6Cisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vUGxhdGZvcm1Db250ZXh0Q2Fpcm8uY3Bw OgorICAgICAgICAoV2ViQ29yZTo6UGxhdGZvcm1Db250ZXh0Q2Fpcm86OmRyYXdTdXJmYWNlVG9D b250ZXh0KToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9QbGF0Zm9ybUNvbnRl eHRDYWlyby5oOgorICAgICAgICAoV2ViQ29yZTo6UGxhdGZvcm1Db250ZXh0Q2Fpcm86OnNldElt YWdlSW50ZXJwb2xhdGlvblF1YWxpdHkpOiBBZGRlZC4KKyAgICAgICAgKFdlYkNvcmU6OlBsYXRm b3JtQ29udGV4dENhaXJvOjppbWFnZUludGVycG9sYXRpb25RdWFsaXR5KTogQWRkZWQuCisKIDIw MTEtMDUtMTkgIEp1bGllbiBDaGFmZnJhaXggIDxqY2hhZmZyYWl4QGNvZGVhdXJvcmEub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRDYWlyby5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250 ZXh0Q2Fpcm8uY3BwCShyZXZpc2lvbiA4NjkyMikKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dENhaXJvLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMTE1NCwxMyArMTE1NCwxNCBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDo6c2V0UGxhdGZvcm1T aG91bGRBCiAgICAgY2Fpcm9fc2V0X2FudGlhbGlhcyhwbGF0Zm9ybUNvbnRleHQoKS0+Y3IoKSwg ZW5hYmxlID8gQ0FJUk9fQU5USUFMSUFTX0RFRkFVTFQgOiBDQUlST19BTlRJQUxJQVNfTk9ORSk7 CiB9CiAKLXZvaWQgR3JhcGhpY3NDb250ZXh0OjpzZXRJbWFnZUludGVycG9sYXRpb25RdWFsaXR5 KEludGVycG9sYXRpb25RdWFsaXR5KQordm9pZCBHcmFwaGljc0NvbnRleHQ6OnNldEltYWdlSW50 ZXJwb2xhdGlvblF1YWxpdHkoSW50ZXJwb2xhdGlvblF1YWxpdHkgcXVhbGl0eSkKIHsKKyAgICBw bGF0Zm9ybUNvbnRleHQoKS0+c2V0SW1hZ2VJbnRlcnBvbGF0aW9uUXVhbGl0eShxdWFsaXR5KTsK IH0KIAogSW50ZXJwb2xhdGlvblF1YWxpdHkgR3JhcGhpY3NDb250ZXh0OjppbWFnZUludGVycG9s YXRpb25RdWFsaXR5KCkgY29uc3QKIHsKLSAgICByZXR1cm4gSW50ZXJwb2xhdGlvbkRlZmF1bHQ7 CisgICAgcmV0dXJuIHBsYXRmb3JtQ29udGV4dCgpLT5pbWFnZUludGVycG9sYXRpb25RdWFsaXR5 KCk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dFBsYXRmb3JtUHJpdmF0ZUNhaXJv LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8v R3JhcGhpY3NDb250ZXh0UGxhdGZvcm1Qcml2YXRlQ2Fpcm8uaAkocmV2aXNpb24gODY5MjIpCisr KyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRQ bGF0Zm9ybVByaXZhdGVDYWlyby5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMDIsNiArMTAyLDcgQEAg cHVibGljOgogICAgIFZlY3RvcjxmbG9hdD4gbGF5ZXJzOwogICAgIENvbnRleHRTaGFkb3cgc2hh ZG93OwogICAgIFZlY3RvcjxDb250ZXh0U2hhZG93PiBzaGFkb3dTdGFjazsKKyAgICBJbnRlcnBv bGF0aW9uUXVhbGl0eSBpbWFnZUludGVycG9sYXRpb25RdWFsaXR5OwogCiAjaWYgUExBVEZPUk0o R1RLKQogICAgIEdka0V2ZW50RXhwb3NlKiBleHBvc2U7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jYWlyby9QbGF0Zm9ybUNvbnRleHRDYWlyby5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vUGxhdGZvcm1Db250 ZXh0Q2Fpcm8uY3BwCShyZXZpc2lvbiA4NjkyMikKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2NhaXJvL1BsYXRmb3JtQ29udGV4dENhaXJvLmNwcAkod29ya2luZyBjb3B5KQpA QCAtOTcsNiArOTcsMjAgQEAgdm9pZCBQbGF0Zm9ybUNvbnRleHRDYWlybzo6ZHJhd1N1cmZhY2VU bwogICAgIC8vIGEgcGF0dGVybiB0cmFuc2Zvcm1hdGlvbiBvbiB0aGUgaW1hZ2UgYW5kIGRyYXcg dGhlIHRyYW5zZm9ybWVkIHBhdHRlcm4uCiAgICAgLy8gVGVzdCB1c2luZyBleGFtcGxlIHNpdGUg YXQgaHR0cDovL3d3dy5tZXllcndlYi5jb20vZXJpYy9jc3MvZWRnZS9jb21wbGV4c3BpcmFsL2Rl bW8uaHRtbAogICAgIFJlZlB0cjxjYWlyb19wYXR0ZXJuX3Q+IHBhdHRlcm4gPSBhZG9wdFJlZihj YWlyb19wYXR0ZXJuX2NyZWF0ZV9mb3Jfc3VyZmFjZShzdXJmYWNlKSk7CisKKyAgICBzd2l0Y2gg KG1faW1hZ2VJbnRlcnBvbGF0aW9uUXVhbGl0eSkgeworICAgIGNhc2UgSW50ZXJwb2xhdGlvbk5v bmU6CisgICAgY2FzZSBJbnRlcnBvbGF0aW9uTG93OgorICAgICAgICBjYWlyb19wYXR0ZXJuX3Nl dF9maWx0ZXIocGF0dGVybi5nZXQoKSwgQ0FJUk9fRklMVEVSX0ZBU1QpOworICAgICAgICBicmVh azsKKyAgICBjYXNlIEludGVycG9sYXRpb25NZWRpdW06CisgICAgY2FzZSBJbnRlcnBvbGF0aW9u SGlnaDoKKyAgICAgICAgY2Fpcm9fcGF0dGVybl9zZXRfZmlsdGVyKHBhdHRlcm4uZ2V0KCksIENB SVJPX0ZJTFRFUl9CSUxJTkVBUik7CisgICAgICAgIGJyZWFrOworICAgIGNhc2UgSW50ZXJwb2xh dGlvbkRlZmF1bHQ6CisgICAgICAgIGNhaXJvX3BhdHRlcm5fc2V0X2ZpbHRlcihwYXR0ZXJuLmdl dCgpLCBDQUlST19GSUxURVJfQklMSU5FQVIpOworICAgICAgICBicmVhazsKKyAgICB9CiAgICAg Y2Fpcm9fcGF0dGVybl9zZXRfZXh0ZW5kKHBhdHRlcm4uZ2V0KCksIENBSVJPX0VYVEVORF9QQUQp OwogCiAgICAgZmxvYXQgc2NhbGVYID0gc3JjUmVjdC53aWR0aCgpIC8gZGVzdFJlY3Qud2lkdGgo KTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL1BsYXRmb3Jt Q29udGV4dENhaXJvLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY2Fpcm8vUGxhdGZvcm1Db250ZXh0Q2Fpcm8uaAkocmV2aXNpb24gODY5MjIpCisrKyBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9QbGF0Zm9ybUNvbnRleHRDYWly by5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNyw2ICsyNyw3IEBACiAjZGVmaW5lIFBsYXRmb3JtQ29u dGV4dENhaXJvX2gKIAogI2luY2x1ZGUgIkNvbnRleHRTaGFkb3cuaCIKKyNpbmNsdWRlICJHcmFw aGljc0NvbnRleHQuaCIKICNpbmNsdWRlICJSZWZQdHJDYWlyby5oIgogCiBuYW1lc3BhY2UgV2Vi Q29yZSB7CkBAIC02OCw5ICs2OSwxMyBAQCBwdWJsaWM6CiAgICAgdm9pZCBwdXNoSW1hZ2VNYXNr KGNhaXJvX3N1cmZhY2VfdCosIGNvbnN0IEZsb2F0UmVjdCYpOwogICAgIHZvaWQgZHJhd1N1cmZh Y2VUb0NvbnRleHQoY2Fpcm9fc3VyZmFjZV90KiwgY29uc3QgRmxvYXRSZWN0JiBkZXN0UmVjdCwg Y29uc3QgRmxvYXRSZWN0JiBzcmNSZWN0LCBHcmFwaGljc0NvbnRleHQqKTsKIAorICAgIHZvaWQg c2V0SW1hZ2VJbnRlcnBvbGF0aW9uUXVhbGl0eShJbnRlcnBvbGF0aW9uUXVhbGl0eSBxdWFsaXR5 KSB7IG1faW1hZ2VJbnRlcnBvbGF0aW9uUXVhbGl0eSA9IHF1YWxpdHk7IH0KKyAgICBJbnRlcnBv bGF0aW9uUXVhbGl0eSBpbWFnZUludGVycG9sYXRpb25RdWFsaXR5KCkgY29uc3QgeyByZXR1cm4g bV9pbWFnZUludGVycG9sYXRpb25RdWFsaXR5OyB9CisKIHByaXZhdGU6CiAgICAgUmVmUHRyPGNh aXJvX3Q+IG1fY3I7CiAgICAgVmVjdG9yPEltYWdlTWFza0luZm9ybWF0aW9uPiBtX21hc2tJbWFn ZVN0YWNrOworICAgIEludGVycG9sYXRpb25RdWFsaXR5IG1faW1hZ2VJbnRlcnBvbGF0aW9uUXVh bGl0eTsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK 94583 2011-05-24 01:26:34 -0700 2011-05-24 08:13:28 -0700 Patch bug-60827-20110524172628.patch text/plain 5067 ryuan.choi SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg3MTM1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTEtMDUtMjQgIFJ5dWFuIENo b2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIEltcGxlbWVudCBHcmFwaGljc0NvbnRleHRDYWly bzo6aW1hZ2VJbnRlcnBvbGF0aW9uUXVhbGl0eSgpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjA4MjcKKworICAgICAgICBJbXBsZW1lbnQgZ2V0dGVy L3NldHRlciBvZiBpbWFnZUludGVycG9sYXRpb25RdWFsaXR5IGFuZCBsb2dpYyB0byBjaGFuZ2UK KyAgICAgICAgaW50ZXJwb2xhdGlvbiBhbGdvcml0aG0gd2hlbiBkcmF3aW5nIGltYWdlLgorICAg ICAgICBNYWMgYW5kIFF0IGFscmVhZHkgaW1wbGVtZW50ZWQgaXQuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRDYWlyby5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpHcmFwaGljc0NvbnRleHQ6OnNldEltYWdlSW50ZXJwb2xhdGlvblF1YWxpdHkpOgor ICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0OjppbWFnZUludGVycG9sYXRpb25RdWFs aXR5KToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRQ bGF0Zm9ybVByaXZhdGVDYWlyby5oOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NhaXJv L1BsYXRmb3JtQ29udGV4dENhaXJvLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBsYXRmb3JtQ29u dGV4dENhaXJvOjpkcmF3U3VyZmFjZVRvQ29udGV4dCk6CisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvY2Fpcm8vUGxhdGZvcm1Db250ZXh0Q2Fpcm8uaDoKKyAgICAgICAgKFdlYkNvcmU6OlBs YXRmb3JtQ29udGV4dENhaXJvOjpzZXRJbWFnZUludGVycG9sYXRpb25RdWFsaXR5KTogQWRkZWQu CisgICAgICAgIChXZWJDb3JlOjpQbGF0Zm9ybUNvbnRleHRDYWlybzo6aW1hZ2VJbnRlcnBvbGF0 aW9uUXVhbGl0eSk6IEFkZGVkLgorCiAyMDExLTA1LTI0ICBGdW1pdG9zaGkgVWthaSAgPHVrYWlA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCkluZGV4OiBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRDYWly by5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fp cm8vR3JhcGhpY3NDb250ZXh0Q2Fpcm8uY3BwCShyZXZpc2lvbiA4NzEzNSkKKysrIFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dENhaXJvLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMTE1NCwxMyArMTE1NCwxNCBAQCB2b2lkIEdyYXBoaWNzQ29udGV4 dDo6c2V0UGxhdGZvcm1TaG91bGRBCiAgICAgY2Fpcm9fc2V0X2FudGlhbGlhcyhwbGF0Zm9ybUNv bnRleHQoKS0+Y3IoKSwgZW5hYmxlID8gQ0FJUk9fQU5USUFMSUFTX0RFRkFVTFQgOiBDQUlST19B TlRJQUxJQVNfTk9ORSk7CiB9CiAKLXZvaWQgR3JhcGhpY3NDb250ZXh0OjpzZXRJbWFnZUludGVy cG9sYXRpb25RdWFsaXR5KEludGVycG9sYXRpb25RdWFsaXR5KQordm9pZCBHcmFwaGljc0NvbnRl eHQ6OnNldEltYWdlSW50ZXJwb2xhdGlvblF1YWxpdHkoSW50ZXJwb2xhdGlvblF1YWxpdHkgcXVh bGl0eSkKIHsKKyAgICBwbGF0Zm9ybUNvbnRleHQoKS0+c2V0SW1hZ2VJbnRlcnBvbGF0aW9uUXVh bGl0eShxdWFsaXR5KTsKIH0KIAogSW50ZXJwb2xhdGlvblF1YWxpdHkgR3JhcGhpY3NDb250ZXh0 OjppbWFnZUludGVycG9sYXRpb25RdWFsaXR5KCkgY29uc3QKIHsKLSAgICByZXR1cm4gSW50ZXJw b2xhdGlvbkRlZmF1bHQ7CisgICAgcmV0dXJuIHBsYXRmb3JtQ29udGV4dCgpLT5pbWFnZUludGVy cG9sYXRpb25RdWFsaXR5KCk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKSW5kZXg6IFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dFBsYXRm b3JtUHJpdmF0ZUNhaXJvLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0UGxhdGZvcm1Qcml2YXRlQ2Fpcm8uaAkocmV2 aXNpb24gODcxMzUpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9H cmFwaGljc0NvbnRleHRQbGF0Zm9ybVByaXZhdGVDYWlyby5oCSh3b3JraW5nIGNvcHkpCkBAIC0x MDIsNiArMTAyLDcgQEAgcHVibGljOgogICAgIFZlY3RvcjxmbG9hdD4gbGF5ZXJzOwogICAgIENv bnRleHRTaGFkb3cgc2hhZG93OwogICAgIFZlY3RvcjxDb250ZXh0U2hhZG93PiBzaGFkb3dTdGFj azsKKyAgICBJbnRlcnBvbGF0aW9uUXVhbGl0eSBpbWFnZUludGVycG9sYXRpb25RdWFsaXR5Owog CiAjaWYgUExBVEZPUk0oR1RLKQogICAgIEdka0V2ZW50RXhwb3NlKiBleHBvc2U7CkluZGV4OiBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9QbGF0Zm9ybUNvbnRleHRDYWly by5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fp cm8vUGxhdGZvcm1Db250ZXh0Q2Fpcm8uY3BwCShyZXZpc2lvbiA4NzEzNSkKKysrIFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL1BsYXRmb3JtQ29udGV4dENhaXJvLmNwcAko d29ya2luZyBjb3B5KQpAQCAtOTcsNiArOTcsMjAgQEAgdm9pZCBQbGF0Zm9ybUNvbnRleHRDYWly bzo6ZHJhd1N1cmZhY2VUbwogICAgIC8vIGEgcGF0dGVybiB0cmFuc2Zvcm1hdGlvbiBvbiB0aGUg aW1hZ2UgYW5kIGRyYXcgdGhlIHRyYW5zZm9ybWVkIHBhdHRlcm4uCiAgICAgLy8gVGVzdCB1c2lu ZyBleGFtcGxlIHNpdGUgYXQgaHR0cDovL3d3dy5tZXllcndlYi5jb20vZXJpYy9jc3MvZWRnZS9j b21wbGV4c3BpcmFsL2RlbW8uaHRtbAogICAgIFJlZlB0cjxjYWlyb19wYXR0ZXJuX3Q+IHBhdHRl cm4gPSBhZG9wdFJlZihjYWlyb19wYXR0ZXJuX2NyZWF0ZV9mb3Jfc3VyZmFjZShzdXJmYWNlKSk7 CisKKyAgICBzd2l0Y2ggKG1faW1hZ2VJbnRlcnBvbGF0aW9uUXVhbGl0eSkgeworICAgIGNhc2Ug SW50ZXJwb2xhdGlvbk5vbmU6CisgICAgY2FzZSBJbnRlcnBvbGF0aW9uTG93OgorICAgICAgICBj YWlyb19wYXR0ZXJuX3NldF9maWx0ZXIocGF0dGVybi5nZXQoKSwgQ0FJUk9fRklMVEVSX0ZBU1Qp OworICAgICAgICBicmVhazsKKyAgICBjYXNlIEludGVycG9sYXRpb25NZWRpdW06CisgICAgY2Fz ZSBJbnRlcnBvbGF0aW9uSGlnaDoKKyAgICAgICAgY2Fpcm9fcGF0dGVybl9zZXRfZmlsdGVyKHBh dHRlcm4uZ2V0KCksIENBSVJPX0ZJTFRFUl9CSUxJTkVBUik7CisgICAgICAgIGJyZWFrOworICAg IGNhc2UgSW50ZXJwb2xhdGlvbkRlZmF1bHQ6CisgICAgICAgIGNhaXJvX3BhdHRlcm5fc2V0X2Zp bHRlcihwYXR0ZXJuLmdldCgpLCBDQUlST19GSUxURVJfQklMSU5FQVIpOworICAgICAgICBicmVh azsKKyAgICB9CiAgICAgY2Fpcm9fcGF0dGVybl9zZXRfZXh0ZW5kKHBhdHRlcm4uZ2V0KCksIENB SVJPX0VYVEVORF9QQUQpOwogCiAgICAgZmxvYXQgc2NhbGVYID0gc3JjUmVjdC53aWR0aCgpIC8g ZGVzdFJlY3Qud2lkdGgoKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2NhaXJvL1BsYXRmb3JtQ29udGV4dENhaXJvLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vUGxhdGZvcm1Db250ZXh0Q2Fpcm8uaAkocmV2aXNp b24gODcxMzUpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9QbGF0 Zm9ybUNvbnRleHRDYWlyby5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNyw2ICsyNyw3IEBACiAjZGVm aW5lIFBsYXRmb3JtQ29udGV4dENhaXJvX2gKIAogI2luY2x1ZGUgIkNvbnRleHRTaGFkb3cuaCIK KyNpbmNsdWRlICJHcmFwaGljc0NvbnRleHQuaCIKICNpbmNsdWRlICJSZWZQdHJDYWlyby5oIgog CiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBAIC02OCw5ICs2OSwxMyBAQCBwdWJsaWM6CiAgICAgdm9p ZCBwdXNoSW1hZ2VNYXNrKGNhaXJvX3N1cmZhY2VfdCosIGNvbnN0IEZsb2F0UmVjdCYpOwogICAg IHZvaWQgZHJhd1N1cmZhY2VUb0NvbnRleHQoY2Fpcm9fc3VyZmFjZV90KiwgY29uc3QgRmxvYXRS ZWN0JiBkZXN0UmVjdCwgY29uc3QgRmxvYXRSZWN0JiBzcmNSZWN0LCBHcmFwaGljc0NvbnRleHQq KTsKIAorICAgIHZvaWQgc2V0SW1hZ2VJbnRlcnBvbGF0aW9uUXVhbGl0eShJbnRlcnBvbGF0aW9u UXVhbGl0eSBxdWFsaXR5KSB7IG1faW1hZ2VJbnRlcnBvbGF0aW9uUXVhbGl0eSA9IHF1YWxpdHk7 IH0KKyAgICBJbnRlcnBvbGF0aW9uUXVhbGl0eSBpbWFnZUludGVycG9sYXRpb25RdWFsaXR5KCkg Y29uc3QgeyByZXR1cm4gbV9pbWFnZUludGVycG9sYXRpb25RdWFsaXR5OyB9CisKIHByaXZhdGU6 CiAgICAgUmVmUHRyPGNhaXJvX3Q+IG1fY3I7CiAgICAgVmVjdG9yPEltYWdlTWFza0luZm9ybWF0 aW9uPiBtX21hc2tJbWFnZVN0YWNrOworICAgIEludGVycG9sYXRpb25RdWFsaXR5IG1faW1hZ2VJ bnRlcnBvbGF0aW9uUXVhbGl0eTsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK