60679 2011-05-11 17:40:28 -0700 Switch paintBoxDecorationWithSize to IntRect 2011-05-12 19:00:26 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60408 60578 1 leviw leviw darin eae eric simon.fraser oldest_to_newest 402484 0 leviw 2011-05-11 17:40:28 -0700 Another four-ints-but-should-be-an-IntRect offender. 403189 1 93351 leviw 2011-05-12 15:08:08 -0700 Created attachment 93351 Patch 403191 2 93351 eric 2011-05-12 15:10:25 -0700 Comment on attachment 93351 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=93351&action=review > Source/WebCore/rendering/RenderBox.cpp:808 > + if (paintInfo.shouldPaintWithinRoot(this)) > + paintBoxDecorationsWithSize(paintInfo, IntRect(tx, ty, width(), height())); I think I like the other style better. But it doesn't really matter. :) 403195 3 93351 leviw 2011-05-12 15:15:30 -0700 Comment on attachment 93351 Patch Clearing flags on attachment: 93351 Committed r86385: <http://trac.webkit.org/changeset/86385> 403196 4 leviw 2011-05-12 15:15:33 -0700 All reviewed patches have been landed. Closing bug. 403271 5 darin 2011-05-12 17:24:29 -0700 const IntRect&! 403318 6 eric 2011-05-12 19:00:26 -0700 (In reply to comment #5) > const IntRect&! Oops. Sorry. :( 93351 2011-05-12 15:08:08 -0700 2011-05-12 15:15:29 -0700 Patch bug-60679-20110512150806.patch text/plain 3946 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg2Mzg0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDUtMTIgIExldmkgV2Vp bnRyYXViICA8bGV2aXdAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFN3aXRjaCBwYWludEJveERlY29yYXRpb25XaXRoU2l6ZSB0 byBJbnRSZWN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD02MDY3OQorCisgICAgICAgIFN3aXRjaGluZyBwYWludEJveERlY29yYXRpb25XaXRoU2l6ZSB0 byB0YWtlIGFuIEludFJlY3QgaW5zdGVhZCBvZiA0IGludHMuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzIGFzIHRoaXMgaXMgc2ltcGxlIHJlZmFjdG9yaW5nLgorCisgICAgICAgICogcmVuZGVyaW5n L1JlbmRlckJveC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCb3g6OnBhaW50Qm94RGVj b3JhdGlvbnMpOiBDbGVhbmluZyB1cCBhbWF6aW5nbHkgY29uZnVzaW5nIGxvZ2ljLgorICAgICAg ICAoV2ViQ29yZTo6UmVuZGVyQm94OjpwYWludEJveERlY29yYXRpb25zV2l0aFNpemUpOgorICAg ICAgICAqIHJlbmRlcmluZy9SZW5kZXJCb3guaDoKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVy VGV4dENvbnRyb2xTaW5nbGVMaW5lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRleHRD b250cm9sU2luZ2xlTGluZTo6cGFpbnRCb3hEZWNvcmF0aW9ucyk6CisKIDIwMTEtMDUtMTIgIExl dmkgV2VpbnRyYXViICA8bGV2aXdAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEVyaWMgU2VpZGVsLgpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAJ KHJldmlzaW9uIDg2Mzc3KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTgwNCw5ICs4MDQsOCBAQCB2b2lkIFJlbmRlckJveDo6cGFp bnRSb290Qm94RmlsbExheWVycyhjCiAKIHZvaWQgUmVuZGVyQm94OjpwYWludEJveERlY29yYXRp b25zKFBhaW50SW5mbyYgcGFpbnRJbmZvLCBpbnQgdHgsIGludCB0eSkKIHsKLSAgICBpZiAoIXBh aW50SW5mby5zaG91bGRQYWludFdpdGhpblJvb3QodGhpcykpCi0gICAgICAgIHJldHVybjsKLSAg ICByZXR1cm4gcGFpbnRCb3hEZWNvcmF0aW9uc1dpdGhTaXplKHBhaW50SW5mbywgdHgsIHR5LCB3 aWR0aCgpLCBoZWlnaHQoKSk7CisgICAgaWYgKHBhaW50SW5mby5zaG91bGRQYWludFdpdGhpblJv b3QodGhpcykpCisgICAgICAgIHBhaW50Qm94RGVjb3JhdGlvbnNXaXRoU2l6ZShwYWludEluZm8s IEludFJlY3QodHgsIHR5LCB3aWR0aCgpLCBoZWlnaHQoKSkpOwogfQogCiBCYWNrZ3JvdW5kQmxl ZWRBdm9pZGFuY2UgUmVuZGVyQm94OjpkZXRlcm1pbmVCYWNrZ3JvdW5kQmxlZWRBdm9pZGFuY2Uo R3JhcGhpY3NDb250ZXh0KiBjb250ZXh0KSBjb25zdApAQCAtODMyLDkgKzgzMSw4IEBAIEJhY2tn cm91bmRCbGVlZEF2b2lkYW5jZSBSZW5kZXJCb3g6OmRldGUKICAgICByZXR1cm4gQmFja2dyb3Vu ZEJsZWVkVXNlVHJhbnNwYXJlbmN5TGF5ZXI7CiB9CiAKLXZvaWQgUmVuZGVyQm94OjpwYWludEJv eERlY29yYXRpb25zV2l0aFNpemUoUGFpbnRJbmZvJiBwYWludEluZm8sIGludCB0eCwgaW50IHR5 LCBpbnQgd2lkdGgsIGludCBoZWlnaHQpCit2b2lkIFJlbmRlckJveDo6cGFpbnRCb3hEZWNvcmF0 aW9uc1dpdGhTaXplKFBhaW50SW5mbyYgcGFpbnRJbmZvLCBJbnRSZWN0IHBhaW50UmVjdCkKIHsK LSAgICBJbnRSZWN0IHBhaW50UmVjdCA9IEludFJlY3QodHgsIHR5LCB3aWR0aCwgaGVpZ2h0KTsK ICAgICAvLyBib3JkZXItZml0IGNhbiBhZGp1c3Qgd2hlcmUgd2UgcGFpbnQgb3VyIGJvcmRlciBh bmQgYmFja2dyb3VuZC4gIElmIHNldCwgd2Ugc251Z2x5IGZpdCBvdXIgbGluZSBib3ggZGVzY2Vu ZGFudHMuICAoVGhlIGlDaGF0CiAgICAgLy8gYmFsbG9vbiBsYXlvdXQgaXMgYW4gZXhhbXBsZSBv ZiB0aGlzKS4KICAgICBib3JkZXJGaXRBZGp1c3QocGFpbnRSZWN0KTsKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyQm94LmgJKHJldmlzaW9uIDg2Mzc3KQorKysgU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckJveC5oCSh3b3JraW5nIGNvcHkpCkBAIC00MDgsNyArNDA4LDcg QEAgcHJvdGVjdGVkOgogICAgIHZvaWQgcGFpbnRGaWxsTGF5ZXIoY29uc3QgUGFpbnRJbmZvJiwg Y29uc3QgQ29sb3ImLCBjb25zdCBGaWxsTGF5ZXIqLCBjb25zdCBJbnRSZWN0JiwgQmFja2dyb3Vu ZEJsZWVkQXZvaWRhbmNlLCBDb21wb3NpdGVPcGVyYXRvciwgUmVuZGVyT2JqZWN0KiBiYWNrZ3Jv dW5kT2JqZWN0KTsKICAgICB2b2lkIHBhaW50RmlsbExheWVycyhjb25zdCBQYWludEluZm8mLCBj b25zdCBDb2xvciYsIGNvbnN0IEZpbGxMYXllciosIGNvbnN0IEludFJlY3QmLCBCYWNrZ3JvdW5k QmxlZWRBdm9pZGFuY2UgPSBCYWNrZ3JvdW5kQmxlZWROb25lLCBDb21wb3NpdGVPcGVyYXRvciA9 IENvbXBvc2l0ZVNvdXJjZU92ZXIsIFJlbmRlck9iamVjdCogYmFja2dyb3VuZE9iamVjdCA9IDAp OwogCi0gICAgdm9pZCBwYWludEJveERlY29yYXRpb25zV2l0aFNpemUoUGFpbnRJbmZvJiwgaW50 IHR4LCBpbnQgdHksIGludCB3aWR0aCwgaW50IGhlaWdodCk7CisgICAgdm9pZCBwYWludEJveERl Y29yYXRpb25zV2l0aFNpemUoUGFpbnRJbmZvJiwgSW50UmVjdCk7CiAgICAgdm9pZCBwYWludE1h c2tJbWFnZXMoY29uc3QgUGFpbnRJbmZvJiwgY29uc3QgSW50UmVjdCYpOwogCiAjaWYgUExBVEZP Uk0oTUFDKQpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHRDb250cm9s U2luZ2xlTGluZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlclRleHRDb250cm9sU2luZ2xlTGluZS5jcHAJKHJldmlzaW9uIDg2Mzc2KQorKysgU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHRDb250cm9sU2luZ2xlTGluZS5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTIzMyw3ICsyMzMsNyBAQCB2b2lkIFJlbmRlclRleHRDb250cm9sU2luZ2xl TGluZTo6cGFpbnQoCiAKIHZvaWQgUmVuZGVyVGV4dENvbnRyb2xTaW5nbGVMaW5lOjpwYWludEJv eERlY29yYXRpb25zKFBhaW50SW5mbyYgcGFpbnRJbmZvLCBpbnQgdHgsIGludCB0eSkKIHsKLSAg ICBwYWludEJveERlY29yYXRpb25zV2l0aFNpemUocGFpbnRJbmZvLCB0eCwgdHksIHdpZHRoKCkg LSBkZWNvcmF0aW9uV2lkdGhSaWdodCgpLCBoZWlnaHQoKSk7CisgICAgcGFpbnRCb3hEZWNvcmF0 aW9uc1dpdGhTaXplKHBhaW50SW5mbywgSW50UmVjdCh0eCwgdHksIHdpZHRoKCkgLSBkZWNvcmF0 aW9uV2lkdGhSaWdodCgpLCBoZWlnaHQoKSkpOwogfQogCiB2b2lkIFJlbmRlclRleHRDb250cm9s U2luZ2xlTGluZTo6YWRkRm9jdXNSaW5nUmVjdHMoVmVjdG9yPEludFJlY3Q+JiByZWN0cywgaW50 IHR4LCBpbnQgdHkpCg==