60670 2011-05-11 15:44:09 -0700 Remove LOOSE_PASS_OWN_ARRAY_PTR 2011-06-15 12:38:43 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 59909 P2 Normal --- 1 paroga darin abarth darin mrowe oldest_to_newest 402360 0 paroga 2011-05-11 15:44:09 -0700 Remove LOOSE_PASS_OWN_ARRAY_PTR 402368 1 93201 paroga 2011-05-11 15:50:43 -0700 Created attachment 93201 Patch 402373 2 paroga 2011-05-11 15:54:52 -0700 Does Apple have some internal dependencies on OwnArrayPtr? 402395 3 93201 abarth 2011-05-11 16:17:23 -0700 Comment on attachment 93201 Patch I think it's safe to remove this if everything compiles. If we screw something up internally for Apple, I'm sure someone will tell us and we can revert this patch. 402428 4 mrowe 2011-05-11 16:57:19 -0700 We added this code back in because it is being used. 402430 5 abarth 2011-05-11 16:58:34 -0700 (In reply to comment #4) > We added this code back in because it is being used. Is there a timetable after which we can remove the code? 402434 6 mrowe 2011-05-11 17:02:01 -0700 (In reply to comment #5) > (In reply to comment #4) > > We added this code back in because it is being used. > > Is there a timetable after which we can remove the code? Is there an urgent need to remove it? 402436 7 abarth 2011-05-11 17:04:48 -0700 > Is there an urgent need to remove it? Looks like it hasn't been used by WebKit in since <http://trac.webkit.org/changeset/77785>, which was 3 months ago. I'm happy to wait another 3 months if that's convenient for Apple internally, but I would like to remove the code at some point. 402442 8 mrowe 2011-05-11 17:09:21 -0700 The code can safely be removed when it’s no longer used. Given the tiny amount of code involved, and its unchanging nature, it seems absurd to try and force the issue. 402445 9 abarth 2011-05-11 17:14:30 -0700 My concern is that without a deadline we'll never remove the code. Presumably we'll have the same issue with the other "LOOSE" code for the other smart pointer types. It seems reasonable to want to not carry this dead code forever. If three months is not enough, how about six months? 402455 10 mrowe 2011-05-11 17:19:52 -0700 > My concern is that without a deadline we'll never remove the code. Was I somehow unclear when I stated that this code can be removed when it is unused? 402462 11 darin 2011-05-11 17:27:41 -0700 Adam, please cool your jets on this one. This is a very small number of lines of code, and it’s extremely helpful to me and my team at Apple to have this in there for a short while longer. We *will* remove it when we’re not relying on it any more. You’re coming on too strong. You may recall I specifically called this out at the contributors meeting. There must be more-worthwhile things for us to spend our time on. I’ll take this bug and I promise to deal with it. 402472 12 paroga 2011-05-11 17:30:48 -0700 @darin: maybe you want to take bug 59909 too 402476 13 abarth 2011-05-11 17:35:18 -0700 > You’re coming on too strong. Sorry if I came across too strongly. That wasn't my intent. 421506 14 darin 2011-06-15 12:38:43 -0700 Decided to handle all of these at once in bug 59909. *** This bug has been marked as a duplicate of bug 59909 *** 93201 2011-05-11 15:50:43 -0700 2011-05-11 17:27:49 -0700 Patch bug-60670-20110512005040.patch text/plain 3624 paroga U3VidmVyc2lvbiBSZXZpc2lvbjogODYyNzAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDhi NjExYzljMjQzYTZhMzUxODk3ZGEwZTc5NjNiN2QzNDE2ZDk5M2YuLjc4Mzk5NTk5NDFmOGY2ZmJl MDQ2ODZmZWRiNDVhZTkwNWFjMGJmZjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE1IEBACisyMDExLTA1LTExICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9nYUB3ZWJraXQu b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJl bW92ZSBMT09TRV9QQVNTX09XTl9BUlJBWV9QVFIgY29kZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjA2NzAKKworICAgICAgICAoUGFzcylPd25BcnJh eVB0ciBhbHJlYWR5IGNvbXBpbGVzIGluIHN0cmljdCBtb2RlLgorCisgICAgICAgICogd3RmL093 bkFycmF5UHRyLmg6CisgICAgICAgICogd3RmL1Bhc3NPd25BcnJheVB0ci5oOgorCiAyMDExLTA1 LTExICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgT2xpdmVyIEh1bnQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3Rm L093bkFycmF5UHRyLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL093bkFycmF5UHRyLmgK aW5kZXggMjgyODY5OGZmM2E2NjU5MDRjZDY1ZmY1ZDY1M2NlMjJiZGEwYzNlNi4uMGU1YjY0MGY5 NjVhMTBhYjZkNWYxOWYxNDlhMmUxMTljMjQ1NWQ1NyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL3d0Zi9Pd25BcnJheVB0ci5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93 dGYvT3duQXJyYXlQdHIuaApAQCAtNzYsMTEgKzc2LDYgQEAgcHVibGljOgogCiAgICAgdm9pZCBz d2FwKE93bkFycmF5UHRyJiBvKSB7IHN0ZDo6c3dhcChtX3B0ciwgby5tX3B0cik7IH0KIAotI2lm ZGVmIExPT1NFX09XTl9BUlJBWV9QVFIKLSAgICBleHBsaWNpdCBPd25BcnJheVB0cihQdHJUeXBl IHB0cikgOiBtX3B0cihwdHIpIHsgfQotICAgIHZvaWQgc2V0KFB0clR5cGUpOwotI2VuZGlmCi0K IHByaXZhdGU6CiAgICAgUHRyVHlwZSBtX3B0cjsKIH07CkBAIC0xMTEsMTYgKzEwNiw2IEBAIHRl bXBsYXRlPHR5cGVuYW1lIFQ+IGlubGluZSB0eXBlbmFtZSBPd25BcnJheVB0cjxUPjo6UHRyVHlw ZSBPd25BcnJheVB0cjxUPjo6bGVhCiAgICAgcmV0dXJuIHB0cjsKIH0KIAotI2lmZGVmIExPT1NF X09XTl9BUlJBWV9QVFIKLXRlbXBsYXRlPHR5cGVuYW1lIFQ+IGlubGluZSB2b2lkIE93bkFycmF5 UHRyPFQ+OjpzZXQoUHRyVHlwZSBwdHIpCi17Ci0gICAgQVNTRVJUKCFwdHIgfHwgbV9wdHIgIT0g cHRyKTsKLSAgICBQdHJUeXBlIG9sZFB0ciA9IG1fcHRyOwotICAgIG1fcHRyID0gcHRyOwotICAg IGRlbGV0ZU93bmVkQXJyYXlQdHIob2xkUHRyKTsKLX0KLSNlbmRpZgotCiB0ZW1wbGF0ZTx0eXBl bmFtZSBUPiBpbmxpbmUgT3duQXJyYXlQdHI8VD4mIE93bkFycmF5UHRyPFQ+OjpvcGVyYXRvcj0o Y29uc3QgUGFzc093bkFycmF5UHRyPFQ+JiBvKQogewogICAgIFB0clR5cGUgcHRyID0gbV9wdHI7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1Bhc3NPd25BcnJheVB0ci5o IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9QYXNzT3duQXJyYXlQdHIuaAppbmRleCAzZjMw OTI0MTc2M2NmNDlhMTU2MDRlY2ZkZDQyYTNlNjE3Yjc5M2RjLi45MzY1Y2YyYjhiOGZlM2ExZTZl MTc1NmM5MGI0YjM4M2M2ZjNkNTZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv d3RmL1Bhc3NPd25BcnJheVB0ci5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvUGFz c093bkFycmF5UHRyLmgKQEAgLTQyLDEwICs0Miw3IEBAIHB1YmxpYzoKICAgICB0eXBlZGVmIFQq IFB0clR5cGU7CiAKICAgICBQYXNzT3duQXJyYXlQdHIoKSA6IG1fcHRyKDApIHsgfQotCi0jaWYg IWRlZmluZWQoTE9PU0VfUEFTU19PV05fUFRSKSB8fCAhSEFWRShOVUxMUFRSKQogICAgIFBhc3NP d25BcnJheVB0cihzdGQ6Om51bGxwdHJfdCkgOiBtX3B0cigwKSB7IH0KLSNlbmRpZgogCiAgICAg Ly8gSXQgc29tZXdoYXQgYnJlYWtzIHRoZSB0eXBlIHN5c3RlbSB0byBhbGxvdyB0cmFuc2ZlciBv ZiBvd25lcnNoaXAgb3V0IG9mCiAgICAgLy8gYSBjb25zdCBQYXNzT3duQXJyYXlQdHIuIEhvd2V2 ZXIsIGl0IG1ha2VzIGl0IG11Y2ggZWFzaWVyIHRvIHdvcmsgd2l0aCBQYXNzT3duQXJyYXlQdHIK QEAgLTc0LDIyICs3MSwxMyBAQCBwdWJsaWM6CiAjZW5kaWYKIAogICAgIFBhc3NPd25BcnJheVB0 ciYgb3BlcmF0b3I9KGNvbnN0IFBhc3NPd25BcnJheVB0cjxUPiYpOwotI2lmICFkZWZpbmVkKExP T1NFX1BBU1NfT1dOX0FSUkFZX1BUUikgfHwgIUhBVkUoTlVMTFBUUikKICAgICBQYXNzT3duQXJy YXlQdHImIG9wZXJhdG9yPShzdGQ6Om51bGxwdHJfdCkgeyBjbGVhcigpOyByZXR1cm4gKnRoaXM7 IH0KLSNlbmRpZgogICAgIHRlbXBsYXRlPHR5cGVuYW1lIFU+IFBhc3NPd25BcnJheVB0ciYgb3Bl cmF0b3I9KGNvbnN0IFBhc3NPd25BcnJheVB0cjxVPiYpOwogCiAgICAgdGVtcGxhdGU8dHlwZW5h bWUgVT4gZnJpZW5kIFBhc3NPd25BcnJheVB0cjxVPiBhZG9wdEFycmF5UHRyKFUqKTsKIAotI2lm ZGVmIExPT1NFX1BBU1NfT1dOX0FSUkFZX1BUUgotICAgIFBhc3NPd25BcnJheVB0cihQdHJUeXBl IHB0cikgOiBtX3B0cihwdHIpIHsgfQotICAgIFBhc3NPd25BcnJheVB0ciYgb3BlcmF0b3I9KFB0 clR5cGUpOwotI2VuZGlmCi0KIHByaXZhdGU6Ci0jaWZuZGVmIExPT1NFX1BBU1NfT1dOX0FSUkFZ X1BUUgogICAgIGV4cGxpY2l0IFBhc3NPd25BcnJheVB0cihQdHJUeXBlIHB0cikgOiBtX3B0cihw dHIpIHsgfQotI2VuZGlmCiAKICAgICBtdXRhYmxlIFB0clR5cGUgbV9wdHI7CiB9OwpAQCAtMTA4 LDE4ICs5Niw2IEBAIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IGlubGluZSB0eXBlbmFtZSBQYXNzT3du QXJyYXlQdHI8VD46OlB0clR5cGUgUGFzc093bkFycmF5UHRyCiAgICAgcmV0dXJuIHB0cjsKIH0K IAotI2lmZGVmIExPT1NFX1BBU1NfT1dOX0FSUkFZX1BUUgotdGVtcGxhdGU8dHlwZW5hbWUgVD4g aW5saW5lIFBhc3NPd25BcnJheVB0cjxUPiYgUGFzc093bkFycmF5UHRyPFQ+OjpvcGVyYXRvcj0o UHRyVHlwZSBvcHRyKQotewotICAgIFB0clR5cGUgcHRyID0gbV9wdHI7Ci0gICAgbV9wdHIgPSBv cHRyOwotICAgIEFTU0VSVCghcHRyIHx8IG1fcHRyICE9IHB0cik7Ci0gICAgaWYgKHB0cikKLSAg ICAgICAgZGVsZXRlT3duZWRBcnJheVB0cihwdHIpOwotICAgIHJldHVybiAqdGhpczsKLX0KLSNl bmRpZgotCiB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBpbmxpbmUgUGFzc093bkFycmF5UHRyPFQ+JiBQ YXNzT3duQXJyYXlQdHI8VD46Om9wZXJhdG9yPShjb25zdCBQYXNzT3duQXJyYXlQdHI8VD4mIG9w dHIpCiB7CiAgICAgUHRyVHlwZSBwdHIgPSBtX3B0cjsK