60640 2011-05-11 10:32:15 -0700 Replace IntPoint with const IntPoint& in RenderFlexibleBox::placeChild 2011-05-12 15:32:12 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 eae webkit-unassigned ap commit-queue darin oldest_to_newest 402090 0 eae 2011-05-11 10:32:15 -0700 Follow up from bug 60592: Use const IntPoint& instead of just IntPoint to avoid extra constructor overhead. 402171 1 93158 eae 2011-05-11 12:38:05 -0700 Created attachment 93158 Patch 402340 2 ap 2011-05-11 15:26:10 -0700 This patch seems fine in that in brings this particular function in line with what we normally do, but it's more than cleanup. I'm not an expert, but I suspect that this negatively affects performance on at least some platforms. 402356 3 eae 2011-05-11 15:37:52 -0700 Alexey, that's a valid point. Would you like me to update the description or discard the patch? 402448 4 ap 2011-05-11 17:15:13 -0700 I talked to Maciej, and he suggested that this patch is fine to land for consistency, but it would be good to investigate this deeper in a follow up bug. Sounded right to me! 402461 5 eae 2011-05-11 17:26:51 -0700 Cool, thanks! 403148 6 93339 eae 2011-05-12 14:13:41 -0700 Created attachment 93339 Patch for landing 403207 7 93339 commit-queue 2011-05-12 15:32:07 -0700 Comment on attachment 93339 Patch for landing Clearing flags on attachment: 93339 Committed r86389: <http://trac.webkit.org/changeset/86389> 403208 8 commit-queue 2011-05-12 15:32:12 -0700 All reviewed patches have been landed. Closing bug. 93158 2011-05-11 12:38:05 -0700 2011-05-12 14:13:37 -0700 Patch 60640.patch text/plain 1975 eae SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg2MjQ1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDUtMTEgIEVtaWwgQSBF a2x1bmQgIDxlYWVAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFJlcGxhY2UgSW50UG9pbnQgd2l0aCBjb25zdCBJbnRQb2ludCYg aW4gUmVuZGVyRmxleGlibGVCb3g6OnBsYWNlQ2hpbGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYwNjQwCisKKyAgICAgICAgQ2xlYW4gdXAsIGNvdmVy ZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyRmxleGli bGVCb3guY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyRmxleGlibGVCb3g6OnBsYWNlQ2hp bGQpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJGbGV4aWJsZUJveC5oOgorICAgICAgICBV c2UgY29uc3QgSW50UG9pbnQmIGluc3RlYWQgb2YganVzdCBJbnRQb2ludCB0byBhdm9pZCBleHRy YSBjb25zdHJ1Y3RvciBvdmVyaGVhZAorCiAyMDExLTA1LTExICBFcmljIENhcmxzb24gIDxlcmlj LmNhcmxzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJ bmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsZXhpYmxlQm94LmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxleGlibGVCb3guY3Bw CShyZXZpc2lvbiA4NjI0NCkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbGV4 aWJsZUJveC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTkzMyw3ICs5MzMsNyBAQCB2b2lkIFJlbmRl ckZsZXhpYmxlQm94OjphcHBseUxpbmVDbGFtcChGCiAgICAgfQogfQogCi12b2lkIFJlbmRlckZs ZXhpYmxlQm94OjpwbGFjZUNoaWxkKFJlbmRlckJveCogY2hpbGQsIEludFBvaW50IGxvY2F0aW9u KQordm9pZCBSZW5kZXJGbGV4aWJsZUJveDo6cGxhY2VDaGlsZChSZW5kZXJCb3gqIGNoaWxkLCBj b25zdCBJbnRQb2ludCYgbG9jYXRpb24pCiB7CiAgICAgSW50UmVjdCBvbGRSZWN0ID0gY2hpbGQt PmZyYW1lUmVjdCgpOwogCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxl eGlibGVCb3guaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy RmxleGlibGVCb3guaAkocmV2aXNpb24gODYyNDQpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyRmxleGlibGVCb3guaAkod29ya2luZyBjb3B5KQpAQCAtNTAsNyArNTAsNyBAQCBw dWJsaWM6CiAgICAgdmlydHVhbCBib29sIGlzRmxleGluZ0NoaWxkcmVuKCkgY29uc3QgeyByZXR1 cm4gbV9mbGV4aW5nQ2hpbGRyZW47IH0KICAgICB2aXJ0dWFsIGJvb2wgaXNTdHJldGNoaW5nQ2hp bGRyZW4oKSBjb25zdCB7IHJldHVybiBtX3N0cmV0Y2hpbmdDaGlsZHJlbjsgfQogCi0gICAgdm9p ZCBwbGFjZUNoaWxkKFJlbmRlckJveCogY2hpbGQsIEludFBvaW50IGxvY2F0aW9uKTsKKyAgICB2 b2lkIHBsYWNlQ2hpbGQoUmVuZGVyQm94KiBjaGlsZCwgY29uc3QgSW50UG9pbnQmIGxvY2F0aW9u KTsKIAogcHJvdGVjdGVkOgogICAgIGludCBhbGxvd2VkQ2hpbGRGbGV4KFJlbmRlckJveCogY2hp bGQsIGJvb2wgZXhwYW5kaW5nLCB1bnNpZ25lZCBncm91cCk7Cg== 93339 2011-05-12 14:13:41 -0700 2011-05-12 15:32:07 -0700 Patch for landing bug-60640-20110512141339.patch text/plain 2055 eae SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg2MjQ1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDUtMTIgIEVtaWwgQSBF a2x1bmQgIDxlYWVAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFk bGVyLgorCisgICAgICAgIFJlcGxhY2UgSW50UG9pbnQgd2l0aCBjb25zdCBJbnRQb2ludCYgaW4g UmVuZGVyRmxleGlibGVCb3g6OnBsYWNlQ2hpbGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTYwNjQwCisKKyAgICAgICAgUGFzcyBieSBjb25zdCByZWZl cmVuY2UgaW5zdGVhZCBvZiBieSB2YWx1ZSBmb3IgY29uc2lzdGVuY3kgcmVhc29ucy4KKworICAg ICAgICBSZWZhY3RvcmluZywgY292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAq IHJlbmRlcmluZy9SZW5kZXJGbGV4aWJsZUJveC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5k ZXJGbGV4aWJsZUJveDo6cGxhY2VDaGlsZCk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckZs ZXhpYmxlQm94Lmg6CisgICAgICAgIFVzZSBjb25zdCBJbnRQb2ludCYgaW5zdGVhZCBvZiBqdXN0 IEludFBvaW50IHRvIGF2b2lkIGV4dHJhIGNvbnN0cnVjdG9yIG92ZXJoZWFkCisKIDIwMTEtMDUt MTEgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyRmxleGlibGVCb3guY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJGbGV4aWJsZUJveC5jcHAJKHJldmlzaW9uIDg2MjQ0KQorKysgU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckZsZXhpYmxlQm94LmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTMz LDcgKzkzMyw3IEBAIHZvaWQgUmVuZGVyRmxleGlibGVCb3g6OmFwcGx5TGluZUNsYW1wKEYKICAg ICB9CiB9CiAKLXZvaWQgUmVuZGVyRmxleGlibGVCb3g6OnBsYWNlQ2hpbGQoUmVuZGVyQm94KiBj aGlsZCwgSW50UG9pbnQgbG9jYXRpb24pCit2b2lkIFJlbmRlckZsZXhpYmxlQm94OjpwbGFjZUNo aWxkKFJlbmRlckJveCogY2hpbGQsIGNvbnN0IEludFBvaW50JiBsb2NhdGlvbikKIHsKICAgICBJ bnRSZWN0IG9sZFJlY3QgPSBjaGlsZC0+ZnJhbWVSZWN0KCk7CiAKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJGbGV4aWJsZUJveC5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbGV4aWJsZUJveC5oCShyZXZpc2lvbiA4NjI0NCkKKysr IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbGV4aWJsZUJveC5oCSh3b3JraW5nIGNv cHkpCkBAIC01MCw3ICs1MCw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIGJvb2wgaXNGbGV4aW5n Q2hpbGRyZW4oKSBjb25zdCB7IHJldHVybiBtX2ZsZXhpbmdDaGlsZHJlbjsgfQogICAgIHZpcnR1 YWwgYm9vbCBpc1N0cmV0Y2hpbmdDaGlsZHJlbigpIGNvbnN0IHsgcmV0dXJuIG1fc3RyZXRjaGlu Z0NoaWxkcmVuOyB9CiAKLSAgICB2b2lkIHBsYWNlQ2hpbGQoUmVuZGVyQm94KiBjaGlsZCwgSW50 UG9pbnQgbG9jYXRpb24pOworICAgIHZvaWQgcGxhY2VDaGlsZChSZW5kZXJCb3gqIGNoaWxkLCBj b25zdCBJbnRQb2ludCYgbG9jYXRpb24pOwogCiBwcm90ZWN0ZWQ6CiAgICAgaW50IGFsbG93ZWRD aGlsZEZsZXgoUmVuZGVyQm94KiBjaGlsZCwgYm9vbCBleHBhbmRpbmcsIHVuc2lnbmVkIGdyb3Vw KTsK