60519 2011-05-09 17:30:49 -0700 IndexedDB: fix up database-quota.html layout test 2011-05-12 11:28:32 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dgrogan dgrogan commit-queue eric hans japhet oldest_to_newest 400931 0 dgrogan 2011-05-09 17:30:49 -0700 IndexedDB: fix up database-quota.html layout test 400932 1 92891 dgrogan 2011-05-09 17:33:46 -0700 Created attachment 92891 Patch 401099 2 hans 2011-05-10 01:40:24 -0700 Unofficial r+. 402558 3 eric 2011-05-11 19:33:32 -0700 Who generally reviews database patches? 402867 4 92891 japhet 2011-05-12 08:54:29 -0700 Comment on attachment 92891 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92891&action=review > LayoutTests/storage/indexeddb/database-quota-expected.txt:28 > -Error function called: (undefined) undefined > +FAIL Error function called: (13) The transaction was aborted, so the request cannot be fulfilled. Is this test genuinely failing, or is this error the correct behavior? I can't tell just from this patch. 402912 5 dgrogan 2011-05-12 09:59:47 -0700 (In reply to comment #4) > (From update of attachment 92891 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=92891&action=review > > > LayoutTests/storage/indexeddb/database-quota-expected.txt:28 > > -Error function called: (undefined) undefined > > +FAIL Error function called: (13) The transaction was aborted, so the request cannot be fulfilled. > > Is this test genuinely failing, or is this error the correct behavior? I can't tell just from this patch. The error is the correct behavior, so it probably shouldn't go in a testFailed. Will re-upload. 402949 6 93302 dgrogan 2011-05-12 10:43:02 -0700 Created attachment 93302 Patch 403003 7 commit-queue 2011-05-12 11:25:15 -0700 The commit-queue encountered the following flaky tests while processing attachment 93302: http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com) http/tests/appcache/resource-redirect.html bug 60714 (author: ap@webkit.org) The commit-queue is continuing to process your patch. 403007 8 93302 commit-queue 2011-05-12 11:28:27 -0700 Comment on attachment 93302 Patch Clearing flags on attachment: 93302 Committed r86363: <http://trac.webkit.org/changeset/86363> 403008 9 commit-queue 2011-05-12 11:28:32 -0700 All reviewed patches have been landed. Closing bug. 92891 2011-05-09 17:33:46 -0700 2011-05-12 10:42:58 -0700 Patch bug-60519-20110509173345.patch text/plain 3039 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogODU5OTIKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA4NDEzNTNkMDIwYzdiZjcwNmEwNGRj YjliYjUwMmIyMWVmMTg5ZTdjLi41ODBlZDJjMmQ3MjQxMzU4MzI5NmY3ZmQ5MzZjZGM2ZTE2M2U2 YzZmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDUtMDkgIERhdmlkIEdyb2dhbiAgPGRn cm9nYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEluZGV4ZWREQjogZml4IHVwIGRhdGFiYXNlLXF1b3RhLmh0bWwgbGF5b3V0 IHRlc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYw NTE5CisKKyAgICAgICAgUmVtb3ZlIGNvbW1pdEFuZENvbnRpbnVlIGlkaW9tOyB0cmFuc2xhdGUg c29tZSBtaXNzZWQgaW5zdGFuY2VzIG9mCisgICAgICAgIGV2ZW50LmNvZGUgdG8gZXZlbnQudGFy Z2V0LmVycm9yQ29kZSBmcm9tIGJ1ZyA1NDMzMQorCisgICAgICAgICogc3RvcmFnZS9pbmRleGVk ZGIvZGF0YWJhc2UtcXVvdGEtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIHN0b3JhZ2UvaW5kZXhl ZGRiL2RhdGFiYXNlLXF1b3RhLmh0bWw6CisKIDIwMTEtMDUtMDYgIEtlbmppIEltYXNha2kgIDxp bWFzYWtpQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBMZXZpbi4K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL2RhdGFiYXNlLXF1b3Rh LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL2RhdGFiYXNlLXF1 b3RhLWV4cGVjdGVkLnR4dAppbmRleCAxNWFhMDc1MGI4Nzg4OTc1ZTc3YWI5NzY4ZmU1NzcxOGM3 NWY0OWZkLi5lNGQ1NjUyMDcxMjcwODM2MmM2Nzc1NjhiYTcwZWMxNTlkMWZhNjBhIDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9kYXRhYmFzZS1xdW90YS1leHBlY3Rl ZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvZGF0YWJhc2UtcXVvdGEt ZXhwZWN0ZWQudHh0CkBAIC0yNSw3ICsyNSw3IEBAIHRyYW5zID0gZGIudHJhbnNhY3Rpb24oW10s IHdlYmtpdElEQlRyYW5zYWN0aW9uLlJFQURfV1JJVEUpCiBDcmVhdGluZyAnZGF0YScgd2hpY2gg Y29udGFpbnMgNjRLIG9mIGRhdGEKIFBBU1MgZGF0YS5sZW5ndGggaXMgNjU1MzYKIHN0b3JlID0g dHJhbnMub2JqZWN0U3RvcmUoJ3Rlc3QxMjMnKQotRXJyb3IgZnVuY3Rpb24gY2FsbGVkOiAodW5k ZWZpbmVkKSB1bmRlZmluZWQKK0ZBSUwgRXJyb3IgZnVuY3Rpb24gY2FsbGVkOiAoMTMpIFRoZSB0 cmFuc2FjdGlvbiB3YXMgYWJvcnRlZCwgc28gdGhlIHJlcXVlc3QgY2Fubm90IGJlIGZ1bGZpbGxl ZC4KIGV2ZW50LnByZXZlbnREZWZhdWx0KCkKIFBBU1MgQWRkaW5nIGRhdGEgZmFpbGVkIGR1ZSB0 byBxdW90YSBlcnJvci4gRGF0YSBhZGRlZCB3YXMgYWJvdXQgNSBNQgogUEFTUyBzdWNjZXNzZnVs bHlQYXJzZWQgaXMgdHJ1ZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVk ZGIvZGF0YWJhc2UtcXVvdGEuaHRtbCBiL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL2Rh dGFiYXNlLXF1b3RhLmh0bWwKaW5kZXggMDM4ZThkOGU1Y2IxNjI4MzlhODUzODRmNTY4MDhhNjUx ODUyZjk2My4uMzc2Mjk3MjlkMWM1ZjAxNTZkM2MwNTZhMWJjMjViMTA5YjFmNjk0MiAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvZGF0YWJhc2UtcXVvdGEuaHRtbAor KysgYi9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9kYXRhYmFzZS1xdW90YS5odG1sCkBA IC0zNiw2ICszNiw3IEBAIGZ1bmN0aW9uIHNldFZlcnNpb25TdWNjZXNzKCkKICAgICB3aW5kb3cu dHJhbnMgPSBldmFsQW5kTG9nKCJ0cmFucyA9IGV2ZW50LnRhcmdldC5yZXN1bHQiKTsKICAgICBz aG91bGRCZVRydWUoInRyYW5zICE9PSBudWxsIik7CiAgICAgdHJhbnMub25hYm9ydCA9IHVuZXhw ZWN0ZWRBYm9ydENhbGxiYWNrOworICAgIHRyYW5zLm9uY29tcGxldGUgPSBjaGVja1F1b3RhRW5m b3JjaW5nOwogCiAgICAgZGVsZXRlQWxsT2JqZWN0U3RvcmVzKGRiKTsKIApAQCAtNDcsNyArNDgs NiBAQCBmdW5jdGlvbiBzZXRWZXJzaW9uU3VjY2VzcygpCiAKICAgICBvYmplY3RTdG9yZSA9IGV2 YWxBbmRMb2coJ2RiLmNyZWF0ZU9iamVjdFN0b3JlKCJ0ZXN0MTIzIiknKTsKICAgICBjaGVja09i amVjdFN0b3JlKCk7Ci0gICAgY29tbWl0QW5kQ29udGludWUoKTsKIH0KIAogZnVuY3Rpb24gY2hl Y2tPYmplY3RTdG9yZSgpCkBAIC01OSwxMSArNTksNiBAQCBmdW5jdGlvbiBjaGVja09iamVjdFN0 b3JlKCkKICAgICBzaG91bGRCZSgiZGIub2JqZWN0U3RvcmVOYW1lcy5jb250YWlucygndGVzdDEy MycpIiwgInRydWUiKTsKIH0KIAotZnVuY3Rpb24gY29tbWl0QW5kQ29udGludWUoKQotewotICAg IHdpbmRvdy5zZXRUaW1lb3V0KGNoZWNrUXVvdGFFbmZvcmNpbmcsIDApOwotfQotCiBmdW5jdGlv biBjaGVja1F1b3RhRW5mb3JjaW5nKCkKIHsKICAgICB2YXIgdHJhbnMgPSBldmFsQW5kTG9nKCJ0 cmFucyA9IGRiLnRyYW5zYWN0aW9uKFtdLCB3ZWJraXRJREJUcmFuc2FjdGlvbi5SRUFEX1dSSVRF KSIpOwpAQCAtOTcsNyArOTIsNyBAQCBmdW5jdGlvbiBhZGREYXRhKCkKIAogZnVuY3Rpb24gbG9n RXJyb3IoKQogewotICAgIGRlYnVnKCJFcnJvciBmdW5jdGlvbiBjYWxsZWQ6ICgiICsgZXZlbnQu Y29kZSArICIpICIgKyBldmVudC5tZXNzYWdlKTsKKyAgICB0ZXN0RmFpbGVkKCJFcnJvciBmdW5j dGlvbiBjYWxsZWQ6ICgiICsgZXZlbnQudGFyZ2V0LmVycm9yQ29kZSArICIpICIgKyBldmVudC50 YXJnZXQud2Via2l0RXJyb3JNZXNzYWdlKTsKICAgICBldmFsQW5kTG9nKCJldmVudC5wcmV2ZW50 RGVmYXVsdCgpIik7CiB9CiAK 93302 2011-05-12 10:43:02 -0700 2011-05-12 11:28:27 -0700 Patch bug-60519-20110512104300.patch text/plain 3029 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogODU5OTIKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA4NDEzNTNkMDIwYzdiZjcwNmEwNGRj YjliYjUwMmIyMWVmMTg5ZTdjLi41ODBlZDJjMmQ3MjQxMzU4MzI5NmY3ZmQ5MzZjZGM2ZTE2M2U2 YzZmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDUtMDkgIERhdmlkIEdyb2dhbiAgPGRn cm9nYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEluZGV4ZWREQjogZml4IHVwIGRhdGFiYXNlLXF1b3RhLmh0bWwgbGF5b3V0 IHRlc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYw NTE5CisKKyAgICAgICAgUmVtb3ZlIGNvbW1pdEFuZENvbnRpbnVlIGlkaW9tOyB0cmFuc2xhdGUg c29tZSBtaXNzZWQgaW5zdGFuY2VzIG9mCisgICAgICAgIGV2ZW50LmNvZGUgdG8gZXZlbnQudGFy Z2V0LmVycm9yQ29kZSBmcm9tIGJ1ZyA1NDMzMQorCisgICAgICAgICogc3RvcmFnZS9pbmRleGVk ZGIvZGF0YWJhc2UtcXVvdGEtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIHN0b3JhZ2UvaW5kZXhl ZGRiL2RhdGFiYXNlLXF1b3RhLmh0bWw6CisKIDIwMTEtMDUtMDYgIEtlbmppIEltYXNha2kgIDxp bWFzYWtpQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBMZXZpbi4K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL2RhdGFiYXNlLXF1b3Rh LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL2RhdGFiYXNlLXF1 b3RhLWV4cGVjdGVkLnR4dAppbmRleCAxNWFhMDc1MGI4Nzg4OTc1ZTc3YWI5NzY4ZmU1NzcxOGM3 NWY0OWZkLi5lZjFjZmJkN2QzNzA5NWJkNDU1ODY3MWQyNmU3MGQyMDIxYjFiMDczIDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9kYXRhYmFzZS1xdW90YS1leHBlY3Rl ZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvZGF0YWJhc2UtcXVvdGEt ZXhwZWN0ZWQudHh0CkBAIC0yNSw3ICsyNSw3IEBAIHRyYW5zID0gZGIudHJhbnNhY3Rpb24oW10s IHdlYmtpdElEQlRyYW5zYWN0aW9uLlJFQURfV1JJVEUpCiBDcmVhdGluZyAnZGF0YScgd2hpY2gg Y29udGFpbnMgNjRLIG9mIGRhdGEKIFBBU1MgZGF0YS5sZW5ndGggaXMgNjU1MzYKIHN0b3JlID0g dHJhbnMub2JqZWN0U3RvcmUoJ3Rlc3QxMjMnKQotRXJyb3IgZnVuY3Rpb24gY2FsbGVkOiAodW5k ZWZpbmVkKSB1bmRlZmluZWQKK0Vycm9yIGZ1bmN0aW9uIGNhbGxlZDogKDEzKSBUaGUgdHJhbnNh Y3Rpb24gd2FzIGFib3J0ZWQsIHNvIHRoZSByZXF1ZXN0IGNhbm5vdCBiZSBmdWxmaWxsZWQuCiBl dmVudC5wcmV2ZW50RGVmYXVsdCgpCiBQQVNTIEFkZGluZyBkYXRhIGZhaWxlZCBkdWUgdG8gcXVv dGEgZXJyb3IuIERhdGEgYWRkZWQgd2FzIGFib3V0IDUgTUIKIFBBU1Mgc3VjY2Vzc2Z1bGx5UGFy c2VkIGlzIHRydWUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL2Rh dGFiYXNlLXF1b3RhLmh0bWwgYi9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9kYXRhYmFz ZS1xdW90YS5odG1sCmluZGV4IDAzOGU4ZDhlNWNiMTYyODM5YTg1Mzg0ZjU2ODA4YTY1MTg1MmY5 NjMuLjJlNjIyZjA0NTU4ZWNhN2UwZjBlYTc1NzQxYjRkZTFjZjQ1ZjhiOGIgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL2RhdGFiYXNlLXF1b3RhLmh0bWwKKysrIGIv TGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvZGF0YWJhc2UtcXVvdGEuaHRtbApAQCAtMzYs NiArMzYsNyBAQCBmdW5jdGlvbiBzZXRWZXJzaW9uU3VjY2VzcygpCiAgICAgd2luZG93LnRyYW5z ID0gZXZhbEFuZExvZygidHJhbnMgPSBldmVudC50YXJnZXQucmVzdWx0Iik7CiAgICAgc2hvdWxk QmVUcnVlKCJ0cmFucyAhPT0gbnVsbCIpOwogICAgIHRyYW5zLm9uYWJvcnQgPSB1bmV4cGVjdGVk QWJvcnRDYWxsYmFjazsKKyAgICB0cmFucy5vbmNvbXBsZXRlID0gY2hlY2tRdW90YUVuZm9yY2lu ZzsKIAogICAgIGRlbGV0ZUFsbE9iamVjdFN0b3JlcyhkYik7CiAKQEAgLTQ3LDcgKzQ4LDYgQEAg ZnVuY3Rpb24gc2V0VmVyc2lvblN1Y2Nlc3MoKQogCiAgICAgb2JqZWN0U3RvcmUgPSBldmFsQW5k TG9nKCdkYi5jcmVhdGVPYmplY3RTdG9yZSgidGVzdDEyMyIpJyk7CiAgICAgY2hlY2tPYmplY3RT dG9yZSgpOwotICAgIGNvbW1pdEFuZENvbnRpbnVlKCk7CiB9CiAKIGZ1bmN0aW9uIGNoZWNrT2Jq ZWN0U3RvcmUoKQpAQCAtNTksMTEgKzU5LDYgQEAgZnVuY3Rpb24gY2hlY2tPYmplY3RTdG9yZSgp CiAgICAgc2hvdWxkQmUoImRiLm9iamVjdFN0b3JlTmFtZXMuY29udGFpbnMoJ3Rlc3QxMjMnKSIs ICJ0cnVlIik7CiB9CiAKLWZ1bmN0aW9uIGNvbW1pdEFuZENvbnRpbnVlKCkKLXsKLSAgICB3aW5k b3cuc2V0VGltZW91dChjaGVja1F1b3RhRW5mb3JjaW5nLCAwKTsKLX0KLQogZnVuY3Rpb24gY2hl Y2tRdW90YUVuZm9yY2luZygpCiB7CiAgICAgdmFyIHRyYW5zID0gZXZhbEFuZExvZygidHJhbnMg PSBkYi50cmFuc2FjdGlvbihbXSwgd2Via2l0SURCVHJhbnNhY3Rpb24uUkVBRF9XUklURSkiKTsK QEAgLTk3LDcgKzkyLDcgQEAgZnVuY3Rpb24gYWRkRGF0YSgpCiAKIGZ1bmN0aW9uIGxvZ0Vycm9y KCkKIHsKLSAgICBkZWJ1ZygiRXJyb3IgZnVuY3Rpb24gY2FsbGVkOiAoIiArIGV2ZW50LmNvZGUg KyAiKSAiICsgZXZlbnQubWVzc2FnZSk7CisgICAgZGVidWcoIkVycm9yIGZ1bmN0aW9uIGNhbGxl ZDogKCIgKyBldmVudC50YXJnZXQuZXJyb3JDb2RlICsgIikgIiArIGV2ZW50LnRhcmdldC53ZWJr aXRFcnJvck1lc3NhZ2UpOwogICAgIGV2YWxBbmRMb2coImV2ZW50LnByZXZlbnREZWZhdWx0KCki KTsKIH0KIAo=