60505 2011-05-09 14:30:56 -0700 REGRESSION(r86039): DragCaretController doesn't draw caret 2011-05-09 16:37:10 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60273 60454 1 rniwa rniwa darin oldest_to_newest 400758 0 rniwa 2011-05-09 14:30:56 -0700 Apparently, an early exit added in r86039 causes drag caret to be not drawn. 400811 1 darin 2011-05-09 15:27:23 -0700 Since we *just* introduced this, I suggest rolling out the early exit quickly, then at leisure looking more deeply at the causes. 400825 2 rniwa 2011-05-09 15:38:26 -0700 (In reply to comment #1) > Since we *just* introduced this, I suggest rolling out the early exit quickly, then at leisure looking more deeply at the causes. Definitely. I just wasted much time fighting with the bug 60506 but I'll submit a patch shortly without a test. 400834 3 92870 rniwa 2011-05-09 15:45:04 -0700 Created attachment 92870 reverts r86039 in setCaretPosition 400888 4 92870 rniwa 2011-05-09 16:37:07 -0700 Comment on attachment 92870 reverts r86039 in setCaretPosition Clearing flags on attachment: 92870 Committed r86104: <http://trac.webkit.org/changeset/86104> 400889 5 rniwa 2011-05-09 16:37:10 -0700 All reviewed patches have been landed. Closing bug. 92870 2011-05-09 15:45:04 -0700 2011-05-09 16:37:07 -0700 reverts r86039 in setCaretPosition bug-60505-20110509154503.patch text/plain 1898 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogODYwNjEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBjYWQ2YzJiOTg3MTY5MmEx NzQwZmQyMDQ5ZDNkMGU1MjdlNDg2NTk4Li5lZWRlYjY5NTFkY2FkYzQzZjFhMWM4MWQyNzkwNWVl ODEzMjFjYjlhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDUtMDkgIFJ5b3N1 a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgUkVHUkVTU0lPTihyODYwMzkpOiBEcmFnQ2FyZXRDb250cm9s bGVyIGRvZXNuJ3QgZHJhdyBjYXJldAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NjA1MDUKKworICAgICAgICBSZW1vdmVkIGFuIGVhcmx5IGV4aXQgaW4g c2V0Q2FyZXRQb3NpdGlvbiBpbnRyb2R1Y2VkIGJ5IHI4NjAzOS4KKyAgICAgICAgQWxzbyByZXBs YWNlZCBjYWxscyB0byBjb250YWluZXJOb2RlIGJ5IGRlcHJlY2F0ZWROb2RlIHNpbmNlIHJlbmRl cmluZyBjb2RlIGRvZXNuJ3QKKyAgICAgICAgc3VwcG9ydCBjb250YWluZXIgbm9kZSBmb3IgcmVu ZGVyaW5nIGNhcmV0LgorCisgICAgICAgICogZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpEcmFnQ2FyZXRDb250cm9sbGVyOjpzZXRDYXJldFBvc2l0aW9uKToK KwogMjAxMS0wNS0wOSAgQWJoaXNoZWsgQXJ5YSAgPGluZmVybm9AY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IERhdmUgSHlhdHQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9lZGl0aW5nL0ZyYW1lU2VsZWN0aW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJh bWVTZWxlY3Rpb24uY3BwCmluZGV4IDRjZTRlOWZmNDA4ODI0NTIwYThjZTg5NzJmNjM5MjBhYWRi OWM4MmMuLjhhNDkwYTI1M2JhMjc2Mjg3ZmVkMmI2N2UzMGM5ZDA5MTU0MzczMzIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJhbWVTZWxlY3Rpb24uY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2VkaXRpbmcvRnJhbWVTZWxlY3Rpb24uY3BwCkBAIC0xNDMsMTUgKzE0MywxMiBA QCB2b2lkIEZyYW1lU2VsZWN0aW9uOjptb3ZlVG8oY29uc3QgUG9zaXRpb24gJmJhc2UsIGNvbnN0 IFBvc2l0aW9uICZleHRlbnQsIEVBZmZpbgogCiB2b2lkIERyYWdDYXJldENvbnRyb2xsZXI6OnNl dENhcmV0UG9zaXRpb24oY29uc3QgVmlzaWJsZVBvc2l0aW9uJiBwb3NpdGlvbikKIHsKLSAgICBp ZiAobV9wb3NpdGlvbiA9PSBwb3NpdGlvbikKLSAgICAgICAgcmV0dXJuOwotCi0gICAgaWYgKE5v ZGUqIG5vZGUgPSBtX3Bvc2l0aW9uLmRlZXBFcXVpdmFsZW50KCkuY29udGFpbmVyTm9kZSgpKQor ICAgIGlmIChOb2RlKiBub2RlID0gbV9wb3NpdGlvbi5kZWVwRXF1aXZhbGVudCgpLmRlcHJlY2F0 ZWROb2RlKCkpCiAgICAgICAgIGludmFsaWRhdGVDYXJldFJlY3Qobm9kZSk7CiAgICAgbV9wb3Np dGlvbiA9IHBvc2l0aW9uOwogICAgIG1fY2FyZXRSZWN0TmVlZHNVcGRhdGUgPSB0cnVlOwogICAg IERvY3VtZW50KiBkb2N1bWVudCA9IDA7Ci0gICAgaWYgKE5vZGUqIG5vZGUgPSBtX3Bvc2l0aW9u LmRlZXBFcXVpdmFsZW50KCkuY29udGFpbmVyTm9kZSgpKSB7CisgICAgaWYgKE5vZGUqIG5vZGUg PSBtX3Bvc2l0aW9uLmRlZXBFcXVpdmFsZW50KCkuZGVwcmVjYXRlZE5vZGUoKSkgewogICAgICAg ICBpbnZhbGlkYXRlQ2FyZXRSZWN0KG5vZGUpOwogICAgICAgICBkb2N1bWVudCA9IG5vZGUtPmRv Y3VtZW50KCk7CiAgICAgfQo=