60435 2011-05-07 06:49:09 -0700 [EFL] Replace ewk_view_select_* functions by extending Ewk_Editor_Command enum 2011-05-08 11:53:54 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 k.blank webkit-unassigned antognolli+webkit commit-queue gyuyoung.kim kenneth leandro l.slachciak lucas.de.marchi tonikitoo oldest_to_newest 400063 0 k.blank 2011-05-07 06:49:09 -0700 As a continuation of bug 54439 (https://bugs.webkit.org/show_bug.cgi?id=54439) I'd like to propose patch which replaces existing editor commands functions EAPI Eina_Bool ewk_view_select_none(Evas_Object *o); EAPI Eina_Bool ewk_view_select_all(Evas_Object *o); EAPI Eina_Bool ewk_view_select_paragraph(Evas_Object *o); EAPI Eina_Bool ewk_view_select_sentence(Evas_Object *o); EAPI Eina_Bool ewk_view_select_line(Evas_Object *o); EAPI Eina_Bool ewk_view_select_word(Evas_Object *o); by adding new enums into Ewk_Editor_Command. 400064 1 92688 k.blank 2011-05-07 06:54:14 -0700 Created attachment 92688 patch 400264 2 commit-queue 2011-05-08 11:50:55 -0700 The commit-queue encountered the following flaky tests while processing attachment 92688: http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com) The commit-queue is continuing to process your patch. 400265 3 92688 commit-queue 2011-05-08 11:53:50 -0700 Comment on attachment 92688 patch Clearing flags on attachment: 92688 Committed r86031: <http://trac.webkit.org/changeset/86031> 400266 4 commit-queue 2011-05-08 11:53:54 -0700 All reviewed patches have been landed. Closing bug. 92688 2011-05-07 06:54:14 -0700 2011-05-08 11:53:50 -0700 patch editor_select.diff text/plain 5442 k.blank ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBhYzZiN2YzLi4zZDQyMTM4IDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTEtMDUtMDcgIEthbWlsIEJsYW5rICA8ay5ibGFua0BzYW1zdW5n LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB ZGRlZCBuZXcgY29tbWFuZHMgdG8gYmUgY2FsbGVkIGJ5IGV3a192aWV3X2VkaXRvcl9jb21tYW5k LgorICAgICAgICBEdWUgdG8gdGhpcyBjaGFuZ2UgZXdrX3ZpZXdfc2VsZWN0XyogZnVuY3Rpb25z IGhhdmUgYmVlbiByZW1vdmVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NjA0MzUKKworICAgICAgICAqIGV3ay9ld2tfdmlldy5jcHA6CisgICAgICAg IChld2tfdmlld19leGVjdXRlX2VkaXRvcl9jb21tYW5kKToKKyAgICAgICAgKiBld2svZXdrX3Zp ZXcuaDoKKwogMjAxMS0wNS0wNSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvZWZsL2V3ay9ld2tfdmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcu Y3BwCmluZGV4IDdkMWMwYzAuLjdkMWVlOGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZs L2V3ay9ld2tfdmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNw cApAQCAtMTU0OCw3OCArMTU0OCw2IEBAIHN0YXRpYyBFaW5hX0Jvb2wgX2V3a192aWV3X2VkaXRv cl9jb21tYW5kKEV3a19WaWV3X1ByaXZhdGVfRGF0YSogcHJpdiwgY29uc3QgY2hhCiB9CiAKIC8q KgotICogVW5zZWxlY3RzIHdoYXRldmVyIHdhcyBzZWxlY3RlZC4KLSAqCi0gKiBAcmV0dXJuIEBj IEVJTkFfVFJVRSBpZiBvcGVyYXRpb24gd2FzIGV4ZWN1dGVkLCBAYyBFSU5BX0ZBTFNFIG90aGVy d2lzZS4KLSAqLwotRWluYV9Cb29sIGV3a192aWV3X3NlbGVjdF9ub25lKEV2YXNfT2JqZWN0KiBv KQotewotICAgIEVXS19WSUVXX1NEX0dFVF9PUl9SRVRVUk4obywgc2QsIEVJTkFfRkFMU0UpOwot ICAgIEVXS19WSUVXX1BSSVZfR0VUX09SX1JFVFVSTihzZCwgcHJpdiwgRUlOQV9GQUxTRSk7Ci0g ICAgcmV0dXJuIF9ld2tfdmlld19lZGl0b3JfY29tbWFuZChwcml2LCAiVW5zZWxlY3QiKTsKLX0K LQotLyoqCi0gKiBTZWxlY3RzIGV2ZXJ5dGhpbmcuCi0gKgotICogQHJldHVybiBAYyBFSU5BX1RS VUUgaWYgb3BlcmF0aW9uIHdhcyBleGVjdXRlZCwgQGMgRUlOQV9GQUxTRSBvdGhlcndpc2UuCi0g Ki8KLUVpbmFfQm9vbCBld2tfdmlld19zZWxlY3RfYWxsKEV2YXNfT2JqZWN0KiBvKQotewotICAg IEVXS19WSUVXX1NEX0dFVF9PUl9SRVRVUk4obywgc2QsIEVJTkFfRkFMU0UpOwotICAgIEVXS19W SUVXX1BSSVZfR0VUX09SX1JFVFVSTihzZCwgcHJpdiwgRUlOQV9GQUxTRSk7Ci0gICAgcmV0dXJu IF9ld2tfdmlld19lZGl0b3JfY29tbWFuZChwcml2LCAiU2VsZWN0QWxsIik7Ci19Ci0KLS8qKgot ICogU2VsZWN0cyB0aGUgY3VycmVudCBwYXJhZ3JhaC4KLSAqCi0gKiBAcmV0dXJuIEBjIEVJTkFf VFJVRSBpZiBvcGVyYXRpb24gd2FzIGV4ZWN1dGVkLCBAYyBFSU5BX0ZBTFNFIG90aGVyd2lzZS4K LSAqLwotRWluYV9Cb29sIGV3a192aWV3X3NlbGVjdF9wYXJhZ3JhcGgoRXZhc19PYmplY3QqIG8p Ci17Ci0gICAgRVdLX1ZJRVdfU0RfR0VUX09SX1JFVFVSTihvLCBzZCwgRUlOQV9GQUxTRSk7Ci0g ICAgRVdLX1ZJRVdfUFJJVl9HRVRfT1JfUkVUVVJOKHNkLCBwcml2LCBFSU5BX0ZBTFNFKTsKLSAg ICByZXR1cm4gX2V3a192aWV3X2VkaXRvcl9jb21tYW5kKHByaXYsICJTZWxlY3RQYXJhZ3JhcGgi KTsKLX0KLQotLyoqCi0gKiBTZWxlY3RzIHRoZSBjdXJyZW50IHNlbnRlbmNlLgotICoKLSAqIEBy ZXR1cm4gQGMgRUlOQV9UUlVFIGlmIG9wZXJhdGlvbiB3YXMgZXhlY3V0ZWQsIEBjIEVJTkFfRkFM U0Ugb3RoZXJ3aXNlLgotICovCi1FaW5hX0Jvb2wgZXdrX3ZpZXdfc2VsZWN0X3NlbnRlbmNlKEV2 YXNfT2JqZWN0KiBvKQotewotICAgIEVXS19WSUVXX1NEX0dFVF9PUl9SRVRVUk4obywgc2QsIEVJ TkFfRkFMU0UpOwotICAgIEVXS19WSUVXX1BSSVZfR0VUX09SX1JFVFVSTihzZCwgcHJpdiwgRUlO QV9GQUxTRSk7Ci0gICAgcmV0dXJuIF9ld2tfdmlld19lZGl0b3JfY29tbWFuZChwcml2LCAiU2Vs ZWN0U2VudGVuY2UiKTsKLX0KLQotLyoqCi0gKiBTZWxlY3RzIHRoZSBjdXJyZW50IGxpbmUuCi0g KgotICogQHJldHVybiBAYyBFSU5BX1RSVUUgaWYgb3BlcmF0aW9uIHdhcyBleGVjdXRlZCwgQGMg RUlOQV9GQUxTRSBvdGhlcndpc2UuCi0gKi8KLUVpbmFfQm9vbCBld2tfdmlld19zZWxlY3RfbGlu ZShFdmFzX09iamVjdCogbykKLXsKLSAgICBFV0tfVklFV19TRF9HRVRfT1JfUkVUVVJOKG8sIHNk LCBFSU5BX0ZBTFNFKTsKLSAgICBFV0tfVklFV19QUklWX0dFVF9PUl9SRVRVUk4oc2QsIHByaXYs IEVJTkFfRkFMU0UpOwotICAgIHJldHVybiBfZXdrX3ZpZXdfZWRpdG9yX2NvbW1hbmQocHJpdiwg IlNlbGVjdExpbmUiKTsKLX0KLQotLyoqCi0gKiBTZWxlY3RzIHRoZSBjdXJyZW50IHdvcmQuCi0g KgotICogQHJldHVybiBAYyBFSU5BX1RSVUUgaWYgb3BlcmF0aW9uIHdhcyBleGVjdXRlZCwgQGMg RUlOQV9GQUxTRSBvdGhlcndpc2UuCi0gKi8KLUVpbmFfQm9vbCBld2tfdmlld19zZWxlY3Rfd29y ZChFdmFzX09iamVjdCogbykKLXsKLSAgICBFV0tfVklFV19TRF9HRVRfT1JfUkVUVVJOKG8sIHNk LCBFSU5BX0ZBTFNFKTsKLSAgICBFV0tfVklFV19QUklWX0dFVF9PUl9SRVRVUk4oc2QsIHByaXYs IEVJTkFfRkFMU0UpOwotICAgIHJldHVybiBfZXdrX3ZpZXdfZWRpdG9yX2NvbW1hbmQocHJpdiwg IlNlbGVjdFdvcmQiKTsKLX0KLQotLyoqCiAgKiBFeGVjdXRlcyBlZGl0b3IgY29tbWFuZC4KICAq CiAgKiBAcGFyYW0gbyB2aWV3IG9iamVjdCB0byBleGVjdXRlIGNvbW1hbmQuCkBAIC0xNjM4LDYg KzE1NjYsMTggQEAgRWluYV9Cb29sIGV3a192aWV3X2V4ZWN1dGVfZWRpdG9yX2NvbW1hbmQoRXZh c19PYmplY3QqIG8sIGNvbnN0IEV3a19FZGl0b3JfQ29tbWEKICAgICAgICAgcmV0dXJuIF9ld2tf dmlld19lZGl0b3JfY29tbWFuZChwcml2LCAiSW5zZXJ0SW1hZ2UiLCB2YWx1ZSk7CiAgICAgY2Fz ZSBFV0tfRURJVE9SX0NPTU1BTkRfSU5TRVJUX1RFWFQ6CiAgICAgICAgIHJldHVybiBfZXdrX3Zp ZXdfZWRpdG9yX2NvbW1hbmQocHJpdiwgIkluc2VydFRleHQiLCB2YWx1ZSk7CisgICAgY2FzZSBF V0tfRURJVE9SX0NPTU1BTkRfU0VMRUNUX05PTkU6CisgICAgICAgIHJldHVybiBfZXdrX3ZpZXdf ZWRpdG9yX2NvbW1hbmQocHJpdiwgIlVuc2VsZWN0Iik7CisgICAgY2FzZSBFV0tfRURJVE9SX0NP TU1BTkRfU0VMRUNUX0FMTDoKKyAgICAgICAgcmV0dXJuIF9ld2tfdmlld19lZGl0b3JfY29tbWFu ZChwcml2LCAiU2VsZWN0QWxsIik7CisgICAgY2FzZSBFV0tfRURJVE9SX0NPTU1BTkRfU0VMRUNU X1BBUkFHUkFQSDoKKyAgICAgICAgcmV0dXJuIF9ld2tfdmlld19lZGl0b3JfY29tbWFuZChwcml2 LCAiU2VsZWN0UGFyYWdyYXBoIik7CisgICAgY2FzZSBFV0tfRURJVE9SX0NPTU1BTkRfU0VMRUNU X1NFTlRFTkNFOgorICAgICAgICByZXR1cm4gX2V3a192aWV3X2VkaXRvcl9jb21tYW5kKHByaXYs ICJTZWxlY3RTZW50ZW5jZSIpOworICAgIGNhc2UgRVdLX0VESVRPUl9DT01NQU5EX1NFTEVDVF9M SU5FOgorICAgICAgICByZXR1cm4gX2V3a192aWV3X2VkaXRvcl9jb21tYW5kKHByaXYsICJTZWxl Y3RMaW5lIik7CisgICAgY2FzZSBFV0tfRURJVE9SX0NPTU1BTkRfU0VMRUNUX1dPUkQ6CisgICAg ICAgIHJldHVybiBfZXdrX3ZpZXdfZWRpdG9yX2NvbW1hbmQocHJpdiwgIlNlbGVjdFdvcmQiKTsK ICAgICBkZWZhdWx0OgogICAgICAgICByZXR1cm4gRUlOQV9GQUxTRTsKICAgICB9CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuaCBiL1NvdXJjZS9XZWJLaXQvZWZs L2V3ay9ld2tfdmlldy5oCmluZGV4IDg0OTk0ZGMuLjc4YmNkNjQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5oCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9l d2tfdmlldy5oCkBAIC0zNDcsMTggKzM0NywxOCBAQCBFQVBJIHZvaWQgICAgICAgICBld2tfdmll d19iZ19jb2xvcl9zZXQoRXZhc19PYmplY3QgKm8sIGludCByLCBpbnQgZywgaW50IGIsIGludAog RUFQSSB2b2lkICAgICAgICAgZXdrX3ZpZXdfYmdfY29sb3JfZ2V0KGNvbnN0IEV2YXNfT2JqZWN0 ICpvLCBpbnQgKnIsIGludCAqZywgaW50ICpiLCBpbnQgKmEpOwogCiBFQVBJIGNoYXIgICAgICAg ICpld2tfdmlld19zZWxlY3Rpb25fZ2V0KGNvbnN0IEV2YXNfT2JqZWN0ICpvKTsKLUVBUEkgRWlu YV9Cb29sICAgIGV3a192aWV3X3NlbGVjdF9ub25lKEV2YXNfT2JqZWN0ICpvKTsKLUVBUEkgRWlu YV9Cb29sICAgIGV3a192aWV3X3NlbGVjdF9hbGwoRXZhc19PYmplY3QgKm8pOwotRUFQSSBFaW5h X0Jvb2wgICAgZXdrX3ZpZXdfc2VsZWN0X3BhcmFncmFwaChFdmFzX09iamVjdCAqbyk7Ci1FQVBJ IEVpbmFfQm9vbCAgICBld2tfdmlld19zZWxlY3Rfc2VudGVuY2UoRXZhc19PYmplY3QgKm8pOwot RUFQSSBFaW5hX0Jvb2wgICAgZXdrX3ZpZXdfc2VsZWN0X2xpbmUoRXZhc19PYmplY3QgKm8pOwot RUFQSSBFaW5hX0Jvb2wgICAgZXdrX3ZpZXdfc2VsZWN0X3dvcmQoRXZhc19PYmplY3QgKm8pOwog CiBFQVBJIEVpbmFfQm9vbCAgICBld2tfdmlld19jb250ZXh0X21lbnVfZm9yd2FyZF9ldmVudChF dmFzX09iamVjdCAqbywgY29uc3QgRXZhc19FdmVudF9Nb3VzZV9Eb3duICpldik7CiAKIGVudW0g X0V3a19FZGl0b3JfQ29tbWFuZCB7CiAgICAgRVdLX0VESVRPUl9DT01NQU5EX0lOU0VSVF9JTUFH RSA9IDAsCi0gICAgRVdLX0VESVRPUl9DT01NQU5EX0lOU0VSVF9URVhUCisgICAgRVdLX0VESVRP Ul9DT01NQU5EX0lOU0VSVF9URVhULAorICAgIEVXS19FRElUT1JfQ09NTUFORF9TRUxFQ1RfTk9O RSwKKyAgICBFV0tfRURJVE9SX0NPTU1BTkRfU0VMRUNUX0FMTCwKKyAgICBFV0tfRURJVE9SX0NP TU1BTkRfU0VMRUNUX1BBUkFHUkFQSCwKKyAgICBFV0tfRURJVE9SX0NPTU1BTkRfU0VMRUNUX1NF TlRFTkNFLAorICAgIEVXS19FRElUT1JfQ09NTUFORF9TRUxFQ1RfTElORSwKKyAgICBFV0tfRURJ VE9SX0NPTU1BTkRfU0VMRUNUX1dPUkQKIH07CiB0eXBlZGVmIGVudW0gX0V3a19FZGl0b3JfQ29t bWFuZCBFd2tfRWRpdG9yX0NvbW1hbmQ7CiAK