<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>60377</bug_id>
          
          <creation_ts>2011-05-06 09:48:50 -0700</creation_ts>
          <short_desc>[Qt] fast/canvas/webgl/gl-uniform-arrays.html failing for Qt on Linux</short_desc>
          <delta_ts>2011-05-27 10:53:31 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebGL</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt, QtTriaged</keywords>
          <priority>P5</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Idrees">sidreesshah</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ademar</cc>
    
    <cc>benjamin</cc>
    
    <cc>commit-queue</cc>
    
    <cc>jarkko.j.sakkinen</cc>
    
    <cc>kbr</cc>
    
    <cc>kling</cc>
    
    <cc>luiz</cc>
    
    <cc>webkit.review.bot</cc>
    
    <cc>zmo</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>399575</commentid>
    <comment_count>0</comment_count>
    <who name="Idrees">sidreesshah</who>
    <bug_when>2011-05-06 09:48:50 -0700</bug_when>
    <thetext>fast/canvas/webgl/gl-uniform-arrays.html failing for webkit2 on qt (linux). 

Also the debug version is giving assertion failing. The bug might be reproducible on other platforms as well.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>399578</commentid>
    <comment_count>1</comment_count>
      <attachid>92593</attachid>
    <who name="Idrees">sidreesshah</who>
    <bug_when>2011-05-06 09:52:36 -0700</bug_when>
    <thetext>Created attachment 92593
Fix the debug version plus test case

I have attached the fix for test case. The comment was already there but not followed correctly.

We do not need to put assert in useProgram as program can be null (according to the test case).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>402566</commentid>
    <comment_count>2</comment_count>
      <attachid>92593</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-05-11 19:43:55 -0700</bug_when>
    <thetext>Comment on attachment 92593
Fix the debug version plus test case

Need a ChangeLog and test.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>403038</commentid>
    <comment_count>3</comment_count>
      <attachid>93319</attachid>
    <who name="Idrees">sidreesshah</who>
    <bug_when>2011-05-12 11:53:48 -0700</bug_when>
    <thetext>Created attachment 93319
Second version of the fix

Trying again after editing the changelog.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>403041</commentid>
    <comment_count>4</comment_count>
      <attachid>93320</attachid>
    <who name="Idrees">sidreesshah</who>
    <bug_when>2011-05-12 11:55:03 -0700</bug_when>
    <thetext>Created attachment 93320
Test case</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>403044</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-05-12 11:57:01 -0700</bug_when>
    <thetext>Attachment 93319 did not pass style-queue:

Failed to run &quot;[&apos;Tools/Scripts/check-webkit-style&apos;, &apos;--diff-files&apos;, u&apos;Source/WebCore/ChangeLog&apos;, u&apos;Source/WebCor...&quot; exit_code: 1

Source/WebKit2/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>403046</commentid>
    <comment_count>6</comment_count>
      <attachid>93319</attachid>
    <who name="Idrees">sidreesshah</who>
    <bug_when>2011-05-12 12:00:45 -0700</bug_when>
    <thetext>Comment on attachment 93319
Second version of the fix

Removing because of format failing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>403048</commentid>
    <comment_count>7</comment_count>
      <attachid>93321</attachid>
    <who name="Idrees">sidreesshah</who>
    <bug_when>2011-05-12 12:01:48 -0700</bug_when>
    <thetext>Created attachment 93321
Trying Fix again</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>405217</commentid>
    <comment_count>8</comment_count>
      <attachid>93321</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2011-05-17 12:13:13 -0700</bug_when>
    <thetext>Comment on attachment 93321
Trying Fix again

View in context: https://bugs.webkit.org/attachment.cgi?id=93321&amp;action=review

&gt; Source/WebKit2/Shared/WebPreferencesStore.h:61
&gt; -    macro(WebGLEnabled, webGLEnabled, Bool, bool, false) \
&gt; +    macro(WebGLEnabled, webGLEnabled, Bool, bool, true) \

This enables WebGL for all WK2 ports, that kind of change should not be done behind a bug marked [Qt].
Not to mention that it has nothing to do with the failing test this bug is about.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>405231</commentid>
    <comment_count>9</comment_count>
    <who name="Idrees">sidreesshah</who>
    <bug_when>2011-05-17 12:27:07 -0700</bug_when>
    <thetext>(In reply to comment #8)
&gt; This enables WebGL for all WK2 ports, that kind of change should not be done behind a bug marked [Qt].
&gt; Not to mention that it has nothing to do with the failing test this bug is about.

I agree. But i put this in the patch just for everybody to enable webgl without changing the code. Any i take out this part from the patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>405233</commentid>
    <comment_count>10</comment_count>
      <attachid>93807</attachid>
    <who name="Idrees">sidreesshah</who>
    <bug_when>2011-05-17 12:28:03 -0700</bug_when>
    <thetext>Created attachment 93807
Removing the webgl enabler for wk2</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>405694</commentid>
    <comment_count>11</comment_count>
      <attachid>93807</attachid>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2011-05-18 07:18:24 -0700</bug_when>
    <thetext>Comment on attachment 93807
Removing the webgl enabler for wk2

You need to describe the change in the changelog, like why the assertion is not needed.

Also, without changelog, it looks like you are fixing 2 unrelated things:
-The assert which is Qt specific
-The uniform name, which is common code.

I would prefer 2 patches with the test for each change.

Finally, how is this related to WebKit 2? Your changes only WebCore common code?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>405712</commentid>
    <comment_count>12</comment_count>
    <who name="Jarkko Sakkinen">jarkko.j.sakkinen</who>
    <bug_when>2011-05-18 07:43:40 -0700</bug_when>
    <thetext>Nice to see that more people are contributing to this work :)

Fix itself looks good but why you have added ASSERT()? How is it related fixing *this* particular bug?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>405799</commentid>
    <comment_count>13</comment_count>
    <who name="Idrees">sidreesshah</who>
    <bug_when>2011-05-18 10:12:23 -0700</bug_when>
    <thetext>(In reply to comment #12)
&gt; Fix itself looks good but why you have added ASSERT()? How is it related fixing *this* particular bug?
I have not added but removed the assert because in debug mode compilation, the test case is giving assertion failed. As the test case itself mentions that it is ok to have program NULL, we do not need it in any case.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>405860</commentid>
    <comment_count>14</comment_count>
    <who name="Idrees">sidreesshah</who>
    <bug_when>2011-05-18 11:15:14 -0700</bug_when>
    <thetext>(In reply to comment #11)
&gt; (From update of attachment 93807 [details])
&gt; You need to describe the change in the changelog, like why the assertion is not needed.

Ok i will do so.

&gt; 
&gt; Also, without changelog, it looks like you are fixing 2 unrelated things:

Both are related to same test case. Thats why i created a single patch for it. Also both are one liners. so in my view creating a single patch makes sense.

&gt; -The assert which is Qt specific

agreed.

&gt; -The uniform name, which is common code.

agreed. I have not checked it with other platforms but i have mentioned the possibility that it might be reproducible on other platforms. I was just checking it on qt webkit2.

&gt; 
&gt; I would prefer 2 patches with the test for each change.
&gt; 
&gt; Finally, how is this related to WebKit 2? Your changes only WebCore common code?

I had only tested with Webkit2 for Qt. Now i tested with qt webkit and got the same behaviour. so will remove wk2 from the summary.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>405879</commentid>
    <comment_count>15</comment_count>
      <attachid>93949</attachid>
    <who name="Idrees">sidreesshah</who>
    <bug_when>2011-05-18 11:26:33 -0700</bug_when>
    <thetext>Created attachment 93949
Another patch for fix</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>405880</commentid>
    <comment_count>16</comment_count>
      <attachid>93949</attachid>
    <who name="Idrees">sidreesshah</who>
    <bug_when>2011-05-18 11:27:14 -0700</bug_when>
    <thetext>Comment on attachment 93949
Another patch for fix

Putting for review.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>405890</commentid>
    <comment_count>17</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-05-18 11:31:07 -0700</bug_when>
    <thetext>Attachment 93949 did not pass style-queue:

Failed to run &quot;[&apos;Tools/Scripts/check-webkit-style&apos;, &apos;--diff-files&apos;, u&apos;Source/WebCore/ChangeLog&apos;, u&apos;Source/WebCor...&quot; exit_code: 1

Source/WebCore/html/canvas/WebGLRenderingContext.cpp:2446:  Tab found; better to use spaces  [whitespace/tab] [1]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>405892</commentid>
    <comment_count>18</comment_count>
      <attachid>93952</attachid>
    <who name="Idrees">sidreesshah</who>
    <bug_when>2011-05-18 11:34:54 -0700</bug_when>
    <thetext>Created attachment 93952
Another patch for fix</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>406075</commentid>
    <comment_count>19</comment_count>
      <attachid>93952</attachid>
    <who name="Luiz Agostini">luiz</who>
    <bug_when>2011-05-18 16:05:39 -0700</bug_when>
    <thetext>Comment on attachment 93952
Another patch for fix

View in context: https://bugs.webkit.org/attachment.cgi?id=93952&amp;action=review

&gt; Source/WebCore/ChangeLog:8
&gt; +        [Qt] fast/canvas/webgl/gl-uniform-arrays.html failing for Qt on Linux
&gt; +        https://bugs.webkit.org/show_bug.cgi?id=60377 
&gt; +
&gt; +        LayoutTests/fast/canvas/webgl/gl-uniform-arrays.html

It would be nice to have a description of what was causing the problem and how this patch solves it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>406471</commentid>
    <comment_count>20</comment_count>
      <attachid>94081</attachid>
    <who name="Idrees">sidreesshah</who>
    <bug_when>2011-05-19 10:03:14 -0700</bug_when>
    <thetext>Created attachment 94081
More description about the issue in changelog</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>406478</commentid>
    <comment_count>21</comment_count>
    <who name="Idrees">sidreesshah</who>
    <bug_when>2011-05-19 10:11:11 -0700</bug_when>
    <thetext>(In reply to comment #19)
&gt; (From update of attachment 93952 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=93952&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/ChangeLog:8
&gt; &gt; +        [Qt] fast/canvas/webgl/gl-uniform-arrays.html failing for Qt on Linux
&gt; &gt; +        https://bugs.webkit.org/show_bug.cgi?id=60377 
&gt; &gt; +
&gt; &gt; +        LayoutTests/fast/canvas/webgl/gl-uniform-arrays.html
&gt; 
&gt; It would be nice to have a description of what was causing the problem and how this patch solves it.


The problem was that we were truncating the name of the active uniform array without checking if it contains the array braces &quot;[0]&quot;. As a result we were truncating the actual name of the active uniform. My patch checks for the array braces before taking them out.

Also we do not need assert in useProgram as program can be null. 

I have added these comments to the changelog as well.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>408428</commentid>
    <comment_count>22</comment_count>
      <attachid>93952</attachid>
    <who name="Alexis Menard (darktears)">menard</who>
    <bug_when>2011-05-23 16:04:05 -0700</bug_when>
    <thetext>Comment on attachment 93952
Another patch for fix

Clearing that one because a new version has been uploaded.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>408436</commentid>
    <comment_count>23</comment_count>
      <attachid>94081</attachid>
    <who name="Alexis Menard (darktears)">menard</who>
    <bug_when>2011-05-23 16:05:42 -0700</bug_when>
    <thetext>Comment on attachment 94081
More description about the issue in changelog

View in context: https://bugs.webkit.org/attachment.cgi?id=94081&amp;action=review

&gt; Source/WebCore/ChangeLog:10
&gt; +        for an array of active uniform, we can receive just a name without 

Uppercase for the first letter, it&apos;s a sentence.

&gt; Source/WebCore/ChangeLog:11
&gt; +        array braces. Currently i donot see any [0] in the active uniform arrays name 

missing space.

&gt; Source/WebCore/ChangeLog:12
&gt; +        and as a result we were trucating the the actual name of the active uniforms. 

typo again.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>408900</commentid>
    <comment_count>24</comment_count>
      <attachid>94622</attachid>
    <who name="Idrees">sidreesshah</who>
    <bug_when>2011-05-24 09:03:00 -0700</bug_when>
    <thetext>Created attachment 94622
Fixing typos.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>408913</commentid>
    <comment_count>25</comment_count>
      <attachid>94622</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2011-05-24 09:19:56 -0700</bug_when>
    <thetext>Comment on attachment 94622
Fixing typos.

View in context: https://bugs.webkit.org/attachment.cgi?id=94622&amp;action=review

&gt; Source/WebCore/html/canvas/WebGLRenderingContext.cpp:2446
&gt; -        if (info.size &gt; 1)
&gt; +        if (info.size &gt; 1 &amp;&amp; info.name.endsWith(&quot;[0]&quot;))

Is &quot;[0]&quot; the only thing we should be stripping. What about &quot;[1]&quot;?
This looks like a testable change, why is there no new test in this patch?

&gt; Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:-1448
&gt; -    ASSERT(program);

This should be in a separate patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>408943</commentid>
    <comment_count>26</comment_count>
    <who name="Idrees">sidreesshah</who>
    <bug_when>2011-05-24 10:03:14 -0700</bug_when>
    <thetext>(In reply to comment #25)
&gt; (From update of attachment 94622 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=94622&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/html/canvas/WebGLRenderingContext.cpp:2446
&gt; &gt; -        if (info.size &gt; 1)
&gt; &gt; +        if (info.size &gt; 1 &amp;&amp; info.name.endsWith(&quot;[0]&quot;))
&gt; 
&gt; Is &quot;[0]&quot; the only thing we should be stripping. What about &quot;[1]&quot;?

Yes, because if its an array the first element will be either just a name or it will end with [0]. There is no way it will end with [1].

&gt; This looks like a testable change, why is there no new test in this patch?

The test case that i have attached is actually failing without this change for qtwebkit. because we are truncating the last three characters without verifying if they are really [0]. &quot;getActiveUniform&quot; gives only &quot;color&quot; as the name for &quot;info&quot; even its an array. So we need to make sure we are not truncating the name of the uniform itself.

&gt; 
&gt; &gt; Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:-1448
&gt; &gt; -    ASSERT(program);
&gt; 
&gt; This should be in a separate patch.

Ok. I have created two different patches now. But the same test case can be applied for both. So i have added it to the changelog.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>408946</commentid>
    <comment_count>27</comment_count>
      <attachid>94631</attachid>
    <who name="Idrees">sidreesshah</who>
    <bug_when>2011-05-24 10:04:28 -0700</bug_when>
    <thetext>Created attachment 94631
Assenrtion not needed patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>408949</commentid>
    <comment_count>28</comment_count>
      <attachid>94633</attachid>
    <who name="Idrees">sidreesshah</who>
    <bug_when>2011-05-24 10:05:39 -0700</bug_when>
    <thetext>Created attachment 94633
array name should be checked before removing the [0].</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>408963</commentid>
    <comment_count>29</comment_count>
      <attachid>94636</attachid>
    <who name="Idrees">sidreesshah</who>
    <bug_when>2011-05-24 10:21:47 -0700</bug_when>
    <thetext>Created attachment 94636
Another try for name checking patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>408968</commentid>
    <comment_count>30</comment_count>
      <attachid>94636</attachid>
    <who name="Idrees">sidreesshah</who>
    <bug_when>2011-05-24 10:23:35 -0700</bug_when>
    <thetext>Comment on attachment 94636
Another try for name checking patch

Sorry again tab :(</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>408970</commentid>
    <comment_count>31</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-05-24 10:24:28 -0700</bug_when>
    <thetext>Attachment 94636 did not pass style-queue:

Failed to run &quot;[&apos;Tools/Scripts/check-webkit-style&apos;, &apos;--diff-files&apos;, u&apos;Source/WebCore/ChangeLog&apos;, u&apos;Source/WebCor...&quot; exit_code: 1

Source/WebCore/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>408971</commentid>
    <comment_count>32</comment_count>
      <attachid>94639</attachid>
    <who name="Idrees">sidreesshah</who>
    <bug_when>2011-05-24 10:25:35 -0700</bug_when>
    <thetext>Created attachment 94639
Another try for name checking patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>408973</commentid>
    <comment_count>33</comment_count>
      <attachid>94640</attachid>
    <who name="Idrees">sidreesshah</who>
    <bug_when>2011-05-24 10:28:33 -0700</bug_when>
    <thetext>Created attachment 94640
getting crazy. Trying again</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>409220</commentid>
    <comment_count>34</comment_count>
      <attachid>94631</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-05-24 14:47:39 -0700</bug_when>
    <thetext>Comment on attachment 94631
Assenrtion not needed patch.

Clearing flags on attachment: 94631

Committed r87208: &lt;http://trac.webkit.org/changeset/87208&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>410783</commentid>
    <comment_count>35</comment_count>
    <who name="Zhenyao Mo">zmo</who>
    <bug_when>2011-05-26 13:35:31 -0700</bug_when>
    <thetext>Looks good.  Thanks for catching this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>410786</commentid>
    <comment_count>36</comment_count>
      <attachid>94640</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2011-05-26 13:37:20 -0700</bug_when>
    <thetext>Comment on attachment 94640
getting crazy. Trying again

r=me based on zmo&apos;s lgtm.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>411015</commentid>
    <comment_count>37</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-05-26 16:57:03 -0700</bug_when>
    <thetext>The commit-queue encountered the following flaky tests while processing attachment 94640:

inspector/debugger/debugger-breakpoints-not-activated-on-reload.html bug 55551 (authors: pfeldman@chromium.org and podivilov@chromium.org)
java/lc3/JavaObject/JavaObjectToInt-002-n.html bug 58299 (author: ap@webkit.org)
The commit-queue is continuing to process your patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>411016</commentid>
    <comment_count>38</comment_count>
      <attachid>94640</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-05-26 16:58:49 -0700</bug_when>
    <thetext>Comment on attachment 94640
getting crazy. Trying again

Clearing flags on attachment: 94640

Committed r87451: &lt;http://trac.webkit.org/changeset/87451&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>411017</commentid>
    <comment_count>39</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-05-26 16:58:57 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>411543</commentid>
    <comment_count>40</comment_count>
    <who name="Ademar Reis">ademar</who>
    <bug_when>2011-05-27 10:53:31 -0700</bug_when>
    <thetext>Revision r87208 cherry-picked into qtwebkit-2.2 with commit 122c9e6 &lt;http://gitorious.org/webkit/qtwebkit/commit/122c9e6&gt;
Revision r87451 cherry-picked into qtwebkit-2.2 with commit 9682ccf &lt;http://gitorious.org/webkit/qtwebkit/commit/9682ccf&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>92593</attachid>
            <date>2011-05-06 09:52:36 -0700</date>
            <delta_ts>2011-05-12 12:01:48 -0700</delta_ts>
            <desc>Fix the debug version plus test case</desc>
            <filename>gl-uniformm-arrays.patch</filename>
            <type>text/plain</type>
            <size>1433</size>
            <attacher name="Idrees">sidreesshah</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29u
dGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRl
eHQuY3BwCmluZGV4IGIzZmEwMTMuLjYwYzM5YWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl
L2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNv
cmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcApAQCAtMjQ0MSw3ICsyNDQx
LDcgQEAgV2ViR0xHZXRJbmZvIFdlYkdMUmVuZGVyaW5nQ29udGV4dDo6Z2V0VW5pZm9ybShXZWJH
TFByb2dyYW0qIHByb2dyYW0sIGNvbnN0IFdlYkcKICAgICAgICAgaWYgKCFtX2NvbnRleHQtPmdl
dEFjdGl2ZVVuaWZvcm0ob2JqZWN0T3JaZXJvKHByb2dyYW0pLCBpLCBpbmZvKSkKICAgICAgICAg
ICAgIHJldHVybiBXZWJHTEdldEluZm8oKTsKICAgICAgICAgLy8gU3RyaXAgIlswXSIgZnJvbSB0
aGUgbmFtZSBpZiBpdCdzIGFuIGFycmF5LgotICAgICAgICBpZiAoaW5mby5zaXplID4gMSkKKyAg
ICAgICAgaWYgKGluZm8uc2l6ZSA+IDEgJiYgaW5mby5uYW1lLmVuZHNXaXRoKCJbMF0iKSkKICAg
ICAgICAgICAgIGluZm8ubmFtZSA9IGluZm8ubmFtZS5sZWZ0KGluZm8ubmFtZS5sZW5ndGgoKSAt
IDMpOwogICAgICAgICAvLyBJZiBpdCdzIGFuIGFycmF5LCB3ZSBuZWVkIHRvIGl0ZXJhdGUgdGhy
b3VnaCBlYWNoIGVsZW1lbnQsIGFwcGVuZGluZyAiW2luZGV4XSIgdG8gdGhlIG5hbWUuCiAgICAg
ICAgIGZvciAoR0MzRGludCBpbmRleCA9IDA7IGluZGV4IDwgaW5mby5zaXplOyArK2luZGV4KSB7
CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGlj
c0NvbnRleHQzRFF0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dy
YXBoaWNzQ29udGV4dDNEUXQuY3BwCmluZGV4IGU1OGYwNjEuLmEyZGFlNzYgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dDNEUXQu
Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29u
dGV4dDNEUXQuY3BwCkBAIC0xMzcxLDcgKzEzNzEsNiBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDNE
Ojp1bmlmb3JtTWF0cml4NGZ2KEdDM0RpbnQgbG9jYXRpb24sIEdDM0Rib29sZWFuIHRyYW5zcG9z
ZQogCiB2b2lkIEdyYXBoaWNzQ29udGV4dDNEOjp1c2VQcm9ncmFtKFBsYXRmb3JtM0RPYmplY3Qg
cHJvZ3JhbSkKIHsKLSAgICBBU1NFUlQocHJvZ3JhbSk7CiAgICAgCiAgICAgbV9pbnRlcm5hbC0+
bV9nbFdpZGdldC0+bWFrZUN1cnJlbnQoKTsKICAgICBtX2ludGVybmFsLT51c2VQcm9ncmFtKHBy
b2dyYW0pOwo=
</data>
<flag name="review"
          id="85581"
          type_id="1"
          status="-"
          setter="eric"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>93319</attachid>
            <date>2011-05-12 11:53:48 -0700</date>
            <delta_ts>2011-05-12 12:00:45 -0700</delta_ts>
            <desc>Second version of the fix</desc>
            <filename>gl-uniformm-arrays_1.patch</filename>
            <type>text/plain</type>
            <size>3594</size>
            <attacher name="Idrees">sidreesshah</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCAxNjFhZTRmLi4yM2ExZTIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg
QEAKKzIwMTEtMDUtMTIgIFN5ZWQgSWRyaXMgU2hhaCAgPHN5ZWQuaWRyaXMtc2hhaEBub2tpYS5j
b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1dL
Ml1bUXRdIGZhc3QvY2FudmFzL3dlYmdsL2dsLXVuaWZvcm0tYXJyYXlzLmh0bWwgZmFpbGluZyBm
b3IgUXQgb24gTGludXgKKwlodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9
NjAzNzcgCisKKyAgICAgICAgTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvZ2wtdW5pZm9y
bS1hcnJheXMuaHRtbAorCisgICAgICAgICogaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250
ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldlYkdMUmVuZGVyaW5nQ29udGV4dDo6Z2V0VW5p
Zm9ybSk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0M0RR
dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQzRDo6dXNlUHJvZ3JhbSk6
CisKIDIwMTEtMDUtMTIgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAg
ICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0
bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1s
L2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwCmluZGV4IDg5MzY5ZWEuLjgwNzZhNzkg
MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29u
dGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdD
b250ZXh0LmNwcApAQCAtMjQ0MSw3ICsyNDQxLDcgQEAgV2ViR0xHZXRJbmZvIFdlYkdMUmVuZGVy
aW5nQ29udGV4dDo6Z2V0VW5pZm9ybShXZWJHTFByb2dyYW0qIHByb2dyYW0sIGNvbnN0IFdlYkcK
ICAgICAgICAgaWYgKCFtX2NvbnRleHQtPmdldEFjdGl2ZVVuaWZvcm0ob2JqZWN0T3JaZXJvKHBy
b2dyYW0pLCBpLCBpbmZvKSkKICAgICAgICAgICAgIHJldHVybiBXZWJHTEdldEluZm8oKTsKICAg
ICAgICAgLy8gU3RyaXAgIlswXSIgZnJvbSB0aGUgbmFtZSBpZiBpdCdzIGFuIGFycmF5LgotICAg
ICAgICBpZiAoaW5mby5zaXplID4gMSkKKyAgICAgICAgaWYgKGluZm8uc2l6ZSA+IDEgJiYgaW5m
by5uYW1lLmVuZHNXaXRoKCJbMF0iKSkKICAgICAgICAgICAgIGluZm8ubmFtZSA9IGluZm8ubmFt
ZS5sZWZ0KGluZm8ubmFtZS5sZW5ndGgoKSAtIDMpOwogICAgICAgICAvLyBJZiBpdCdzIGFuIGFy
cmF5LCB3ZSBuZWVkIHRvIGl0ZXJhdGUgdGhyb3VnaCBlYWNoIGVsZW1lbnQsIGFwcGVuZGluZyAi
W2luZGV4XSIgdG8gdGhlIG5hbWUuCiAgICAgICAgIGZvciAoR0MzRGludCBpbmRleCA9IDA7IGlu
ZGV4IDwgaW5mby5zaXplOyArK2luZGV4KSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w
bGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHQzRFF0LmNwcCBiL1NvdXJjZS9XZWJD
b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dDNEUXQuY3BwCmluZGV4IDZm
ZjcwYzQuLjhiZDhiOTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo
aWNzL3F0L0dyYXBoaWNzQ29udGV4dDNEUXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm
b3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dDNEUXQuY3BwCkBAIC0xNDQ1LDcgKzE0NDUs
NiBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDNEOjp1bmlmb3JtTWF0cml4NGZ2KEdDM0RpbnQgbG9j
YXRpb24sIEdDM0Rib29sZWFuIHRyYW5zcG9zZQogCiB2b2lkIEdyYXBoaWNzQ29udGV4dDNEOjp1
c2VQcm9ncmFtKFBsYXRmb3JtM0RPYmplY3QgcHJvZ3JhbSkKIHsKLSAgICBBU1NFUlQocHJvZ3Jh
bSk7CiAgICAgCiAgICAgbV9pbnRlcm5hbC0+bV9nbFdpZGdldC0+bWFrZUN1cnJlbnQoKTsKICAg
ICBtX2ludGVybmFsLT51c2VQcm9ncmFtKHByb2dyYW0pOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl
YktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IDQxMjI0ZDgu
LjFkYzU3MTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3Vy
Y2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMS0wNS0xMiAgU3llZCBJ
ZHJpcyBTaGFoICA8c3llZC5pZHJpcy1zaGFoQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdl
ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFbmFibGluZyBXZWJHTCBmb3IgV0syIG9u
IFF0IExpbnV4CisJaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYwMzc3
CisKKyAgICAgICAgKiBTaGFyZWQvV2ViUHJlZmVyZW5jZXNTdG9yZS5oOgorCiAyMDExLTA1LTEx
ICBCcmlhbiBXZWluc3RlaW4gIDxid2VpbnN0ZWluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZp
ZXdlZCBieSBBbmRlcnMgQ2FybHNzb24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFy
ZWQvV2ViUHJlZmVyZW5jZXNTdG9yZS5oIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYlByZWZl
cmVuY2VzU3RvcmUuaAppbmRleCAyOTQxOGY2Li5lMTY1MTdhIDEwMDY0NAotLS0gYS9Tb3VyY2Uv
V2ViS2l0Mi9TaGFyZWQvV2ViUHJlZmVyZW5jZXNTdG9yZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQy
L1NoYXJlZC9XZWJQcmVmZXJlbmNlc1N0b3JlLmgKQEAgLTU4LDcgKzU4LDcgQEAgbmFtZXNwYWNl
IFdlYktpdCB7CiAgICAgbWFjcm8oQ2FudmFzVXNlc0FjY2VsZXJhdGVkRHJhd2luZywgY2FudmFz
VXNlc0FjY2VsZXJhdGVkRHJhd2luZywgQm9vbCwgYm9vbCwgdHJ1ZSkgXAogICAgIG1hY3JvKENv
bXBvc2l0aW5nQm9yZGVyc1Zpc2libGUsIGNvbXBvc2l0aW5nQm9yZGVyc1Zpc2libGUsIEJvb2ws
IGJvb2wsIGZhbHNlKSBcCiAgICAgbWFjcm8oQ29tcG9zaXRpbmdSZXBhaW50Q291bnRlcnNWaXNp
YmxlLCBjb21wb3NpdGluZ1JlcGFpbnRDb3VudGVyc1Zpc2libGUsIEJvb2wsIGJvb2wsIGZhbHNl
KSBcCi0gICAgbWFjcm8oV2ViR0xFbmFibGVkLCB3ZWJHTEVuYWJsZWQsIEJvb2wsIGJvb2wsIGZh
bHNlKSBcCisgICAgbWFjcm8oV2ViR0xFbmFibGVkLCB3ZWJHTEVuYWJsZWQsIEJvb2wsIGJvb2ws
IHRydWUpIFwKICAgICBtYWNybyhGb3JjZUZUUERpcmVjdG9yeUxpc3RpbmdzLCBmb3JjZUZUUERp
cmVjdG9yeUxpc3RpbmdzLCBCb29sLCBib29sLCBmYWxzZSkgXAogICAgIG1hY3JvKFRhYnNUb0xp
bmtzLCB0YWJzVG9MaW5rcywgQm9vbCwgYm9vbCwgZmFsc2UpIFwKICAgICBtYWNybyhETlNQcmVm
ZXRjaGluZ0VuYWJsZWQsIGRuc1ByZWZldGNoaW5nRW5hYmxlZCwgQm9vbCwgYm9vbCwgZmFsc2Up
IFwK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>93320</attachid>
            <date>2011-05-12 11:55:03 -0700</date>
            <delta_ts>2011-05-12 11:55:03 -0700</delta_ts>
            <desc>Test case</desc>
            <filename>gl-uniform-arrays.html</filename>
            <type>text/html</type>
            <size>10154</size>
            <attacher name="Idrees">sidreesshah</attacher>
            
              <data encoding="base64">PCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEgVHJhbnNpdGlvbmFs
Ly9FTiIKICAiaHR0cDovL3d3dy53My5vcmcvVFIvaHRtbDQvbG9vc2UuZHRkIj4KPGh0bWw+Cjxo
ZWFkPgo8bWV0YSBodHRwLWVxdWl2PSJDb250ZW50LVR5cGUiIGNvbnRlbnQ9InRleHQvaHRtbDsg
Y2hhcnNldD11dGYtOCI+Cjx0aXRsZT5XZWJHTCB1bmlmb3JtIGFycmF5IENvbmZvcm1hbmNlIFRl
c3RzPC90aXRsZT4KPGxpbmsgcmVsPSJzdHlsZXNoZWV0IiBocmVmPSIuLi8uLi9qcy9yZXNvdXJj
ZXMvanMtdGVzdC1zdHlsZS5jc3MiLz4KPHNjcmlwdCBzcmM9Ii4uLy4uL2pzL3Jlc291cmNlcy9q
cy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+CjxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvd2ViZ2wtdGVz
dC5qcyI+PC9zY3JpcHQ+CjwvaGVhZD4KPGJvZHk+CjxkaXYgaWQ9ImRlc2NyaXB0aW9uIj48L2Rp
dj4KPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+CjxjYW52YXMgaWQ9ImV4YW1wbGUiIHdpZHRoPSIy
IiBoZWlnaHQ9IjIiPiA8L2NhbnZhcz4KPHNjcmlwdCBpZD0idnNoYWRlciIgdHlwZT0ieC1zaGFk
ZXIveC12ZXJ0ZXgiPgogICAgYXR0cmlidXRlIHZlYzQgdlBvc2l0aW9uOwogICAgdm9pZCBtYWlu
KCkKICAgIHsKICAgICAgICBnbF9Qb3NpdGlvbiA9IHZQb3NpdGlvbjsKICAgIH0KPC9zY3JpcHQ+
Cgo8c2NyaXB0IGlkPSJmc2hhZGVyIiB0eXBlPSJ4LXNoYWRlci94LWZyYWdtZW50Ij4KICAgICNp
ZmRlZiBHTF9FUwogICAgcHJlY2lzaW9uIG1lZGl1bXAgZmxvYXQ7CiAgICAjZW5kaWYKICAgIHVu
aWZvcm0gJHR5cGUgY29sb3JbM107CiAgICB2b2lkIG1haW4oKQogICAgewogICAgICAgIGdsX0Zy
YWdDb2xvciA9IHZlYzQoY29sb3JbMF0kZWxlbSwgY29sb3JbMV0kZWxlbSwgY29sb3JbMl0kZWxl
bSwgMSk7CiAgICB9Cjwvc2NyaXB0Pgo8c2NyaXB0PgpmdW5jdGlvbiBsb2FkU2hhZGVyKGN0eCwg
c2hhZGVyVHlwZSwgc2hhZGVyU291cmNlKSB7CiAgLy8gQ3JlYXRlIHRoZSBzaGFkZXIgb2JqZWN0
CiAgdmFyIHNoYWRlciA9IGN0eC5jcmVhdGVTaGFkZXIoc2hhZGVyVHlwZSk7CiAgaWYgKHNoYWRl
ciA9PSBudWxsKSB7CiAgICBkZWJ1ZygiKioqIEVycm9yOiB1bmFibGUgdG8gY3JlYXRlIHNoYWRl
ciAnIitzaGFkZXIrIiciKTsKICAgIHJldHVybiBudWxsOwogIH0KCiAgLy8gTG9hZCB0aGUgc2hh
ZGVyIHNvdXJjZQogIGN0eC5zaGFkZXJTb3VyY2Uoc2hhZGVyLCBzaGFkZXJTb3VyY2UpOwoKICAv
LyBDb21waWxlIHRoZSBzaGFkZXIKICBjdHguY29tcGlsZVNoYWRlcihzaGFkZXIpOwoKICAvLyBD
aGVjayB0aGUgY29tcGlsZSBzdGF0dXMKICB2YXIgY29tcGlsZWQgPSBjdHguZ2V0U2hhZGVyUGFy
YW1ldGVyKHNoYWRlciwgY3R4LkNPTVBJTEVfU1RBVFVTKTsKICBpZiAoIWNvbXBpbGVkKSB7CiAg
ICAvLyBTb21ldGhpbmcgd2VudCB3cm9uZyBkdXJpbmcgY29tcGlsYXRpb247IGdldCB0aGUgZXJy
b3IKICAgIHZhciBlcnJvciA9IGN0eC5nZXRTaGFkZXJJbmZvTG9nKHNoYWRlcik7CiAgICBkZWJ1
ZygiKioqIEVycm9yIGNvbXBpbGluZyBzaGFkZXIgJyIrc2hhZGVyKyInOiIrZXJyb3IpOwogICAg
Y3R4LmRlbGV0ZVNoYWRlcihzaGFkZXIpOwogICAgcmV0dXJuIG51bGw7CiAgfQoKICByZXR1cm4g
c2hhZGVyOwp9CgpmdW5jdGlvbiBsb2FkUHJvZ3JhbShjdHgsIHZlcnRleFNoYWRlclNyYywgZnJh
Z21lbnRTaGFkZXJTcmMpIHsKICB2YXIgcHJvZ3JhbSA9IGN0eC5jcmVhdGVQcm9ncmFtKCk7CiAg
dmFyIHZTaGFkZXIgPSBsb2FkU2hhZGVyKGN0eCwgY3R4LlZFUlRFWF9TSEFERVIsIHZlcnRleFNo
YWRlclNyYykKICB2YXIgZlNoYWRlciA9IGxvYWRTaGFkZXIoY3R4LCBjdHguRlJBR01FTlRfU0hB
REVSLCBmcmFnbWVudFNoYWRlclNyYyk7CiAgY3R4LmF0dGFjaFNoYWRlcihwcm9ncmFtLCB2U2hh
ZGVyKTsKICBjdHguYXR0YWNoU2hhZGVyKHByb2dyYW0sIGZTaGFkZXIpOwogIGN0eC5saW5rUHJv
Z3JhbShwcm9ncmFtKTsKICB2YXIgbGlua2VkID0gY3R4LmdldFByb2dyYW1QYXJhbWV0ZXIocHJv
Z3JhbSwgY3R4LkxJTktfU1RBVFVTKTsKICBpZiAoIWxpbmtlZCkgewogICAgLy8gc29tZXRoaW5n
IHdlbnQgd3Jvbmcgd2l0aCB0aGUgbGluawogICAgdmFyIGVycm9yID0gY3R4LmdldFByb2dyYW1J
bmZvTG9nIChjdHgucHJvZ3JhbSk7CiAgICBkZWJ1ZygiRXJyb3IgaW4gcHJvZ3JhbSBsaW5raW5n
OiIgKyBlcnJvcik7CiAgICBjdHguZGVsZXRlUHJvZ3JhbShjdHgucHJvZ3JhbSk7CiAgICBwcm9n
cmFtID0gbnVsbDsKICB9Ci8vICBjdHguZGVsZXRlU2hhZGVyKGZTaGFkZXIpOwovLyAgY3R4LmRl
bGV0ZVNoYWRlcih2U2hhZGVyKTsKICByZXR1cm4gcHJvZ3JhbTsKfQoKZGVzY3JpcHRpb24oIlRo
aXMgdGVzdCBlbnN1cmVzIFdlYkdMIGltcGxlbWVudGF0aW9ucyBoYW5kbGUgdW5pZm9ybSBhcnJh
eXMgY29ycmVjdGx5LiIpOwoKZGVidWcoIiIpOwoKdmFyIGdsID0gY3JlYXRlM0RDb250ZXh0KGRv
Y3VtZW50LmdldEVsZW1lbnRCeUlkKCJleGFtcGxlIikpOwoKdmFyIHZTcmMgPSBkb2N1bWVudC5n
ZXRFbGVtZW50QnlJZCgidnNoYWRlciIpLnRleHQ7CnZhciBmVGVtcGxhdGUgPSBkb2N1bWVudC5n
ZXRFbGVtZW50QnlJZCgiZnNoYWRlciIpLnRleHQ7Cgp2YXIgdHlwZUluZm9zID0gWwogIHsgdHlw
ZTogJ2Zsb2F0JywKICAgIGpzVHlwZU9mOiAnbnVtYmVyJywKICAgIHNldHRlcjogJ3VuaWZvcm0x
ZnYnLAogICAgZWxlbTogJycsCiAgICBudW1TcmNWYWx1ZXM6IDMsCiAgICBpbnZhbGlkU2V0OiBm
dW5jdGlvbihsb2MpIHsKICAgICAgZ2wudW5pZm9ybTJmdihsb2MsIFsxLCAyXSk7CiAgICB9LAog
ICAgc3JjVmFsdWVBc1N0cmluZzogZnVuY3Rpb24oaW5kZXgsIHNyY1ZhbHVlcykgewogICAgICBy
ZXR1cm4gc3JjVmFsdWVzW2luZGV4XS50b1N0cmluZygpOwogICAgfSwKICAgIHJldHVyblZhbHVl
QXNTdHJpbmc6IGZ1bmN0aW9uKHZhbHVlKSB7CiAgICAgIHJldHVybiB2YWx1ZSA9PT0gbnVsbCA/
ICdudWxsJyA6IHZhbHVlLnRvU3RyaW5nKCk7CiAgICB9LAogICAgY2hlY2tUeXBlOiBmdW5jdGlv
bih2YWx1ZSkgewogICAgICByZXR1cm4gdHlwZW9mIHZhbHVlID09PSAnbnVtYmVyJzsKICAgIH0s
CiAgICBjaGVja1ZhbHVlOiBmdW5jdGlvbih0eXBlSW5mbywgaW5kZXgsIHZhbHVlKSB7CiAgICAg
IHJldHVybiB0eXBlSW5mby5zcmNWYWx1ZXNbaW5kZXhdID09IHZhbHVlOwogICAgfSwKICAgIHNy
Y1ZhbHVlczogWzE2LCAxNSwgMTRdLAogICAgc3JjVmFsdWVzTGVzczogW10sCiAgICBzcmNWYWx1
ZXNOb25NdWx0aXBsZTogbnVsbCwKICB9LAogIHsgdHlwZTogJ3ZlYzInLAogICAganNUeXBlT2Y6
ICdGbG9hdDMyQXJyYXknLAogICAgc2V0dGVyOiAndW5pZm9ybTJmdicsCiAgICBlbGVtOiAnWzFd
JywKICAgIG51bVNyY1ZhbHVlczogMywKICAgIGludmFsaWRTZXQ6IGZ1bmN0aW9uKGxvYykgewog
ICAgICBnbC51bmlmb3JtMWZ2KGxvYywgWzJdKTsKICAgIH0sCiAgICBpbGxlZ2FsU2V0OiBmdW5j
dGlvbihsb2MpIHsKICAgICAgZ2wudW5pZm9ybTFmdihsb2MsIDIpOwogICAgfSwKICAgIHNyY1Zh
bHVlQXNTdHJpbmc6IGZ1bmN0aW9uKGluZGV4LCBzcmNWYWx1ZXMpIHsKICAgICAgcmV0dXJuICJb
IiArIHNyY1ZhbHVlc1tpbmRleCAqIDIgKyAwXS50b1N0cmluZygpICsgIiwgIiArCiAgICAgICAg
ICAgICAgICAgICBzcmNWYWx1ZXNbaW5kZXggKiAyICsgMV0udG9TdHJpbmcoKSArICJdIjsKICAg
IH0sCiAgICByZXR1cm5WYWx1ZUFzU3RyaW5nOiBmdW5jdGlvbih2YWx1ZSkgewogICAgICByZXR1
cm4gdmFsdWUgPT09IG51bGwgPyAnbnVsbCcgOiAoIlsiICsgdmFsdWVbMF0gKyAiLCAiICsgdmFs
dWVbMV0gKyAiXSIpOwogICAgfSwKICAgIGNoZWNrVHlwZTogZnVuY3Rpb24odmFsdWUpIHsKICAg
ICAgcmV0dXJuIHZhbHVlICYmCiAgICAgICAgICAgICB0eXBlb2YgdmFsdWUubGVuZ3RoID09PSAn
bnVtYmVyJyAmJgogICAgICAgICAgICAgdmFsdWUubGVuZ3RoID09IDI7CiAgICB9LAogICAgY2hl
Y2tWYWx1ZTogZnVuY3Rpb24odHlwZUluZm8sIGluZGV4LCB2YWx1ZSkgewogICAgICByZXR1cm4g
dmFsdWUgIT09IG51bGwgJiYKICAgICAgICAgICAgIHR5cGVJbmZvLnNyY1ZhbHVlc1tpbmRleCAq
IDIgKyAwXSA9PSB2YWx1ZVswXSAmJgogICAgICAgICAgICAgdHlwZUluZm8uc3JjVmFsdWVzW2lu
ZGV4ICogMiArIDFdID09IHZhbHVlWzFdOwogICAgfSwKICAgIHNyY1ZhbHVlczogWzE2LCAxNSwg
MTQsIDEzLCAxMiwgMTFdLAogICAgc3JjVmFsdWVzTGVzczogWzE2XSwKICAgIHNyY1ZhbHVlc05v
bk11bHRpcGxlOiBbMTYsIDE1LCAxNCwgMTMsIDEyLCAxMSwgMTBdLAogIH0sCiAgeyB0eXBlOiAn
dmVjMycsCiAgICBqc1R5cGVPZjogJ0Zsb2F0MzJBcnJheScsCiAgICBzZXR0ZXI6ICd1bmlmb3Jt
M2Z2JywKICAgIGVsZW06ICdbMl0nLAogICAgbnVtU3JjVmFsdWVzOiAzLAogICAgaW52YWxpZFNl
dDogZnVuY3Rpb24obG9jKSB7CiAgICAgIGdsLnVuaWZvcm0xZnYobG9jLCBbMl0pOwogICAgfSwK
ICAgIGlsbGVnYWxTZXQ6IGZ1bmN0aW9uKGxvYykgewogICAgICBnbC51bmlmb3JtMWZ2KGxvYywg
Mik7CiAgICB9LAogICAgc3JjVmFsdWVBc1N0cmluZzogZnVuY3Rpb24oaW5kZXgsIHNyY1ZhbHVl
cykgewogICAgICByZXR1cm4gIlsiICsgc3JjVmFsdWVzW2luZGV4ICogMyArIDBdLnRvU3RyaW5n
KCkgKyAiLCAiICsKICAgICAgICAgICAgICAgICAgIHNyY1ZhbHVlc1tpbmRleCAqIDMgKyAxXS50
b1N0cmluZygpICsgIiwgIiArCiAgICAgICAgICAgICAgICAgICBzcmNWYWx1ZXNbaW5kZXggKiAz
ICsgMl0udG9TdHJpbmcoKSArICJdIjsKICAgIH0sCiAgICByZXR1cm5WYWx1ZUFzU3RyaW5nOiBm
dW5jdGlvbih2YWx1ZSkgewogICAgICByZXR1cm4gdmFsdWUgPT09IG51bGwgPyAnbnVsbCcgOgog
ICAgICAgICAgKCJbIiArIHZhbHVlWzBdICsgIiwgIiArIHZhbHVlWzFdICsgIiwgIiArIHZhbHVl
WzJdICsgIl0iKTsKICAgIH0sCiAgICBjaGVja1R5cGU6IGZ1bmN0aW9uKHZhbHVlKSB7CiAgICAg
IHJldHVybiB2YWx1ZSAmJgogICAgICAgICAgICAgdHlwZW9mIHZhbHVlLmxlbmd0aCA9PT0gJ251
bWJlcicgJiYKICAgICAgICAgICAgIHZhbHVlLmxlbmd0aCA9PSAzOwogICAgfSwKICAgIGNoZWNr
VmFsdWU6IGZ1bmN0aW9uKHR5cGVJbmZvLCBpbmRleCwgdmFsdWUpIHsKICAgICAgcmV0dXJuIHZh
bHVlICE9PSBudWxsICYmCiAgICAgICAgICAgICB0eXBlSW5mby5zcmNWYWx1ZXNbaW5kZXggKiAz
ICsgMF0gPT0gdmFsdWVbMF0gJiYKICAgICAgICAgICAgIHR5cGVJbmZvLnNyY1ZhbHVlc1tpbmRl
eCAqIDMgKyAxXSA9PSB2YWx1ZVsxXSAmJgogICAgICAgICAgICAgdHlwZUluZm8uc3JjVmFsdWVz
W2luZGV4ICogMyArIDJdID09IHZhbHVlWzJdOwogICAgfSwKICAgIHNyY1ZhbHVlczogWzE2LCAx
NSwgMTQsIDEzLCAxMiwgMTEsIDEwLCA5LCA4XSwKICAgIHNyY1ZhbHVlc0xlc3M6IFsxNiwgMTVd
LAogICAgc3JjVmFsdWVzTm9uTXVsdGlwbGU6IFsxNiwgMTUsIDE0LCAxMywgMTIsIDExLCAxMCwg
OSwgOCwgN10sCiAgfSwKICB7IHR5cGU6ICd2ZWM0JywKICAgIGpzVHlwZU9mOiAnRmxvYXQzMkFy
cmF5JywKICAgIHNldHRlcjogJ3VuaWZvcm00ZnYnLAogICAgZWxlbTogJ1szXScsCiAgICBudW1T
cmNWYWx1ZXM6IDMsCiAgICBpbnZhbGlkU2V0OiBmdW5jdGlvbihsb2MpIHsKICAgICAgZ2wudW5p
Zm9ybTFmdihsb2MsIFsyXSk7CiAgICB9LAogICAgaWxsZWdhbFNldDogZnVuY3Rpb24obG9jKSB7
CiAgICAgIGdsLnVuaWZvcm0xZnYobG9jLCAyKTsKICAgIH0sCiAgICBzcmNWYWx1ZUFzU3RyaW5n
OiBmdW5jdGlvbihpbmRleCwgc3JjVmFsdWVzKSB7CiAgICAgIHJldHVybiAiWyIgKyBzcmNWYWx1
ZXNbaW5kZXggKiA0ICsgMF0udG9TdHJpbmcoKSArICIsICIgKwogICAgICAgICAgICAgICAgICAg
c3JjVmFsdWVzW2luZGV4ICogNCArIDFdLnRvU3RyaW5nKCkgKyAiLCAiICsKICAgICAgICAgICAg
ICAgICAgIHNyY1ZhbHVlc1tpbmRleCAqIDQgKyAyXS50b1N0cmluZygpICsgIiwgIiArCiAgICAg
ICAgICAgICAgICAgICBzcmNWYWx1ZXNbaW5kZXggKiA0ICsgM10udG9TdHJpbmcoKSArICJdIjsK
ICAgIH0sCiAgICByZXR1cm5WYWx1ZUFzU3RyaW5nOiBmdW5jdGlvbih2YWx1ZSkgewogICAgICBy
ZXR1cm4gdmFsdWUgPT09IG51bGwgPyAnbnVsbCcgOgogICAgICAgICAgKCJbIiArIHZhbHVlWzBd
ICsgIiwgIiArIHZhbHVlWzFdICsKICAgICAgICAgICAiLCAiICsgdmFsdWVbMl0gKyAiLCAiICsg
dmFsdWVbM10gKyAiXSIpOwogICAgfSwKICAgIGNoZWNrVHlwZTogZnVuY3Rpb24odmFsdWUpIHsK
ICAgICAgcmV0dXJuIHZhbHVlICYmCiAgICAgICAgICAgICB0eXBlb2YgdmFsdWUubGVuZ3RoID09
PSAnbnVtYmVyJyAmJgogICAgICAgICAgICAgdmFsdWUubGVuZ3RoID09IDQ7CiAgICB9LAogICAg
Y2hlY2tWYWx1ZTogZnVuY3Rpb24odHlwZUluZm8sIGluZGV4LCB2YWx1ZSkgewogICAgICByZXR1
cm4gdmFsdWUgIT09IG51bGwgJiYKICAgICAgICAgICAgIHR5cGVJbmZvLnNyY1ZhbHVlc1tpbmRl
eCAqIDQgKyAwXSA9PSB2YWx1ZVswXSAmJgogICAgICAgICAgICAgdHlwZUluZm8uc3JjVmFsdWVz
W2luZGV4ICogNCArIDFdID09IHZhbHVlWzFdICYmCiAgICAgICAgICAgICB0eXBlSW5mby5zcmNW
YWx1ZXNbaW5kZXggKiA0ICsgMl0gPT0gdmFsdWVbMl0gJiYKICAgICAgICAgICAgIHR5cGVJbmZv
LnNyY1ZhbHVlc1tpbmRleCAqIDQgKyAzXSA9PSB2YWx1ZVszXTsKICAgIH0sCiAgICBzcmNWYWx1
ZXM6IFsxNiwgMTUsIDE0LCAxMywgMTIsIDExLCAxMCwgOSwgOCwgNywgNiwgNV0sCiAgICBzcmNW
YWx1ZXNMZXNzOiBbMTYsIDE1LCAxNF0sCiAgICBzcmNWYWx1ZXNOb25NdWx0aXBsZTogWzE2LCAx
NSwgMTQsIDEzLCAxMiwgMTEsIDEwLCA5LCA4LCA3LCA2LCA1LCA0XSwKICB9Cl07Cgpmb3IgKHZh
ciB0dCA9IDA7IHR0IDwgdHlwZUluZm9zLmxlbmd0aDsgKyt0dCkgewogIHZhciB0eXBlSW5mbyA9
IHR5cGVJbmZvc1t0dF07CiAgZGVidWcoIiIpOwogIGRlYnVnKCJjaGVjayAiICsgdHlwZUluZm8u
dHlwZSk7CiAgdmFyIGZTcmMgPSBmVGVtcGxhdGUucmVwbGFjZSgvXCR0eXBlL2csIHR5cGVJbmZv
LnR5cGUpLgogICAgICAgICAgICAgICAgICAgICAgIHJlcGxhY2UoL1wkZWxlbS9nLCB0eXBlSW5m
by5lbGVtKTsKICAvL2RlYnVnKCJmU3JjOiAiICsgZlNyYyk7CiAgdmFyIHByb2dyYW0gPSBsb2Fk
UHJvZ3JhbShnbCwgdlNyYywgZlNyYyk7CgogIHZhciBudW1Vbmlmb3JtcyA9IGdsLmdldFByb2dy
YW1QYXJhbWV0ZXIocHJvZ3JhbSwgZ2wuQUNUSVZFX1VOSUZPUk1TKTsKICBhc3NlcnRNc2cobnVt
VW5pZm9ybXMgPT0gMSwgIjEgdW5pZm9ybSBmb3VuZCIpOwogIHZhciBpbmZvID0gZ2wuZ2V0QWN0
aXZlVW5pZm9ybShwcm9ncmFtLCAwKTsKICBhc3NlcnRNc2coaW5mby5uYW1lID09ICJjb2xvclsw
XSIsCiAgICAgICAgICAgICJ1bmlmb3JtIG5hbWUgaXMgJ2NvbG9yWzBdJyBub3QgJ2NvbG9yJyBh
cyBwZXIgT3BlbkdMIEVTIDIuMC4yNCBzZWN0aW9uIDIuMTAiKTsKICB2YXIgbG9jID0gZ2wuZ2V0
VW5pZm9ybUxvY2F0aW9uKHByb2dyYW0sICJjb2xvclswXSIpOwogIHZhciBzcmNWYWx1ZXMgPSB0
eXBlSW5mby5zcmNWYWx1ZXM7CiAgdmFyIHNyY1ZhbHVlc0xlc3MgPSB0eXBlSW5mby5zcmNWYWx1
ZXNMZXNzOwogIHZhciBzcmNWYWx1ZXNOb25NdWx0aXBsZSA9IHR5cGVJbmZvLnNyY1ZhbHVlc05v
bk11bHRpcGxlOwoKICAvLyBUcnkgc2V0dGluZyB0aGUgdmFsdWUgYmVmb3JlIHVzaW5nIHRoZSBw
cm9ncmFtCiAgZ2xbdHlwZUluZm8uc2V0dGVyXShsb2MsIHNyY1ZhbHVlcyk7CiAgZ2xFcnJvclNo
b3VsZEJlKGdsLCBnbC5JTlZBTElEX09QRVJBVElPTiwKICAgICAgICAgICAgICAgICAgInNob3Vs
ZCBmYWlsIGlmIHRoZXJlIGlzIG5vIGN1cnJlbnQgcHJvZ3JhbSIpOwoKICBnbC51c2VQcm9ncmFt
KHByb2dyYW0pOwogIGdsW3R5cGVJbmZvLnNldHRlcl0obG9jLCBzcmNWYWx1ZXNMZXNzKTsKICBn
bEVycm9yU2hvdWxkQmUoZ2wsIGdsLklOVkFMSURfVkFMVUUsCiAgICAgICAgICAgICAgICAgICJz
aG91bGQgZmFpbCB3aXRoIGluc3VmZmljaWVudCBhcnJheSBzaXplIHdpdGggZ2wuIiArIHR5cGVJ
bmZvLnNldHRlcik7CiAgaWYgKHNyY1ZhbHVlc05vbk11bHRpcGxlKSB7CiAgICBnbFt0eXBlSW5m
by5zZXR0ZXJdKGxvYywgc3JjVmFsdWVzTm9uTXVsdGlwbGUpOwogICAgZ2xFcnJvclNob3VsZEJl
KGdsLCBnbC5JTlZBTElEX1ZBTFVFLAogICAgICAgICAgICAgICAgICAgICJzaG91bGQgZmFpbCB3
aXRoIG5vbi1tdWx0aXBsZSBhcnJheSBzaXplIHdpdGggZ2wuIiArIHR5cGVJbmZvLnNldHRlcik7
CiAgfQogIGdsW3R5cGVJbmZvLnNldHRlcl0obG9jLCBzcmNWYWx1ZXMpOwogIGdsRXJyb3JTaG91
bGRCZShnbCwgZ2wuTk9fRVJST1IsCiAgICAgICAgICAgICAgICAgICJjYW4gc2V0IGFuIGFycmF5
IG9mIHVuaWZvcm1zIHdpdGggZ2wuIiArIHR5cGVJbmZvLnNldHRlcik7CiAgdmFyIHZhbHVlcyA9
IGdsLmdldFVuaWZvcm0ocHJvZ3JhbSwgbG9jKTsKICBnbEVycm9yU2hvdWxkQmUoZ2wsIGdsLk5P
X0VSUk9SLAogICAgICAgICAgICAgICAgICAiY2FuIGNhbGwgZ2wuZ2V0VW5pZm9ybSIpOwogIGFz
c2VydE1zZyh0eXBlSW5mby5jaGVja1R5cGUodmFsdWVzKSwKICAgICAgICAgICAgImdsLmdldFVu
aWZvcm0gcmV0dXJucyB0aGUgY29ycmVjdCB0eXBlLiIpOwogIGZvciAodmFyIGlpID0gMDsgaWkg
PCB0eXBlSW5mby5udW1TcmNWYWx1ZXM7ICsraWkpIHsKICAgIHZhciBlbGVtTG9jID0gZ2wuZ2V0
VW5pZm9ybUxvY2F0aW9uKHByb2dyYW0sICJjb2xvclsiICsgaWkgKyAiXSIpOwogICAgZ2xFcnJv
clNob3VsZEJlKGdsLCBnbC5OT19FUlJPUiwKICAgICAgICAgICAgICAgICAgICAiY2FuIGdldCBs
b2NhdGlvbiBvZiBlbGVtZW50ICIgKyBpaSArCiAgICAgICAgICAgICAgICAgICAgIiBvZiBhcnJh
eSBmcm9tIGdsLmdldFVuaWZvcm1Mb2NhdGlvbiIpOwogICAgdmFyIHZhbHVlID0gZ2wuZ2V0VW5p
Zm9ybShwcm9ncmFtLCBlbGVtTG9jKTsKICAgIGdsRXJyb3JTaG91bGRCZShnbCwgZ2wuTk9fRVJS
T1IsCiAgICAgICAgICAgICAgICAgICAgImNhbiBnZXQgdmFsdWUgb2YgZWxlbWVudCAiICsgaWkg
KyAiIG9mIGFycmF5IGZyb20gZ2wuZ2V0VW5pZm9ybSIpOwogICAgYXNzZXJ0TXNnKHR5cGVJbmZv
LmNoZWNrVmFsdWUodHlwZUluZm8sIGlpLCB2YWx1ZSksCiAgICAgICAgICAgICAgInZhbHVlIHB1
dCBpbiAoIiArIHR5cGVJbmZvLnNyY1ZhbHVlQXNTdHJpbmcoaWksIHNyY1ZhbHVlcykgKwogICAg
ICAgICAgICAgICIpIG1hdGNoZXMgdmFsdWUgcHVsbGVkIG91dCAoIiArCiAgICAgICAgICAgICAg
dHlwZUluZm8ucmV0dXJuVmFsdWVBc1N0cmluZyh2YWx1ZSkgKyAiKSIpOwogIH0KICB0eXBlSW5m
by5pbnZhbGlkU2V0KGxvYyk7CiAgZ2xFcnJvclNob3VsZEJlKGdsLCBnbC5JTlZBTElEX09QRVJB
VElPTiwKICAgICAgICAgICAgICAgICAgInVzaW5nIHRoZSB3cm9uZyBzaXplIG9mIGdsLlVuaWZv
cm0gZmFpbHMiKTsKICB2YXIgZXhjZXB0aW9uQ2F1Z2h0ID0gZmFsc2U7CiAgaWYgKHR5cGVJbmZv
LmlsbGVnYWxTZXQpIHsKICAgIHRyeSB7CiAgICAgIHR5cGVJbmZvLmlsbGVnYWxTZXQobG9jKTsK
ICAgIH0gY2F0Y2ggKGUpIHsKICAgICAgZXhjZXB0aW9uQ2F1Z2h0ID0gdHJ1ZTsKICAgIH0KICAg
IGFzc2VydE1zZyhleGNlcHRpb25DYXVnaHQsICJwYXNzaW5nIG5vbi1hcnJheSB0byBnbFVuaWZv
cm0qZnYgc2hvdWxkIHRocm93IFR5cGVFcnJvciIpOwogIH0KCiAgZ2wudXNlUHJvZ3JhbShudWxs
KTsKICBnbEVycm9yU2hvdWxkQmUoZ2wsIGdsLk5PX0VSUk9SLAogICAgICAgICAgICAgICAgICAi
Y2FuIGNhbGwgZ2wudXNlUHJvZ3JhbShudWxsKSIpOwp9CmRlYnVnKCIiKTsKc3VjY2Vzc2Z1bGx5
UGFyc2VkID0gdHJ1ZTsKCjwvc2NyaXB0Pgo8c2NyaXB0IHNyYz0iLi4vLi4vanMvcmVzb3VyY2Vz
L2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cgo8c2NyaXB0Pgo8L3NjcmlwdD4KCjwvYm9keT4K
PC9odG1sPgo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>93321</attachid>
            <date>2011-05-12 12:01:48 -0700</date>
            <delta_ts>2011-05-17 12:28:03 -0700</delta_ts>
            <desc>Trying Fix again</desc>
            <filename>gl-uniformm-arrays_1.patch</filename>
            <type>text/plain</type>
            <size>3608</size>
            <attacher name="Idrees">sidreesshah</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCAxNjFhZTRmLi5iYmJhN2JiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg
QEAKKzIwMTEtMDUtMTIgIFN5ZWQgSWRyaXMgU2hhaCAgPHN5ZWQuaWRyaXMtc2hhaEBub2tpYS5j
b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1dL
Ml1bUXRdIGZhc3QvY2FudmFzL3dlYmdsL2dsLXVuaWZvcm0tYXJyYXlzLmh0bWwgZmFpbGluZyBm
b3IgUXQgb24gTGludXgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTYwMzc3IAorCisgICAgICAgIExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2ds
LXVuaWZvcm0tYXJyYXlzLmh0bWwKKworICAgICAgICAqIGh0bWwvY2FudmFzL1dlYkdMUmVuZGVy
aW5nQ29udGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXZWJHTFJlbmRlcmluZ0NvbnRleHQ6
OmdldFVuaWZvcm0pOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29u
dGV4dDNEUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0M0Q6OnVzZVBy
b2dyYW0pOgorCiAyMDExLTA1LTEyICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAK
ICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi
Q29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwIGIvU291cmNlL1dlYkNv
cmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcAppbmRleCA4OTM2OWVhLi44
MDc2YTc5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRl
cmluZ0NvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVu
ZGVyaW5nQ29udGV4dC5jcHAKQEAgLTI0NDEsNyArMjQ0MSw3IEBAIFdlYkdMR2V0SW5mbyBXZWJH
TFJlbmRlcmluZ0NvbnRleHQ6OmdldFVuaWZvcm0oV2ViR0xQcm9ncmFtKiBwcm9ncmFtLCBjb25z
dCBXZWJHCiAgICAgICAgIGlmICghbV9jb250ZXh0LT5nZXRBY3RpdmVVbmlmb3JtKG9iamVjdE9y
WmVybyhwcm9ncmFtKSwgaSwgaW5mbykpCiAgICAgICAgICAgICByZXR1cm4gV2ViR0xHZXRJbmZv
KCk7CiAgICAgICAgIC8vIFN0cmlwICJbMF0iIGZyb20gdGhlIG5hbWUgaWYgaXQncyBhbiBhcnJh
eS4KLSAgICAgICAgaWYgKGluZm8uc2l6ZSA+IDEpCisgICAgICAgIGlmIChpbmZvLnNpemUgPiAx
ICYmIGluZm8ubmFtZS5lbmRzV2l0aCgiWzBdIikpCiAgICAgICAgICAgICBpbmZvLm5hbWUgPSBp
bmZvLm5hbWUubGVmdChpbmZvLm5hbWUubGVuZ3RoKCkgLSAzKTsKICAgICAgICAgLy8gSWYgaXQn
cyBhbiBhcnJheSwgd2UgbmVlZCB0byBpdGVyYXRlIHRocm91Z2ggZWFjaCBlbGVtZW50LCBhcHBl
bmRpbmcgIltpbmRleF0iIHRvIHRoZSBuYW1lLgogICAgICAgICBmb3IgKEdDM0RpbnQgaW5kZXgg
PSAwOyBpbmRleCA8IGluZm8uc2l6ZTsgKytpbmRleCkgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dl
YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0M0RRdC5jcHAgYi9Tb3Vy
Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHQzRFF0LmNwcApp
bmRleCA2ZmY3MGM0Li44YmQ4YjkyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y
bS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHQzRFF0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y
ZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHQzRFF0LmNwcApAQCAtMTQ0NSw3
ICsxNDQ1LDYgQEAgdm9pZCBHcmFwaGljc0NvbnRleHQzRDo6dW5pZm9ybU1hdHJpeDRmdihHQzNE
aW50IGxvY2F0aW9uLCBHQzNEYm9vbGVhbiB0cmFuc3Bvc2UKIAogdm9pZCBHcmFwaGljc0NvbnRl
eHQzRDo6dXNlUHJvZ3JhbShQbGF0Zm9ybTNET2JqZWN0IHByb2dyYW0pCiB7Ci0gICAgQVNTRVJU
KHByb2dyYW0pOwogICAgIAogICAgIG1faW50ZXJuYWwtPm1fZ2xXaWRnZXQtPm1ha2VDdXJyZW50
KCk7CiAgICAgbV9pbnRlcm5hbC0+dXNlUHJvZ3JhbShwcm9ncmFtKTsKZGlmZiAtLWdpdCBhL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA0
MTIyNGQ4Li5mYmIzMjdiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysr
IGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDUtMTIg
IFN5ZWQgSWRyaXMgU2hhaCAgPHN5ZWQuaWRyaXMtc2hhaEBub2tpYS5jb20+CisKKyAgICAgICAg
UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRW5hYmxpbmcgV2ViR0wgZm9y
IFdLMiBvbiBRdCBMaW51eAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9NjAzNzcKKworICAgICAgICAqIFNoYXJlZC9XZWJQcmVmZXJlbmNlc1N0b3JlLmg6
CisKIDIwMTEtMDUtMTEgIEJyaWFuIFdlaW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUuY29tPgog
CiAgICAgICAgIFJldmlld2VkIGJ5IEFuZGVycyBDYXJsc3Nvbi4KZGlmZiAtLWdpdCBhL1NvdXJj
ZS9XZWJLaXQyL1NoYXJlZC9XZWJQcmVmZXJlbmNlc1N0b3JlLmggYi9Tb3VyY2UvV2ViS2l0Mi9T
aGFyZWQvV2ViUHJlZmVyZW5jZXNTdG9yZS5oCmluZGV4IDI5NDE4ZjYuLmUxNjUxN2EgMTAwNjQ0
Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJQcmVmZXJlbmNlc1N0b3JlLmgKKysrIGIv
U291cmNlL1dlYktpdDIvU2hhcmVkL1dlYlByZWZlcmVuY2VzU3RvcmUuaApAQCAtNTgsNyArNTgs
NyBAQCBuYW1lc3BhY2UgV2ViS2l0IHsKICAgICBtYWNybyhDYW52YXNVc2VzQWNjZWxlcmF0ZWRE
cmF3aW5nLCBjYW52YXNVc2VzQWNjZWxlcmF0ZWREcmF3aW5nLCBCb29sLCBib29sLCB0cnVlKSBc
CiAgICAgbWFjcm8oQ29tcG9zaXRpbmdCb3JkZXJzVmlzaWJsZSwgY29tcG9zaXRpbmdCb3JkZXJz
VmlzaWJsZSwgQm9vbCwgYm9vbCwgZmFsc2UpIFwKICAgICBtYWNybyhDb21wb3NpdGluZ1JlcGFp
bnRDb3VudGVyc1Zpc2libGUsIGNvbXBvc2l0aW5nUmVwYWludENvdW50ZXJzVmlzaWJsZSwgQm9v
bCwgYm9vbCwgZmFsc2UpIFwKLSAgICBtYWNybyhXZWJHTEVuYWJsZWQsIHdlYkdMRW5hYmxlZCwg
Qm9vbCwgYm9vbCwgZmFsc2UpIFwKKyAgICBtYWNybyhXZWJHTEVuYWJsZWQsIHdlYkdMRW5hYmxl
ZCwgQm9vbCwgYm9vbCwgdHJ1ZSkgXAogICAgIG1hY3JvKEZvcmNlRlRQRGlyZWN0b3J5TGlzdGlu
Z3MsIGZvcmNlRlRQRGlyZWN0b3J5TGlzdGluZ3MsIEJvb2wsIGJvb2wsIGZhbHNlKSBcCiAgICAg
bWFjcm8oVGFic1RvTGlua3MsIHRhYnNUb0xpbmtzLCBCb29sLCBib29sLCBmYWxzZSkgXAogICAg
IG1hY3JvKEROU1ByZWZldGNoaW5nRW5hYmxlZCwgZG5zUHJlZmV0Y2hpbmdFbmFibGVkLCBCb29s
LCBib29sLCBmYWxzZSkgXAo=
</data>
<flag name="review"
          id="86463"
          type_id="1"
          status="-"
          setter="kling"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>93807</attachid>
            <date>2011-05-17 12:28:03 -0700</date>
            <delta_ts>2011-05-18 11:26:33 -0700</delta_ts>
            <desc>Removing the webgl enabler for wk2</desc>
            <filename>gl-uniformm-arrays_1.patch</filename>
            <type>text/plain</type>
            <size>2208</size>
            <attacher name="Idrees">sidreesshah</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCAxNjFhZTRmLi5iYmJhN2JiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg
QEAKKzIwMTEtMDUtMTIgIFN5ZWQgSWRyaXMgU2hhaCAgPHN5ZWQuaWRyaXMtc2hhaEBub2tpYS5j
b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1dL
Ml1bUXRdIGZhc3QvY2FudmFzL3dlYmdsL2dsLXVuaWZvcm0tYXJyYXlzLmh0bWwgZmFpbGluZyBm
b3IgUXQgb24gTGludXgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTYwMzc3IAorCisgICAgICAgIExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2ds
LXVuaWZvcm0tYXJyYXlzLmh0bWwKKworICAgICAgICAqIGh0bWwvY2FudmFzL1dlYkdMUmVuZGVy
aW5nQ29udGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXZWJHTFJlbmRlcmluZ0NvbnRleHQ6
OmdldFVuaWZvcm0pOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29u
dGV4dDNEUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0M0Q6OnVzZVBy
b2dyYW0pOgorCiAyMDExLTA1LTEyICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAK
ICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi
Q29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwIGIvU291cmNlL1dlYkNv
cmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcAppbmRleCA4OTM2OWVhLi44
MDc2YTc5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRl
cmluZ0NvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVu
ZGVyaW5nQ29udGV4dC5jcHAKQEAgLTI0NDEsNyArMjQ0MSw3IEBAIFdlYkdMR2V0SW5mbyBXZWJH
TFJlbmRlcmluZ0NvbnRleHQ6OmdldFVuaWZvcm0oV2ViR0xQcm9ncmFtKiBwcm9ncmFtLCBjb25z
dCBXZWJHCiAgICAgICAgIGlmICghbV9jb250ZXh0LT5nZXRBY3RpdmVVbmlmb3JtKG9iamVjdE9y
WmVybyhwcm9ncmFtKSwgaSwgaW5mbykpCiAgICAgICAgICAgICByZXR1cm4gV2ViR0xHZXRJbmZv
KCk7CiAgICAgICAgIC8vIFN0cmlwICJbMF0iIGZyb20gdGhlIG5hbWUgaWYgaXQncyBhbiBhcnJh
eS4KLSAgICAgICAgaWYgKGluZm8uc2l6ZSA+IDEpCisgICAgICAgIGlmIChpbmZvLnNpemUgPiAx
ICYmIGluZm8ubmFtZS5lbmRzV2l0aCgiWzBdIikpCiAgICAgICAgICAgICBpbmZvLm5hbWUgPSBp
bmZvLm5hbWUubGVmdChpbmZvLm5hbWUubGVuZ3RoKCkgLSAzKTsKICAgICAgICAgLy8gSWYgaXQn
cyBhbiBhcnJheSwgd2UgbmVlZCB0byBpdGVyYXRlIHRocm91Z2ggZWFjaCBlbGVtZW50LCBhcHBl
bmRpbmcgIltpbmRleF0iIHRvIHRoZSBuYW1lLgogICAgICAgICBmb3IgKEdDM0RpbnQgaW5kZXgg
PSAwOyBpbmRleCA8IGluZm8uc2l6ZTsgKytpbmRleCkgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dl
YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0M0RRdC5jcHAgYi9Tb3Vy
Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHQzRFF0LmNwcApp
bmRleCA2ZmY3MGM0Li44YmQ4YjkyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y
bS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHQzRFF0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y
ZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHQzRFF0LmNwcApAQCAtMTQ0NSw3
ICsxNDQ1LDYgQEAgdm9pZCBHcmFwaGljc0NvbnRleHQzRDo6dW5pZm9ybU1hdHJpeDRmdihHQzNE
aW50IGxvY2F0aW9uLCBHQzNEYm9vbGVhbiB0cmFuc3Bvc2UKIAogdm9pZCBHcmFwaGljc0NvbnRl
eHQzRDo6dXNlUHJvZ3JhbShQbGF0Zm9ybTNET2JqZWN0IHByb2dyYW0pCiB7Ci0gICAgQVNTRVJU
KHByb2dyYW0pOwogICAgIAogICAgIG1faW50ZXJuYWwtPm1fZ2xXaWRnZXQtPm1ha2VDdXJyZW50
KCk7CiAgICAgbV9pbnRlcm5hbC0+dXNlUHJvZ3JhbShwcm9ncmFtKTsK
</data>
<flag name="review"
          id="87031"
          type_id="1"
          status="-"
          setter="benjamin"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>93949</attachid>
            <date>2011-05-18 11:26:33 -0700</date>
            <delta_ts>2011-05-18 11:34:54 -0700</delta_ts>
            <desc>Another patch for fix</desc>
            <filename>gl-uniformm-arrays_2.patch</filename>
            <type>text/plain</type>
            <size>2281</size>
            <attacher name="Idrees">sidreesshah</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCBhZGI1Mjg5Li4wYjQ4YjZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg
QEAKKzIwMTEtMDUtMTggIFN5ZWQgSWRyaXMgU2hhaCAgPHN5ZWQuaWRyaXMtc2hhaEBub2tpYS5j
b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0
XSBmYXN0L2NhbnZhcy93ZWJnbC9nbC11bmlmb3JtLWFycmF5cy5odG1sIGZhaWxpbmcgZm9yIFF0
IG9uIExpbnV4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD02MDM3NyAKKworICAgICAgICBMYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9nbC11bmlm
b3JtLWFycmF5cy5odG1sCisKKyAgICAgICAgKiBodG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0Nv
bnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V2ViR0xSZW5kZXJpbmdDb250ZXh0OjpnZXRV
bmlmb3JtKTogU3RyaXAgIlswXSIgZnJvbSB0aGUgbmFtZSBpZiBpdCdzIGFuIGFycmF5LgorICAg
ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dDNEUXQuY3BwOgorICAg
ICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0M0Q6OnVzZVByb2dyYW0pOiBQcm9ncmFtIGNh
biBiZSBudWxsLiBSZW1vdmluZyBhc3NlcnQuCisKIDIwMTEtMDUtMTYgIEFkYW0gQmFydGggIDxh
YmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlm
ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4
dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQu
Y3BwCmluZGV4IDYxOWQ5NjkuLmNhNTMxYTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0
bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv
aHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcApAQCAtMjQ0Myw3ICsyNDQzLDcg
QEAgV2ViR0xHZXRJbmZvIFdlYkdMUmVuZGVyaW5nQ29udGV4dDo6Z2V0VW5pZm9ybShXZWJHTFBy
b2dyYW0qIHByb2dyYW0sIGNvbnN0IFdlYkcKICAgICAgICAgaWYgKCFtX2NvbnRleHQtPmdldEFj
dGl2ZVVuaWZvcm0ob2JqZWN0T3JaZXJvKHByb2dyYW0pLCBpLCBpbmZvKSkKICAgICAgICAgICAg
IHJldHVybiBXZWJHTEdldEluZm8oKTsKICAgICAgICAgLy8gU3RyaXAgIlswXSIgZnJvbSB0aGUg
bmFtZSBpZiBpdCdzIGFuIGFycmF5LgotICAgICAgICBpZiAoaW5mby5zaXplID4gMSkKKwlpZiAo
aW5mby5zaXplID4gMSAmJiBpbmZvLm5hbWUuZW5kc1dpdGgoIlswXSIpKQogICAgICAgICAgICAg
aW5mby5uYW1lID0gaW5mby5uYW1lLmxlZnQoaW5mby5uYW1lLmxlbmd0aCgpIC0gMyk7CiAgICAg
ICAgIC8vIElmIGl0J3MgYW4gYXJyYXksIHdlIG5lZWQgdG8gaXRlcmF0ZSB0aHJvdWdoIGVhY2gg
ZWxlbWVudCwgYXBwZW5kaW5nICJbaW5kZXhdIiB0byB0aGUgbmFtZS4KICAgICAgICAgZm9yIChH
QzNEaW50IGluZGV4ID0gMDsgaW5kZXggPCBpbmZvLnNpemU7ICsraW5kZXgpIHsKZGlmZiAtLWdp
dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dDNE
UXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250
ZXh0M0RRdC5jcHAKaW5kZXggNWNjMjc1MC4uN2JiODQ2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dl
YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0M0RRdC5jcHAKKysrIGIv
U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0M0RRdC5j
cHAKQEAgLTE0NDUsOCArMTQ0NSw2IEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0M0Q6OnVuaWZvcm1N
YXRyaXg0ZnYoR0MzRGludCBsb2NhdGlvbiwgR0MzRGJvb2xlYW4gdHJhbnNwb3NlCiAKIHZvaWQg
R3JhcGhpY3NDb250ZXh0M0Q6OnVzZVByb2dyYW0oUGxhdGZvcm0zRE9iamVjdCBwcm9ncmFtKQog
ewotICAgIEFTU0VSVChwcm9ncmFtKTsKLSAgICAKICAgICBtX2ludGVybmFsLT5tX2dsV2lkZ2V0
LT5tYWtlQ3VycmVudCgpOwogICAgIG1faW50ZXJuYWwtPnVzZVByb2dyYW0ocHJvZ3JhbSk7CiB9
Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>93952</attachid>
            <date>2011-05-18 11:34:54 -0700</date>
            <delta_ts>2011-05-24 09:03:00 -0700</delta_ts>
            <desc>Another patch for fix</desc>
            <filename>gl-uniformm-arrays_2.patch</filename>
            <type>text/plain</type>
            <size>2288</size>
            <attacher name="Idrees">sidreesshah</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCBhZGI1Mjg5Li4wYjQ4YjZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg
QEAKKzIwMTEtMDUtMTggIFN5ZWQgSWRyaXMgU2hhaCAgPHN5ZWQuaWRyaXMtc2hhaEBub2tpYS5j
b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0
XSBmYXN0L2NhbnZhcy93ZWJnbC9nbC11bmlmb3JtLWFycmF5cy5odG1sIGZhaWxpbmcgZm9yIFF0
IG9uIExpbnV4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD02MDM3NyAKKworICAgICAgICBMYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9nbC11bmlm
b3JtLWFycmF5cy5odG1sCisKKyAgICAgICAgKiBodG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0Nv
bnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V2ViR0xSZW5kZXJpbmdDb250ZXh0OjpnZXRV
bmlmb3JtKTogU3RyaXAgIlswXSIgZnJvbSB0aGUgbmFtZSBpZiBpdCdzIGFuIGFycmF5LgorICAg
ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dDNEUXQuY3BwOgorICAg
ICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0M0Q6OnVzZVByb2dyYW0pOiBQcm9ncmFtIGNh
biBiZSBudWxsLiBSZW1vdmluZyBhc3NlcnQuCisKIDIwMTEtMDUtMTYgIEFkYW0gQmFydGggIDxh
YmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlm
ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4
dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQu
Y3BwCmluZGV4IDYxOWQ5NjkuLmNhNTMxYTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0
bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv
aHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcApAQCAtMjQ0Myw3ICsyNDQzLDcg
QEAgV2ViR0xHZXRJbmZvIFdlYkdMUmVuZGVyaW5nQ29udGV4dDo6Z2V0VW5pZm9ybShXZWJHTFBy
b2dyYW0qIHByb2dyYW0sIGNvbnN0IFdlYkcKICAgICAgICAgaWYgKCFtX2NvbnRleHQtPmdldEFj
dGl2ZVVuaWZvcm0ob2JqZWN0T3JaZXJvKHByb2dyYW0pLCBpLCBpbmZvKSkKICAgICAgICAgICAg
IHJldHVybiBXZWJHTEdldEluZm8oKTsKICAgICAgICAgLy8gU3RyaXAgIlswXSIgZnJvbSB0aGUg
bmFtZSBpZiBpdCdzIGFuIGFycmF5LgotICAgICAgICBpZiAoaW5mby5zaXplID4gMSkKKyAgICAg
ICAgaWYgKGluZm8uc2l6ZSA+IDEgJiYgaW5mby5uYW1lLmVuZHNXaXRoKCJbMF0iKSkKICAgICAg
ICAgICAgIGluZm8ubmFtZSA9IGluZm8ubmFtZS5sZWZ0KGluZm8ubmFtZS5sZW5ndGgoKSAtIDMp
OwogICAgICAgICAvLyBJZiBpdCdzIGFuIGFycmF5LCB3ZSBuZWVkIHRvIGl0ZXJhdGUgdGhyb3Vn
aCBlYWNoIGVsZW1lbnQsIGFwcGVuZGluZyAiW2luZGV4XSIgdG8gdGhlIG5hbWUuCiAgICAgICAg
IGZvciAoR0MzRGludCBpbmRleCA9IDA7IGluZGV4IDwgaW5mby5zaXplOyArK2luZGV4KSB7CmRp
ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0Nv
bnRleHQzRFF0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBo
aWNzQ29udGV4dDNEUXQuY3BwCmluZGV4IDVjYzI3NTAuLjdiYjg0NjAgMTAwNjQ0Ci0tLSBhL1Nv
dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dDNEUXQuY3Bw
CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4
dDNEUXQuY3BwCkBAIC0xNDQ1LDggKzE0NDUsNiBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDNEOjp1
bmlmb3JtTWF0cml4NGZ2KEdDM0RpbnQgbG9jYXRpb24sIEdDM0Rib29sZWFuIHRyYW5zcG9zZQog
CiB2b2lkIEdyYXBoaWNzQ29udGV4dDNEOjp1c2VQcm9ncmFtKFBsYXRmb3JtM0RPYmplY3QgcHJv
Z3JhbSkKIHsKLSAgICBBU1NFUlQocHJvZ3JhbSk7Ci0gICAgCiAgICAgbV9pbnRlcm5hbC0+bV9n
bFdpZGdldC0+bWFrZUN1cnJlbnQoKTsKICAgICBtX2ludGVybmFsLT51c2VQcm9ncmFtKHByb2dy
YW0pOwogfQo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>94081</attachid>
            <date>2011-05-19 10:03:14 -0700</date>
            <delta_ts>2011-05-24 09:03:00 -0700</delta_ts>
            <desc>More description about the issue in changelog</desc>
            <filename>gl-uniformm-arrays_2.patch</filename>
            <type>text/plain</type>
            <size>2730</size>
            <attacher name="Idrees">sidreesshah</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCBhZGI1Mjg5Li40YTRkMWE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQg
QEAKKzIwMTEtMDUtMTggIFN5ZWQgSWRyaXMgU2hhaCAgPHN5ZWQuaWRyaXMtc2hhaEBub2tpYS5j
b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0
XSBmYXN0L2NhbnZhcy93ZWJnbC9nbC11bmlmb3JtLWFycmF5cy5odG1sIGZhaWxpbmcgZm9yIFF0
IG9uIExpbnV4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD02MDM3NyAKKworICAgICAgICBMYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9nbC11bmlm
b3JtLWFycmF5cy5odG1sCisKKyAgICAgICAgZm9yIGFuIGFycmF5IG9mIGFjdGl2ZSB1bmlmb3Jt
LCB3ZSBjYW4gcmVjZWl2ZSBqdXN0IGEgbmFtZSB3aXRob3V0IAorICAgICAgICBhcnJheSBicmFj
ZXMuIEN1cnJlbnRseSBpIGRvbm90IHNlZSBhbnkgWzBdIGluIHRoZSBhY3RpdmUgdW5pZm9ybSBh
cnJheXMgbmFtZSAKKyAgICAgICAgYW5kIGFzIGEgcmVzdWx0IHdlIHdlcmUgdHJ1Y2F0aW5nIHRo
ZSB0aGUgYWN0dWFsIG5hbWUgb2YgdGhlIGFjdGl2ZSB1bmlmb3Jtcy4gCisgICAgICAgIGJlZm9y
ZSBzdHJpcGluZyAiWzBdIiB3ZSBuZWVkIHRvIG1ha2Ugc3VyZSB0aGF0IGl0IGlzIHRoZXJlIGlu
IHRoZSBuYW1lLgorCisgICAgICAgIEFsc28gd2UgZG8gbm90IG5lZWQgYXNzZXJ0IGZvciB0aGUg
dXNlUHJvZ3JhbSBhcyBwcm9ncmFtIGNhbiBiZSBudWxsLgorCisgICAgICAgICogaHRtbC9jYW52
YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldlYkdMUmVu
ZGVyaW5nQ29udGV4dDo6Z2V0VW5pZm9ybSk6IFN0cmlwICJbMF0iIGZyb20gdGhlIG5hbWUgaWYg
aXQncyBhbiBhcnJheSBhbmQgaXMgcGFydCBvZiB0aGUgbmFtZS4KKyAgICAgICAgKiBwbGF0Zm9y
bS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHQzRFF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6
OkdyYXBoaWNzQ29udGV4dDNEOjp1c2VQcm9ncmFtKTogUHJvZ3JhbSBjYW4gYmUgbnVsbC4gUmVt
b3ZpbmcgYXNzZXJ0LgorCiAyMDExLTA1LTE2ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5v
cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9Tb3Vy
Y2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwIGIvU291cmNl
L1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcAppbmRleCA2MTlk
OTY5Li5kOGFlZmVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJH
TFJlbmRlcmluZ0NvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dl
YkdMUmVuZGVyaW5nQ29udGV4dC5jcHAKQEAgLTI0NDMsNyArMjQ0Myw3IEBAIFdlYkdMR2V0SW5m
byBXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OmdldFVuaWZvcm0oV2ViR0xQcm9ncmFtKiBwcm9ncmFt
LCBjb25zdCBXZWJHCiAgICAgICAgIGlmICghbV9jb250ZXh0LT5nZXRBY3RpdmVVbmlmb3JtKG9i
amVjdE9yWmVybyhwcm9ncmFtKSwgaSwgaW5mbykpCiAgICAgICAgICAgICByZXR1cm4gV2ViR0xH
ZXRJbmZvKCk7CiAgICAgICAgIC8vIFN0cmlwICJbMF0iIGZyb20gdGhlIG5hbWUgaWYgaXQncyBh
biBhcnJheS4KLSAgICAgICAgaWYgKGluZm8uc2l6ZSA+IDEpCisgICAgICAgIGlmIChpbmZvLnNp
emUgPiAxICYmIGluZm8ubmFtZS5lbmRzV2l0aCgiWzBdIikpCiAgICAgICAgICAgICBpbmZvLm5h
bWUgPSBpbmZvLm5hbWUubGVmdChpbmZvLm5hbWUubGVuZ3RoKCkgLSAzKTsKICAgICAgICAgLy8g
SWYgaXQncyBhbiBhcnJheSwgd2UgbmVlZCB0byBpdGVyYXRlIHRocm91Z2ggZWFjaCBlbGVtZW50
LCBhcHBlbmRpbmcgIltpbmRleF0iIHRvIHRoZSBuYW1lLgogICAgICAgICBmb3IgKEdDM0RpbnQg
aW5kZXggPSAwOyBpbmRleCA8IGluZm8uc2l6ZTsgKytpbmRleCkgewpkaWZmIC0tZ2l0IGEvU291
cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0M0RRdC5jcHAg
Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHQzRFF0
LmNwcAppbmRleCA1Y2MyNzUwLi43YmI4NDYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w
bGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHQzRFF0LmNwcAorKysgYi9Tb3VyY2Uv
V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHQzRFF0LmNwcApAQCAt
MTQ0NSw4ICsxNDQ1LDYgQEAgdm9pZCBHcmFwaGljc0NvbnRleHQzRDo6dW5pZm9ybU1hdHJpeDRm
dihHQzNEaW50IGxvY2F0aW9uLCBHQzNEYm9vbGVhbiB0cmFuc3Bvc2UKIAogdm9pZCBHcmFwaGlj
c0NvbnRleHQzRDo6dXNlUHJvZ3JhbShQbGF0Zm9ybTNET2JqZWN0IHByb2dyYW0pCiB7Ci0gICAg
QVNTRVJUKHByb2dyYW0pOwotICAgIAogICAgIG1faW50ZXJuYWwtPm1fZ2xXaWRnZXQtPm1ha2VD
dXJyZW50KCk7CiAgICAgbV9pbnRlcm5hbC0+dXNlUHJvZ3JhbShwcm9ncmFtKTsKIH0K
</data>
<flag name="review"
          id="87336"
          type_id="1"
          status="-"
          setter="menard"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>94622</attachid>
            <date>2011-05-24 09:03:00 -0700</date>
            <delta_ts>2011-05-24 10:21:47 -0700</delta_ts>
            <desc>Fixing typos.</desc>
            <filename>gl-uniformm-arrays_2.patch</filename>
            <type>text/plain</type>
            <size>2732</size>
            <attacher name="Idrees">sidreesshah</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCBhZGI1Mjg5Li40YTRkMWE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQg
QEAKKzIwMTEtMDUtMTggIFN5ZWQgSWRyaXMgU2hhaCAgPHN5ZWQuaWRyaXMtc2hhaEBub2tpYS5j
b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0
XSBmYXN0L2NhbnZhcy93ZWJnbC9nbC11bmlmb3JtLWFycmF5cy5odG1sIGZhaWxpbmcgZm9yIFF0
IG9uIExpbnV4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD02MDM3NyAKKworICAgICAgICBMYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9nbC11bmlm
b3JtLWFycmF5cy5odG1sCisKKyAgICAgICAgRm9yIGFuIGFycmF5IG9mIGFjdGl2ZSB1bmlmb3Jt
LCB3ZSBjYW4gcmVjZWl2ZSBqdXN0IGEgbmFtZSB3aXRob3V0IAorICAgICAgICBhcnJheSBicmFj
ZXMuIEN1cnJlbnRseSBpIGRvIG5vdCBzZWUgYW55IFswXSBpbiB0aGUgYWN0aXZlIHVuaWZvcm0g
YXJyYXlzIG5hbWUgCisgICAgICAgIGFuZCBhcyBhIHJlc3VsdCB3ZSB3ZXJlIHRydW5jYXRpbmcg
dGhlIHRoZSBhY3R1YWwgbmFtZSBvZiB0aGUgYWN0aXZlIHVuaWZvcm1zLiAKKyAgICAgICAgYmVm
b3JlIHN0cmlwaW5nICJbMF0iIHdlIG5lZWQgdG8gbWFrZSBzdXJlIHRoYXQgaXQgaXMgdGhlcmUg
aW4gdGhlIG5hbWUuCisKKyAgICAgICAgQWxzbyB3ZSBkbyBub3QgbmVlZCBhc3NlcnQgZm9yIHRo
ZSB1c2VQcm9ncmFtIGFzIHByb2dyYW0gY2FuIGJlIG51bGwuCisKKyAgICAgICAgKiBodG1sL2Nh
bnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V2ViR0xS
ZW5kZXJpbmdDb250ZXh0OjpnZXRVbmlmb3JtKTogU3RyaXAgIlswXSIgZnJvbSB0aGUgbmFtZSBp
ZiBpdCdzIGFuIGFycmF5IGFuZCBpcyBwYXJ0IG9mIHRoZSBuYW1lLgorICAgICAgICAqIHBsYXRm
b3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dDNEUXQuY3BwOgorICAgICAgICAoV2ViQ29y
ZTo6R3JhcGhpY3NDb250ZXh0M0Q6OnVzZVByb2dyYW0pOiBQcm9ncmFtIGNhbiBiZSBudWxsLiBS
ZW1vdmluZyBhc3NlcnQuCisKIDIwMTEtMDUtMTYgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0
Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL1Nv
dXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAgYi9Tb3Vy
Y2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwCmluZGV4IDYx
OWQ5NjkuLmQ4YWVmZWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dl
YkdMUmVuZGVyaW5nQ29udGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMv
V2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcApAQCAtMjQ0Myw3ICsyNDQzLDcgQEAgV2ViR0xHZXRJ
bmZvIFdlYkdMUmVuZGVyaW5nQ29udGV4dDo6Z2V0VW5pZm9ybShXZWJHTFByb2dyYW0qIHByb2dy
YW0sIGNvbnN0IFdlYkcKICAgICAgICAgaWYgKCFtX2NvbnRleHQtPmdldEFjdGl2ZVVuaWZvcm0o
b2JqZWN0T3JaZXJvKHByb2dyYW0pLCBpLCBpbmZvKSkKICAgICAgICAgICAgIHJldHVybiBXZWJH
TEdldEluZm8oKTsKICAgICAgICAgLy8gU3RyaXAgIlswXSIgZnJvbSB0aGUgbmFtZSBpZiBpdCdz
IGFuIGFycmF5LgotICAgICAgICBpZiAoaW5mby5zaXplID4gMSkKKyAgICAgICAgaWYgKGluZm8u
c2l6ZSA+IDEgJiYgaW5mby5uYW1lLmVuZHNXaXRoKCJbMF0iKSkKICAgICAgICAgICAgIGluZm8u
bmFtZSA9IGluZm8ubmFtZS5sZWZ0KGluZm8ubmFtZS5sZW5ndGgoKSAtIDMpOwogICAgICAgICAv
LyBJZiBpdCdzIGFuIGFycmF5LCB3ZSBuZWVkIHRvIGl0ZXJhdGUgdGhyb3VnaCBlYWNoIGVsZW1l
bnQsIGFwcGVuZGluZyAiW2luZGV4XSIgdG8gdGhlIG5hbWUuCiAgICAgICAgIGZvciAoR0MzRGlu
dCBpbmRleCA9IDA7IGluZGV4IDwgaW5mby5zaXplOyArK2luZGV4KSB7CmRpZmYgLS1naXQgYS9T
b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHQzRFF0LmNw
cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dDNE
UXQuY3BwCmluZGV4IDVjYzI3NTAuLjdiYjg0NjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl
L3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dDNEUXQuY3BwCisrKyBiL1NvdXJj
ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dDNEUXQuY3BwCkBA
IC0xNDQ1LDggKzE0NDUsNiBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDNEOjp1bmlmb3JtTWF0cml4
NGZ2KEdDM0RpbnQgbG9jYXRpb24sIEdDM0Rib29sZWFuIHRyYW5zcG9zZQogCiB2b2lkIEdyYXBo
aWNzQ29udGV4dDNEOjp1c2VQcm9ncmFtKFBsYXRmb3JtM0RPYmplY3QgcHJvZ3JhbSkKIHsKLSAg
ICBBU1NFUlQocHJvZ3JhbSk7Ci0gICAgCiAgICAgbV9pbnRlcm5hbC0+bV9nbFdpZGdldC0+bWFr
ZUN1cnJlbnQoKTsKICAgICBtX2ludGVybmFsLT51c2VQcm9ncmFtKHByb2dyYW0pOwogfQo=
</data>
<flag name="review"
          id="87947"
          type_id="1"
          status="-"
          setter="kling"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>94631</attachid>
            <date>2011-05-24 10:04:28 -0700</date>
            <delta_ts>2011-05-24 14:47:39 -0700</delta_ts>
            <desc>Assenrtion not needed patch.</desc>
            <filename>gl-uniformm-arrays_null.patch</filename>
            <type>text/plain</type>
            <size>1359</size>
            <attacher name="Idrees">sidreesshah</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCBhZGI1Mjg5Li5kZGM2OWYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg
QEAKKzIwMTEtMDUtMjQgIFN5ZWQgSWRyaXMgU2hhaCAgPHN5ZWQuaWRyaXMtc2hhaEBub2tpYS5j
b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0
XSBmYXN0L2NhbnZhcy93ZWJnbC9nbC11bmlmb3JtLWFycmF5cy5odG1sIGZhaWxpbmcgZm9yIFF0
IG9uIExpbnV4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD02MDM3NyAKKworICAgICAgICBMYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9nbC11bmlm
b3JtLWFycmF5cy5odG1sCisKKyAgICAgICAgV2UgZG8gbm90IG5lZWQgYXNzZXJ0IGZvciB0aGUg
dXNlUHJvZ3JhbSBhcyBwcm9ncmFtIGNhbiBiZSBudWxsLgorCisgICAgICAgICogcGxhdGZvcm0v
Z3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0M0RRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpH
cmFwaGljc0NvbnRleHQzRDo6dXNlUHJvZ3JhbSk6IFByb2dyYW0gY2FuIGJlIG51bGwuIFJlbW92
aW5nIGFzc2VydC4KKwogMjAxMS0wNS0xNiAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3Jn
PgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvU291cmNl
L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0M0RRdC5jcHAgYi9T
b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHQzRFF0LmNw
cAppbmRleCA1Y2MyNzUwLi43YmI4NDYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0
Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHQzRFF0LmNwcAorKysgYi9Tb3VyY2UvV2Vi
Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHQzRFF0LmNwcApAQCAtMTQ0
NSw4ICsxNDQ1LDYgQEAgdm9pZCBHcmFwaGljc0NvbnRleHQzRDo6dW5pZm9ybU1hdHJpeDRmdihH
QzNEaW50IGxvY2F0aW9uLCBHQzNEYm9vbGVhbiB0cmFuc3Bvc2UKIAogdm9pZCBHcmFwaGljc0Nv
bnRleHQzRDo6dXNlUHJvZ3JhbShQbGF0Zm9ybTNET2JqZWN0IHByb2dyYW0pCiB7Ci0gICAgQVNT
RVJUKHByb2dyYW0pOwotICAgIAogICAgIG1faW50ZXJuYWwtPm1fZ2xXaWRnZXQtPm1ha2VDdXJy
ZW50KCk7CiAgICAgbV9pbnRlcm5hbC0+dXNlUHJvZ3JhbShwcm9ncmFtKTsKIH0K
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>94633</attachid>
            <date>2011-05-24 10:05:39 -0700</date>
            <delta_ts>2011-05-24 10:21:47 -0700</delta_ts>
            <desc>array name should be checked before removing the [0].</desc>
            <filename>gl-uniformm-arrays_uniform.patch</filename>
            <type>text/plain</type>
            <size>1898</size>
            <attacher name="Idrees">sidreesshah</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCBhZGI1Mjg5Li5mNmE2ZmFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzMg
QEAKKzIwMTEtMDUtMjQgIFN5ZWQgSWRyaXMgU2hhaCAgPHN5ZWQuaWRyaXMtc2hhaEBub2tpYS5j
b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0
XSBmYXN0L2NhbnZhcy93ZWJnbC9nbC11bmlmb3JtLWFycmF5cy5odG1sIGZhaWxpbmcgZm9yIFF0
IG9uIExpbnV4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD02MDM3NyAKKworICAgICAgICBMYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9nbC11bmlm
b3JtLWFycmF5cy5odG1sCisJCisgICAgICAgIEZvciBhbiBhcnJheSBvZiBhY3RpdmUgdW5pZm9y
bSwgd2Ugc2hvdWxkIGJlIGNhcmVmdWwgd2hpbGUgdHJ1bmNhdGluZyB0aGUgbmFtZSBvZiB0aGUg
dW5pZm9ybS4gCisgICAgICAgIEN1cnJlbnRseSB3ZSBhcmUgdHJ1bmNhdGluZyB0aGUgbGFzdCB0
aHJlZSBjaGFyYWN0ZXJzIG9mIGFuIGFycmF5IHdpdGggb3V0IGNoZWNraW5nIGZvciBbMF0uIAor
ICAgICAgICBBcyBhIHJlc3VsdCB3ZSBhcmUgdHJ1bmNhdGluZyB0aGUgdGhlIGFjdHVhbCBuYW1l
IG9mIHRoZSBhY3RpdmUgdW5pZm9ybXMgaS5lLiBjb2xvciB0byBjby4gCisKKyAgICAgICAgKiBo
dG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6
V2ViR0xSZW5kZXJpbmdDb250ZXh0OjpnZXRVbmlmb3JtKTogU3RyaXAgIlswXSIgZnJvbSB0aGUg
bmFtZSBpZiBpdCdzIGFuIGFycmF5IGFuZCBpcyBwYXJ0IG9mIHRoZSBuYW1lLgorCiAyMDExLTA1
LTE2ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg
YnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9X
ZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2Vi
R0xSZW5kZXJpbmdDb250ZXh0LmNwcAppbmRleCA2MTlkOTY5Li5kOGFlZmVlIDEwMDY0NAotLS0g
YS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwCisr
KyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAK
QEAgLTI0NDMsNyArMjQ0Myw3IEBAIFdlYkdMR2V0SW5mbyBXZWJHTFJlbmRlcmluZ0NvbnRleHQ6
OmdldFVuaWZvcm0oV2ViR0xQcm9ncmFtKiBwcm9ncmFtLCBjb25zdCBXZWJHCiAgICAgICAgIGlm
ICghbV9jb250ZXh0LT5nZXRBY3RpdmVVbmlmb3JtKG9iamVjdE9yWmVybyhwcm9ncmFtKSwgaSwg
aW5mbykpCiAgICAgICAgICAgICByZXR1cm4gV2ViR0xHZXRJbmZvKCk7CiAgICAgICAgIC8vIFN0
cmlwICJbMF0iIGZyb20gdGhlIG5hbWUgaWYgaXQncyBhbiBhcnJheS4KLSAgICAgICAgaWYgKGlu
Zm8uc2l6ZSA+IDEpCisgICAgICAgIGlmIChpbmZvLnNpemUgPiAxICYmIGluZm8ubmFtZS5lbmRz
V2l0aCgiWzBdIikpCiAgICAgICAgICAgICBpbmZvLm5hbWUgPSBpbmZvLm5hbWUubGVmdChpbmZv
Lm5hbWUubGVuZ3RoKCkgLSAzKTsKICAgICAgICAgLy8gSWYgaXQncyBhbiBhcnJheSwgd2UgbmVl
ZCB0byBpdGVyYXRlIHRocm91Z2ggZWFjaCBlbGVtZW50LCBhcHBlbmRpbmcgIltpbmRleF0iIHRv
IHRoZSBuYW1lLgogICAgICAgICBmb3IgKEdDM0RpbnQgaW5kZXggPSAwOyBpbmRleCA8IGluZm8u
c2l6ZTsgKytpbmRleCkgewo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>94636</attachid>
            <date>2011-05-24 10:21:47 -0700</date>
            <delta_ts>2011-05-24 10:23:35 -0700</delta_ts>
            <desc>Another try for name checking patch</desc>
            <filename>gl-uniformm-arrays_uniform.patch</filename>
            <type>text/plain</type>
            <size>1898</size>
            <attacher name="Idrees">sidreesshah</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCBhZGI1Mjg5Li43MTVhMzZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg
QEAKKzIwMTEtMDUtMjQgIFN5ZWQgSWRyaXMgU2hhaCAgPHN5ZWQuaWRyaXMtc2hhaEBub2tpYS5j
b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0
XSBmYXN0L2NhbnZhcy93ZWJnbC9nbC11bmlmb3JtLWFycmF5cy5odG1sIGZhaWxpbmcgZm9yIFF0
IG9uIExpbnV4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD02MDM3NyAKKworICAgICAgICBMYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9nbC11bmlm
b3JtLWFycmF5cy5odG1sCisJCisgICAgICAgIEZvciBhbiBhcnJheSBvZiBhY3RpdmUgdW5pZm9y
bSwgd2Ugc2hvdWxkIGJlIGNhcmVmdWwgd2hpbGUgdHJ1bmNhdGluZyB0aGUgbmFtZSBvZiB0aGUg
dW5pZm9ybS4gCisgICAgICAgIEN1cnJlbnRseSB3ZSBhcmUgdHJ1bmNhdGluZyB0aGUgbGFzdCB0
aHJlZSBjaGFyYWN0ZXJzIG9mIGFuIGFycmF5IHdpdGggb3V0IGNoZWNraW5nIGZvciBbMF0uIAor
ICAgICAgICBBcyBhIHJlc3VsdCB3ZSBhcmUgdHJ1bmNhdGluZyB0aGUgdGhlIGFjdHVhbCBuYW1l
IG9mIHRoZSBhY3RpdmUgdW5pZm9ybXMgaS5lLiBjb2xvciB0byBjby4gCisKKyAgICAgICAgKiBo
dG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6
V2ViR0xSZW5kZXJpbmdDb250ZXh0OjpnZXRVbmlmb3JtKTogU3RyaXAgIlswXSIgZnJvbSB0aGUg
bmFtZSBpZiBpdCdzIGFuIGFycmF5IGFuZCBpcyBwYXJ0IG9mIHRoZSBuYW1lLgorCiAyMDExLTA1
LTE2ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg
YnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9X
ZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2Vi
R0xSZW5kZXJpbmdDb250ZXh0LmNwcAppbmRleCA2MTlkOTY5Li5kOGFlZmVlIDEwMDY0NAotLS0g
YS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwCisr
KyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAK
QEAgLTI0NDMsNyArMjQ0Myw3IEBAIFdlYkdMR2V0SW5mbyBXZWJHTFJlbmRlcmluZ0NvbnRleHQ6
OmdldFVuaWZvcm0oV2ViR0xQcm9ncmFtKiBwcm9ncmFtLCBjb25zdCBXZWJHCiAgICAgICAgIGlm
ICghbV9jb250ZXh0LT5nZXRBY3RpdmVVbmlmb3JtKG9iamVjdE9yWmVybyhwcm9ncmFtKSwgaSwg
aW5mbykpCiAgICAgICAgICAgICByZXR1cm4gV2ViR0xHZXRJbmZvKCk7CiAgICAgICAgIC8vIFN0
cmlwICJbMF0iIGZyb20gdGhlIG5hbWUgaWYgaXQncyBhbiBhcnJheS4KLSAgICAgICAgaWYgKGlu
Zm8uc2l6ZSA+IDEpCisgICAgICAgIGlmIChpbmZvLnNpemUgPiAxICYmIGluZm8ubmFtZS5lbmRz
V2l0aCgiWzBdIikpCiAgICAgICAgICAgICBpbmZvLm5hbWUgPSBpbmZvLm5hbWUubGVmdChpbmZv
Lm5hbWUubGVuZ3RoKCkgLSAzKTsKICAgICAgICAgLy8gSWYgaXQncyBhbiBhcnJheSwgd2UgbmVl
ZCB0byBpdGVyYXRlIHRocm91Z2ggZWFjaCBlbGVtZW50LCBhcHBlbmRpbmcgIltpbmRleF0iIHRv
IHRoZSBuYW1lLgogICAgICAgICBmb3IgKEdDM0RpbnQgaW5kZXggPSAwOyBpbmRleCA8IGluZm8u
c2l6ZTsgKytpbmRleCkgewo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>94639</attachid>
            <date>2011-05-24 10:25:35 -0700</date>
            <delta_ts>2011-05-24 10:28:33 -0700</delta_ts>
            <desc>Another try for name checking patch</desc>
            <filename>gl-uniformm-arrays_uniform.patch</filename>
            <type>text/plain</type>
            <size>4693</size>
            <attacher name="Idrees">sidreesshah</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2
YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGUzYWQwNjYuLjQ5NjJhMGUgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD
b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDExLTA1LTI0ICBTeWVkIElkcmlzIFNo
YWggIDxzeWVkLmlkcmlzLXNoYWhAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P
Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE5lZWQgYSBzaG9ydCBkZXNjcmlwdGlvbiBhbmQgYnVn
IFVSTCAoT09QUyEpCisKKyAgICAgICAgKiB3dGYvUGFzc093blB0ci5oOgorCisyMDExLTA1LTI0
ICBTeWVkIElkcmlzIFNoYWggIDxzeWVkLmlkcmlzLXNoYWhAbm9raWEuY29tPgorCisgICAgICAg
IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5lZWQgYSBzaG9ydCBkZXNj
cmlwdGlvbiBhbmQgYnVnIFVSTCAoT09QUyEpCisKKyAgICAgICAgKiB3dGYvUGFzc093blB0ci5o
OgorCiAyMDExLTA1LTE2ICBTaWRkaGFydGggTWF0aHVyICA8c2lkZGhhcnRoLm1hdGh1ckBub2tp
YS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTGFzemxvIEdvbWJvcy4KZGlmZiAtLWdpdCBh
L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvUGFzc093blB0ci5oIGIvU291cmNlL0phdmFTY3Jp
cHRDb3JlL3d0Zi9QYXNzT3duUHRyLmgKaW5kZXggMzYzNWYzYy4uY2UwZGMzNyAxMDA2NDQKLS0t
IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9QYXNzT3duUHRyLmgKKysrIGIvU291cmNlL0ph
dmFTY3JpcHRDb3JlL3d0Zi9QYXNzT3duUHRyLmgKQEAgLTMxLDcgKzMxLDcgQEAKICNpbmNsdWRl
ICJPd25QdHJDb21tb24uaCIKICNpbmNsdWRlICJUeXBlVHJhaXRzLmgiCiAKLSNpZiAhUExBVEZP
Uk0oQ0hST01JVU0pICYmICFQTEFURk9STShXSU4pICYmICFQTEFURk9STShNQUMpICYmICFQTEFU
Rk9STShRVCkKKyNpZiAhUExBVEZPUk0oQ0hST01JVU0pICYmICFQTEFURk9STShXSU4pICYmICFQ
TEFURk9STShNQUMpIAogLy8gUmVtb3ZlIHRoaXMgb25jZSB3ZSBtYWtlIGFsbCBXZWJLaXQgY29k
ZSBjb21wYXRpYmxlIHdpdGggc3RyaWN0ZXIgcnVsZXMgYWJvdXQgUGFzc093blB0ci4KICNkZWZp
bmUgTE9PU0VfUEFTU19PV05fUFRSCiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl
L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhZGI1Mjg5Li42YzNm
NmYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl
YkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDUtMjQgIFN5ZWQgSWRyaXMg
U2hhaCAgPHN5ZWQuaWRyaXMtc2hhaEBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBmYXN0L2NhbnZhcy93ZWJnbC9nbC11bmlm
b3JtLWFycmF5cy5odG1sIGZhaWxpbmcgZm9yIFF0IG9uIExpbnV4CisgICAgICAgIGh0dHBzOi8v
YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MDM3NyAKKworICAgICAgICBMYXlvdXRU
ZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9nbC11bmlmb3JtLWFycmF5cy5odG1sCisKKyAgICAgICAg
Rm9yIGFuIGFycmF5IG9mIGFjdGl2ZSB1bmlmb3JtLCB3ZSBzaG91bGQgYmUgY2FyZWZ1bCB3aGls
ZSB0cnVuY2F0aW5nIHRoZSBuYW1lIG9mIHRoZSB1bmlmb3JtLiAKKyAgICAgICAgQ3VycmVudGx5
IHdlIGFyZSB0cnVuY2F0aW5nIHRoZSBsYXN0IHRocmVlIGNoYXJhY3RlcnMgb2YgYW4gYXJyYXkg
d2l0aCBvdXQgY2hlY2tpbmcgZm9yIFswXS4gCisgICAgICAgIEFzIGEgcmVzdWx0IHdlIGFyZSB0
cnVuY2F0aW5nIHRoZSB0aGUgYWN0dWFsIG5hbWUgb2YgdGhlIGFjdGl2ZSB1bmlmb3JtcyBpLmUu
IGNvbG9yIHRvIGNvLiAKKworICAgICAgICAqIGh0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29u
dGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OmdldFVu
aWZvcm0pOiBTdHJpcCAiWzBdIiBmcm9tIHRoZSBuYW1lIGlmIGl0J3MgYW4gYXJyYXkgYW5kIGlz
IHBhcnQgb2YgdGhlIG5hbWUuCisKIDIwMTEtMDUtMTYgIEFkYW0gQmFydGggIDxhYmFydGhAd2Vi
a2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBh
L1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAgYi9T
b3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwCmluZGV4
IDYxOWQ5NjkuLmQ4YWVmZWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFz
L1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52
YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcApAQCAtMjQ0Myw3ICsyNDQzLDcgQEAgV2ViR0xH
ZXRJbmZvIFdlYkdMUmVuZGVyaW5nQ29udGV4dDo6Z2V0VW5pZm9ybShXZWJHTFByb2dyYW0qIHBy
b2dyYW0sIGNvbnN0IFdlYkcKICAgICAgICAgaWYgKCFtX2NvbnRleHQtPmdldEFjdGl2ZVVuaWZv
cm0ob2JqZWN0T3JaZXJvKHByb2dyYW0pLCBpLCBpbmZvKSkKICAgICAgICAgICAgIHJldHVybiBX
ZWJHTEdldEluZm8oKTsKICAgICAgICAgLy8gU3RyaXAgIlswXSIgZnJvbSB0aGUgbmFtZSBpZiBp
dCdzIGFuIGFycmF5LgotICAgICAgICBpZiAoaW5mby5zaXplID4gMSkKKyAgICAgICAgaWYgKGlu
Zm8uc2l6ZSA+IDEgJiYgaW5mby5uYW1lLmVuZHNXaXRoKCJbMF0iKSkKICAgICAgICAgICAgIGlu
Zm8ubmFtZSA9IGluZm8ubmFtZS5sZWZ0KGluZm8ubmFtZS5sZW5ndGgoKSAtIDMpOwogICAgICAg
ICAvLyBJZiBpdCdzIGFuIGFycmF5LCB3ZSBuZWVkIHRvIGl0ZXJhdGUgdGhyb3VnaCBlYWNoIGVs
ZW1lbnQsIGFwcGVuZGluZyAiW2luZGV4XSIgdG8gdGhlIG5hbWUuCiAgICAgICAgIGZvciAoR0Mz
RGludCBpbmRleCA9IDA7IGluZGV4IDwgaW5mby5zaXplOyArK2luZGV4KSB7CmRpZmYgLS1naXQg
YS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5k
ZXggOTJiNDE1Ny4uYmYxOTY5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9n
CisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDExLTA1
LTI0ICBTeWVkIElkcmlzIFNoYWggIDxzeWVkLmlkcmlzLXNoYWhAbm9raWEuY29tPgorCisgICAg
ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5lZWQgYSBzaG9ydCBk
ZXNjcmlwdGlvbiBhbmQgYnVnIFVSTCAoT09QUyEpCisKKyAgICAgICAgKiBTaGFyZWQvV2ViUHJl
ZmVyZW5jZXNTdG9yZS5oOgorCisyMDExLTA1LTI0ICBTeWVkIElkcmlzIFNoYWggIDxzeWVkLmlk
cmlzLXNoYWhAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp
LgorCisgICAgICAgIE5lZWQgYSBzaG9ydCBkZXNjcmlwdGlvbiBhbmQgYnVnIFVSTCAoT09QUyEp
CisKKyAgICAgICAgKiBTaGFyZWQvV2ViUHJlZmVyZW5jZXNTdG9yZS5oOgorCiAyMDExLTA1LTE2
ICBTaWRkaGFydGggTWF0aHVyICA8c2lkZGhhcnRoLm1hdGh1ckBub2tpYS5jb20+CiAKICAgICAg
ICAgUnViYmVyLXN0YW1wZWQgYnkgQ3NhYmEgT3N6dHJvZ29uw6FjLgpkaWZmIC0tZ2l0IGEvU291
cmNlL1dlYktpdDIvU2hhcmVkL1dlYlByZWZlcmVuY2VzU3RvcmUuaCBiL1NvdXJjZS9XZWJLaXQy
L1NoYXJlZC9XZWJQcmVmZXJlbmNlc1N0b3JlLmgKaW5kZXggMjk0MThmNi4uZTE2NTE3YSAxMDA2
NDQKLS0tIGEvU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYlByZWZlcmVuY2VzU3RvcmUuaAorKysg
Yi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViUHJlZmVyZW5jZXNTdG9yZS5oCkBAIC01OCw3ICs1
OCw3IEBAIG5hbWVzcGFjZSBXZWJLaXQgewogICAgIG1hY3JvKENhbnZhc1VzZXNBY2NlbGVyYXRl
ZERyYXdpbmcsIGNhbnZhc1VzZXNBY2NlbGVyYXRlZERyYXdpbmcsIEJvb2wsIGJvb2wsIHRydWUp
IFwKICAgICBtYWNybyhDb21wb3NpdGluZ0JvcmRlcnNWaXNpYmxlLCBjb21wb3NpdGluZ0JvcmRl
cnNWaXNpYmxlLCBCb29sLCBib29sLCBmYWxzZSkgXAogICAgIG1hY3JvKENvbXBvc2l0aW5nUmVw
YWludENvdW50ZXJzVmlzaWJsZSwgY29tcG9zaXRpbmdSZXBhaW50Q291bnRlcnNWaXNpYmxlLCBC
b29sLCBib29sLCBmYWxzZSkgXAotICAgIG1hY3JvKFdlYkdMRW5hYmxlZCwgd2ViR0xFbmFibGVk
LCBCb29sLCBib29sLCBmYWxzZSkgXAorICAgIG1hY3JvKFdlYkdMRW5hYmxlZCwgd2ViR0xFbmFi
bGVkLCBCb29sLCBib29sLCB0cnVlKSBcCiAgICAgbWFjcm8oRm9yY2VGVFBEaXJlY3RvcnlMaXN0
aW5ncywgZm9yY2VGVFBEaXJlY3RvcnlMaXN0aW5ncywgQm9vbCwgYm9vbCwgZmFsc2UpIFwKICAg
ICBtYWNybyhUYWJzVG9MaW5rcywgdGFic1RvTGlua3MsIEJvb2wsIGJvb2wsIGZhbHNlKSBcCiAg
ICAgbWFjcm8oRE5TUHJlZmV0Y2hpbmdFbmFibGVkLCBkbnNQcmVmZXRjaGluZ0VuYWJsZWQsIEJv
b2wsIGJvb2wsIGZhbHNlKSBcCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>94640</attachid>
            <date>2011-05-24 10:28:33 -0700</date>
            <delta_ts>2011-05-26 16:58:49 -0700</delta_ts>
            <desc>getting crazy. Trying again</desc>
            <filename>gl-uniformm-arrays_uniform.patch</filename>
            <type>text/plain</type>
            <size>1897</size>
            <attacher name="Idrees">sidreesshah</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCBhZGI1Mjg5Li42YzNmNmYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg
QEAKKzIwMTEtMDUtMjQgIFN5ZWQgSWRyaXMgU2hhaCAgPHN5ZWQuaWRyaXMtc2hhaEBub2tpYS5j
b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0
XSBmYXN0L2NhbnZhcy93ZWJnbC9nbC11bmlmb3JtLWFycmF5cy5odG1sIGZhaWxpbmcgZm9yIFF0
IG9uIExpbnV4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD02MDM3NyAKKworICAgICAgICBMYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9nbC11bmlm
b3JtLWFycmF5cy5odG1sCisKKyAgICAgICAgRm9yIGFuIGFycmF5IG9mIGFjdGl2ZSB1bmlmb3Jt
LCB3ZSBzaG91bGQgYmUgY2FyZWZ1bCB3aGlsZSB0cnVuY2F0aW5nIHRoZSBuYW1lIG9mIHRoZSB1
bmlmb3JtLiAKKyAgICAgICAgQ3VycmVudGx5IHdlIGFyZSB0cnVuY2F0aW5nIHRoZSBsYXN0IHRo
cmVlIGNoYXJhY3RlcnMgb2YgYW4gYXJyYXkgd2l0aCBvdXQgY2hlY2tpbmcgZm9yIFswXS4gCisg
ICAgICAgIEFzIGEgcmVzdWx0IHdlIGFyZSB0cnVuY2F0aW5nIHRoZSB0aGUgYWN0dWFsIG5hbWUg
b2YgdGhlIGFjdGl2ZSB1bmlmb3JtcyBpLmUuIGNvbG9yIHRvIGNvLiAKKworICAgICAgICAqIGh0
bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpX
ZWJHTFJlbmRlcmluZ0NvbnRleHQ6OmdldFVuaWZvcm0pOiBTdHJpcCAiWzBdIiBmcm9tIHRoZSBu
YW1lIGlmIGl0J3MgYW4gYXJyYXkgYW5kIGlzIHBhcnQgb2YgdGhlIG5hbWUuCisKIDIwMTEtMDUt
MTYgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi
eSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dl
YkdMUmVuZGVyaW5nQ29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJH
TFJlbmRlcmluZ0NvbnRleHQuY3BwCmluZGV4IDYxOWQ5NjkuLmQ4YWVmZWUgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAKKysr
IGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcApA
QCAtMjQ0Myw3ICsyNDQzLDcgQEAgV2ViR0xHZXRJbmZvIFdlYkdMUmVuZGVyaW5nQ29udGV4dDo6
Z2V0VW5pZm9ybShXZWJHTFByb2dyYW0qIHByb2dyYW0sIGNvbnN0IFdlYkcKICAgICAgICAgaWYg
KCFtX2NvbnRleHQtPmdldEFjdGl2ZVVuaWZvcm0ob2JqZWN0T3JaZXJvKHByb2dyYW0pLCBpLCBp
bmZvKSkKICAgICAgICAgICAgIHJldHVybiBXZWJHTEdldEluZm8oKTsKICAgICAgICAgLy8gU3Ry
aXAgIlswXSIgZnJvbSB0aGUgbmFtZSBpZiBpdCdzIGFuIGFycmF5LgotICAgICAgICBpZiAoaW5m
by5zaXplID4gMSkKKyAgICAgICAgaWYgKGluZm8uc2l6ZSA+IDEgJiYgaW5mby5uYW1lLmVuZHNX
aXRoKCJbMF0iKSkKICAgICAgICAgICAgIGluZm8ubmFtZSA9IGluZm8ubmFtZS5sZWZ0KGluZm8u
bmFtZS5sZW5ndGgoKSAtIDMpOwogICAgICAgICAvLyBJZiBpdCdzIGFuIGFycmF5LCB3ZSBuZWVk
IHRvIGl0ZXJhdGUgdGhyb3VnaCBlYWNoIGVsZW1lbnQsIGFwcGVuZGluZyAiW2luZGV4XSIgdG8g
dGhlIG5hbWUuCiAgICAgICAgIGZvciAoR0MzRGludCBpbmRleCA9IDA7IGluZGV4IDwgaW5mby5z
aXplOyArK2luZGV4KSB7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>