60316 2011-05-05 16:57:24 -0700 Implement document.innerHTML 2012-05-17 11:33:21 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED WONTFIX P2 Enhancement --- 1 aestes webkit-unassigned abarth aestes ap darin eric ian mathias rafaelw oldest_to_newest 399195 0 aestes 2011-05-05 16:57:24 -0700 HTML5 includes an innerHTML attribute in the HTMLDocument interface definition, which should basically behave like the innerHTML on Element. See <http://www.whatwg.org/specs/web-apps/current-work/multipage/apis-in-html-documents.html#dom-innerhtml> for details. The most interesting difference between Document's innerHTML and Element's innerHTML is that the Document case is the only time when parsing a fragment should have no context element. This is important since we have implemented several optimizations to fragment parsing that assume there is always a context element, but there won't be in this case. In a W3C bug discussing context-less fragments, it was mentioned that document.innerHTML is prescriptive, rather than descriptive of existing web content. See <http://www.w3.org/Bugs/Public/show_bug.cgi?id=12031>. 399207 1 92505 aestes 2011-05-05 17:10:05 -0700 Created attachment 92505 Patch 399209 2 92505 eric 2011-05-05 17:11:00 -0700 Comment on attachment 92505 Patch OK. I would have said "if". I'm not sure we want to implement document.innerHTML. 399210 3 aestes 2011-05-05 17:11:19 -0700 (In reply to comment #2) > (From update of attachment 92505 [details]) > OK. I would have said "if". I'm not sure we want to implement document.innerHTML. Sure, I'll change that. 399215 4 aestes 2011-05-05 17:12:52 -0700 Committed r85903: <http://trac.webkit.org/changeset/85903> 399323 5 ap 2011-05-05 22:16:00 -0700 A read-only document.innerHTML would be a handy shortcut for (new XMLSerializer).serializeToString(document). What's the difference between parsing for document.innerHTML setter and DOMParser.parseFromString()? Do we really want them to be different? 399326 6 eric 2011-05-05 22:22:33 -0700 Sounds like a question for Hixie (probably in the w3c bug). 399338 7 ap 2011-05-05 22:41:54 -0700 Note that HTML5 doesn't specify DOMParser and XMLSerializer. 399649 8 ian 2011-05-06 11:11:12 -0700 It's just a convenience accessor so you can replace the contents of an existing document more easily. DOMParser and company are being specced here, FWIW: http://html5.org/specs/dom-parsing.html 423159 9 ap 2011-06-18 12:15:04 -0700 Only a FIXME has been landed, and this bug is still unresolved. 423168 10 ap 2011-06-18 12:22:12 -0700 The reason why I'm asking about DOMParser here is that it works without triggering this assertion. If document.innerHTML is going to trigger it, then maybe its specification is incorrect. 552086 11 mathias 2012-02-08 06:46:29 -0800 The spec has moved to http://html5.org/specs/dom-parsing.html#innerhtml, and sadly, `document.innerHTML` has been removed. 552160 12 eric 2012-02-08 08:46:09 -0800 Yay! So you're saying we can remove this support from the parser. :) (Which should simplify things again.) 626691 13 ap 2012-05-17 10:34:55 -0700 What's the status of this bug now, given bug 84646? 626716 14 rafaelw 2012-05-17 10:52:22 -0700 I'd say it's safe to close it. Document.parse() is now the consensus recommendation for contextless parsing. 626740 15 ap 2012-05-17 11:14:03 -0700 Let's close it then! 626758 16 rafaelw 2012-05-17 11:33:21 -0700 Hazzah! 92505 2011-05-05 17:10:05 -0700 2011-06-18 12:15:11 -0700 Patch bug-60316-20110505171004.patch text/plain 1783 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogODU4OTgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhOTM1MmU3NmRmY2E2Mjdh ZDE2OTllMThhMzE2ZGEwMWU3MTc0Mjc0Li5mYjllMzU2Nzk1N2QwMGM4NjIwZTczOWM0ZTc2NmFh NjhiOTU2ZjE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDUtMDUgIEFuZHkg RXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEltcGxlbWVudCBkb2N1bWVudC5pbm5lckhUTUwKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYwMzE2CisKKyAgICAgICAg QVNTRVJUIHRoYXQgY29udGV4dEVsZW1lbnQgaXMgbm9uLTAgd2hlbiBjb25zdHJ1Y3RpbmcgYSBI VE1MVHJlZUJ1aWxkZXIKKyAgICAgICAgZm9yIGZyYWdtZW50IHBhcnNpbmcuIFRoaXMgYXNzZXJ0 aW9uIHdpbGwgYmVjb21lIGludmFsaWQgd2hlbgorICAgICAgICBkb2N1bWVudC5pbm5lckhUTUwg aXMgaW1wbGVtZW50ZWQsIHdoaWNoIGlzIHRoZSBvbmx5IGNhc2Ugd2hlcmUgSFRNTDUKKyAgICAg ICAgc3BlY2lmaWVzIHRoYXQgYSBmcmFnbWVudCB3aWxsIG5vdCBoYXZlIGEgY29udGV4dCBlbGVt ZW50LgorCisgICAgICAgICogaHRtbC9wYXJzZXIvSFRNTFRyZWVCdWlsZGVyLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkhUTUxUcmVlQnVpbGRlcjo6SFRNTFRyZWVCdWlsZGVyKToKKwogMjAxMS0w NS0wNSAgSnVzdGluIE5vdm9zYWQgIDxqdW5vdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgS2VubmV0aCBSdXNzZWxsLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRt bC9wYXJzZXIvSFRNTFRyZWVCdWlsZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2Vy L0hUTUxUcmVlQnVpbGRlci5jcHAKaW5kZXggNWIxNWNjYWY0YzRmYTVkZjEzZDYwYTJjZTljNTBm NTg2MGE2ZDVkYi4uMThmZDliZDIyYjY1MTIxNWRhN2E4NjA1NjEzNjM5NTliNWJjNWZkMiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTFRyZWVCdWlsZGVyLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MVHJlZUJ1aWxkZXIuY3BwCkBAIC0z NzQsNiArMzc0LDggQEAgSFRNTFRyZWVCdWlsZGVyOjpIVE1MVHJlZUJ1aWxkZXIoSFRNTERvY3Vt ZW50UGFyc2VyKiBwYXJzZXIsIERvY3VtZW50RnJhZ21lbnQqIGYKICAgICAsIG1fdXNlUHJlSFRN TDVQYXJzZXJRdWlya3ModXNlUHJlSFRNTDVQYXJzZXJRdWlya3MpCiAgICAgLCBtX2hhc1BlbmRp bmdGb3JlaWduSW5zZXJ0aW9uTW9kZVN0ZXBzKGZhbHNlKQogeworICAgIC8vIEZJWE1FOiBUaGlz IGFzc2VydGlvbiB3aWxsIGJlY29tZSBpbnZhbGlkIHdoZW4gPGh0dHA6Ly93ZWJraXQub3JnL2Iv NjAzMTY+IGlzIGZpeGVkLgorICAgIEFTU0VSVChjb250ZXh0RWxlbWVudCk7CiAgICAgaWYgKGNv bnRleHRFbGVtZW50KSB7CiAgICAgICAgIC8vIFN0ZXBzIDQuMi00LjYgb2YgdGhlIEhUTUw1IEZy YWdtZW50IENhc2UgcGFyc2luZyBhbGdvcml0aG06CiAgICAgICAgIC8vIGh0dHA6Ly93d3cud2hh dHdnLm9yZy9zcGVjcy93ZWItYXBwcy9jdXJyZW50LXdvcmsvbXVsdGlwYWdlL3RoZS1lbmQuaHRt bCNmcmFnbWVudC1jYXNlCg==