60241 2011-05-04 19:47:30 -0700 new-run-webkit-tests: doesn't wait for children if it gets a ctrl-c 2011-05-31 15:27:13 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth commit-queue eric ojan tony oldest_to_newest 398499 0 dpranke 2011-05-04 19:47:30 -0700 new-run-webkit-tests: doesn't wait for children if it gets a ctrl-c 398500 1 92364 dpranke 2011-05-04 19:47:51 -0700 Created attachment 92364 Patch 399852 2 92364 tony 2011-05-06 15:25:55 -0700 Comment on attachment 92364 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92364&action=review > Tools/Scripts/new-run-webkit-tests:59 > + finally: Do we need to catch other exceptions? E.g., if proc.wait() throws another error (e.g., an IO or OS error), it looks like we'll just silently ignore the error if we make it to sys.exit(proc.returncode). Maybe that's not possible? 399868 3 92364 dpranke 2011-05-06 15:41:54 -0700 Comment on attachment 92364 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92364&action=review >> Tools/Scripts/new-run-webkit-tests:59 >> + finally: > > Do we need to catch other exceptions? E.g., if proc.wait() throws another error (e.g., an IO or OS error), it looks like we'll just silently ignore the error if we make it to sys.exit(proc.returncode). Maybe that's not possible? Hm. Good point. I should rework this. 402584 4 92364 eric 2011-05-11 20:16:47 -0700 Comment on attachment 92364 Patch Sounds like dirk is gonna take another pass. 412374 5 95374 dpranke 2011-05-30 15:05:22 -0700 Created attachment 95374 Patch 412375 6 95374 dpranke 2011-05-30 15:08:10 -0700 Comment on attachment 95374 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95374&action=review Okay, reworked. Can haz another review, plz? > Tools/Scripts/new-run-webkit-tests:-57 > - sys.exit(signal.SIGINT + 128) Note that we don't need or want this line, because the same logic exists the subprocess, and omitting this will help catch cases where the subprocess starts doing the wrong thing. 412773 7 95374 tony 2011-05-31 12:06:47 -0700 Comment on attachment 95374 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95374&action=review > Tools/Scripts/new-run-webkit-tests:59 > + proc.wait() Is it possible for this to hang completely? 412866 8 95374 dpranke 2011-05-31 14:34:14 -0700 Comment on attachment 95374 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95374&action=review >> Tools/Scripts/new-run-webkit-tests:59 >> + proc.wait() > > Is it possible for this to hang completely? Good question (since that's why I put the fixme in). I haven't seen in in practice, and in theory, I wouldn't think so (since the subprocess also got a Keyboard interrupt and should be exiting), but I can't definitively say that it's not possible. 412869 9 95374 tony 2011-05-31 14:37:23 -0700 Comment on attachment 95374 Patch Ok, let's try it. I guess worst case scenario, the user will press ctrl+c again and both the subprocess and the main process will raise a KeyboardInterrupt exception, right? 412874 10 dpranke 2011-05-31 14:39:45 -0700 (In reply to comment #9) > (From update of attachment 95374 [details]) > Ok, let's try it. I guess worst case scenario, the user will press ctrl+c again and both the subprocess and the main process will raise a KeyboardInterrupt exception, right? Yup. 412925 11 commit-queue 2011-05-31 15:25:37 -0700 The commit-queue encountered the following flaky tests while processing attachment 95374: editing/pasteboard/copy-standalone-image.html bug 61813 (authors: andrew@webkit.org and mitz@webkit.org) The commit-queue is continuing to process your patch. 412927 12 95374 commit-queue 2011-05-31 15:27:07 -0700 Comment on attachment 95374 Patch Clearing flags on attachment: 95374 Committed r87757: <http://trac.webkit.org/changeset/87757> 412928 13 commit-queue 2011-05-31 15:27:13 -0700 All reviewed patches have been landed. Closing bug. 92364 2011-05-04 19:47:51 -0700 2011-05-30 15:05:18 -0700 Patch bug-60241-20110504194750.patch text/plain 1620 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogODU2NjUKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmMjFlMjU4ZDQ1Yzk5ZWZiYmJiMzZlZmE3ZWQwZDNmZGIz NmQzOGYzLi4wOWM2MzhhNWM0NzM3NTNhNjMxYTY0Nzg1OWRlOTY2Y2M4M2MxNDBkIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMDUtMDQgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgbmV3LXJ1bi13ZWJr aXQtdGVzdHM6IGRvZXNuJ3Qgd2FpdCBmb3IgY2hpbGRyZW4gaWYgaXQgZ2V0cyBhIGN0cmwtYwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjAyNDEKKwor ICAgICAgICAqIFNjcmlwdHMvbmV3LXJ1bi13ZWJraXQtdGVzdHM6CisKIDIwMTEtMDUtMDMgIERp cmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwg cm9sbGluZyBvdXQgcjg1NjU5LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9uZXctcnVuLXdl YmtpdC10ZXN0cyBiL1Rvb2xzL1NjcmlwdHMvbmV3LXJ1bi13ZWJraXQtdGVzdHMKaW5kZXggNGNm OTQ1YWM2Y2MwODhlODVhOThhNTQyZDliNjk5MWZkMjBlOTRhZS4uNzA1MGQyN2NjYmM0ZTNiZmRm MjcwODU5MTM4OTNiNjVmMDM1NWRiNyAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9uZXctcnVu LXdlYmtpdC10ZXN0cworKysgYi9Ub29scy9TY3JpcHRzL25ldy1ydW4td2Via2l0LXRlc3RzCkBA IC01MCw4ICs1MCwxNSBAQCBpZiBfX25hbWVfXyA9PSAnX19tYWluX18nOgogICAgICAgICBlbnZb J1BZVEhPTlBBVEgnXSA9IHNjcmlwdF9kaXIKICAgICBtb2R1bGVfcGF0aCA9IG9zLnBhdGguam9p bihzY3JpcHRfZGlyLCAnd2Via2l0cHknLCAnbGF5b3V0X3Rlc3RzJywgJ3J1bl93ZWJraXRfdGVz dHMucHknKQogICAgIGNtZCA9IFtzeXMuZXhlY3V0YWJsZSwgbW9kdWxlX3BhdGhdICsgc3lzLmFy Z3ZbMTpdCisgICAgcHJvYyA9IE5vbmUKICAgICB0cnk6Ci0gICAgICAgIHN5cy5leGl0KHN1YnBy b2Nlc3MuY2FsbChjbWQsIGVudj1lbnYpKQorICAgICAgICBwcm9jID0gc3VicHJvY2Vzcy5Qb3Bl bihjbWQsIGVudj1lbnYpCisgICAgICAgIHByb2Mud2FpdCgpCiAgICAgZXhjZXB0IEtleWJvYXJk SW50ZXJydXB0OgotICAgICAgICAjIHRoaXMgbWlycm9ycyB3aGF0IHRoZSBzaGVsbCBub3JtYWxs eSBkb2VzCi0gICAgICAgIHN5cy5leGl0KHNpZ25hbC5TSUdJTlQgKyAxMjgpCisgICAgICAgIHBh c3MKKyAgICBmaW5hbGx5OgorICAgICAgICAjIFdlIG5lZWQgYSBzZWNvbmQgd2FpdCBpbiBvcmRl ciB0byBtYWtlIHN1cmUgdGhlIHN1YnByb2Nlc3MgZXhpdHMgZnVsbHkuCisgICAgICAgICMgRklY TUU6IEl0IHdvdWxkIGJlIG5pY2UgaWYgd2UgY291bGQgcHV0IGEgdGltZW91dCBvbiB0aGlzLgor ICAgICAgICBpZiBwcm9jOgorICAgICAgICAgICAgcHJvYy53YWl0KCkKKyAgICAgICAgICAgIHN5 cy5leGl0KHByb2MucmV0dXJuY29kZSkK 95374 2011-05-30 15:05:22 -0700 2011-05-31 15:27:07 -0700 Patch bug-60241-20110530150520.patch text/plain 1545 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogODc2OTcKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzNmU5ZDE0ZTEyN2M4MzZkMzcwNGQxMDAzMDY1ZjFiNmQ1 M2VlZDc0Li5lNmM1OWI3NjhkYjk1MmZjYTY0YjY1NzM0NmMwMTM0NDlhNGQ5ZTNkIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMDUtMzAgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgbmV3LXJ1bi13ZWJr aXQtdGVzdHM6IGRvZXNuJ3Qgd2FpdCBmb3IgY2hpbGRyZW4gaWYgaXQgZ2V0cyBhIGN0cmwtYwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjAyNDEKKwor ICAgICAgICAqIFNjcmlwdHMvbmV3LXJ1bi13ZWJraXQtdGVzdHM6CisKIDIwMTEtMDUtMzAgIENh cmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IE1hcnRpbiBSb2JpbnNvbi4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvbmV3LXJ1 bi13ZWJraXQtdGVzdHMgYi9Ub29scy9TY3JpcHRzL25ldy1ydW4td2Via2l0LXRlc3RzCmluZGV4 IDRjZjk0NWFjNmNjMDg4ZTg1YTk4YTU0MmQ5YjY5OTFmZDIwZTk0YWUuLmI0OTQ2MzZiYWQ1Nzk4 NGYyZjIxODc0NGU4MTVlNTg3M2Q2YjdkMzMgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvbmV3 LXJ1bi13ZWJraXQtdGVzdHMKKysrIGIvVG9vbHMvU2NyaXB0cy9uZXctcnVuLXdlYmtpdC10ZXN0 cwpAQCAtNTAsOCArNTAsMTEgQEAgaWYgX19uYW1lX18gPT0gJ19fbWFpbl9fJzoKICAgICAgICAg ZW52WydQWVRIT05QQVRIJ10gPSBzY3JpcHRfZGlyCiAgICAgbW9kdWxlX3BhdGggPSBvcy5wYXRo LmpvaW4oc2NyaXB0X2RpciwgJ3dlYmtpdHB5JywgJ2xheW91dF90ZXN0cycsICdydW5fd2Via2l0 X3Rlc3RzLnB5JykKICAgICBjbWQgPSBbc3lzLmV4ZWN1dGFibGUsIG1vZHVsZV9wYXRoXSArIHN5 cy5hcmd2WzE6XQorICAgIHByb2MgPSBzdWJwcm9jZXNzLlBvcGVuKGNtZCwgZW52PWVudikKICAg ICB0cnk6Ci0gICAgICAgIHN5cy5leGl0KHN1YnByb2Nlc3MuY2FsbChjbWQsIGVudj1lbnYpKQor ICAgICAgICBwcm9jLndhaXQoKQogICAgIGV4Y2VwdCBLZXlib2FyZEludGVycnVwdDoKLSAgICAg ICAgIyB0aGlzIG1pcnJvcnMgd2hhdCB0aGUgc2hlbGwgbm9ybWFsbHkgZG9lcwotICAgICAgICBz eXMuZXhpdChzaWduYWwuU0lHSU5UICsgMTI4KQorICAgICAgICAjIFdlIG5lZWQgYSBzZWNvbmQg d2FpdCBpbiBvcmRlciB0byBtYWtlIHN1cmUgdGhlIHN1YnByb2Nlc3MgZXhpdHMgZnVsbHkuCisg ICAgICAgICMgRklYTUU6IEl0IHdvdWxkIGJlIG5pY2UgaWYgd2UgY291bGQgcHV0IGEgdGltZW91 dCBvbiB0aGlzLgorICAgICAgICBwcm9jLndhaXQoKQorICAgIHN5cy5leGl0KHByb2MucmV0dXJu Y29kZSkK