60162 2011-05-04 05:56:42 -0700 [NRWT] chromium-linux tests shouldn't run on other platforms 2011-05-13 07:49:35 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 34984 1 ossy kkristof kkristof ossy rgabor oldest_to_newest 397845 0 ossy 2011-05-04 05:56:42 -0700 These tests run, but they shouldn't: platform/chromium-linux/fast/text/international/arabic-vertical-offset.html platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html Gábor, could you check it, please? 403541 1 93449 kkristof 2011-05-13 07:40:31 -0700 Created attachment 93449 proposed fix 403542 2 93449 ossy 2011-05-13 07:43:49 -0700 Comment on attachment 93449 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=93449&action=review LGTM, r=me with a little fix in changelog > Tools/ChangeLog:9 > + Remove _tests_for_other_platforms defs because in the r82753 > + it is implemented properly in the baseclass in webkit.py little nit: ... because r82753 implemented it properly ... 403544 3 ossy 2011-05-13 07:48:57 -0700 Landed in http://trac.webkit.org/changeset/86429 93449 2011-05-13 07:40:31 -0700 2011-05-13 07:49:35 -0700 proposed fix 13.patch text/plain 3575 kkristof ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBkNGQz MDdkLi5hZmU5ZjVmIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDUtMTMgIEtyaXN0w7NmIEtvc3p0ecOzICA8 S29zenR5by5LcmlzdG9mQHN0dWQudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW05SV1RdIGNocm9taXVtLWxpbnV4IHRlc3RzIHNo b3VsZG4ndCBydW4gb24gb3RoZXIgcGxhdGZvcm1zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MDE2MgorCisgICAgICAgIFJlbW92ZSBfdGVzdHNfZm9y X290aGVyX3BsYXRmb3JtcyBkZWZzIGJlY2F1c2UgaW4gdGhlIHI4Mjc1MworICAgICAgICBpdCBp cyBpbXBsZW1lbnRlZCBwcm9wZXJseSBpbiB0aGUgYmFzZWNsYXNzIGluIHdlYmtpdC5weQorCisg ICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9ndGsucHk6CisgICAg ICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9xdC5weToKKyAgICAgICAg KiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dpbi5weToKKwogMjAxMS0wNS0x MiAgUnl1YW4gQ2hvaSAgPHJ5dWFuLmNob2lAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgQW50b25pbyBHb21lcy4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL3BvcnQvZ3RrLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcG9ydC9ndGsucHkKaW5kZXggMGVjOWY4Ny4uY2YwNjZiMCAxMDA2NDQKLS0tIGEvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9ndGsucHkKKysrIGIvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9ndGsucHkKQEAgLTQ0LDE3ICs0NCw2 IEBAIGNsYXNzIEd0a1BvcnQoV2ViS2l0UG9ydCk6CiAgICAgICAgIGt3YXJncy5zZXRkZWZhdWx0 KCdwb3J0X25hbWUnLCAnZ3RrJykKICAgICAgICAgV2ViS2l0UG9ydC5fX2luaXRfXyhzZWxmLCAq Kmt3YXJncykKIAotICAgIGRlZiBfdGVzdHNfZm9yX290aGVyX3BsYXRmb3JtcyhzZWxmKToKLSAg ICAgICAgIyBGSVhNRTogVGhpcyBsaXN0IGNvdWxkIGJlIGR5bmFtaWMgYmFzZWQgb24gcGxhdGZv cm0gbmFtZSBhbmQKLSAgICAgICAgIyBwdXNoZWQgaW50byBiYXNlLlBvcnQuCi0gICAgICAgICMg VGhpcyByZWFsbHkgbmVlZCB0byBiZSBhdXRvbWF0ZWQuCi0gICAgICAgIHJldHVybiBbCi0gICAg ICAgICAgICAicGxhdGZvcm0vY2hyb21pdW0iLAotICAgICAgICAgICAgInBsYXRmb3JtL3dpbiIs Ci0gICAgICAgICAgICAicGxhdGZvcm0vcXQiLAotICAgICAgICAgICAgInBsYXRmb3JtL21hYyIs Ci0gICAgICAgIF0KLQogICAgIGRlZiBfcGF0aF90b19hcGFjaGVfY29uZmlnX2ZpbGUoc2VsZik6 CiAgICAgICAgICMgRklYTUU6IFRoaXMgbmVlZHMgdG8gZGV0ZWN0IHRoZSBkaXN0cmlidXRpb24g YW5kIGNoYW5nZSBjb25maWcgZmlsZXMuCiAgICAgICAgIHJldHVybiBzZWxmLl9maWxlc3lzdGVt LmpvaW4oc2VsZi5sYXlvdXRfdGVzdHNfZGlyKCksICdodHRwJywgJ2NvbmYnLApkaWZmIC0tZ2l0 IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9xdC5weSBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvcXQucHkKaW5kZXggZTE1OWJmNy4u OTE0NTY3OSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv cG9ydC9xdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0 L3F0LnB5CkBAIC01OCwxNyArNTgsNiBAQCBjbGFzcyBRdFBvcnQoV2ViS2l0UG9ydCk6CiAgICAg ICAgIHBvcnRfbmFtZXMuYXBwZW5kKCJxdCIpCiAgICAgICAgIHJldHVybiBtYXAoc2VsZi5fd2Vi a2l0X2Jhc2VsaW5lX3BhdGgsIHBvcnRfbmFtZXMpCiAKLSAgICBkZWYgX3Rlc3RzX2Zvcl9vdGhl cl9wbGF0Zm9ybXMoc2VsZik6Ci0gICAgICAgICMgRklYTUU6IFRoaXMgbGlzdCBjb3VsZCBiZSBk eW5hbWljIGJhc2VkIG9uIHBsYXRmb3JtIG5hbWUgYW5kCi0gICAgICAgICMgcHVzaGVkIGludG8g YmFzZS5Qb3J0LgotICAgICAgICAjIFRoaXMgcmVhbGx5IG5lZWQgdG8gYmUgYXV0b21hdGVkLgot ICAgICAgICByZXR1cm4gWwotICAgICAgICAgICAgInBsYXRmb3JtL2Nocm9taXVtIiwKLSAgICAg ICAgICAgICJwbGF0Zm9ybS93aW4iLAotICAgICAgICAgICAgInBsYXRmb3JtL2d0ayIsCi0gICAg ICAgICAgICAicGxhdGZvcm0vbWFjIiwKLSAgICAgICAgXQotCiAgICAgZGVmIF9wYXRoX3RvX2Fw YWNoZV9jb25maWdfZmlsZShzZWxmKToKICAgICAgICAgIyBGSVhNRTogVGhpcyBuZWVkcyB0byBk ZXRlY3QgdGhlIGRpc3RyaWJ1dGlvbiBhbmQgY2hhbmdlIGNvbmZpZyBmaWxlcy4KICAgICAgICAg cmV0dXJuIHNlbGYuX2ZpbGVzeXN0ZW0uam9pbihzZWxmLmxheW91dF90ZXN0c19kaXIoKSwgJ2h0 dHAnLCAnY29uZicsCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9wb3J0L3dpbi5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3Bv cnQvd2luLnB5CmluZGV4IDAzYTc2ZjQuLjhhNWRlODEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2luLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2luLnB5CkBAIC00OSwxNyArNDksNiBAQCBjbGFz cyBXaW5Qb3J0KFdlYktpdFBvcnQpOgogICAgICAgICBwb3J0X25hbWVzID0gWyJ3aW4iLCAibWFj LXNub3dsZW9wYXJkIiwgIm1hYyJdCiAgICAgICAgIHJldHVybiBtYXAoc2VsZi5fd2Via2l0X2Jh c2VsaW5lX3BhdGgsIHBvcnRfbmFtZXMpCiAKLSAgICBkZWYgX3Rlc3RzX2Zvcl9vdGhlcl9wbGF0 Zm9ybXMoc2VsZik6Ci0gICAgICAgICMgRklYTUU6IFRoaXMgbGlzdCBjb3VsZCBiZSBkeW5hbWlj IGJhc2VkIG9uIHBsYXRmb3JtIG5hbWUgYW5kCi0gICAgICAgICMgcHVzaGVkIGludG8gYmFzZS5Q b3J0LgotICAgICAgICAjIFRoaXMgcmVhbGx5IG5lZWQgdG8gYmUgYXV0b21hdGVkLgotICAgICAg ICByZXR1cm4gWwotICAgICAgICAgICAgInBsYXRmb3JtL2Nocm9taXVtIiwKLSAgICAgICAgICAg ICJwbGF0Zm9ybS9ndGsiLAotICAgICAgICAgICAgInBsYXRmb3JtL3F0IiwKLSAgICAgICAgICAg ICJwbGF0Zm9ybS9tYWMiLAotICAgICAgICBdCi0KICAgICBkZWYgX3BhdGhfdG9fYXBhY2hlX2Nv bmZpZ19maWxlKHNlbGYpOgogICAgICAgICByZXR1cm4gc2VsZi5fZmlsZXN5c3RlbS5qb2luKHNl bGYubGF5b3V0X3Rlc3RzX2RpcigpLCAnaHR0cCcsICdjb25mJywKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAnY3lnd2luLWh0dHBkLmNvbmYnKQo=