60007 2011-05-02 20:38:11 -0700 REGRESSION (r83122): CSS !important not respected by JavaScript 2016-07-20 10:00:08 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=159959 InRadar, Regression P1 Normal --- 1 ian webkit-unassigned commit-queue mitz simon.fraser oldest_to_newest 396932 0 ian 2011-05-02 20:38:11 -0700 An element with a !important property in its style will allow you to override this property in JavaScript without using !important. Caused by <http://trac.webkit.org/changeset/83122>. 396933 1 ian 2011-05-02 20:38:27 -0700 <rdar://problem/9299919> 396935 2 mitz 2011-05-02 20:46:39 -0700 <rdar://problem/9299919> 396937 3 92042 ian 2011-05-02 20:47:31 -0700 Created attachment 92042 proposed patch 396956 4 92042 commit-queue 2011-05-02 22:08:02 -0700 Comment on attachment 92042 proposed patch Clearing flags on attachment: 92042 Committed r85585: <http://trac.webkit.org/changeset/85585> 396957 5 commit-queue 2011-05-02 22:08:07 -0700 All reviewed patches have been landed. Closing bug. 92042 2011-05-02 20:47:31 -0700 2011-05-02 22:08:02 -0700 proposed patch 60007-1.patch text/plain 4338 ian SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1NTc4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTEtMDUtMDIgIElhbiBIZW5k ZXJzb24gIDxpYW5oQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBDU1MgIWltcG9ydGFudCBub3QgcmVzcGVjdGVkIGJ5IEphdmFTY3Jp cHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYwMDA3 CisKKyAgICAgICAgVGhlIGFkZFBhcnNlZFByb3BlcnR5IGFuZCBhZGRQYXJzZWRQcm9wZXJ0aWVz IG1ldGhvZHMgd2VyZSBzdWJ0bHkKKyAgICAgICAgZGlmZmVyZW50LiAgVGhlIGZvcm1lciBkaWQg bm90IGNoZWNrIGZvciAhaW1wb3J0YW50IGJlZm9yZSBzZXR0aW5nIHRoZQorICAgICAgICBnaXZl biBwcm9wZXJ0eS4KKworICAgICAgICBDaGFuZ2UgYWRkUGFyc2VkUHJvcGVydGllcyB0byBjYWxs IGFkZFBhcnNlZFByb3BlcnR5IGFuZCBtb3ZlIHRoZQorICAgICAgICByZWxldmFudCBjb2RlLiAg VGhlIG9uZSBvdGhlciBjYWxsZXIgb2YgdGhpcyBtZXRob2QsIGluCisgICAgICAgIGVkaXRpbmcv bWFya3VwLmNwcCwgcHJvYmFibHkgd2FudGVkIHRoaXMgYmVoYXZpb3IgYW55d2F5LgorCisgICAg ICAgIFRlc3Q6IGZhc3QvY3NzL2ltcG9ydGFudC1qcy1vdmVycmlkZS5odG1sCisKKyAgICAgICAg KiBjc3MvQ1NTTXV0YWJsZVN0eWxlRGVjbGFyYXRpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6 Q1NTTXV0YWJsZVN0eWxlRGVjbGFyYXRpb246OmFkZFBhcnNlZFByb3BlcnRpZXMpOgorICAgICAg ICAoV2ViQ29yZTo6Q1NTTXV0YWJsZVN0eWxlRGVjbGFyYXRpb246OmFkZFBhcnNlZFByb3BlcnR5 KToKKwogMjAxMS0wNS0wMiAgQmVuIFdlbGxzICA8YmVud2VsbHNAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNlci4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nz cy9DU1NNdXRhYmxlU3R5bGVEZWNsYXJhdGlvbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvY3NzL0NTU011dGFibGVTdHlsZURlY2xhcmF0aW9uLmNwcAkocmV2aXNpb24gODU1NzAp CisrKyBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTTXV0YWJsZVN0eWxlRGVjbGFyYXRpb24uY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC02NDIsMTcgKzY0MiwxMSBAQAogdm9pZCBDU1NNdXRhYmxlU3R5bGVE ZWNsYXJhdGlvbjo6YWRkUGFyc2VkUHJvcGVydGllcyhjb25zdCBDU1NQcm9wZXJ0eSogY29uc3Qq IHByb3BlcnRpZXMsIGludCBudW1Qcm9wZXJ0aWVzKQogewogICAgIEFTU0VSVCghbV9pdGVyYXRv ckNvdW50KTsKLSAgICAKKwogICAgIG1fcHJvcGVydGllcy5yZXNlcnZlQ2FwYWNpdHkobnVtUHJv cGVydGllcyk7Ci0gICAgCi0gICAgZm9yIChpbnQgaSA9IDA7IGkgPCBudW1Qcm9wZXJ0aWVzOyAr K2kpIHsKLSAgICAgICAgLy8gT25seSBhZGQgcHJvcGVydGllcyB0aGF0IGhhdmUgbm8gIWltcG9y dGFudCBjb3VudGVycGFydCBwcmVzZW50Ci0gICAgICAgIGlmICghZ2V0UHJvcGVydHlQcmlvcml0 eShwcm9wZXJ0aWVzW2ldLT5pZCgpKSB8fCBwcm9wZXJ0aWVzW2ldLT5pc0ltcG9ydGFudCgpKSB7 Ci0gICAgICAgICAgICByZW1vdmVQcm9wZXJ0eShwcm9wZXJ0aWVzW2ldLT5pZCgpLCBmYWxzZSk7 Ci0gICAgICAgICAgICBBU1NFUlQocHJvcGVydGllc1tpXSk7Ci0gICAgICAgICAgICBtX3Byb3Bl cnRpZXMuYXBwZW5kKCpwcm9wZXJ0aWVzW2ldKTsKLSAgICAgICAgfQotICAgIH0KKyAgICBmb3Ig KGludCBpID0gMDsgaSA8IG51bVByb3BlcnRpZXM7ICsraSkKKyAgICAgICAgYWRkUGFyc2VkUHJv cGVydHkoKnByb3BlcnRpZXNbaV0pOworCiAgICAgLy8gRklYTUU6IFRoaXMgcHJvYmFibHkgc2hv dWxkIGhhdmUgYSBjYWxsIHRvIHNldE5lZWRzU3R5bGVSZWNhbGMoKSBpZiBzb21ldGhpbmcgY2hh bmdlZC4gV2UgbWF5IGFsc28gd2lzaCB0byBhZGQKICAgICAvLyBhIG5vdGlmeUNoYW5nZWQgYXJn dW1lbnQgdG8gdGhpcyBmdW5jdGlvbiB0byBmb2xsb3cgdGhlIG1vZGVsIG9mIG90aGVyIGZ1bmN0 aW9ucyBpbiB0aGlzIGNsYXNzLgogfQpAQCAtNjYxLDcgKzY1NSwxMSBAQAogewogICAgIEFTU0VS VCghbV9pdGVyYXRvckNvdW50KTsKIAotICAgIHNldFByb3BlcnR5SW50ZXJuYWwocHJvcGVydHkp OworICAgIC8vIE9ubHkgYWRkIHByb3BlcnRpZXMgdGhhdCBoYXZlIG5vICFpbXBvcnRhbnQgY291 bnRlcnBhcnQgcHJlc2VudAorICAgIGlmICghZ2V0UHJvcGVydHlQcmlvcml0eShwcm9wZXJ0eS5p ZCgpKSB8fCBwcm9wZXJ0eS5pc0ltcG9ydGFudCgpKSB7CisgICAgICAgIHJlbW92ZVByb3BlcnR5 KHByb3BlcnR5LmlkKCksIGZhbHNlKTsKKyAgICAgICAgbV9wcm9wZXJ0aWVzLmFwcGVuZChwcm9w ZXJ0eSk7CisgICAgfQogfQogCiB2b2lkIENTU011dGFibGVTdHlsZURlY2xhcmF0aW9uOjpzZXRM ZW5ndGhQcm9wZXJ0eShpbnQgcHJvcGVydHlJZCwgY29uc3QgU3RyaW5nJiB2YWx1ZSwgYm9vbCBp bXBvcnRhbnQsIGJvb2wgLyptdWx0aUxlbmd0aCovKQpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9j c3MvaW1wb3J0YW50LWpzLW92ZXJyaWRlLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9mYXN0L2Nzcy9pbXBvcnRhbnQtanMtb3ZlcnJpZGUtZXhwZWN0ZWQudHh0CShyZXZp c2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9jc3MvaW1wb3J0YW50LWpzLW92ZXJyaWRlLWV4 cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSBAQAorVGhlIGJhY2tncm91bmQgb2Yg dGhpcyBlbGVtZW50IHNob3VsZCBiZSBncmVlbi4gSXQgaXMgZ3JlZW4KSW5kZXg6IExheW91dFRl c3RzL2Zhc3QvY3NzL2ltcG9ydGFudC1qcy1vdmVycmlkZS5odG1sCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL2Zhc3QvY3NzL2ltcG9ydGFudC1qcy1vdmVycmlkZS5odG1sCShyZXZpc2lvbiAw KQorKysgTGF5b3V0VGVzdHMvZmFzdC9jc3MvaW1wb3J0YW50LWpzLW92ZXJyaWRlLmh0bWwJKHJl dmlzaW9uIDApCkBAIC0wLDAgKzEsOCBAQAorPGRpdiBpZD0iYSIgc3R5bGU9ImJhY2tncm91bmQt Y29sb3I6IGdyZWVuICFpbXBvcnRhbnQiPlRoZSBiYWNrZ3JvdW5kIG9mIHRoaXMgZWxlbWVudCBz aG91bGQgYmUgZ3JlZW4uIEl0IGlzIDwvZGl2PgorPHNjcmlwdD4KKyAgICBpZiAod2luZG93Lmxh eW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNU ZXh0KCk7CisgICAgdmFyIGEgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiYSIpOworICAgIGEu c3R5bGUuYmFja2dyb3VuZENvbG9yID0gInJlZCI7CisgICAgYS5pbm5lckhUTUwgKz0gYS5zdHls ZS5iYWNrZ3JvdW5kQ29sb3I7Cis8L3NjcmlwdD4KSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxv Zwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1NTc4KQor KysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTEtMDUtMDIgIElhbiBIZW5kZXJzb24gIDxpYW5oQGFwcGxlLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDU1MgIWltcG9ydGFudCBub3Qg cmVzcGVjdGVkIGJ5IEphdmFTY3JpcHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTYwMDA3CisKKyAgICAgICAgKiBmYXN0L2Nzcy9pbXBvcnRhbnQtanMt b3ZlcnJpZGUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Nzcy9pbXBvcnRh bnQtanMtb3ZlcnJpZGUuaHRtbDogQWRkZWQuCisKIDIwMTEtMDUtMDIgIERpbWl0cmkgR2xhemtv diAgPGRnbGF6a292QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBB ZGxlci4K