59975 2011-05-02 16:26:48 -0700 ValidityState::valid causes value sanitization 7 times 2024-06-29 16:04:42 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) PC OS X 10.5 NEW InRadar P2 Normal --- 1 joepeck webkit-unassigned ahmad.saleem792 akeerthi ashvayka dmikurube joepeck rniwa tkent webkit-bug-importer oldest_to_newest 396769 0 joepeck 2011-05-02 16:26:48 -0700 I noticed this while working on value sanitization for date inputs. This could be a performance issue, because sanitization requires parsing the input to see if it is valid. bool ValidityState::valid() const { bool someError = typeMismatch() || stepMismatch() || rangeUnderflow() || rangeOverflow() || tooLong() || patternMismatch() || valueMissing() || customError(); return !someError; } It seems like this could really benefit from caching, or a better design that allows for getting the sanitized value once, and running the different validity tests on the pre-calculated value. 1960233 1 ahmad.saleem792 2023-06-07 01:57:11 -0700 We still have similar function but different name: https://searchfox.org/wubkat/source/Source/WebCore/html/FormListedElement.cpp#244 bool FormListedElement::computeValidity() const { bool someError = typeMismatch() || stepMismatch() || rangeUnderflow() || rangeOverflow() || tooShort() || tooLong() || patternMismatch() || valueMissing() || hasBadInput() || customError(); return !someError; } https://searchfox.org/wubkat/source/Source/WebCore/html/HTMLInputElement.cpp#344 bool HTMLInputElement::computeValidity() const { String value = this->value(); bool someError = m_inputType->isInvalid(value) || tooShort(value, CheckDirtyFlag) || tooLong(value, CheckDirtyFlag) || customError(); return !someError; } 2043806 2 webkit-bug-importer 2024-06-29 16:04:42 -0700 <rdar://problem/130825308>