59936 2011-05-02 07:14:46 -0700 Port Mozilla's IndexedDB tests: inline autoincrement key added on put 2011-05-02 14:03:34 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P3 Normal --- 0 pilgrim webkit-unassigned commit-queue dgrogan fishd hans hclam pilgrim tony oldest_to_newest 396368 0 pilgrim 2011-05-02 07:14:46 -0700 Original test: http://mxr.mozilla.org/mozilla2.0/source/dom/indexedDB/test/test_objectStore_inline_autoincrement_key_added_on_put.html?force=1 This is a port of a test from Mozilla's IndexedDB test suite. It adds a record with an autoincremented key and then retrieves the record by key and verifies that all data matches expected values. WebKit passes this test. 396371 1 91923 pilgrim 2011-05-02 07:16:59 -0700 Created attachment 91923 Patch 396544 2 91923 tony 2011-05-02 12:17:57 -0700 Comment on attachment 91923 Patch OK 396597 3 commit-queue 2011-05-02 13:30:49 -0700 The commit-queue encountered the following flaky tests while processing attachment 91923: http/tests/xmlhttprequest/remember-bad-password.html bug 51733 (author: ap@webkit.org) The commit-queue is continuing to process your patch. 396599 4 91923 commit-queue 2011-05-02 13:32:28 -0700 Comment on attachment 91923 Patch Clearing flags on attachment: 91923 Committed r85514: <http://trac.webkit.org/changeset/85514> 396600 5 commit-queue 2011-05-02 13:32:33 -0700 All reviewed patches have been landed. Closing bug. 396622 6 hclam 2011-05-02 13:49:57 -0700 Committed r85517: <http://trac.webkit.org/changeset/85517> 396626 7 hclam 2011-05-02 13:52:08 -0700 webkit-patch land caused this bug to be marked as closed. 396630 8 hclam 2011-05-02 13:55:56 -0700 Somehow due to update-webkit mystery I committed this patch for you. 396631 9 hclam 2011-05-02 13:56:12 -0700 I mean webkit-patch. 396636 10 pilgrim 2011-05-02 13:59:06 -0700 Well thanks, I guess. :) It was on its way to being committed anyway, so no harm done, I suppose. Mark as RESOLVED FIXED? 396637 11 hclam 2011-05-02 13:59:39 -0700 Yes please do. 396638 12 tony 2011-05-02 14:03:26 -0700 hclam: webkit-patch was confused because your ChangeLog description was not at the top of the file (maybe it got merged wrong). This change was already landed by the time your change went in. 91923 2011-05-02 07:16:59 -0700 2011-05-02 14:03:34 -0700 Patch bug-59936-20110502101657.patch text/plain 5394 pilgrim SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDg1NDcyKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDUtMDIgIE1hcmsgUGlsZ3JpbSAgPHBp bGdyaW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFBvcnQgTW96aWxsYSdzIEluZGV4ZWREQiB0ZXN0czogaW5saW5lIGF1dG9p bmNyZW1lbnQga2V5IGFkZGVkIG9uIHB1dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NTk5MzYKKworICAgICAgICAqIHN0b3JhZ2UvaW5kZXhlZGRiL21v emlsbGEvb2JqZWN0LXN0b3JlLWlubGluZS1hdXRvaW5jcmVtZW50LWtleS1hZGRlZC1vbi1wdXQt ZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBzdG9yYWdlL2luZGV4ZWRkYi9tb3ppbGxh L29iamVjdC1zdG9yZS1pbmxpbmUtYXV0b2luY3JlbWVudC1rZXktYWRkZWQtb24tcHV0Lmh0bWw6 IEFkZGVkLgorCiAyMDExLTA1LTAyICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlh LmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByZS1lbmFibGUgd2Vic29ja2V0IHRlc3RzIG9u IEdUSy4gdGhleSBtb3ZlZCBvdmVyIHRvIGEKSW5kZXg6IExheW91dFRlc3RzL3N0b3JhZ2UvaW5k ZXhlZGRiL21vemlsbGEvb2JqZWN0LXN0b3JlLWlubGluZS1hdXRvaW5jcmVtZW50LWtleS1hZGRl ZC1vbi1wdXQtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3N0b3JhZ2Uv aW5kZXhlZGRiL21vemlsbGEvb2JqZWN0LXN0b3JlLWlubGluZS1hdXRvaW5jcmVtZW50LWtleS1h ZGRlZC1vbi1wdXQtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvc3Rv cmFnZS9pbmRleGVkZGIvbW96aWxsYS9vYmplY3Qtc3RvcmUtaW5saW5lLWF1dG9pbmNyZW1lbnQt a2V5LWFkZGVkLW9uLXB1dC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMjkg QEAKK1Rlc3QgSW5kZXhlZERCIGFkZGluZyBhbiBhdXRvaW5jcmVtZW50ZWQga2V5IGFuZCByZXRy aWV2aW5nIGl0IHN1Y2Nlc3NmdWxseQorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJp ZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKwor aW5kZXhlZERCID0gd2luZG93LmluZGV4ZWREQiB8fCB3aW5kb3cud2Via2l0SW5kZXhlZERCIHx8 IHdpbmRvdy5tb3pJbmRleGVkREI7CitQQVNTIGluZGV4ZWREQiA9PSBudWxsIGlzIGZhbHNlCitJ REJEYXRhYmFzZUV4Y2VwdGlvbiA9IHdpbmRvdy5JREJEYXRhYmFzZUV4Y2VwdGlvbiB8fCB3aW5k b3cud2Via2l0SURCRGF0YWJhc2VFeGNlcHRpb247CitQQVNTIElEQkRhdGFiYXNlRXhjZXB0aW9u ID09IG51bGwgaXMgZmFsc2UKK2luZGV4ZWREQi5vcGVuKG5hbWUsIGRlc2NyaXB0aW9uKQorZGIg PSBldmVudC50YXJnZXQucmVzdWx0CityZXF1ZXN0ID0gZGIuc2V0VmVyc2lvbignMScpCitEZWxl dGVkIGFsbCBvYmplY3Qgc3RvcmVzLgordGVzdCA9IHsKKyAgICAgICAgbmFtZTogJ2lubGluZSBr ZXk7IGtleSBnZW5lcmF0b3InLAorICAgICAgICBhdXRvSW5jcmVtZW50OiB0cnVlLAorICAgICAg ICBzdG9yZWRPYmplY3Q6IHsgbmFtZTogJ0xpbmNvbG4nIH0sCisgICAgICAgIGtleU5hbWU6ICdp ZCcsCisgICAgfTsKK29iamVjdFN0b3JlID0gZGIuY3JlYXRlT2JqZWN0U3RvcmUodGVzdC5uYW1l LCB7IGtleVBhdGg6IHRlc3Qua2V5TmFtZSwgYXV0b0luY3JlbWVudDogdGVzdC5hdXRvSW5jcmVt ZW50IH0pOworcmVxdWVzdCA9IG9iamVjdFN0b3JlLmFkZCh0ZXN0LnN0b3JlZE9iamVjdCk7Citp ZCA9IGV2ZW50LnRhcmdldC5yZXN1bHQ7CityZXF1ZXN0ID0gb2JqZWN0U3RvcmUuZ2V0KGlkKTsK K1BBU1MgZXZlbnQudGFyZ2V0LnJlc3VsdC5uYW1lIGlzIHRlc3Quc3RvcmVkT2JqZWN0Lm5hbWUK K1BBU1MgZXZlbnQudGFyZ2V0LnJlc3VsdC5pZCBpcyBpZAorUEFTUyBzdWNjZXNzZnVsbHlQYXJz ZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKSW5kZXg6IExheW91dFRlc3RzL3N0b3JhZ2Uv aW5kZXhlZGRiL21vemlsbGEvb2JqZWN0LXN0b3JlLWlubGluZS1hdXRvaW5jcmVtZW50LWtleS1h ZGRlZC1vbi1wdXQuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4 ZWRkYi9tb3ppbGxhL29iamVjdC1zdG9yZS1pbmxpbmUtYXV0b2luY3JlbWVudC1rZXktYWRkZWQt b24tcHV0Lmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRk Yi9tb3ppbGxhL29iamVjdC1zdG9yZS1pbmxpbmUtYXV0b2luY3JlbWVudC1rZXktYWRkZWQtb24t cHV0Lmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsODQgQEAKKzwhRE9DVFlQRSBodG1sPgor PCEtLQorICBvcmlnaW5hbCB0ZXN0OiBodHRwOi8vbXhyLm1vemlsbGEub3JnL21vemlsbGEyLjAv c291cmNlL2RvbS9pbmRleGVkREIvdGVzdC90ZXN0X29iamVjdFN0b3JlX2lubGluZV9hdXRvaW5j cmVtZW50X2tleV9hZGRlZF9vbl9wdXQuaHRtbD9mb3JjZT0xCisgIGxpY2Vuc2Ugb2Ygb3JpZ2lu YWwgdGVzdDoKKyAgICAiIEFueSBjb3B5cmlnaHQgaXMgZGVkaWNhdGVkIHRvIHRoZSBQdWJsaWMg RG9tYWluLgorICAgICAgaHR0cDovL2NyZWF0aXZlY29tbW9ucy5vcmcvcHVibGljZG9tYWluL3pl cm8vMS4wLyAiCistLT4KKzxodG1sPgorPGhlYWQ+Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhy ZWY9Ii4uLy4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3Qtc3R5bGUuY3NzIj4KKzxzY3Jp cHQgc3JjPSIuLi8uLi8uLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3Jp cHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0 LWZ1bmN0aW9uLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi9yZXNvdXJjZXMvc2hhcmVk LmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+ Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQ+CisKK2Rlc2NyaXB0aW9uKCJUZXN0 IEluZGV4ZWREQiBhZGRpbmcgYW4gYXV0b2luY3JlbWVudGVkIGtleSBhbmQgcmV0cmlldmluZyBp dCBzdWNjZXNzZnVsbHkiKTsKK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAg bGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOworCitmdW5jdGlvbiB0ZXN0KCkK K3sKKyAgICBpbmRleGVkREIgPSBldmFsQW5kTG9nKCJpbmRleGVkREIgPSB3aW5kb3cuaW5kZXhl ZERCIHx8IHdpbmRvdy53ZWJraXRJbmRleGVkREIgfHwgd2luZG93Lm1vekluZGV4ZWREQjsiKTsK KyAgICBzaG91bGRCZUZhbHNlKCJpbmRleGVkREIgPT0gbnVsbCIpOworICAgIElEQkRhdGFiYXNl RXhjZXB0aW9uID0gZXZhbEFuZExvZygiSURCRGF0YWJhc2VFeGNlcHRpb24gPSB3aW5kb3cuSURC RGF0YWJhc2VFeGNlcHRpb24gfHwgd2luZG93LndlYmtpdElEQkRhdGFiYXNlRXhjZXB0aW9uOyIp OworICAgIHNob3VsZEJlRmFsc2UoIklEQkRhdGFiYXNlRXhjZXB0aW9uID09IG51bGwiKTsKKwor ICAgIG5hbWUgPSB3aW5kb3cubG9jYXRpb24ucGF0aG5hbWU7CisgICAgZGVzY3JpcHRpb24gPSAi TXkgVGVzdCBEYXRhYmFzZSI7CisgICAgcmVxdWVzdCA9IGV2YWxBbmRMb2coImluZGV4ZWREQi5v cGVuKG5hbWUsIGRlc2NyaXB0aW9uKSIpOworICAgIHJlcXVlc3Qub25zdWNjZXNzID0gb3BlblN1 Y2Nlc3M7CisgICAgcmVxdWVzdC5vbmVycm9yID0gdW5leHBlY3RlZEVycm9yQ2FsbGJhY2s7Cit9 CisKK2Z1bmN0aW9uIG9wZW5TdWNjZXNzKCkKK3sKKyAgICBkYiA9IGV2YWxBbmRMb2coImRiID0g ZXZlbnQudGFyZ2V0LnJlc3VsdCIpOworCisgICAgcmVxdWVzdCA9IGV2YWxBbmRMb2coInJlcXVl c3QgPSBkYi5zZXRWZXJzaW9uKCcxJykiKTsKKyAgICByZXF1ZXN0Lm9uc3VjY2VzcyA9IHNldHVw T2JqZWN0U3RvcmU7CisgICAgcmVxdWVzdC5vbmVycm9yID0gdW5leHBlY3RlZEVycm9yQ2FsbGJh Y2s7Cit9CisKK2Z1bmN0aW9uIHNldHVwT2JqZWN0U3RvcmUoKQoreworICAgIGRlbGV0ZUFsbE9i amVjdFN0b3JlcyhkYik7CisgICAgdGVzdCA9IGV2YWxBbmRMb2coInRlc3QgPSB7XG4iICsKKyIg ICAgICAgIG5hbWU6ICdpbmxpbmUga2V5OyBrZXkgZ2VuZXJhdG9yJyxcbiIgKworIiAgICAgICAg YXV0b0luY3JlbWVudDogdHJ1ZSxcbiIgKworIiAgICAgICAgc3RvcmVkT2JqZWN0OiB7IG5hbWU6 ICdMaW5jb2xuJyB9LFxuIiArCisiICAgICAgICBrZXlOYW1lOiAnaWQnLFxuIiArCisiICAgIH07 Iik7CisgICAgb2JqZWN0U3RvcmUgPSBldmFsQW5kTG9nKCJvYmplY3RTdG9yZSA9IGRiLmNyZWF0 ZU9iamVjdFN0b3JlKHRlc3QubmFtZSwgeyBrZXlQYXRoOiB0ZXN0LmtleU5hbWUsIGF1dG9JbmNy ZW1lbnQ6IHRlc3QuYXV0b0luY3JlbWVudCB9KTsiKTsKKyAgICByZXF1ZXN0ID0gZXZhbEFuZExv ZygicmVxdWVzdCA9IG9iamVjdFN0b3JlLmFkZCh0ZXN0LnN0b3JlZE9iamVjdCk7Iik7CisgICAg cmVxdWVzdC5vbnN1Y2Nlc3MgPSBhZGRTdWNjZXNzOworICAgIHJlcXVlc3Qub25lcnJvciA9IHVu ZXhwZWN0ZWRFcnJvckNhbGxiYWNrOworfQorCitmdW5jdGlvbiBhZGRTdWNjZXNzKCkKK3sKKyAg ICBpZCA9IGV2YWxBbmRMb2coImlkID0gZXZlbnQudGFyZ2V0LnJlc3VsdDsiKTsKKyAgICByZXF1 ZXN0ID0gZXZhbEFuZExvZygicmVxdWVzdCA9IG9iamVjdFN0b3JlLmdldChpZCk7Iik7CisgICAg cmVxdWVzdC5vbnN1Y2Nlc3MgPSBnZXRTdWNjZXNzOworICAgIHJlcXVlc3Qub25lcnJvciA9IHVu ZXhwZWN0ZWRFcnJvckNhbGxiYWNrOworfQorCitmdW5jdGlvbiBnZXRTdWNjZXNzKCkKK3sKKyAg ICBzaG91bGRCZSgiZXZlbnQudGFyZ2V0LnJlc3VsdC5uYW1lIiwgInRlc3Quc3RvcmVkT2JqZWN0 Lm5hbWUiKTsKKyAgICBzaG91bGRCZSgiZXZlbnQudGFyZ2V0LnJlc3VsdC5pZCIsICJpZCIpOwor ICAgIGRvbmUoKTsKK30KKwordmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7CisKK3Rlc3Qo KTsKKworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CisK