59923 2011-05-02 02:50:52 -0700 EWS should report the list of unexpected failures 2011-05-02 13:03:09 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 59272 1 abarth abarth commit-queue eric oldest_to_newest 396306 0 abarth 2011-05-02 02:50:52 -0700 EWS should report the list of unexpected failures 396307 1 91902 abarth 2011-05-02 02:53:50 -0700 Created attachment 91902 Patch 396438 2 91902 eric 2011-05-02 10:13:38 -0700 Comment on attachment 91902 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91902&action=review > Tools/Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:447 > + task = self._run_through_task(commit_queue, expected_stderr, ScriptError) > + self.assertEqual(task.results_from_patch_test_run(task._patch).failing_tests(), ["foo.html", "bar.html"]) Seems to support the case that this should be moved onto a custom Exception. 396519 3 abarth 2011-05-02 11:57:18 -0700 (In reply to comment #2) > (From update of attachment 91902 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=91902&action=review > > > Tools/Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:447 > > + task = self._run_through_task(commit_queue, expected_stderr, ScriptError) > > + self.assertEqual(task.results_from_patch_test_run(task._patch).failing_tests(), ["foo.html", "bar.html"]) > > Seems to support the case that this should be moved onto a custom Exception. Actually, if we moved it onto a custom exception, the test would be even harder to write. :) 396568 4 91902 commit-queue 2011-05-02 13:03:04 -0700 Comment on attachment 91902 Patch Clearing flags on attachment: 91902 Committed r85509: <http://trac.webkit.org/changeset/85509> 396569 5 commit-queue 2011-05-02 13:03:09 -0700 All reviewed patches have been landed. Closing bug. 91902 2011-05-02 02:53:50 -0700 2011-05-02 13:03:04 -0700 Patch bug-59923-20110502025349.patch text/plain 4694 abarth SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDg1NDY3KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTggQEAKKzIwMTEtMDUtMDIgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFV1Mgc2hvdWxk IHJlcG9ydCB0aGUgbGlzdCBvZiB1bmV4cGVjdGVkIGZhaWx1cmVzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTkyMworCisgICAgICAgIFdlIGNhY2hl IHRoZSByZXN1bHRzIG9mIHRoZSBmaXJzdCBsYXlvdXQgdGVzdCByZXN1bHRzIHJ1biBvbiB0aGUg dGFzaworICAgICAgICBzbyB0aGUgRVdTIGNhbiBncmFiIHRoZW0gbGF0ZXIuICBBbm90aGVyIG9w dGlvbiBpcyB0byBpbmNsdWRlIHRoZW0gaW4KKyAgICAgICAgdGhlIGV4Y2VwdGlvbiB0aGF0J3Mg dGhyb3duLCBidXQgdGhpcyBhcHByb2FjaCBzZWVtZWQgc2xpZ2h0bHkgbW9yZQorICAgICAgICBh ZXN0aGV0aWMuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L2NvbW1pdHF1 ZXVldGFza191bml0dGVzdC5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90 L3BhdGNoYW5hbHlzaXN0YXNrLnB5OgorCiAyMDExLTA1LTAyICBBZGFtIEJhcnRoICA8YWJhcnRo QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBU b29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L2NvbW1pdHF1ZXVldGFza191bml0dGVzdC5w eQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L2NvbW1pdHF1 ZXVldGFza191bml0dGVzdC5weQkocmV2aXNpb24gODU0NjUpCisrKyBUb29scy9TY3JpcHRzL3dl YmtpdHB5L3Rvb2wvYm90L2NvbW1pdHF1ZXVldGFza191bml0dGVzdC5weQkod29ya2luZyBjb3B5 KQpAQCAtMTE0LDYgKzExNCw3IEBAIGNsYXNzIENvbW1pdFF1ZXVlVGFza1Rlc3QodW5pdHRlc3Qu VGVzdEMKICAgICAgICAgc3VjY2VzcyA9IE91dHB1dENhcHR1cmUoKS5hc3NlcnRfb3V0cHV0cyhz ZWxmLCB0YXNrLnJ1biwgZXhwZWN0ZWRfc3RkZXJyPWV4cGVjdGVkX3N0ZGVyciwgZXhwZWN0ZWRf ZXhjZXB0aW9uPWV4cGVjdGVkX2V4Y2VwdGlvbikKICAgICAgICAgaWYgbm90IGV4cGVjdGVkX2V4 Y2VwdGlvbjoKICAgICAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoc3VjY2Vzcywgbm90IGV4cGVj dF9yZXRyeSkKKyAgICAgICAgcmV0dXJuIHRhc2sKIAogICAgIGRlZiB0ZXN0X3N1Y2Nlc3NfY2Fz ZShzZWxmKToKICAgICAgICAgY29tbWl0X3F1ZXVlID0gTW9ja0NvbW1pdFF1ZXVlKFtdKQpAQCAt NDQyLDcgKzQ0Myw4IEBAIGFyY2hpdmVfbGFzdF9sYXlvdXRfdGVzdF9yZXN1bHRzOiBwYXRjaD0K IHJ1bl93ZWJraXRfcGF0Y2g6IFsnYnVpbGQtYW5kLXRlc3QnLCAnLS1mb3JjZS1jbGVhbicsICct LW5vLXVwZGF0ZScsICctLWJ1aWxkJywgJy0tdGVzdCcsICctLW5vbi1pbnRlcmFjdGl2ZSddCiBj b21tYW5kX2ZhaWxlZDogZmFpbHVyZV9tZXNzYWdlPSdVbmFibGUgdG8gcGFzcyB0ZXN0cyB3aXRo b3V0IHBhdGNoICh0cmVlIGlzIHJlZD8pJyBzY3JpcHRfZXJyb3I9J01PQ0sgY2xlYW4gdGVzdCBm YWlsdXJlJyBwYXRjaD0nMTk3JwogIiIiCi0gICAgICAgIHNlbGYuX3J1bl90aHJvdWdoX3Rhc2so Y29tbWl0X3F1ZXVlLCBleHBlY3RlZF9zdGRlcnIsIFNjcmlwdEVycm9yKQorICAgICAgICB0YXNr ID0gc2VsZi5fcnVuX3Rocm91Z2hfdGFzayhjb21taXRfcXVldWUsIGV4cGVjdGVkX3N0ZGVyciwg U2NyaXB0RXJyb3IpCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwodGFzay5yZXN1bHRzX2Zyb21f cGF0Y2hfdGVzdF9ydW4odGFzay5fcGF0Y2gpLmZhaWxpbmdfdGVzdHMoKSwgWyJmb28uaHRtbCIs ICJiYXIuaHRtbCJdKQogCiAgICAgZGVmIHRlc3RfbGFuZF9mYWlsdXJlKHNlbGYpOgogICAgICAg ICBjb21taXRfcXVldWUgPSBNb2NrQ29tbWl0UXVldWUoWwpJbmRleDogVG9vbHMvU2NyaXB0cy93 ZWJraXRweS90b29sL2JvdC9wYXRjaGFuYWx5c2lzdGFzay5weQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L3BhdGNoYW5hbHlzaXN0YXNrLnB5CShyZXZpc2lv biA4NTQ2NSkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3QvcGF0Y2hhbmFseXNp c3Rhc2sucHkJKHdvcmtpbmcgY29weSkKQEAgLTY2LDYgKzY2LDcgQEAgY2xhc3MgUGF0Y2hBbmFs eXNpc1Rhc2sob2JqZWN0KToKICAgICAgICAgc2VsZi5fcGF0Y2ggPSBwYXRjaAogICAgICAgICBz ZWxmLl9zY3JpcHRfZXJyb3IgPSBOb25lCiAgICAgICAgIHNlbGYuX3Jlc3VsdHNfYXJjaGl2ZV9m cm9tX3BhdGNoX3Rlc3RfcnVuID0gTm9uZQorICAgICAgICBzZWxmLl9yZXN1bHRzX2Zyb21fcGF0 Y2hfdGVzdF9ydW4gPSBOb25lCiAgICAgICAgIHNlbGYuX2V4cGVjdGVkX2ZhaWx1cmVzID0gZGVs ZWdhdGUuZXhwZWN0ZWRfZmFpbHVyZXMoKQogICAgICAgICBhc3NlcnQoc2VsZi5fZXhwZWN0ZWRf ZmFpbHVyZXMpCiAKQEAgLTIwOCw3ICsyMDksNyBAQCBjbGFzcyBQYXRjaEFuYWx5c2lzVGFzayhv YmplY3QpOgogCiAgICAgICAgIGlmIHNlbGYuX2J1aWxkX2FuZF90ZXN0X3dpdGhvdXRfcGF0Y2go KToKICAgICAgICAgICAgICMgVGhlIGVycm9yIGZyb20gdGhlIHByZXZpb3VzIC5fdGVzdCgpIHJ1 biBpcyByZWFsLCByZXBvcnQgaXQuCi0gICAgICAgICAgICByZXR1cm4gc2VsZi5yZXBvcnRfZmFp bHVyZShmaXJzdF9yZXN1bHRzX2FyY2hpdmUpCisgICAgICAgICAgICByZXR1cm4gc2VsZi5yZXBv cnRfZmFpbHVyZShmaXJzdF9yZXN1bHRzX2FyY2hpdmUsIGZpcnN0X3Jlc3VsdHMpCiAKICAgICAg ICAgY2xlYW5fdHJlZV9yZXN1bHRzID0gc2VsZi5fZGVsZWdhdGUubGF5b3V0X3Rlc3RfcmVzdWx0 cygpCiAgICAgICAgIHNlbGYuX2V4cGVjdGVkX2ZhaWx1cmVzLmdyb3dfZXhwZWN0ZWRfZmFpbHVy ZXMoY2xlYW5fdHJlZV9yZXN1bHRzKQpAQCAtMjIwLDcgKzIyMSw3IEBAIGNsYXNzIFBhdGNoQW5h bHlzaXNUYXNrKG9iamVjdCk6CiAgICAgICAgICMgTm93IHRoYXQgd2UgaGF2ZSB1cGRhdGVkIGlu Zm9ybWF0aW9uIGFib3V0IGZhaWxpbmcgdGVzdHMgd2l0aCBhIGNsZWFuIGNoZWNrb3V0LCB3ZSBj YW4KICAgICAgICAgIyB0ZWxsIGlmIG91ciBvcmlnaW5hbCBmYWlsdXJlcyB3ZXJlIHVuZXhwZWN0 ZWQgYW5kIGZhaWwgdGhlIHBhdGNoIGlmIG5lY2Vzc2FyeS4KICAgICAgICAgaWYgc2VsZi5fZXhw ZWN0ZWRfZmFpbHVyZXMudW5leHBlY3RlZF9mYWlsdXJlcyhmaXJzdF9yZXN1bHRzKToKLSAgICAg ICAgICAgIHJldHVybiBzZWxmLnJlcG9ydF9mYWlsdXJlKGZpcnN0X3Jlc3VsdHNfYXJjaGl2ZSkK KyAgICAgICAgICAgIHJldHVybiBzZWxmLnJlcG9ydF9mYWlsdXJlKGZpcnN0X3Jlc3VsdHNfYXJj aGl2ZSwgZmlyc3RfcmVzdWx0cykKIAogICAgICAgICAjIFdlIGRvbid0IGtub3cgd2hhdCdzIGdv aW5nIG9uLiAgVGhlIHRyZWUgaXMgbGlrZWx5IHZlcnkgcmVkIChiZXlvbmQgb3VyIGxheW91dC10 ZXN0LXJlc3VsdHMKICAgICAgICAgIyBmYWlsdXJlIGxpbWl0KSwganVzdCBrZWVwIHJldHJ5aW5n IHRoZSBwYXRjaC4gdW50aWwgc29tZW9uZSBmaXhlcyB0aGUgdHJlZS4KQEAgLTIzMCwxMCArMjMx LDE1IEBAIGNsYXNzIFBhdGNoQW5hbHlzaXNUYXNrKG9iamVjdCk6CiAgICAgICAgIGFzc2VydChz ZWxmLl9wYXRjaC5pZCgpID09IHBhdGNoLmlkKCkpICAjIFBhdGNoQW5hbHlzaXNUYXNrIGlzIG5v dCBjdXJyZW50bHkgcmUtdXNlYWJsZS4KICAgICAgICAgcmV0dXJuIHNlbGYuX3Jlc3VsdHNfYXJj aGl2ZV9mcm9tX3BhdGNoX3Rlc3RfcnVuCiAKLSAgICBkZWYgcmVwb3J0X2ZhaWx1cmUoc2VsZiwg cmVzdWx0c19hcmNoaXZlPU5vbmUpOgorICAgIGRlZiByZXN1bHRzX2Zyb21fcGF0Y2hfdGVzdF9y dW4oc2VsZiwgcGF0Y2gpOgorICAgICAgICBhc3NlcnQoc2VsZi5fcGF0Y2guaWQoKSA9PSBwYXRj aC5pZCgpKSAgIyBQYXRjaEFuYWx5c2lzVGFzayBpcyBub3QgY3VycmVudGx5IHJlLXVzZWFibGUu CisgICAgICAgIHJldHVybiBzZWxmLl9yZXN1bHRzX2Zyb21fcGF0Y2hfdGVzdF9ydW4KKworICAg IGRlZiByZXBvcnRfZmFpbHVyZShzZWxmLCByZXN1bHRzX2FyY2hpdmU9Tm9uZSwgcmVzdWx0cz1O b25lKToKICAgICAgICAgaWYgbm90IHNlbGYudmFsaWRhdGUoKToKICAgICAgICAgICAgIHJldHVy biBGYWxzZQogICAgICAgICBzZWxmLl9yZXN1bHRzX2FyY2hpdmVfZnJvbV9wYXRjaF90ZXN0X3J1 biA9IHJlc3VsdHNfYXJjaGl2ZQorICAgICAgICBzZWxmLl9yZXN1bHRzX2Zyb21fcGF0Y2hfdGVz dF9ydW4gPSByZXN1bHRzCiAgICAgICAgIHJhaXNlIHNlbGYuX3NjcmlwdF9lcnJvcgogCiAgICAg ZGVmIHZhbGlkYXRlKHNlbGYpOgo=