59911 2011-05-01 19:38:39 -0700 Cleanup variable usage in RenderObject.cpp paintOutline() 2011-05-02 22:19:11 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 58999 0 benwells benwells benwells commit-queue mikelawther noel.gordon simon.fraser oldest_to_newest 396191 0 benwells 2011-05-01 19:38:39 -0700 Cleanup variable usage in RenderObject.cpp paintOutline() 396192 1 91872 benwells 2011-05-01 19:41:33 -0700 Created attachment 91872 Patch 396197 2 benwells 2011-05-01 19:45:32 -0700 This change has been added as an outcome of the review of bug 58999. As suggested the oc, os and ow variables have been renamed. I've also introduced some more variables to hopefully make the invocation of drawLineForBoxSize more obvious as I was finding it pretty confusing. 396911 3 91872 commit-queue 2011-05-02 19:22:55 -0700 Comment on attachment 91872 Patch Clearing flags on attachment: 91872 Committed r85577: <http://trac.webkit.org/changeset/85577> 396912 4 commit-queue 2011-05-02 19:22:59 -0700 All reviewed patches have been landed. Closing bug. 91872 2011-05-01 19:41:33 -0700 2011-05-02 19:22:55 -0700 Patch bug-59911-20110502124131.patch text/plain 3139 benwells U3VidmVyc2lvbiBSZXZpc2lvbjogODU0NTEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAyMDdiMzc2MDAzNDkxZWU1 YTgyNTU1MjMzMTI0ODg3MGQwMDAwZDk2Li4zOGM3MWEwYWYwNWIwOWUxYzBjZDA3OTcxNGRkYzYx MmYwOTc1OGJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDUtMDEgIEJlbiBX ZWxscyAgPGJlbndlbGxzQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBDbGVhbnVwIHZhcmlhYmxlIHVzYWdlIGluIFJlbmRlck9i amVjdC5jcHAgcGFpbnRPdXRsaW5lKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTU5OTExCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGZvciB0aGlzLCB0 aGVyZSBzaG91bGQgYmUgbm8gY2hhbmdlIGluIGJlaGF2aW91ci4KKworICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJPYmplY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyT2JqZWN0Ojpw YWludE91dGxpbmUpOgorCiAyMDExLTA1LTAxICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJPYmplY3QuY3BwCmluZGV4IGNjNjFiM2Y2OGE3YTNkYTBhMGQwMzY3MGM1 ZjZlYTE5YzZjNjFlMTQuLjg4NTRkM2NiY2IwNDY5YjYyZDBmNmQ5ZTFlMWRkYTczZGNiNWIwMDQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwCkBAIC0xMDI2LDEw ICsxMDI2LDEwIEBAIHZvaWQgUmVuZGVyT2JqZWN0OjpwYWludE91dGxpbmUoR3JhcGhpY3NDb250 ZXh0KiBncmFwaGljc0NvbnRleHQsIGludCB0eCwgaW50IHR5CiAgICAgICAgIHJldHVybjsKIAog ICAgIFJlbmRlclN0eWxlKiBzdHlsZVRvVXNlID0gc3R5bGUoKTsKLSAgICBpbnQgb3cgPSBzdHls ZVRvVXNlLT5vdXRsaW5lV2lkdGgoKTsKLSAgICBFQm9yZGVyU3R5bGUgb3MgPSBzdHlsZVRvVXNl LT5vdXRsaW5lU3R5bGUoKTsKKyAgICBpbnQgb3V0bGluZVdpZHRoID0gc3R5bGVUb1VzZS0+b3V0 bGluZVdpZHRoKCk7CisgICAgRUJvcmRlclN0eWxlIG91dGxpbmVTdHlsZSA9IHN0eWxlVG9Vc2Ut Pm91dGxpbmVTdHlsZSgpOwogCi0gICAgQ29sb3Igb2MgPSBzdHlsZVRvVXNlLT52aXNpdGVkRGVw ZW5kZW50Q29sb3IoQ1NTUHJvcGVydHlPdXRsaW5lQ29sb3IpOworICAgIENvbG9yIG91dGxpbmVD b2xvciA9IHN0eWxlVG9Vc2UtPnZpc2l0ZWREZXBlbmRlbnRDb2xvcihDU1NQcm9wZXJ0eU91dGxp bmVDb2xvcik7CiAKICAgICBpbnQgb2Zmc2V0ID0gc3R5bGVUb1VzZS0+b3V0bGluZU9mZnNldCgp OwogCkBAIC0xMDUxLDEwICsxMDUxLDE5IEBAIHZvaWQgUmVuZGVyT2JqZWN0OjpwYWludE91dGxp bmUoR3JhcGhpY3NDb250ZXh0KiBncmFwaGljc0NvbnRleHQsIGludCB0eCwgaW50IHR5CiAgICAg aWYgKGggPCAwIHx8IHcgPCAwKQogICAgICAgICByZXR1cm47CiAKLSAgICBkcmF3TGluZUZvckJv eFNpZGUoZ3JhcGhpY3NDb250ZXh0LCB0eCAtIG93LCB0eSAtIG93LCB0eCwgdHkgKyBoICsgb3cs IEJTTGVmdCwgb2MsIG9zLCBvdywgb3cpOwotICAgIGRyYXdMaW5lRm9yQm94U2lkZShncmFwaGlj c0NvbnRleHQsIHR4IC0gb3csIHR5IC0gb3csIHR4ICsgdyArIG93LCB0eSwgQlNUb3AsIG9jLCBv cywgb3csIG93KTsKLSAgICBkcmF3TGluZUZvckJveFNpZGUoZ3JhcGhpY3NDb250ZXh0LCB0eCAr IHcsIHR5IC0gb3csIHR4ICsgdyArIG93LCB0eSArIGggKyBvdywgQlNSaWdodCwgb2MsIG9zLCBv dywgb3cpOwotICAgIGRyYXdMaW5lRm9yQm94U2lkZShncmFwaGljc0NvbnRleHQsIHR4IC0gb3cs IHR5ICsgaCwgdHggKyB3ICsgb3csIHR5ICsgaCArIG93LCBCU0JvdHRvbSwgb2MsIG9zLCBvdywg b3cpOworICAgIGludCBsZWZ0T3V0ZXIgPSB0eCAtIG91dGxpbmVXaWR0aDsKKyAgICBpbnQgbGVm dElubmVyID0gdHg7CisgICAgaW50IHJpZ2h0T3V0ZXIgPSB0eCArIHcgKyBvdXRsaW5lV2lkdGg7 CisgICAgaW50IHJpZ2h0SW5uZXIgPSB0eCArIHc7CisgICAgaW50IHRvcE91dGVyID0gdHkgLSBv dXRsaW5lV2lkdGg7CisgICAgaW50IHRvcElubmVyID0gdHk7CisgICAgaW50IGJvdHRvbU91dGVy ID0gdHkgKyBoICsgb3V0bGluZVdpZHRoOworICAgIGludCBib3R0b21Jbm5lciA9IHR5ICsgaDsK KyAgICAKKyAgICBkcmF3TGluZUZvckJveFNpZGUoZ3JhcGhpY3NDb250ZXh0LCBsZWZ0T3V0ZXIs IHRvcE91dGVyLCBsZWZ0SW5uZXIsIGJvdHRvbU91dGVyLCBCU0xlZnQsIG91dGxpbmVDb2xvciwg b3V0bGluZVN0eWxlLCBvdXRsaW5lV2lkdGgsIG91dGxpbmVXaWR0aCk7CisgICAgZHJhd0xpbmVG b3JCb3hTaWRlKGdyYXBoaWNzQ29udGV4dCwgbGVmdE91dGVyLCB0b3BPdXRlciwgcmlnaHRPdXRl ciwgdG9wSW5uZXIsIEJTVG9wLCBvdXRsaW5lQ29sb3IsIG91dGxpbmVTdHlsZSwgb3V0bGluZVdp ZHRoLCBvdXRsaW5lV2lkdGgpOworICAgIGRyYXdMaW5lRm9yQm94U2lkZShncmFwaGljc0NvbnRl eHQsIHJpZ2h0SW5uZXIsIHRvcE91dGVyLCByaWdodE91dGVyLCBib3R0b21PdXRlciwgQlNSaWdo dCwgb3V0bGluZUNvbG9yLCBvdXRsaW5lU3R5bGUsIG91dGxpbmVXaWR0aCwgb3V0bGluZVdpZHRo KTsKKyAgICBkcmF3TGluZUZvckJveFNpZGUoZ3JhcGhpY3NDb250ZXh0LCBsZWZ0T3V0ZXIsIGJv dHRvbUlubmVyLCByaWdodE91dGVyLCBib3R0b21PdXRlciwgQlNCb3R0b20sIG91dGxpbmVDb2xv ciwgb3V0bGluZVN0eWxlLCBvdXRsaW5lV2lkdGgsIG91dGxpbmVXaWR0aCk7CiB9CiAKIEludFJl Y3QgUmVuZGVyT2JqZWN0OjphYnNvbHV0ZUJvdW5kaW5nQm94UmVjdChib29sIHVzZVRyYW5zZm9y bXMpCg==