5987 2005-12-07 04:11:31 -0800 <applet> is broken in xhtml 2019-02-06 09:03:27 -0800 1 1 1 Unclassified WebKit DOM 420+ Mac OS X 10.4 RESOLVED FIXED P4 Normal --- 1 eric eric cdumez c.petersen87 darin julien.palmas oldest_to_newest 25651 0 eric 2005-12-07 04:11:31 -0800 <applet> is broken in xhtml closeRenderer() is never being called by the xml parser. 25652 1 4985 eric 2005-12-07 04:12:35 -0800 Created attachment 4985 Proposed patch 25653 2 4985 eric 2005-12-07 04:19:10 -0800 Comment on attachment 4985 Proposed patch This line should actually probably go after the implicit table node escaping code right below it in the current patch. However another question raised by this patch, is why are we supporting implicit table element construction in xhtml? Hyatt or darin should look at this one. 25654 3 4985 eric 2005-12-07 04:25:58 -0800 Comment on attachment 4985 Proposed patch Actually, I think the logic should be re-written to step out of implicit elements, then call closeRenderer(), then step out to your parent... right now I bet <applet><tr /> </applet> will fail. :) 25655 4 4985 eric 2005-12-07 04:30:00 -0800 Comment on attachment 4985 Proposed patch Actually, implicit elements (<tbody>) are only created between <table> and <tr>, so we're safe here. However the fix would still probably be "more correct" to do what I mentioned above. 25656 5 4985 eric 2005-12-07 04:35:52 -0800 Comment on attachment 4985 Proposed patch Posting a better patch. 25657 6 4986 eric 2005-12-07 04:36:28 -0800 Created attachment 4986 Better patch (correctly handles implicit elements) 25658 7 4986 eric 2005-12-07 04:37:07 -0800 Comment on attachment 4986 Better patch (correctly handles implicit elements) Here is a better patch which correctly handles implicit elements. Dave or Darin should take a look at this one. 25666 8 4986 darin 2005-12-07 09:58:30 -0800 Comment on attachment 4986 Better patch (correctly handles implicit elements) There are three changes here. One is to call closeRenderer. That looks fine. Another is to set m_currentNode to the grandparent of the implicit node rather than the parent of the implicit node. That also seems fine, because we need to close the element. The third change is to remove NULL checks. That one worries me a bit, but I guess we can count on not getting an endElement callback unless we have successfully started and element. It's worth looking closely at that. What happens if the startElement fails? r=me 25673 9 eric 2005-12-07 14:44:32 -0800 I could add an ASSERT that m_currentNode->parentNode() != 0 if you'd like. But from what I understand this code never should get called in an error case. I've also tried with some xml docs missing opening tags, and not hit any crashes. 25697 10 eric 2005-12-08 01:06:49 -0800 *** Bug 5835 has been marked as a duplicate of this bug. *** 25740 11 eric 2005-12-08 18:26:46 -0800 *** Bug 3332 has been marked as a duplicate of this bug. *** 1502972 12 lforschler 2019-02-06 09:03:27 -0800 Mass moving XML DOM bugs to the "DOM" Component. 4985 2005-12-07 04:12:35 -0800 2005-12-07 04:36:28 -0800 Proposed patch applet.patch text/plain 640 eric SW5kZXg6IGtodG1sL3htbC94bWxfdG9rZW5pemVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAv Y3ZzL3Jvb3QvV2ViQ29yZS9raHRtbC94bWwveG1sX3Rva2VuaXplci5jcHAsdgpyZXRyaWV2aW5n IHJldmlzaW9uIDEuNTQKZGlmZiAtcCAtdSAtcjEuNTQga2h0bWwveG1sL3htbF90b2tlbml6ZXIu Y3BwCi0tLSBraHRtbC94bWwveG1sX3Rva2VuaXplci5jcHAJMjggTm92IDIwMDUgMTg6MjM6NDYg LTAwMDAJMS41NAorKysga2h0bWwveG1sL3htbF90b2tlbml6ZXIuY3BwCTcgRGVjIDIwMDUgMTE6 NTA6MjkgLTAwMDAKQEAgLTM3NSw2ICszNzUsNyBAQCB2b2lkIFhNTFRva2VuaXplcjo6ZW5kRWxl bWVudE5zKCkKIAogICAgIGlmIChtX2N1cnJlbnROb2RlLT5ub2RlVHlwZSgpID09IE5vZGU6OlRF WFRfTk9ERSkKICAgICAgICAgZXhpdFRleHQoKTsKKyAgICBtX2N1cnJlbnROb2RlLT5jbG9zZVJl bmRlcmVyKCk7CiAgICAgaWYgKG1fY3VycmVudE5vZGUtPnBhcmVudE5vZGUoKSAhPSAwKSB7CiAg ICAgICAgIGRvIHsKICAgICAgICAgICAgIG1fY3VycmVudE5vZGUgPSBtX2N1cnJlbnROb2RlLT5w YXJlbnROb2RlKCk7Cg== 4986 2005-12-07 04:36:28 -0800 2005-12-07 09:58:30 -0800 Better patch (correctly handles implicit elements) applet.patch text/plain 946 eric SW5kZXg6IGtodG1sL3htbC94bWxfdG9rZW5pemVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAv Y3ZzL3Jvb3QvV2ViQ29yZS9raHRtbC94bWwveG1sX3Rva2VuaXplci5jcHAsdgpyZXRyaWV2aW5n IHJldmlzaW9uIDEuNTQKZGlmZiAtcCAtdSAtcjEuNTQga2h0bWwveG1sL3htbF90b2tlbml6ZXIu Y3BwCi0tLSBraHRtbC94bWwveG1sX3Rva2VuaXplci5jcHAJMjggTm92IDIwMDUgMTg6MjM6NDYg LTAwMDAJMS41NAorKysga2h0bWwveG1sL3htbF90b2tlbml6ZXIuY3BwCTcgRGVjIDIwMDUgMTI6 MzU6MTkgLTAwMDAKQEAgLTM3NSwxMiArMzc1LDEwIEBAIHZvaWQgWE1MVG9rZW5pemVyOjplbmRF bGVtZW50TnMoKQogCiAgICAgaWYgKG1fY3VycmVudE5vZGUtPm5vZGVUeXBlKCkgPT0gTm9kZTo6 VEVYVF9OT0RFKQogICAgICAgICBleGl0VGV4dCgpOwotICAgIGlmIChtX2N1cnJlbnROb2RlLT5w YXJlbnROb2RlKCkgIT0gMCkgewotICAgICAgICBkbyB7Ci0gICAgICAgICAgICBtX2N1cnJlbnRO b2RlID0gbV9jdXJyZW50Tm9kZS0+cGFyZW50Tm9kZSgpOwotICAgICAgICB9IHdoaWxlIChtX2N1 cnJlbnROb2RlICYmIG1fY3VycmVudE5vZGUtPmltcGxpY2l0Tm9kZSgpKTsKLSAgICB9Ci0vLyAj IyMgIGVsc2UgZXJyb3IKKyAgICB3aGlsZSAobV9jdXJyZW50Tm9kZS0+aW1wbGljaXROb2RlKCkp CisgICAgICAgIG1fY3VycmVudE5vZGUgPSBtX2N1cnJlbnROb2RlLT5wYXJlbnROb2RlKCk7Cisg ICAgbV9jdXJyZW50Tm9kZS0+Y2xvc2VSZW5kZXJlcigpOworICAgIG1fY3VycmVudE5vZGUgPSBt X2N1cnJlbnROb2RlLT5wYXJlbnROb2RlKCk7CiB9CiAKIHZvaWQgWE1MVG9rZW5pemVyOjpjaGFy YWN0ZXJzKGNvbnN0IHhtbENoYXIgKnMsIGludCBsZW4pCg==