59659 2011-04-27 16:56:18 -0700 Make GraphicsContext3DChromium play nice with strict OwnPtrs 2011-04-27 17:49:22 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 59434 59459 59487 1 abarth abarth kbr levin oldest_to_newest 394003 0 abarth 2011-04-27 16:56:18 -0700 Make GraphicsContext3DChromium play nice with strict OwnPtrs 394004 1 91385 abarth 2011-04-27 16:56:57 -0700 Created attachment 91385 Patch 394015 2 91385 levin 2011-04-27 17:06:25 -0700 Comment on attachment 91385 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91385&action=review > Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp:112 > + OwnPtr<WebKit::WebGraphicsContext3D> webContext = adoptPtr(WebKit::webKitClient()->createGraphicsContext3D()); Since it is part of webKitClient we can't change it to return PassOwnPtr? 394021 3 91385 abarth 2011-04-27 17:14:49 -0700 Comment on attachment 91385 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91385&action=review >> Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp:112 >> - WebKit::WebGraphicsContext3D* webContext = WebKit::webKitClient()->createGraphicsContext3D(); >> + OwnPtr<WebKit::WebGraphicsContext3D> webContext = adoptPtr(WebKit::webKitClient()->createGraphicsContext3D()); > > Since it is part of webKitClient we can't change it to return PassOwnPtr? I don't think we can use PassOwnPtr in WebKitClient.h. That code needs to be free of WebCore types. 394024 4 abarth 2011-04-27 17:17:35 -0700 Committed r85126: <http://trac.webkit.org/changeset/85126> 91385 2011-04-27 16:56:57 -0700 2011-04-27 17:14:49 -0700 Patch bug-59659-20110427165656.patch text/plain 2029 abarth SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA4NTEyMikKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDQtMjcgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIEdyYXBoaWNzQ29u dGV4dDNEQ2hyb21pdW0gcGxheSBuaWNlIHdpdGggc3RyaWN0IE93blB0cnMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU5NjU5CisKKyAgICAgICAgQXR0 ZW1wdCAjMi4gIEhvcGVmdWxseSB0aGlzIHRpbWUgSSB3b24ndCBtYWtlIGV2ZXJ5dGhpbmcgY3Jh c2guCisKKyAgICAgICAgKiBzcmMvR3JhcGhpY3NDb250ZXh0M0RDaHJvbWl1bS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQzREludGVybmFsOjppbml0aWFsaXplKToKKwog MjAxMS0wNC0yNyAgRGlyayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9HcmFwaGljc0NvbnRleHQzRENocm9taXVtLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9HcmFwaGljc0NvbnRleHQzRENocm9taXVtLmNwcAkocmV2aXNp b24gODUxMTIpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9HcmFwaGljc0NvbnRleHQz RENocm9taXVtLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTA5LDcgKzEwOSw3IEBAIGJvb2wgR3Jh cGhpY3NDb250ZXh0M0RJbnRlcm5hbDo6aW5pdGlhbGkKICAgICB3ZWJBdHRyaWJ1dGVzLmFudGlh bGlhcyA9IGF0dHJzLmFudGlhbGlhczsKICAgICB3ZWJBdHRyaWJ1dGVzLnByZW11bHRpcGxpZWRB bHBoYSA9IGF0dHJzLnByZW11bHRpcGxpZWRBbHBoYTsKICAgICB3ZWJBdHRyaWJ1dGVzLmNhblJl Y292ZXJGcm9tQ29udGV4dExvc3MgPSBhdHRycy5jYW5SZWNvdmVyRnJvbUNvbnRleHRMb3NzOwot ICAgIFdlYktpdDo6V2ViR3JhcGhpY3NDb250ZXh0M0QqIHdlYkNvbnRleHQgPSBXZWJLaXQ6Ondl YktpdENsaWVudCgpLT5jcmVhdGVHcmFwaGljc0NvbnRleHQzRCgpOworICAgIE93blB0cjxXZWJL aXQ6OldlYkdyYXBoaWNzQ29udGV4dDNEPiB3ZWJDb250ZXh0ID0gYWRvcHRQdHIoV2ViS2l0Ojp3 ZWJLaXRDbGllbnQoKS0+Y3JlYXRlR3JhcGhpY3NDb250ZXh0M0QoKSk7CiAgICAgaWYgKCF3ZWJD b250ZXh0KQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKQEAgLTEyMCwxMSArMTIwLDkgQEAgYm9v bCBHcmFwaGljc0NvbnRleHQzREludGVybmFsOjppbml0aWFsaQogCiAgICAgaWYgKCFtX3dlYlZp ZXdJbXBsKQogICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgaWYgKCF3ZWJDb250ZXh0LT5pbml0 aWFsaXplKHdlYkF0dHJpYnV0ZXMsIG1fd2ViVmlld0ltcGwsIHJlbmRlckRpcmVjdGx5VG9Ib3N0 V2luZG93KSkgewotICAgICAgICBkZWxldGUgd2ViQ29udGV4dDsKKyAgICBpZiAoIXdlYkNvbnRl eHQtPmluaXRpYWxpemUod2ViQXR0cmlidXRlcywgbV93ZWJWaWV3SW1wbCwgcmVuZGVyRGlyZWN0 bHlUb0hvc3RXaW5kb3cpKQogICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgfQotICAgIG1faW1w bC5zZXQod2ViQ29udGV4dCk7CisgICAgbV9pbXBsID0gd2ViQ29udGV4dC5yZWxlYXNlKCk7CiAK ICNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCiAgICAgbV9jb21wb3NpdGluZ0xheWVy ID0gV2ViR0xMYXllckNocm9taXVtOjpjcmVhdGUoMCk7Cg==