59586 2011-04-27 00:57:22 -0700 [GTK][Qt] fast/events/keydown-1.html fails 2011-05-02 15:20:37 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P3 Normal --- 1 mrobinson cshu commit-queue cshu oldest_to_newest 393428 0 mrobinson 2011-04-27 00:57:22 -0700 The period is not missing from the end of the sentence, as the test suggests. --- /tmp/layout-test-results/fast/events/keydown-1-expected.txt 2011-04-27 00:56:22.484711997 -0700 +++ /tmp/layout-test-results/fast/events/keydown-1-actual.txt 2011-04-27 00:56:22.484711997 -0700 @@ -3,4 +3,4 @@ keydown in subframe: [object KeyboardEvent] keydown in subframe: [object KeyboardEvent] -This sentence should not end with a period +This sentence should not end with a period. 393633 1 ap 2011-04-27 10:15:39 -0700 FWIW, the test was converted to text only in <trac.webkit.org/r84897>. This looks more like an actual bug in the port at a first glance though. 393635 2 mrobinson 2011-04-27 10:20:12 -0700 (In reply to comment #1) > FWIW, the test was converted to text only in <trac.webkit.org/r84897>. This looks more like an actual bug in the port at a first glance though. Yes, even before the text conversion this test was incredibly flaky across different machines. The text conversion provides good impetus to finally squash this bug. 393645 3 cshu 2011-04-27 10:34:58 -0700 I believe so. The pixel result may falsely consider it's passing because one dot doesn't contribute much in the whole image. This test also fails on Qt but it was skipped. I suspect it's a key binding issue. Probably we should rewrite the test to use common key codes. 396611 4 91970 cshu 2011-05-02 13:39:23 -0700 Created attachment 91970 fix patch 396621 5 91970 mrobinson 2011-05-02 13:48:44 -0700 Comment on attachment 91970 fix patch Thanks! 396714 6 commit-queue 2011-05-02 15:19:08 -0700 The commit-queue encountered the following flaky tests while processing attachment 91970: inspector/debugger/debugger-scripts.html bug 59921 (authors: pfeldman@chromium.org and podivilov@chromium.org) The commit-queue is continuing to process your patch. 396717 7 91970 commit-queue 2011-05-02 15:20:32 -0700 Comment on attachment 91970 fix patch Clearing flags on attachment: 91970 Committed r85528: <http://trac.webkit.org/changeset/85528> 396718 8 commit-queue 2011-05-02 15:20:37 -0700 All reviewed patches have been landed. Closing bug. 91970 2011-05-02 13:39:23 -0700 2011-05-02 15:20:31 -0700 fix patch 59586_1.patch text/plain 2592 cshu SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDg1NTE0KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDUtMDIgIENoYW5nIFNodSAgPGNzaHVA d2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbR1RLXVtRdF0gZmFzdC9ldmVudHMva2V5ZG93bi0xLmh0bWwgZmFpbHMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU5NTg2CisKKyAgICAgICAg UmVwbGFjZSBtYWMtc3BlY2lmaWMga2V5cyB3aXRoIGNyb3NzLXBsYXRmb3JtIGtleXMgdG8gbWFr ZSB0aGUgdGVzdAorICAgICAgICBwYXNzIG9uIEdUSyBhbmQgUXQgcGxhdGZvcm1zLgorCisgICAg ICAgICogZmFzdC9ldmVudHMva2V5ZG93bi0xLmh0bWw6CisgICAgICAgICogcGxhdGZvcm0vZ3Rr L1NraXBwZWQ6CisgICAgICAgICogcGxhdGZvcm0vcXQvU2tpcHBlZDoKKwogMjAxMS0wNS0wMiAg TWFyayBQaWxncmltICA8cGlsZ3JpbUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgVG9ueSBDaGFuZy4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2tleWRvd24tMS5o dG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2tleWRvd24tMS5odG1s CShyZXZpc2lvbiA4NTE3OSkKKysrIExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2tleWRvd24tMS5o dG1sCSh3b3JraW5nIGNvcHkpCkBAIC00MSw5ICs0MSw5IEBAIGZ1bmN0aW9uIHN0ZXAyKCkgewog ICAgIAogICAgIHdpbmRvdy5mcmFtZXNbMF0uZG9jdW1lbnQuZXhlY0NvbW1hbmQoIkluc2VydFRl eHQiLCBmYWxzZSwgIlRoaXMgc2VudGVuY2Ugc2hvdWxkIG5vdCBlbmQgd2l0aCBhIHBlcmlvZC4i KTsKICAgICAvLyBNb3ZlIGJhY2t3YXJkIGJ5IG9uZSBjaGFyYWN0ZXIuCi0gICAgZXZlbnRTZW5k ZXIua2V5RG93bigiYiIsIEFycmF5KCJjdHJsS2V5IikpOworICAgIGV2ZW50U2VuZGVyLmtleURv d24oImxlZnRBcnJvdyIpOwogICAgIC8vIERlbGV0ZSBmb3J3YXJkIGJ5IG9uZSBjaGFyYWN0ZXIu Ci0gICAgZXZlbnRTZW5kZXIua2V5RG93bigiZCIsIEFycmF5KCJjdHJsS2V5IikpOworICAgIGV2 ZW50U2VuZGVyLmtleURvd24oImRlbGV0ZSIpOwogCiAgICAgbG9nKHdpbmRvdy5mcmFtZXNbMF0u ZG9jdW1lbnQuYm9keS5pbm5lclRleHQpOwogICAgIHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxl ci5ub3RpZnlEb25lKCk7CkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZAkocmV2aXNpb24g ODUxNzkpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZAkod29ya2luZyBjb3B5 KQpAQCAtMTM5Myw5ICsxMzkzLDYgQEAgZmFzdC90ZXh0L3plcm8td2lkdGgtY2hhcmFjdGVycy1j b21wbGV4LQogIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTkzOTEK IGVkaXRpbmcvdGV4dC1pdGVyYXRvci9maW5kU3RyaW5nLmh0bWwKIAotIyBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTk1ODYKLWZhc3QvZXZlbnRzL2tleWRvd24tMS5o dG1sCi0KICMgVW5za2lwIHdoZW4gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTU5NTcxIGlzIGZpeGVkCiBmYXN0L2RvbS9zaGFkb3cvZ2Mtc2hhZG93Lmh0bWwKIGZhc3Qv ZG9tL3NoYWRvdy9uby1yZW5kZXJlcnMtZm9yLWxpZ2h0LWNoaWxkcmVuLmh0bWwKXCBObyBuZXds aW5lIGF0IGVuZCBvZiBmaWxlCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVk Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQJKHJldmlzaW9u IDg1MTc5KQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAkod29ya2luZyBjb3B5 KQpAQCAtMTQ1Myw3ICsxNDUzLDYgQEAgZmFzdC9ldmVudHMvYXV0b3Njcm9sbC5odG1sCiBmYXN0 L2V2ZW50cy9jbGljay1jb3VudC5odG1sCiBmYXN0L2V2ZW50cy9jb250ZW50LWNoYW5nZWQtZHVy aW5nLWRyb3AuaHRtbAogZmFzdC9ldmVudHMvanMta2V5Ym9hcmQtZXZlbnQtY3JlYXRpb24uaHRt bAotZmFzdC9ldmVudHMva2V5ZG93bi0xLmh0bWwKIGZhc3QvZXZlbnRzL2tleXByZXNzLWluc2Vy dC10YWIuaHRtbAogZmFzdC9ldmVudHMvb25kcmFnZW50ZXIuaHRtbAogZmFzdC9ldmVudHMvcmV2 ZWFsLWxpbmstd2hlbi1mb2N1c2VkLmh0bWwK