59487 2011-04-26 13:49:16 -0700 OwnPtr assignment operator should be private 2011-04-27 17:49:22 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 59459 59659 1 abarth abarth abarth commit-queue darin eric jamesr kbr webkit.review.bot oldest_to_newest 392665 0 abarth 2011-04-26 13:49:16 -0700 OwnPtr assignment operator should be private 392666 1 91150 abarth 2011-04-26 13:50:42 -0700 Created attachment 91150 Patch 392680 2 91150 kbr 2011-04-26 14:05:36 -0700 Comment on attachment 91150 Patch This is important to fix as it allowed https://bugs.webkit.org/show_bug.cgi?id=59459 to creep in during the strict OwnPtr cleanup yesterday. I wonder whether it's worth a comment directly above the new private assignment operator indicating why it's necessary. Looks good to me otherwise. 393406 3 commit-queue 2011-04-27 00:14:16 -0700 The commit-queue encountered the following flaky tests while processing attachment 91150: java/lc3/JSObject/ToObject-001.html bug 53091 (author: ap@webkit.org) http/tests/xmlhttprequest/basic-auth.html bug 51613 (author: ap@webkit.org) The commit-queue is continuing to process your patch. 393408 4 91150 commit-queue 2011-04-27 00:15:58 -0700 Comment on attachment 91150 Patch Clearing flags on attachment: 91150 Committed r85028: <http://trac.webkit.org/changeset/85028> 393409 5 commit-queue 2011-04-27 00:16:04 -0700 All reviewed patches have been landed. Closing bug. 393430 6 webkit.review.bot 2011-04-27 01:01:50 -0700 http://trac.webkit.org/changeset/85028 might have broken Chromium Win Release 91150 2011-04-26 13:50:42 -0700 2011-04-27 00:15:58 -0700 Patch bug-59487-20110426135040.patch text/plain 1045 abarth SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODQ5NDgpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTEtMDQtMjYgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPd25QdHIgYXNzaWdubWVudCBv cGVyYXRvciBzaG91bGQgYmUgcHJpdmF0ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NTk0ODcKKworICAgICAgICBVbmZvcnR1bmF0ZWx5IHdlIGNhbid0 IHJlbW92ZSB0aGUgY29weSBjb25zdHJ1Y3RvciBiZWNhdXNlIG9mIHNvbWUKKyAgICAgICAgZGV0 YWlsIGFib3V0IGdjYy4gIChUaGUgaXNzdWUgaXMgZG9jdW1lbnRlZCBpbiBhIGNvbW1lbnQgYWxy ZWFkeS4pCisKKyAgICAgICAgKiB3dGYvT3duUHRyLmg6CisKIDIwMTEtMDQtMjYgIERhbiBCZXJu c3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYXJrIFJvd2Uu CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL093blB0ci5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvT3duUHRyLmgJKHJldmlzaW9uIDg0OTQyKQorKysg U291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9Pd25QdHIuaAkod29ya2luZyBjb3B5KQpAQCAtODMs NiArODMsOCBAQCBuYW1lc3BhY2UgV1RGIHsKICNlbmRpZgogCiAgICAgcHJpdmF0ZToKKyAgICAg ICAgT3duUHRyJiBvcGVyYXRvcj0oY29uc3QgT3duUHRyPFQ+Jik7CisKICAgICAgICAgUHRyVHlw ZSBtX3B0cjsKICAgICB9OwogCg==