59428 2011-04-25 23:48:45 -0700 Enable strict mode for OwnPtr and PassOwnPtr 2011-05-01 18:26:19 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 59666 59667 59861 59876 59878 59881 59898 59909 1 abarth abarth abarth buildbot darin dglazkov eric gustavo.noronha gustavo levin webkit-ews webkit.review.bot xan.lopez oldest_to_newest 392309 0 abarth 2011-04-25 23:48:45 -0700 Enable strict mode for OwnPtr 392310 1 91073 abarth 2011-04-25 23:49:26 -0700 Created attachment 91073 Patch 392313 2 91073 levin 2011-04-25 23:56:56 -0700 Comment on attachment 91073 Patch pending ews results. 392317 3 webkit.review.bot 2011-04-26 00:12:28 -0700 Attachment 91073 did not build on chromium: Build output: http://queues.webkit.org/results/8509542 392321 4 webkit-ews 2011-04-26 00:19:32 -0700 Attachment 91073 did not build on qt: Build output: http://queues.webkit.org/results/8509543 392338 5 buildbot 2011-04-26 00:41:44 -0700 Attachment 91073 did not build on win: Build output: http://queues.webkit.org/results/8506647 392343 6 webkit.review.bot 2011-04-26 00:55:45 -0700 Attachment 91073 did not build on chromium: Build output: http://queues.webkit.org/results/8508569 392369 7 gustavo.noronha 2011-04-26 03:01:40 -0700 Attachment 91073 did not build on gtk: Build output: http://queues.webkit.org/results/8507579 393763 8 91337 abarth 2011-04-27 13:40:17 -0700 Created attachment 91337 Patch 393764 9 91337 levin 2011-04-27 13:41:34 -0700 Comment on attachment 91337 Patch This will make it easier for other ports to break the mac platform, but I guess it will get fixed quickly and it shouldn't happen too often. 393777 10 abarth 2011-04-27 13:55:51 -0700 > This will make it easier for other ports to break the mac platform, but I guess it will get fixed quickly and it shouldn't happen too often. Yeah, this is just an intermediate state. We shouldn't linger here very long. 393781 11 abarth 2011-04-27 13:59:04 -0700 Committed r85084: <http://trac.webkit.org/changeset/85084> 393790 12 abarth 2011-04-27 14:03:36 -0700 Re-opening because we need to enable this on other platforms. 393815 13 webkit.review.bot 2011-04-27 14:19:02 -0700 http://trac.webkit.org/changeset/85084 might have broken Leopard Intel Debug (Build) 393844 14 darin 2011-04-27 14:41:49 -0700 We also want to enable the strict mode for PassOwnPtr. 393849 15 abarth 2011-04-27 14:45:56 -0700 (In reply to comment #14) > We also want to enable the strict mode for PassOwnPtr. Yep. I'm testing compile for that one now. 394122 16 91337 levin 2011-04-27 19:29:28 -0700 Comment on attachment 91337 Patch Clearing r+ since it has been landed (to move out of the list to be committed). 396104 17 91860 abarth 2011-05-01 17:33:22 -0700 Created attachment 91860 Patch 396109 18 abarth 2011-05-01 17:33:50 -0700 Committed r85445: <http://trac.webkit.org/changeset/85445> 396156 19 91860 abarth 2011-05-01 18:02:54 -0700 Comment on attachment 91860 Patch Oh, well technically we didn't do strict PassOwnPtr, but that can be another bug. 91073 2011-04-25 23:49:26 -0700 2011-04-27 13:40:12 -0700 Patch bug-59428-20110425234924.patch text/plain 1179 abarth SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODQ4ODYpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTEtMDQtMjUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFbmFibGUgc3RyaWN0IG1vZGUg Zm9yIE93blB0cgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NTk0MjgKKworICAgICAgICBUaGVyZSBhcmUgc3RpbGwgZm91ciB3aGl0ZWxpc3RlZCBmaWxl cyBpbiBXZWJDb3JlIHRoYXQgbmVlZCB0byBiZQorICAgICAgICBmaXhlZCwgYnV0IHRoaXMgcGF0 Y2ggc2hvdWxkIHByZXZlbnQgcmVncmVzc2lvbnMuCisKKyAgICAgICAgKiB3dGYvT3duUHRyLmg6 CisKIDIwMTEtMDQtMjUgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBPbGl2ZXIgSHVudC4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS93dGYvT3duUHRyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9P d25QdHIuaAkocmV2aXNpb24gODQ4ODApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL093 blB0ci5oCSh3b3JraW5nIGNvcHkpCkBAIC0yOCw5ICsyOCw2IEBACiAjaW5jbHVkZSA8YWxnb3Jp dGhtPgogI2luY2x1ZGUgPG1lbW9yeT4KIAotLy8gUmVtb3ZlIHRoaXMgb25jZSB3ZSBtYWtlIGFs bCBXZWJLaXQgY29kZSBjb21wYXRpYmxlIHdpdGggc3RyaWN0ZXIgcnVsZXMgYWJvdXQgT3duUHRy LgotI2RlZmluZSBMT09TRV9PV05fUFRSCi0KIG5hbWVzcGFjZSBXVEYgewogCiAgICAgLy8gVW5s aWtlIG1vc3Qgb2Ygb3VyIHNtYXJ0IHBvaW50ZXJzLCBPd25QdHIgY2FuIHRha2UgZWl0aGVyIHRo ZSBwb2ludGVyIHR5cGUgb3IgdGhlIHBvaW50ZWQtdG8gdHlwZS4K 91337 2011-04-27 13:40:17 -0700 2011-05-01 17:33:16 -0700 Patch bug-59428-20110427134016.patch text/plain 1020 abarth SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODUwNzgpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTEtMDQtMjcgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFbmFibGUgc3RyaWN0IG1vZGUg Zm9yIE93blB0cgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NTk0MjgKKworICAgICAgICBUaGlzIHBhdGNoIGVuYWJsZXMgc3RyaWN0IG1vZGUgZm9yIE93 blB0ciBvbiBQTEFURk9STShNQUMpIG9ubHkuCisKKyAgICAgICAgKiB3dGYvT3duUHRyLmg6CisK IDIwMTEtMDQtMjcgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29nbGUuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IERhdmlkIExldmluLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L3d0Zi9Pd25QdHIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL093 blB0ci5oCShyZXZpc2lvbiA4NTA3NCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvT3du UHRyLmgJKHdvcmtpbmcgY29weSkKQEAgLTI5LDcgKzI5LDkgQEAKICNpbmNsdWRlIDxtZW1vcnk+ CiAKIC8vIFJlbW92ZSB0aGlzIG9uY2Ugd2UgbWFrZSBhbGwgV2ViS2l0IGNvZGUgY29tcGF0aWJs ZSB3aXRoIHN0cmljdGVyIHJ1bGVzIGFib3V0IE93blB0ci4KKyNpZiAhUExBVEZPUk0oTUFDKQog I2RlZmluZSBMT09TRV9PV05fUFRSCisjZW5kaWYKIAogbmFtZXNwYWNlIFdURiB7CiAK 91860 2011-05-01 17:33:22 -0700 2011-05-01 18:02:54 -0700 Patch bug-59428-20110501173320.patch text/plain 1163 abarth SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODU0NDQpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTEtMDUtMDEgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBEYXZpZCBMZXZpbi4KKworICAgICAgICBFbmFibGUgc3RyaWN0IG1vZGUgZm9y IE93blB0ciBhbmQgUGFzc093blB0cgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NTk0MjgKKworICAgICAgICAqIHd0Zi9Pd25QdHIuaDoKKwogMjAxMS0w NS0wMSAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9P d25QdHIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL093blB0ci5o CShyZXZpc2lvbiA4NTQ0NCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvT3duUHRyLmgJ KHdvcmtpbmcgY29weSkKQEAgLTI4LDExICsyOCw2IEBACiAjaW5jbHVkZSA8YWxnb3JpdGhtPgog I2luY2x1ZGUgPG1lbW9yeT4KIAotLy8gUmVtb3ZlIHRoaXMgb25jZSB3ZSBtYWtlIGFsbCBXZWJL aXQgY29kZSBjb21wYXRpYmxlIHdpdGggc3RyaWN0ZXIgcnVsZXMgYWJvdXQgT3duUHRyLgotI2lm ICFQTEFURk9STShNQUMpICYmICFQTEFURk9STShDSFJPTUlVTSkgJiYgIVBMQVRGT1JNKFFUKSAm JiAhUExBVEZPUk0oR1RLKSAmJiAhUExBVEZPUk0oV0lOKQotI2RlZmluZSBMT09TRV9PV05fUFRS Ci0jZW5kaWYKLQogbmFtZXNwYWNlIFdURiB7CiAKICAgICAvLyBVbmxpa2UgbW9zdCBvZiBvdXIg c21hcnQgcG9pbnRlcnMsIE93blB0ciBjYW4gdGFrZSBlaXRoZXIgdGhlIHBvaW50ZXIgdHlwZSBv ciB0aGUgcG9pbnRlZC10byB0eXBlLgo=