5940 2005-12-04 23:56:42 -0800 <svg> inside <body> incorrectly extends over top/bottom borders 2007-07-14 16:17:16 -0700 1 1 1 Unclassified WebKit SVG 420+ Mac OS X 10.4 RESOLVED FIXED http://developer.mozilla.org/presentations/xtech2005/svg-canvas/SVGDemo.xml NeedsReduction P2 Normal --- 12207 1 rwlbuis webkit-unassigned ian oldest_to_newest 25544 0 rwlbuis 2005-12-04 23:56:42 -0800 Hi, See topic :) It seems like the big gradient renders over everyhing else? Cheers, Rob. 25659 1 4987 rwlbuis 2005-12-07 04:51:32 -0800 Created attachment 4987 Reduced testcase This testcase has script and style elements removed. Also just one svg shape(rect) and a form that should display over the svg rect. 25690 2 eric 2005-12-07 23:47:49 -0800 I bet my disabling of RenderLayer creation for svg elements is causing the z-ordering system to be confused... 28488 3 eric 2006-01-15 03:10:42 -0800 This will crash recent development builds due to an ASSERT. 30164 4 eric 2006-01-26 14:54:19 -0800 Removing: virtual bool requiresLayer() { return false; } should fix this. The problem then becomes making sure that they layer code doesnt' cause double-opacity in certain instances, since the SVG render objects handle their own opacity instead of relying on RenderLayer. 52291 5 eric 2006-08-11 21:50:23 -0700 This seems to be a CSS selector problem at this point. 52292 6 eric 2006-08-11 21:56:16 -0700 Actually, I was wrong. This is still a z-order issue. 29890 7 eric 2007-01-31 04:45:40 -0800 It seems that webkit renders it fine now, except for slice. 8513 8 eric 2007-06-01 15:54:22 -0700 It's still not clipping 100% correctly. The top and bottom extend too far. 8514 9 14836 eric 2007-06-01 16:03:18 -0700 Created attachment 14836 even better test case This seems to be a CDF interaction problem. Somehow the SVG thinks it is taller than it should think it is. 7532 10 15030 rwlbuis 2007-06-14 13:49:22 -0700 Created attachment 15030 Fix z-index problems This should fix the last issue. It still needs a testcase, but that should be easy. What is more annoying is that it changes most DRT results. So we may need to wait with it and make RenderSVGRoot output RenderSVGRoot instead of RenderSVGContainer in the DRT in one fell swoop. Cheers, Rob. 7531 11 15030 eric 2007-06-14 13:51:38 -0700 Comment on attachment 15030 Fix z-index problems Perfect. The final patch will need to include test updates as well as this new test. However the code change itself looks great. Rob will land this later this week. 5403 12 15030 mrowe 2007-07-06 03:15:21 -0700 Comment on attachment 15030 Fix z-index problems Rob said there is an issue with SVG + z-indexing that he needs to discuss with Hyatt before this can be landed. Marking as r- to get it out of the commit queue for now. 4706 13 zimmermann 2007-07-14 16:16:25 -0700 Fixed in r24292. 4987 2005-12-07 04:51:32 -0800 2007-06-01 16:03:18 -0700 Reduced testcase SVGDemo.xml application/xml 831 rwlbuis PGh0bWwgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwiPgo8aGVhZD4KICA8dGl0 bGU+WFRlY2ggU1ZHIERlbW88L3RpdGxlPgo8L2hlYWQ+Cjxib2R5IGlkPSJib2R5IgogICBzdHls ZT0icG9zaXRpb246YWJzb2x1dGU7IHotaW5kZXg6MDsgYm9yZGVyOjFweCBzb2xpZCBibGFjazsg bGVmdDo1JTsgdG9wOjUlOyB3aWR0aDo5MCU7IGhlaWdodDo5MCU7Ij4KICA8Zm9ybT4KICAgICA8 ZmllbGRzZXQ+CiAgICAgICA8bGVnZW5kPkhUTUwgRm9ybTwvbGVnZW5kPgogICAgICAgPHA+PGJ1 dHRvbj5BY3RpdmF0ZSE8L2J1dHRvbj48L3A+CiAgICAgPC9maWVsZHNldD4KICA8L2Zvcm0+CiAg PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZlcnNpb249IjEuMSIKICAg IHZpZXdCb3g9IjAgMCAxMDAgMTAwIgogICAgcHJlc2VydmVBc3BlY3RSYXRpbz0ieE1pZFlNaWQg c2xpY2UiCiAgICBzdHlsZT0id2lkdGg6MTAwJTsgaGVpZ2h0OjEwMCU7IHBvc2l0aW9uOmFic29s dXRlOyB0b3A6MDsgbGVmdDowOyB6LWluZGV4Oi0xOyI+CiAgICA8bGluZWFyR3JhZGllbnQgaWQ9 ImdyYWRpZW50Ij4KICAgICAgPHN0b3Agc3RvcC1jb2xvcj0ieWVsbG93IiBjbGFzcz0iYmVnaW4i IG9mZnNldD0iMCUiLz4KICAgICAgPHN0b3Agc3RvcC1jb2xvcj0iZ3JlZW4iIGNsYXNzPSJlbmQi IG9mZnNldD0iMTAwJSIvPgogICAgPC9saW5lYXJHcmFkaWVudD4KICAgIDxyZWN0IHg9IjAiIHk9 IjAiIHdpZHRoPSIxMDAiIGhlaWdodD0iMTAwIgogICAgIHN0eWxlPSJmaWxsOnVybCgjZ3JhZGll bnQpIiAvPgogIDwvc3ZnPgo8L2JvZHk+CjwvaHRtbD4K 14836 2007-06-01 16:03:18 -0700 2007-06-01 16:03:18 -0700 even better test case slice.xhtml application/xhtml+xml 301 eric PGh0bWwgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwiPgo8Ym9keSBzdHlsZT0i Ym9yZGVyOjFweCBzb2xpZCBibGFjazsgd2lkdGg6OTAlOyBoZWlnaHQ6OTAlOyI+CiAgPHN2ZyB4 bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZlcnNpb249IjEuMSIKICAgIHZpZXdC b3g9IjAgMCAxMDAgMTAwIiBwcmVzZXJ2ZUFzcGVjdFJhdGlvPSJ4TWlkWU1pZCBzbGljZSI+CiAg ICA8cmVjdCB3aWR0aD0iMTAwIiBoZWlnaHQ9IjEwMCIgZmlsbD0iYmx1ZSIgLz4KICA8L3N2Zz4K PC9ib2R5Pgo8L2h0bWw+Cg== 15030 2007-06-14 13:49:22 -0700 2007-07-06 03:15:21 -0700 Fix z-index problems 5940.diff text/plain 1829 rwlbuis SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzUzNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDctMDYtMTQgIFJvYiBCdWlzICA8YnVpc0BrZGUub3JnPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdBUk5JTkc6IE5P IFRFU1QgQ0FTRVMgQURERUQgT1IgQ0hBTkdFRAorCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTU5NDAKKyAgICAgICAgPHN2Zz4gaW5zaWRlIDxib2R5PiBp bmNvcnJlY3RseSBleHRlbmRzIG92ZXIgdG9wL2JvdHRvbSBib3JkZXJzCisKKyAgICAgICAgVGFr ZSBpbnRvIGFjY291bnQgei1pbmRleCBmb3Igb3V0ZXIgPHN2Zz4uCisKKyAgICAgICAgKiByZW5k ZXJpbmcvUmVuZGVyU1ZHUm9vdC5jcHA6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclNWR1Jv b3QuaDoKKwogMjAwNy0wNi0xNCAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgTmlrby4KSW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclNW R1Jvb3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclNWR1Jvb3Qu Y3BwCShyZXZpc2lvbiAyMzUzNCkKKysrIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclNWR1Jvb3Qu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC02MCwxMiArNjAsNiBAQCB2b2lkIFJlbmRlclNWR1Jvb3Q6 OnNldExvY2FsVHJhbnNmb3JtKGNvCiAgICAgbV9tYXRyaXggPSBtYXRyaXg7CiB9CiAKLWJvb2wg UmVuZGVyU1ZHUm9vdDo6cmVxdWlyZXNMYXllcigpCi17Ci0gICAgLy8gT25seSBhbGxvdyBhbiA8 c3ZnPiBlbGVtZW50IHRvIGdlbmVyYXRlIGEgbGF5ZXIgd2hlbiBpdCdzIHBvc2l0aW9uZWQgaW4g YSBub24tU1ZHIGNvbnRleHQKLSAgICByZXR1cm4gZmFsc2U7Ci19Ci0KIHNob3J0IFJlbmRlclNW R1Jvb3Q6OmxpbmVIZWlnaHQoYm9vbCBiLCBib29sIGlzUm9vdExpbmVCb3gpIGNvbnN0CiB7CiAg ICAgcmV0dXJuIGhlaWdodCgpICsgbWFyZ2luVG9wKCkgKyBtYXJnaW5Cb3R0b20oKTsKSW5kZXg6 IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclNWR1Jvb3QuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJTVkdSb290LmgJKHJldmlzaW9uIDIzNTM0KQorKysgV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyU1ZHUm9vdC5oCSh3b3JraW5nIGNvcHkpCkBAIC00MSw3ICs0MSw2IEBA IHB1YmxpYzoKICAgICB2aXJ0dWFsIGJvb2wgaXNTVkdDb250YWluZXIoKSBjb25zdCB7IHJldHVy biB0cnVlOyB9CiAgICAgdmlydHVhbCBjb25zdCBjaGFyKiByZW5kZXJOYW1lKCkgY29uc3QgeyBy ZXR1cm4gIlJlbmRlclNWR0NvbnRhaW5lciI7IH0KICAgICAgICAgCi0gICAgdmlydHVhbCBib29s IHJlcXVpcmVzTGF5ZXIoKTsKICAgICB2aXJ0dWFsIHNob3J0IGxpbmVIZWlnaHQoYm9vbCBiLCBi b29sIGlzUm9vdExpbmVCb3ggPSBmYWxzZSkgY29uc3Q7CiAgICAgdmlydHVhbCBzaG9ydCBiYXNl bGluZVBvc2l0aW9uKGJvb2wgYiwgYm9vbCBpc1Jvb3RMaW5lQm94ID0gZmFsc2UpIGNvbnN0Owog ICAgIAo=