59284 2011-04-23 15:28:58 -0700 [V8] Nodes in shadow DOM should not be GCed while their hosts are alive 2011-04-23 18:31:33 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 52962 0 dominicc webkit-unassigned commit-queue morrita oldest_to_newest 391487 0 dominicc 2011-04-23 15:28:58 -0700 The lifetime of nodes in shadow DOM and their hosts should be linked, since event listeners and JavaScript properties set up on one should not disappear (via the wrapper being prematurely garbage collected) while the other is alive. 391492 1 90863 dominicc 2011-04-23 15:53:50 -0700 Created attachment 90863 Patch 391498 2 90863 dglazkov 2011-04-23 16:35:12 -0700 Comment on attachment 90863 Patch awesome! 391512 3 90863 morrita 2011-04-23 18:31:29 -0700 Comment on attachment 90863 Patch Clearing flags on attachment: 90863 Committed r84749: <http://trac.webkit.org/changeset/84749> 391513 4 morrita 2011-04-23 18:31:33 -0700 All reviewed patches have been landed. Closing bug. 90863 2011-04-23 15:53:50 -0700 2011-04-23 18:31:29 -0700 Patch bug-59284-20110423155349.patch text/plain 6008 dominicc U3VidmVyc2lvbiBSZXZpc2lvbjogODQ3NDQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA2YzZiMDM3MzgxZGZmZGIxMjVlNjdh OWY4ZmRmODY0ZWFkZGUxNTZlLi5kNTc4YjA3ODc5MThiNmQ3YzAyM2I0MGViYzVmMGExNWFkNzc0 ZGZhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDQtMjMgIERvbWluaWMgQ29vbmV5ICA8 ZG9taW5pY2NAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFtWOF0gTm9kZXMgaW4gc2hhZG93IERPTSBzaG91bGQgbm90IGJlIEdD ZWQgd2hpbGUgdGhlaXIgaG9zdHMgYXJlIGFsaXZlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTI4NAorCisgICAgICAgICogZmFzdC9kb20vc2hhZG93 L2djLXNoYWRvdy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZG9tL3NoYWRv dy9nYy1zaGFkb3cuaHRtbDogQWRkZWQuCisKIDIwMTEtMDQtMjMgIEFsZXhleSBQcm9za3VyeWFr b3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4KZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2Zhc3QvZG9tL3NoYWRvdy9nYy1zaGFkb3ctZXhwZWN0ZWQudHh0IGIvTGF5b3V0 VGVzdHMvZmFzdC9kb20vc2hhZG93L2djLXNoYWRvdy1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4u NjM5MzQ1ZDhkODkzOWViY2VhZjBlMDA1MDNhMjZiNjUzMDNlMDMyYQotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL3NoYWRvdy9nYy1zaGFkb3ctZXhwZWN0ZWQudHh0CkBA IC0wLDAgKzEsOCBAQAorVGhpcyB0ZXN0cyB0aGF0IHRoZSBKYXZhU2NyaXB0IHdyYXBwZXIgb2Jq ZWN0cyBvZiBzaGFkb3cgRE9NIG9iamVjdHMKK2FyZSBub3QgcHJlbWF0dXJlbHkgZ2FyYmFnZSBj b2xsZWN0ZWQuCisKK1BBU1Mgc2hhZG93LnRhdHRvbyBpcyAiSSA8MyBXZWJLaXQiCitQQVNTIHN1 Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvZmFzdC9kb20vc2hhZG93L2djLXNoYWRvdy5odG1sIGIvTGF5b3V0VGVzdHMv ZmFzdC9kb20vc2hhZG93L2djLXNoYWRvdy5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmJlMjhiNWRhZGE5ZjZk MzMzMGM1YmE3MjA1ZjMzN2VhOTFjYTdiNGIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L2RvbS9zaGFkb3cvZ2Mtc2hhZG93Lmh0bWwKQEAgLTAsMCArMSwyOSBAQAorPCFET0NU WVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9Ii4uLy4uL2pzL3Jlc291cmNl cy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxwcmUgaWQ9ImNv bnNvbGUiPgorVGhpcyB0ZXN0cyB0aGF0IHRoZSBKYXZhU2NyaXB0IHdyYXBwZXIgb2JqZWN0cyBv ZiBzaGFkb3cgRE9NIG9iamVjdHMKK2FyZSBub3QgcHJlbWF0dXJlbHkgZ2FyYmFnZSBjb2xsZWN0 ZWQuCisKKzwvcHJlPgorPHNjcmlwdD4KK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIp IHsKKyAgICB2YXIgcCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ3AnKTsKKyAgICB2YXIgc2hh ZG93ID0gbGF5b3V0VGVzdENvbnRyb2xsZXIuZW5zdXJlU2hhZG93Um9vdChwKTsKKyAgICBzaGFk b3cudGF0dG9vID0gJ0kgPDMgV2ViS2l0JzsKKyAgICBzaGFkb3cgPSBudWxsOworCisgICAgR0ND b250cm9sbGVyLmNvbGxlY3QoKTsKKworICAgIHNoYWRvdyA9IGxheW91dFRlc3RDb250cm9sbGVy LnNoYWRvd1Jvb3QocCk7CisgICAgc2hvdWxkQmUoJ3NoYWRvdy50YXR0b28nLCAnIkkgPDMgV2Vi S2l0IicpOworfQorCit2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsKKzwvc2NyaXB0Pgor PHNjcmlwdCBzcmM9Ii4uLy4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0 PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n IGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDAzOWFjN2U2NDQ2OWM1NzA2NzY0OGM4 NDI4NjkxYWVjNDMyZTVjNGMuLjhjMzBkNWVjNzc5MTE3Y2ZlMWJjMDE0MjZjNWVjNmQ3ODg4ZjY5 ZDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0wNC0yMyAgRG9taW5pYyBDb29u ZXkgIDxkb21pbmljY0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgW1Y4XSBOb2RlcyBpbiBzaGFkb3cgRE9NIHNob3VsZCBub3Qg YmUgR0NlZCB3aGlsZSB0aGVpciBob3N0cyBhcmUgYWxpdmUKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU5Mjg0CisKKyAgICAgICAgVGVzdDogZmFzdC9k b20vc2hhZG93L2djLXNoYWRvdy5odG1sCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOEdDQ29u dHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjYWxjdWxhdGVHcm91cElkKTogZ3JvdXAg c2hhZG93IG5vZGVzIHdpdGggdGhlaXIgaG9zdHMKKwogMjAxMS0wNC0yMyAgS2V2aW4gT2xsaXZp ZXIgIDxrZXZpbm9AdGhlb2xsaXZpZXJzLmNvbT4KIAogICAgICAgICBbd3hdIFVucmV2aWV3ZWQg YnVpbGQgZml4LiBBZGRlZCBtaXNzaW5nIGhlYWRlci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3Y4L1Y4R0NDb250cm9sbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3Y4L1Y4R0NDb250cm9sbGVyLmNwcAppbmRleCAxYTU1OTMyY2ZkZTExZjAzYTdmNTIyZDkz N2ZlYzExY2UwNTBhYjM0Li4xNzc0ODBkNThmNjgwYWUyZWMwYzFjNWI0NzBhYzM3ZGY3MmJhMTZi IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEdDQ29udHJvbGxlci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhHQ0NvbnRyb2xsZXIuY3BwCkBA IC0yNzksNyArMjc5LDcgQEAgc3RhdGljIEdyb3VwSWQgY2FsY3VsYXRlR3JvdXBJZChOb2RlKiBu b2RlKQogICAgICAgICBpZiAoIXJvb3QpCiAgICAgICAgICAgICByZXR1cm4gR3JvdXBJZCgpOwog ICAgIH0gZWxzZSB7Ci0gICAgICAgIHdoaWxlIChOb2RlKiBwYXJlbnQgPSByb290LT5wYXJlbnRO b2RlKCkpCisgICAgICAgIHdoaWxlIChOb2RlKiBwYXJlbnQgPSByb290LT5wYXJlbnRPckhvc3RO b2RlKCkpCiAgICAgICAgICAgICByb290ID0gcGFyZW50OwogICAgIH0KIApkaWZmIC0tZ2l0IGEv VG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDNiYWExYjUzZmMzMmYwNzQy MmYyZmExYmNhOTZhZDg0NzIwODY4ZTQuLmQyNjhkNTEzZjQ2ZGU0M2EzZjBmYWMyZDQ0ZmE5NjUw ZjMxYmYyZWUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMS0wNC0yMyAgRG9taW5pYyBDb29uZXkgIDxkb21pbmlj Y0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgW1Y4XSBOb2RlcyBpbiBzaGFkb3cgRE9NIHNob3VsZCBub3QgYmUgR0NlZCB3aGls ZSB0aGVpciBob3N0cyBhcmUgYWxpdmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTU5Mjg0CisKKyAgICAgICAgQ2hyb21pdW0gRFJUIG92ZXItcmVmY291 bnRlZCB0aGUgTlBPYmplY3Qgd3JhcHBlcnMgaXQgdXNlZCB0bworICAgICAgICBtYXJzaGFsIHNo YWRvd1Jvb3Qgbm9kZXMgYmFjayB0byB0ZXN0cyAoV2ViQmluZGluZ3M6Om1ha2VOb2RlCisgICAg ICAgIGJpcnRocyBOUE9iamVjdHMgd2l0aCByZWZlcmVuY2VDb3VudCA9PSAxKS4gVGhpcyBtYXNr ZWQgdGhlIEdDIGJ1ZworICAgICAgICA1OTI4NCBpbiB0ZXN0cyBieSBtYWtpbmcgc2hhZG93Um9v dCBub2RlcyBsaXZlIGZvcmV2ZXIuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1 bS9MYXlvdXRUZXN0Q29udHJvbGxlci5jcHA6CisgICAgICAgIChMYXlvdXRUZXN0Q29udHJvbGxl cjo6c2hhZG93Um9vdCk6CisgICAgICAgIChMYXlvdXRUZXN0Q29udHJvbGxlcjo6ZW5zdXJlU2hh ZG93Um9vdCk6CisKIDIwMTEtMDQtMjMgIEtldmluIE9sbGl2aWVyICA8a2V2aW5vQHRoZW9sbGl2 aWVycy5jb20+CiAKICAgICAgICAgW3d4XSBVbnJldmlld2VkIGJ1aWxkIGZpeGVzLiBBZGQgbmV3 IG1ldGhvZHMgdG8gd3ggTGF5b3V0VGVzdENvbnRyb2xsZXIsCmRpZmYgLS1naXQgYS9Ub29scy9E dW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9MYXlvdXRUZXN0Q29udHJvbGxlci5jcHAgYi9Ub29scy9E dW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9MYXlvdXRUZXN0Q29udHJvbGxlci5jcHAKaW5kZXggN2Vl OGY1ZjRiMzVmOWQ3YjA3Y2MwYWM0MDRlNjk4NTUyMGM3MThkNi4uZWU4ZDVhYzcxYjhlZmUzZjRk OGNmM2M2ZjkzM2U2ZTA3NzA1ZWJmOCAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUv Y2hyb21pdW0vTGF5b3V0VGVzdENvbnRyb2xsZXIuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJU cmVlL2Nocm9taXVtL0xheW91dFRlc3RDb250cm9sbGVyLmNwcApAQCAtNjY1LDEzICs2NjUsMTQg QEAgdm9pZCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2hhZG93Um9vdChjb25zdCBDcHBBcmd1bWVu dExpc3QmIGFyZ3VtZW50cywgQ3BwVmFyaWEKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAotICAg IFdlYk5vZGUgc2hhZG93Um9vdCA9IGVsZW1lbnQuc2hhZG93Um9vdCgpOwotICAgIGlmIChzaGFk b3dSb290LmlzTnVsbCgpKSB7CisgICAgTlBPYmplY3QqIHNoYWRvd1Jvb3QgPSBXZWJCaW5kaW5n czo6bWFrZU5vZGUoZWxlbWVudC5zaGFkb3dSb290KCkpOworICAgIGlmICghc2hhZG93Um9vdCkg ewogICAgICAgICByZXN1bHQtPnNldE51bGwoKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAot ICAgIHJlc3VsdC0+c2V0KFdlYkJpbmRpbmdzOjptYWtlTm9kZShzaGFkb3dSb290KSk7CisgICAg cmVzdWx0LT5zZXQoc2hhZG93Um9vdCk7CisgICAgV2ViQmluZGluZ3M6OnJlbGVhc2VPYmplY3Qo c2hhZG93Um9vdCk7CiB9CiAKIHZvaWQgTGF5b3V0VGVzdENvbnRyb2xsZXI6OmVuc3VyZVNoYWRv d1Jvb3QoY29uc3QgQ3BwQXJndW1lbnRMaXN0JiBhcmd1bWVudHMsIENwcFZhcmlhbnQqIHJlc3Vs dCkKQEAgLTY4Nyw3ICs2ODgsMTQgQEAgdm9pZCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6ZW5zdXJl U2hhZG93Um9vdChjb25zdCBDcHBBcmd1bWVudExpc3QmIGFyZ3VtZW50cywgQ3AKICAgICAgICAg cmV0dXJuOwogICAgIH0KIAotICAgIHJlc3VsdC0+c2V0KFdlYkJpbmRpbmdzOjptYWtlTm9kZShl bGVtZW50LmVuc3VyZVNoYWRvd1Jvb3QoKSkpOworICAgIE5QT2JqZWN0KiBzaGFkb3dSb290ID0g V2ViQmluZGluZ3M6Om1ha2VOb2RlKGVsZW1lbnQuZW5zdXJlU2hhZG93Um9vdCgpKTsKKyAgICBp ZiAoIXNoYWRvd1Jvb3QpIHsKKyAgICAgICAgcmVzdWx0LT5zZXROdWxsKCk7CisgICAgICAgIHJl dHVybjsKKyAgICB9CisKKyAgICByZXN1bHQtPnNldChzaGFkb3dSb290KTsKKyAgICBXZWJCaW5k aW5nczo6cmVsZWFzZU9iamVjdChzaGFkb3dSb290KTsKIH0KIAogdm9pZCBMYXlvdXRUZXN0Q29u dHJvbGxlcjo6cmVtb3ZlU2hhZG93Um9vdChjb25zdCBDcHBBcmd1bWVudExpc3QmIGFyZ3VtZW50 cywgQ3BwVmFyaWFudCogcmVzdWx0KQo=