59243 2011-04-22 15:01:22 -0700 Develop sufficient test coverage for editing inside input/textarea 2011-06-03 21:15:04 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) PC OS X 10.5 RESOLVED WONTFIX P2 Normal --- 60211 1 dglazkov dglazkov ap dominicc enrica leviw rniwa tkent oldest_to_newest 391115 0 dglazkov 2011-04-22 15:01:22 -0700 In order to land the switch-over to the new shadow DOM, we must ensure that the areas of change are sufficiently covered by layout tests. To do this, we should study all places where the shadow DOM changes assumptions and make sure these changes don't break the behavior. A good start would be to look at all callsites of parentNode() in editing and ensure we have tests that travel them. http://codesearch.google.com/codesearch?q=%22parentNode%28%29%22+file%3Aediting&exact_package=chromium&hl=en&vert=chromium 396211 1 91876 dglazkov 2011-05-01 21:12:27 -0700 Created attachment 91876 WIP: Beginnings of the harness. 406027 2 dglazkov 2011-05-18 14:34:45 -0700 Quick update: We (rniwa, anniesullivan, myself) defined the test matrix and made first pass at culling, producing around 940K combinations, with an approximate run time of 3 hours. Clearly, this is not something we can afford to run in LayoutTests. Perhaps this needs to be done as a separate bot or something entirely different. In order to unblock shadow DOM conversion, we instead focused on something a bit smarter than effectively fuzz-testing. Specifically, we walked through editing code and identifying all areas where the shadow DOM changes would have affects. 415381 3 rniwa 2011-06-03 21:15:04 -0700 This is no longer needed. 91876 2011-05-01 21:12:27 -0700 2011-05-01 21:12:27 -0700 WIP: Beginnings of the harness. bug-59243-20110501211226.patch text/plain 3528 dglazkov U3VidmVyc2lvbiBSZXZpc2lvbjogODU0MDIKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA1NWZlZWMyYmM3ODU1YjIzNzBiNDc4 OGU2NzAxMTg1Zjk5ZjAyMGY4Li43MGU4ODY4YTNhNDc1Zjc0MTEwODJjMDE0YjRjNjE2YjgyZTNm M2E0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDUtMDEgIERpbWl0cmkgR2xhemtvdiAg PGRnbGF6a292QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBEZXZlbG9wIHN1ZmZpY2llbnQgdGVzdCBjb3ZlcmFnZSBmb3IgZWRp dGluZyBpbnNpZGUgaW5wdXQvdGV4dGFyZWEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTU5MjQzCisKKyAgICAgICAgKiBlZGl0aW5nL2Zvcm1zLmh0bWw6 IEFkZGVkLgorCiAyMDExLTA0LTMwICBBZGFtIFJvYmVuICA8YXJvYmVuQGFwcGxlLmNvbT4KIAog ICAgICAgICBTa2lwIGFub3RoZXIgdGVzdCB0aGF0IHJlcXVpcmVzIGxheW91dFRlc3RDb250cm9s bGVyLnNldEFsd2F5c0FjY2VwdENvb2tpZXMgb24gbWFjLXdrMgpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvZWRpdGluZy9mb3Jtcy5odG1sIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9mb3Jtcy5odG1s Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAuLjg5ZTI2OTMwMzE5MDJhNzU4YzVmYTRmY2UyZjgwN2Y4YWU5OGNjMjIKLS0t IC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL2Zvcm1zLmh0bWwKQEAgLTAsMCAr MSwxMzYgQEAKKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0PgorCitmdW5jdGlvbiBzZXRVcEVudmly b25tZW50KCkKK3sKKyAgICB3aW5kb3cubG9nID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2xv ZycpOworICAgIGxvZy53cml0ZSA9IGZ1bmN0aW9uKCkKKyAgICB7CisgICAgICAgIEFycmF5LnBy b3RvdHlwZS5zbGljZS5jYWxsKGFyZ3VtZW50cywgMCkucmVkdWNlKGZ1bmN0aW9uKGxpbmUsIGFy ZykgeworICAgICAgICAgICAgYXBwZW5kQXJndW1lbnQobGluZS5hcHBlbmRDaGlsZChkb2N1bWVu dC5jcmVhdGVFbGVtZW50KCdzcGFuJykpLCBhcmcpOworICAgICAgICAgICAgbGluZS5hcHBlbmRD aGlsZChkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZSgnICcpKTsKKyAgICAgICAgICAgIHJldHVybiBs aW5lOworICAgICAgICB9LCB0aGlzLmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQo J2xpJykpKTsKKworICAgICAgICBmdW5jdGlvbiBhcHBlbmRBcmd1bWVudChub2RlLCBhcmcpCisg ICAgICAgIHsKKyAgICAgICAgICAgIG5vZGUudGV4dENvbnRlbnQgPSBhcmc7CisgICAgICAgIH0K KyAgICB9OworICAgIGxvZy5kZXNjcmlwdGlvbiA9IGxvZy53cml0ZTsKK30KKwordmFyIGlucHV0 cyA9IFsKK3sKKyAgICBwcmU6IGZ1bmN0aW9uKCkKKyAgICB7CisgICAgICAgIGxvZy5kZXNjcmlw dGlvbignaW5wdXRbdHlwZT10ZXh0XSBwcmUnKTsKKyAgICB9LAorICAgIHBvc3Q6IGZ1bmN0aW9u KCkKKyAgICB7CisgICAgICAgIGxvZy5kZXNjcmlwdGlvbignaW5wdXRbdHlwZT10ZXh0XSBwb3N0 Jyk7CisgICAgfQorfSwKK3sKKyAgICBwcmU6IGZ1bmN0aW9uKCkKKyAgICB7CisgICAgICAgIGxv Zy5kZXNjcmlwdGlvbignaW5wdXRbdHlwZT1zZWFyY2hdIHByZScpOworICAgIH0sCisgICAgcG9z dDogZnVuY3Rpb24oKQorICAgIHsKKyAgICAgICAgbG9nLmRlc2NyaXB0aW9uKCdpbnB1dFt0eXBl PXNlYXJjaF0gcG9zdCcpOworICAgIH0KK30KK107CisKK3ZhciBtb2RlbCA9IFsKK3sKKyAgICBw cmU6IGZ1bmN0aW9uKCkKKyAgICB7CisgICAgICAgIGxvZy53cml0ZSgnZW1wdHkgcHJlJyk7Cisg ICAgfSwKKyAgICBwb3N0OiBmdW5jdGlvbigpCisgICAgeworICAgICAgICBsb2cud3JpdGUoJ2Vt cHR5IHBvc3QnKTsKKyAgICB9LAorfSwKK3sKKyAgICBwcmU6IGZ1bmN0aW9uKCkKKyAgICB7Cisg ICAgICAgIGxvZy53cml0ZSgnbm9uLWVtcHR5IHByZScpOworICAgIH0sCisgICAgcG9zdDogZnVu Y3Rpb24oKQorICAgIHsKKyAgICAgICAgbG9nLndyaXRlKCdub24tZW1wdHkgcG9zdCcpOworICAg IH0sCit9CitdOworCit2YXIgc2VsZWN0aW9uID0gWworeworICAgIHByZTogZnVuY3Rpb24oKQor ICAgIHsKKyAgICAgICAgbG9nLndyaXRlKCdzZWxlY3Rpb24xIHByZScpOworICAgIH0sCisgICAg cG9zdDogZnVuY3Rpb24oKQorICAgIHsKKyAgICAgICAgbG9nLndyaXRlKCdzZWxlY3Rpb24xIHBv c3QnKTsKKyAgICB9LAorfSwKK3sKKyAgICBwcmU6IGZ1bmN0aW9uKCkKKyAgICB7CisgICAgICAg IGxvZy53cml0ZSgnc2VsZWN0aW9uMiBwcmUnKTsKKyAgICB9LAorICAgIHBvc3Q6IGZ1bmN0aW9u KCkKKyAgICB7CisgICAgICAgIGxvZy53cml0ZSgnc2VsZWN0aW9uMiBwb3N0Jyk7CisgICAgfSwK K30KK107CisKK2Z1bmN0aW9uIFBlcm11dGF0b3IobWF0cml4KQoreworICAgIHRoaXMubWF0cml4 ID0gbWF0cml4OworfQorCitQZXJtdXRhdG9yLnByb3RvdHlwZSA9IHsKKyAgICBzdGFjazogW10s CisgICAgcnVuOiBmdW5jdGlvbigpCisgICAgeworICAgICAgICBpZiAodGhpcy5zdGFjay5sZW5n dGggPCB0aGlzLm1hdHJpeC5sZW5ndGgpCisgICAgICAgICAgICB0aGlzLm1hdHJpeFt0aGlzLnN0 YWNrLmxlbmd0aF0uZm9yRWFjaCh0aGlzLnJlY3Vyc2UsIHRoaXMpOworICAgICAgICBlbHNlIHsK KyAgICAgICAgICAgIHRoaXMuc3RhY2suZm9yRWFjaChmdW5jdGlvbihmKSB7IGYucHJlKCk7IH0p OworICAgICAgICAgICAgZm9yKHZhciBpID0gdGhpcy5zdGFjay5sZW5ndGggLSAxOyBpID49IDA7 IC0taSkKKyAgICAgICAgICAgICAgICB0aGlzLnN0YWNrW2ldLnBvc3QoKTsKKyAgICAgICAgfQor ICAgIH0sCisgICAgcmVjdXJzZTogZnVuY3Rpb24oZGltZW5zaW9uKQorICAgIHsKKyAgICAgICAg dGhpcy5zdGFjay5wdXNoKGRpbWVuc2lvbik7CisgICAgICAgIHRoaXMucnVuKCk7CisgICAgICAg IHRoaXMuc3RhY2sucG9wKCk7CisgICAgfQorfQorCitmdW5jdGlvbiBydW5UZXN0TWF0cml4KCkK K3sKKyAgICB2YXIgcGVybXV0YXRvciA9IG5ldyBQZXJtdXRhdG9yKEFycmF5LnByb3RvdHlwZS5z bGljZS5jYWxsKGFyZ3VtZW50cywgMCkpCisgICAgcGVybXV0YXRvci5ydW4oKTsKK30KKword2lu ZG93Lm9ubG9hZCA9IGZ1bmN0aW9uKCkKK3sKKyAgICBzZXRVcEVudmlyb25tZW50KCk7CisgICAg cnVuVGVzdE1hdHJpeChpbnB1dHMsIG1vZGVsLCBzZWxlY3Rpb24pOworfTsKKworPC9zY3JpcHQ+ Cis8L2hlYWQ+Cis8Ym9keT4KKzxkaXYgaWQ9ImFyZW5hIj48L2Rpdj4KKzx1bCBpZD0ibG9nIj48 L3VsPgorPC9ib2R5PgorPC9odG1sPgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK