59184 2011-04-22 02:19:15 -0700 [Gtk] Implement LayoutTestController::setPluginsEnabled 2011-04-26 18:08:13 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 scaroo webkit-unassigned abarth commit-queue eric mrobinson webkit.review.bot oldest_to_newest 390682 0 scaroo 2011-04-22 02:19:15 -0700 [Gtk] Implement LayoutTestController::setPluginsEnabled 390683 1 90681 scaroo 2011-04-22 02:20:02 -0700 Created attachment 90681 Patch 391520 2 90681 mrobinson 2011-04-23 19:44:33 -0700 Comment on attachment 90681 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90681&action=review Can we unskip any tests with this patch? > Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:550 > + WebKitWebSettings* settings = webkit_web_view_get_settings(view); > + g_object_set(G_OBJECT(settings), "enable-plugins", flag, NULL); This can just be: g_object_set(G_OBJECT(webkit_web_view_get_settings(view)), "enable-plugins", flag, NULL); 392850 3 90681 xan.lopez 2011-04-26 15:41:17 -0700 Comment on attachment 90681 Patch Hopefully this should unskip some tests, but the patch looks good. 392875 4 mrobinson 2011-04-26 15:51:05 -0700 Alexandre, please take another pass when this lands which unskips tests which use this feature. If they cannot be unskipped please open bugs for them. Thank you! 393127 5 commit-queue 2011-04-26 17:04:04 -0700 The commit-queue encountered the following flaky tests while processing attachment 90681: http/tests/xmlhttprequest/cross-origin-authorization.html bug 52398 (author: ap@webkit.org) The commit-queue is continuing to process your patch. 393138 6 90681 commit-queue 2011-04-26 17:05:34 -0700 Comment on attachment 90681 Patch Clearing flags on attachment: 90681 Committed r84985: <http://trac.webkit.org/changeset/84985> 393139 7 commit-queue 2011-04-26 17:05:39 -0700 All reviewed patches have been landed. Closing bug. 393200 8 webkit.review.bot 2011-04-26 18:08:13 -0700 http://trac.webkit.org/changeset/84985 might have broken Windows 7 Release (Tests) The following tests are not passing: fast/blockflow/Kusa-Makura-background-canvas.html fast/blockflow/border-vertical-lr.html fast/blockflow/fallback-orientation.html fast/blockflow/japanese-lr-selection.html fast/blockflow/japanese-lr-text.html fast/blockflow/japanese-rl-selection.html fast/blockflow/japanese-rl-text.html fast/blockflow/japanese-ruby-vertical-lr.html fast/blockflow/japanese-ruby-vertical-rl.html fast/dynamic/text-combine.html fast/repaint/japanese-rl-selection-clear.html fast/repaint/japanese-rl-selection-repaint.html fast/ruby/base-shorter-than-text.html fast/text/emphasis-vertical.html fast/text/international/text-combine-image-test.html fast/text/international/vertical-text-glyph-test.html fast/text/justify-ideograph-vertical.html 90681 2011-04-22 02:20:02 -0700 2011-04-26 17:05:34 -0700 Patch bug-59184-20110422112000.patch text/plain 1469 scaroo U3VidmVyc2lvbiBSZXZpc2lvbjogODQ2MTEKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBiNGIxYWZmZmM0MThhM2NmYTQ3OGFmYjgyOTIwY2VmZGE2 MzY3MmRmLi4zNDQ1ODkwOGZmZWQ5NTFkYzFlZTg2YWU4YWZhNWIxMWU1MTI0MGY5IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDQtMjIgIEFsZXhhbmRyZSBNQXphcmkgIDxhbWF6YXJpQGlnYWxpYS5jb20+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0d0a10gSW1w bGVtZW50IExheW91dFRlc3RDb250cm9sbGVyOjpzZXRQbHVnaW5zRW5hYmxlZAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTkxODQKKworICAgICAgICAq IER1bXBSZW5kZXJUcmVlL2d0ay9MYXlvdXRUZXN0Q29udHJvbGxlckd0ay5jcHA6CisgICAgICAg IChMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0UGx1Z2luc0VuYWJsZWQpOgorCiAyMDExLTA0LTIx ICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg TWloYWkgUGFycGFyaXRhLgpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0xh eW91dFRlc3RDb250cm9sbGVyR3RrLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9MYXlv dXRUZXN0Q29udHJvbGxlckd0ay5jcHAKaW5kZXggMzMxZTIyMjg1OGY5NTI2NTEzMjY0YjczNDEx MWE5ZGIxMTQ2NDk1NS4uNjE3YTA4ZmY3M2ZhOTFmOGMzNzIyZjhhZDU2NjEyMWY3ZmE4ZDg5YSAx MDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0xheW91dFRlc3RDb250cm9sbGVy R3RrLmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsvTGF5b3V0VGVzdENvbnRyb2xs ZXJHdGsuY3BwCkBAIC01NDMsNyArNTQzLDExIEBAIHZvaWQgTGF5b3V0VGVzdENvbnRyb2xsZXI6 OnNldFBvcHVwQmxvY2tpbmdFbmFibGVkKGJvb2wgZmxhZykKIAogdm9pZCBMYXlvdXRUZXN0Q29u dHJvbGxlcjo6c2V0UGx1Z2luc0VuYWJsZWQoYm9vbCBmbGFnKQogewotICAgIC8vIEZJWE1FOiBJ bXBsZW1lbnQKKyAgICBXZWJLaXRXZWJWaWV3KiB2aWV3ID0gd2Via2l0X3dlYl9mcmFtZV9nZXRf d2ViX3ZpZXcobWFpbkZyYW1lKTsKKyAgICBBU1NFUlQodmlldyk7CisKKyAgICBXZWJLaXRXZWJT ZXR0aW5ncyogc2V0dGluZ3MgPSB3ZWJraXRfd2ViX3ZpZXdfZ2V0X3NldHRpbmdzKHZpZXcpOwor ICAgIGdfb2JqZWN0X3NldChHX09CSkVDVChzZXR0aW5ncyksICJlbmFibGUtcGx1Z2lucyIsIGZs YWcsIE5VTEwpOwogfQogCiBib29sIExheW91dFRlc3RDb250cm9sbGVyOjplbGVtZW50RG9lc0F1 dG9Db21wbGV0ZUZvckVsZW1lbnRXaXRoSWQoSlNTdHJpbmdSZWYgaWQpIAo=