59097 2011-04-21 06:27:48 -0700 [Qt] Fix the style issue for Api/qwebkitplatformplugin.h 2011-04-21 08:22:13 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED P3 Normal --- 1 max.hong.shen max.hong.shen commit-queue menard yael oldest_to_newest 389977 0 max.hong.shen 2011-04-21 06:27:48 -0700 Fix the style issue for Api/qwebkitplatformplugin.h found by the webkit-check-style 389978 1 90523 max.hong.shen 2011-04-21 06:30:37 -0700 Created attachment 90523 first try 390011 2 max.hong.shen 2011-04-21 07:16:38 -0700 Thanks Antonio! 390042 3 commit-queue 2011-04-21 08:19:38 -0700 The commit-queue encountered the following flaky tests while processing attachment 90523: http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com) http/tests/xmlhttprequest/cross-origin-no-authorization.html bug 33357 (author: ap@webkit.org) http/tests/canvas/webgl/origin-clean-conformance.html bug 52117 (author: enne@google.com) The commit-queue is continuing to process your patch. 390045 4 90523 commit-queue 2011-04-21 08:22:08 -0700 Comment on attachment 90523 first try Clearing flags on attachment: 90523 Committed r84501: <http://trac.webkit.org/changeset/84501> 390046 5 commit-queue 2011-04-21 08:22:13 -0700 All reviewed patches have been landed. Closing bug. 90523 2011-04-21 06:30:37 -0700 2011-04-21 08:22:08 -0700 first try 59097.patch text/plain 2766 max.hong.shen SW5kZXg6IFNvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQvcXQvQ2hhbmdlTG9nCShyZXZpc2lvbiA4NDQ4OSkKKysrIFNvdXJjZS9XZWJLaXQvcXQv Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDQtMjEgIFlp IFNoZW4gIDx5aS40LnNoZW5Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gRml4IHRoZSBzdHlsZSBpc3N1ZSBmb3IgQXBpL3F3 ZWJraXRwbGF0Zm9ybXBsdWdpbi5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD01OTA5NworCisgICAgICAgIEZpeCB0aGUgc3R5bGUgaXNzdWVzIGZvciBB cGkvcXdlYmtpdHBsYXRmb3JtcGx1Z2luLmggZm91bmQgYnkgdGhlIHdlYmtpdC1jaGVjay1zdHls ZS4KKworICAgICAgICAqIEFwaS9xd2Via2l0cGxhdGZvcm1wbHVnaW4uaDoKKwogMjAxMS0wNC0y MSAgQ2FpbyBNYXJjZWxvIGRlIE9saXZlaXJhIEZpbGhvICA8Y2Fpby5vbGl2ZWlyYUBvcGVuYm9z c2Eub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IENzYWJhIE9zenRyb2dvbsOhYy4KSW5kZXg6 IFNvdXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJraXRwbGF0Zm9ybXBsdWdpbi5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJraXRwbGF0Zm9ybXBsdWdpbi5oCShyZXZpc2lv biA4NDQ4OSkKKysrIFNvdXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJraXRwbGF0Zm9ybXBsdWdpbi5o CSh3b3JraW5nIGNvcHkpCkBAIC0zMyw4ICszMyw3IEBACiAjaW5jbHVkZSA8UU1lZGlhUGxheWVy PgogI2VuZGlmCiAKLWNsYXNzIFFXZWJTZWxlY3REYXRhCi17CitjbGFzcyBRV2ViU2VsZWN0RGF0 YSB7CiBwdWJsaWM6CiAgICAgdmlydHVhbCB+UVdlYlNlbGVjdERhdGEoKSB7fQogCkBAIC01Myw4 ICs1Miw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIFFDb2xvciBpdGVtRm9yZWdyb3VuZENvbG9y KGludCBpbmRleCkgY29uc3QgPSAwOwogfTsKIAotY2xhc3MgUVdlYlNlbGVjdE1ldGhvZCA6IHB1 YmxpYyBRT2JqZWN0Ci17CitjbGFzcyBRV2ViU2VsZWN0TWV0aG9kIDogcHVibGljIFFPYmplY3Qg ewogICAgIFFfT0JKRUNUCiBwdWJsaWM6CiAgICAgdmlydHVhbCB+UVdlYlNlbGVjdE1ldGhvZCgp IHt9CkBAIC02Nyw4ICs2NSw3IEBAIFFfU0lHTkFMUzoKICAgICB2b2lkIGRpZEhpZGUoKTsKIH07 CiAKLWNsYXNzIFFXZWJOb3RpZmljYXRpb25EYXRhCi17CitjbGFzcyBRV2ViTm90aWZpY2F0aW9u RGF0YSB7CiBwdWJsaWM6CiAgICAgdmlydHVhbCB+UVdlYk5vdGlmaWNhdGlvbkRhdGEoKSB7fQog CkBAIC03OCw4ICs3NSw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIGNvbnN0IFFVcmwgb3BlbmVy UGFnZVVybCgpIGNvbnN0ID0gMDsKIH07CiAKLWNsYXNzIFFXZWJOb3RpZmljYXRpb25QcmVzZW50 ZXIgOiBwdWJsaWMgUU9iamVjdAoteworY2xhc3MgUVdlYk5vdGlmaWNhdGlvblByZXNlbnRlciA6 IHB1YmxpYyBRT2JqZWN0IHsKICAgICBRX09CSkVDVAogcHVibGljOgogICAgIFFXZWJOb3RpZmlj YXRpb25QcmVzZW50ZXIoKSB7fQpAQCAtOTIsOCArODgsNyBAQCBRX1NJR05BTFM6CiAgICAgdm9p ZCBub3RpZmljYXRpb25DbGlja2VkKCk7CiB9OwogCi1jbGFzcyBRV2ViSGFwdGljRmVlZGJhY2tQ bGF5ZXI6IHB1YmxpYyBRT2JqZWN0Ci17CitjbGFzcyBRV2ViSGFwdGljRmVlZGJhY2tQbGF5ZXI6 IHB1YmxpYyBRT2JqZWN0IHsKICAgICBRX09CSkVDVAogcHVibGljOgogICAgIFFXZWJIYXB0aWNG ZWVkYmFja1BsYXllcigpIHt9CkBAIC0xMTAsOCArMTA1LDcgQEAgcHVibGljOgogICAgIHZpcnR1 YWwgdm9pZCBwbGF5SGFwdGljRmVlZGJhY2soY29uc3QgSGFwdGljRXZlbnQsIGNvbnN0IFFTdHJp bmcmIGhhcHRpY1R5cGUsIGNvbnN0IEhhcHRpY1N0cmVuZ3RoKSA9IDA7CiB9OwogCi1jbGFzcyBR V2ViVG91Y2hNb2RpZmllciA6IHB1YmxpYyBRT2JqZWN0Ci17CitjbGFzcyBRV2ViVG91Y2hNb2Rp ZmllciA6IHB1YmxpYyBRT2JqZWN0IHsKICAgICBRX09CSkVDVAogcHVibGljOgogICAgIHZpcnR1 YWwgflFXZWJUb3VjaE1vZGlmaWVyKCkge30KQEAgLTE0MCw4ICsxMzQsNyBAQCBwdWJsaWMgUV9T TE9UUzoKIH07CiAjZW5kaWYKIAotY2xhc3MgUVdlYktpdFBsYXRmb3JtUGx1Z2luCi17CitjbGFz cyBRV2ViS2l0UGxhdGZvcm1QbHVnaW4gewogcHVibGljOgogICAgIHZpcnR1YWwgflFXZWJLaXRQ bGF0Zm9ybVBsdWdpbigpIHt9CiAKQEAgLTE1Myw4ICsxNDYsOCBAQCBwdWJsaWM6CiAgICAgICAg IEZ1bGxTY3JlZW5WaWRlb1BsYXllcgogICAgIH07CiAKLSAgICB2aXJ0dWFsIGJvb2wgc3VwcG9y dHNFeHRlbnNpb24oRXh0ZW5zaW9uIGV4dGVuc2lvbikgY29uc3QgPSAwOwotICAgIHZpcnR1YWwg UU9iamVjdCogY3JlYXRlRXh0ZW5zaW9uKEV4dGVuc2lvbiBleHRlbnNpb24pIGNvbnN0ID0gMDsK KyAgICB2aXJ0dWFsIGJvb2wgc3VwcG9ydHNFeHRlbnNpb24oRXh0ZW5zaW9uKSBjb25zdCA9IDA7 CisgICAgdmlydHVhbCBRT2JqZWN0KiBjcmVhdGVFeHRlbnNpb24oRXh0ZW5zaW9uKSBjb25zdCA9 IDA7CiB9OwogCiBRVF9CRUdJTl9OQU1FU1BBQ0UK