59081 2011-04-21 00:41:22 -0700 Windows DRT needs an implementation of shadowRoot 2011-06-24 11:45:22 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All Windows 7 RESOLVED FIXED LayoutTestFailure, PlatformOnly P2 Normal --- 61671 1 yutak dominicc dominicc jberlin rolandsteiner oldest_to_newest 389889 0 yutak 2011-04-21 00:41:22 -0700 Since r84472 (bug 59058), fast/dom/shadow/layout-tests-can-access-shadow.html is failing on Windows. 389896 1 yutak 2011-04-21 00:45:59 -0700 Committed r84476: <http://trac.webkit.org/changeset/84476> 389897 2 yutak 2011-04-21 00:47:01 -0700 Ooh, it's not fixed yet :) Fixing the status. 389898 3 yutak 2011-04-21 00:48:39 -0700 Test results (http://build.webkit.org/results/Windows%20XP%20Debug%20(Tests)/r84472%20(27888)/fast/dom/shadow/layout-tests-can-access-shadow-diffs.txt) --- /home/buildbot/slave/win-debug-tests/build/layout-test-results/fast/dom/shadow/layout-tests-can-access-shadow-expected.txt 2011-04-21 23:56:11.531250000 -0700 +++ /home/buildbot/slave/win-debug-tests/build/layout-test-results/fast/dom/shadow/layout-tests-can-access-shadow-actual.txt 2011-04-21 23:56:11.531250000 -0700 @@ -1,12 +1,12 @@ This tests that LayoutTestController can access shadow DOM. -PASS shadow.nodeName is "#shadow-root" -PASS layoutTestController.shadowRoot(shadow) is null -PASS layoutTestController.shadowRoot(p) is null -PASS shadow.nodeName is "#shadow-root" +FAIL shadow.nodeName should be #shadow-root. Threw exception TypeError: 'undefined' is not an object (evaluating 'shadow.nodeName') +FAIL layoutTestController.shadowRoot(shadow) should be null (of type object). Was undefined (of type undefined). +FAIL layoutTestController.shadowRoot(p) should be null (of type object). Was undefined (of type undefined). +FAIL shadow.nodeName should be #shadow-root. Threw exception TypeError: 'undefined' is not an object (evaluating 'shadow.nodeName') PASS shadow === layoutTestController.shadowRoot(p) is true -PASS layoutTestController.shadowRoot(keygen) is null +FAIL layoutTestController.shadowRoot(keygen) should be null (of type object). Was undefined (of type undefined). PASS successfullyParsed is true TEST COMPLETE 390215 4 rolandsteiner 2011-04-21 11:52:06 -0700 Same goes for fast/dom/shadow/nodetype.html 390220 5 rolandsteiner 2011-04-21 12:02:04 -0700 Committed r84533: <http://trac.webkit.org/changeset/84533> 399440 6 pnormand 2011-05-06 02:18:26 -0700 Skipped media/video-controls-visible-audio-only.html too as a consequence of ttp://trac.webkit.org/changeset/85934 420158 7 dominicc 2011-06-13 19:31:32 -0700 It does not make sense to implement layoutTestController.shadowRoot/ensureShadowRoot/removeShadowRoot/shadowPseudoId, because those methods are moving to window.internals per bug 61671. So the win DRT implementation of shadowRoot and friends is blocked on that. 427025 8 dominicc 2011-06-24 11:45:22 -0700 Fixed in r89682. Windows tests can use internals.shadowRoot, ensureShadowRoot, shadowPseudoId, etc. and the mentioned tests were unskipped in that revision.