59076 2011-04-20 22:37:37 -0700 remove unneeded function from graphicscontext3d.cpp 2011-04-21 10:35:18 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 59029 0 jonlee webkit-unassigned commit-queue jamesr kbr mjs oldest_to_newest 389851 0 jonlee 2011-04-20 22:37:37 -0700 refactoring from http://trac.webkit.org/changeset/84441 leaves a compile warning, that unpackOneRowOfRGBA8ToRGBA8 is unused. 389854 1 jonlee 2011-04-20 22:48:25 -0700 <rdar://problem/9315681> 389855 2 90496 jonlee 2011-04-20 22:48:56 -0700 Created attachment 90496 Patch 389860 3 90496 mjs 2011-04-20 22:54:51 -0700 Comment on attachment 90496 Patch r=me I can't really tell what is up with that function, it may be that it was meant to be used, but the relevant case block of doPacking was just overlooked when converting. But removing it seems like a safe fix for now. If it was intended to be used, the folks who came up with the change can handle it. 389882 4 90496 commit-queue 2011-04-21 00:25:13 -0700 Comment on attachment 90496 Patch Clearing flags on attachment: 90496 Committed r84474: <http://trac.webkit.org/changeset/84474> 389883 5 commit-queue 2011-04-21 00:25:18 -0700 All reviewed patches have been landed. Closing bug. 389892 6 commit-queue 2011-04-21 00:41:33 -0700 The commit-queue encountered the following flaky tests while processing attachment 90496: http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com) The commit-queue is continuing to process your patch. 390138 7 kbr 2011-04-21 10:35:18 -0700 Thanks for the cleanup. I didn't see this issue locally. 90496 2011-04-20 22:48:56 -0700 2011-04-21 00:25:13 -0700 Patch 0001-remove-unneeded-function-from-graphicscontext3d.cpp-.patch text/plain 2684 jonlee RnJvbSBiZTI5ZDdlYjg0M2I2ZjQ4NWNkMTIwYjRhMWNlNmRiZjgxMTQ5ZDI2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb24gTGVlIDxqb25sZWVAYXBwbGUuY29tPgpEYXRlOiBXZWQs IDIwIEFwciAyMDExIDIyOjQ0OjM0IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gcmVtb3ZlIHVubmVl ZGVkIGZ1bmN0aW9uIGZyb20gZ3JhcGhpY3Njb250ZXh0M2QuY3BwICg1OTA3NikKIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTA3NgogPHJkYXI6Ly9wcm9ibGVtLzkz MTU2ODE+CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiogcGxhdGZvcm0vZ3JhcGhpY3Mv R3JhcGhpY3NDb250ZXh0M0QuY3BwOiByZW1vdmluZyB1bnVzZWQgZnVuY3Rpb24gdW5wYWNrT25l Um93T2ZSR0JBOFRvUkdCQTgKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAg ICAgICAgICAgICAgICAgICB8ICAgMTAgKysrKysrKwogLi4uL3BsYXRmb3JtL2dyYXBoaWNzL0dy YXBoaWNzQ29udGV4dDNELmNwcCAgICAgICAgfCAgIDI4ICsrKysrLS0tLS0tLS0tLS0tLS0KIDIg ZmlsZXMgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgMjAgZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n CmluZGV4IDM0NTBjY2UuLmU2NGE2NmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAx MS0wNC0yMCAgSm9uIExlZSAgPGpvbmxlZUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgcmVtb3ZlIHVubmVlZGVkIGZ1bmN0aW9uIGZy b20gZ3JhcGhpY3Njb250ZXh0M2QuY3BwICg1OTA3NikKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU5MDc2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS85 MzE1NjgxPgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0Qu Y3BwOiByZW1vdmluZyB1bnVzZWQgZnVuY3Rpb24gdW5wYWNrT25lUm93T2ZSR0JBOFRvUkdCQTgK KwogMjAxMS0wNC0yMCAgUHJhdGlrIFNvbGFua2kgIDxwc29sYW5raUBhcHBsZS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgUnlvc3VrZSBOaXdhLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0QuY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0QuY3BwCmluZGV4IGIxY2EwMjcu LjI1NWY0NWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dy YXBoaWNzQ29udGV4dDNELmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9HcmFwaGljc0NvbnRleHQzRC5jcHAKQEAgLTQ0LDE1ICs0NCwxNSBAQCBuYW1lc3BhY2UgV2Vi Q29yZSB7CiAKIG5hbWVzcGFjZSB7CiAKLSAgICB1aW50OF90IGNvbnZlcnRDb2xvcjE2TGl0dGxl VG84KHVpbnQxNl90IHZhbHVlKQotICAgIHsKLSAgICAgICAgcmV0dXJuIHZhbHVlID4+IDg7Ci0g ICAgfQordWludDhfdCBjb252ZXJ0Q29sb3IxNkxpdHRsZVRvOCh1aW50MTZfdCB2YWx1ZSkKK3sK KyAgICByZXR1cm4gdmFsdWUgPj4gODsKK30KIAotICAgIHVpbnQ4X3QgY29udmVydENvbG9yMTZC aWdUbzgodWludDE2X3QgdmFsdWUpCi0gICAgewotICAgICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8 dWludDhfdD4odmFsdWUgJiAweDAwRkYpOwotICAgIH0KK3VpbnQ4X3QgY29udmVydENvbG9yMTZC aWdUbzgodWludDE2X3QgdmFsdWUpCit7CisgICAgcmV0dXJuIHN0YXRpY19jYXN0PHVpbnQ4X3Q+ KHZhbHVlICYgMHgwMEZGKTsKK30KIAogfSAvLyBhbm9ueW1vdXMgbmFtZXNwYWNlCiAKQEAgLTM1 MiwxOCArMzUyLDYgQEAgbmFtZXNwYWNlIHsKIC8vLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogLy8gUGl4ZWwgdW5w YWNraW5nIHJvdXRpbmVzLgogCi12b2lkIHVucGFja09uZVJvd09mUkdCQThUb1JHQkE4KGNvbnN0 IHVpbnQ4X3QqIHNvdXJjZSwgdWludDhfdCogZGVzdGluYXRpb24sIHVuc2lnbmVkIGludCBwaXhl bHNQZXJSb3cpCi17Ci0gICAgZm9yICh1bnNpZ25lZCBpbnQgaSA9IDA7IGkgPCBwaXhlbHNQZXJS b3c7ICsraSkgewotICAgICAgICBkZXN0aW5hdGlvblswXSA9IHNvdXJjZVswXTsKLSAgICAgICAg ZGVzdGluYXRpb25bMV0gPSBzb3VyY2VbMV07Ci0gICAgICAgIGRlc3RpbmF0aW9uWzJdID0gc291 cmNlWzJdOwotICAgICAgICBkZXN0aW5hdGlvblszXSA9IHNvdXJjZVszXTsKLSAgICAgICAgc291 cmNlICs9IDQ7Ci0gICAgICAgIGRlc3RpbmF0aW9uICs9IDQ7Ci0gICAgfQotfQotCiB2b2lkIHVu cGFja09uZVJvd09mUkdCQTE2TGl0dGxlVG9SR0JBOChjb25zdCB1aW50MTZfdCogc291cmNlLCB1 aW50OF90KiBkZXN0aW5hdGlvbiwgdW5zaWduZWQgaW50IHBpeGVsc1BlclJvdykKIHsKICAgICBm b3IgKHVuc2lnbmVkIGludCBpID0gMDsgaSA8IHBpeGVsc1BlclJvdzsgKytpKSB7Ci0tIAoxLjcu NC40Cgo=