59012 2011-04-20 11:43:39 -0700 Shadows should be imported along with their host nodes 2011-06-01 23:35:22 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 52962 61909 1 dominicc rolandsteiner commit-queue rolandsteiner tkent oldest_to_newest 389391 0 dominicc 2011-04-20 11:43:39 -0700 Document::importedNode doesn’t import new-style shadows. This means that as nodes are imported, they lose their shadows. 389392 1 dominicc 2011-04-20 11:44:11 -0700 s/importedNode/importNode/ 389767 2 90478 rolandsteiner 2011-04-20 19:30:18 -0700 Created attachment 90478 Patch 389769 3 90478 tkent 2011-04-20 19:33:41 -0700 Comment on attachment 90478 Patch Looks good 389775 4 tkent 2011-04-20 19:51:36 -0700 BTW, what about Node::cloneNode()? 390100 5 rolandsteiner 2011-04-21 09:59:09 -0700 (In reply to comment #4) > BTW, what about Node::cloneNode()? Both importNode() and cloneNode() call copyNonAttributeProperties for nodes they clone, so both are handled by this patch. But note that a direct call to cloneNode() and importNode() is currently forbidden. It the end it depends on the JS API we will have for shadowRoot, I think. If you can assign directly to element.shadowRoot, e.g., myBoundElement.shadowRoot = myOtherBoundElement.shadowRoot.cloneNode() then we will need to allow a direct call to cloneNode and importNode on a ShadowRoot. 390189 6 90478 commit-queue 2011-04-21 11:32:31 -0700 Comment on attachment 90478 Patch Clearing flags on attachment: 90478 Committed r84528: <http://trac.webkit.org/changeset/84528> 390190 7 commit-queue 2011-04-21 11:32:35 -0700 All reviewed patches have been landed. Closing bug. 90478 2011-04-20 19:30:18 -0700 2011-04-21 11:32:31 -0700 Patch bug-59012-20110420193017.patch text/plain 5259 rolandsteiner U3VidmVyc2lvbiBSZXZpc2lvbjogODQ0NDEKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA3NTUwMjYwNTk4MDI3NmNjMTczOTcw MmYyOTJkMDY0ZjdlOTNhMDc1Li5iNWNjMDRlMDY4YzQzOGVmOTYwNDA0NzhjMzQ4ZWU2NTk4YWY0 ZGZlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDQtMjAgIFJvbGFuZCBTdGVpbmVyICA8 cm9sYW5kc3RlaW5lckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQnVnIDU5MDEyIC0gU2hhZG93cyBzaG91bGQgYmUgaW1wb3J0 ZWQgYWxvbmcgd2l0aCB0aGVpciBob3N0IG5vZGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTAxMgorCisgICAgICAgIFZlcmlmeSB0aGF0IHRoZSBz aGFkb3cgb2YgYSBib3VuZCBlbGVtZW50IGlzIGltcG9ydGVkIGFsb25nIHdpdGggdGhlIGVsZW1l bnQuCisKKyAgICAgICAgKiBmYXN0L2RvbS9zaGFkb3cvaW1wb3J0LXNoYWRvd3Jvb3QtZXhwZWN0 ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2RvbS9zaGFkb3cvaW1wb3J0LXNoYWRvd3Jv b3QuaHRtbDogQWRkZWQuCisKIDIwMTEtMDQtMjAgIERpbWl0cmkgR2xhemtvdiAgPGRnbGF6a292 QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW50IFRhbXVyYS4KZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL3NoYWRvdy9pbXBvcnQtc2hhZG93cm9vdC1leHBl Y3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9zaGFkb3cvaW1wb3J0LXNoYWRvd3Jvb3Qt ZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmZlZDEyOTU2ZTNhNzZhZWNjZjZjOTBlNjQxNzMwMzg2 ZGUzYjFlYjQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9zaGFkb3cv aW1wb3J0LXNoYWRvd3Jvb3QtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTUgQEAKKworVGhpcyB0 ZXN0cyBpbXBvcnROb2RlKCkgd2l0aCBib3VuZCBlbGVtZW50cy4KKworUEFTUyBkc3REb2MgaXMg bm9uLW51bGwuCitQQVNTIHNyY0tleWdlbiBpcyBub24tbnVsbC4KK1BBU1Mgc3JjU2hhZG93IGlz IG5vbi1udWxsLgorUEFTUyBzcmNTaGFkb3cuZmlyc3RDaGlsZCBpcyBub24tbnVsbC4KK1BBU1Mg aW1wb3J0ZWRLZXlnZW4gaXMgbm9uLW51bGwuCitQQVNTIHNyY0tleWdlbiAhPT0gaW1wb3J0ZWRL ZXlnZW4gaXMgdHJ1ZQorUEFTUyBpbXBvcnRlZFNoYWRvdyBpcyBub24tbnVsbC4KK1BBU1MgaW1w b3J0ZWRTaGFkb3cuZmlyc3RDaGlsZCBpcyBub24tbnVsbC4KK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFy c2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9m YXN0L2RvbS9zaGFkb3cvaW1wb3J0LXNoYWRvd3Jvb3QuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3Qv ZG9tL3NoYWRvdy9pbXBvcnQtc2hhZG93cm9vdC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmYzMWRmZjY4YmVl NDFkOWUzNzk3YTE0MGQyZDQ5NzZmMzc5NzEyMzUKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9mYXN0L2RvbS9zaGFkb3cvaW1wb3J0LXNoYWRvd3Jvb3QuaHRtbApAQCAtMCwwICsxLDM5 IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4v anMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5Pgor PGtleWdlbiBpZD0nSycvPgorPGRpdiBpZD0nWCc+PC9kaXY+Cis8cHJlIGlkPSJjb25zb2xlIj4K K1RoaXMgdGVzdHMgaW1wb3J0Tm9kZSgpIHdpdGggYm91bmQgZWxlbWVudHMuCisKKzwvcHJlPgor PHNjcmlwdD4KKyAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisgICAgICAg IGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKworICAgICAgICB2YXIgZHN0RG9j ID0gbmV3IERPTVBhcnNlcigpLnBhcnNlRnJvbVN0cmluZygnPGRpdi8+JywgJ3RleHQveG1sJyk7 CisgICAgICAgIHNob3VsZEJlTm9uTnVsbCgnZHN0RG9jJyk7CisKKyAgICAgICAgdmFyIHNyY0tl eWdlbiA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdLJyk7CisgICAgICAgIHNob3VsZEJlTm9u TnVsbCgnc3JjS2V5Z2VuJyk7CisgICAgICAgIHZhciBzcmNTaGFkb3cgPSBsYXlvdXRUZXN0Q29u dHJvbGxlci5zaGFkb3dSb290KHNyY0tleWdlbik7CisgICAgICAgIHNob3VsZEJlTm9uTnVsbCgn c3JjU2hhZG93Jyk7CisgICAgICAgIHNob3VsZEJlTm9uTnVsbCgnc3JjU2hhZG93LmZpcnN0Q2hp bGQnKTsKKworICAgICAgICB2YXIgaW1wb3J0ZWRLZXlnZW4gPSBkc3REb2MuaW1wb3J0Tm9kZShz cmNLZXlnZW4pOworICAgICAgICBzaG91bGRCZU5vbk51bGwoJ2ltcG9ydGVkS2V5Z2VuJyk7Cisg ICAgICAgIHNob3VsZEJlVHJ1ZSgnc3JjS2V5Z2VuICE9PSBpbXBvcnRlZEtleWdlbicpOworCisg ICAgICAgIHZhciBpbXBvcnRlZFNoYWRvdyA9IGxheW91dFRlc3RDb250cm9sbGVyLnNoYWRvd1Jv b3QoaW1wb3J0ZWRLZXlnZW4pOworICAgICAgICBzaG91bGRCZU5vbk51bGwoJ2ltcG9ydGVkU2hh ZG93Jyk7CisgICAgICAgIHNob3VsZEJlTm9uTnVsbCgnaW1wb3J0ZWRTaGFkb3cuZmlyc3RDaGls ZCcpOworICAgIH0KKworICAgIHZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOworPC9zY3Jp cHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9z Y3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWJkMjY2ZmY5ZjRlNzIzYmEy NmUzYjdmZTYyNzBmNWMxNDcwZDU5MS4uNjU4NmIwMmUzZWE0YjM4NTAyNDQ4MTNlNGRlODJhYzNm NTE2NzhmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDExLTA0LTIwICBSb2xhbmQg U3RlaW5lciAgPHJvbGFuZHN0ZWluZXJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyA1OTAxMiAtIFNoYWRvd3Mgc2hvdWxk IGJlIGltcG9ydGVkIGFsb25nIHdpdGggdGhlaXIgaG9zdCBub2RlcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTkwMTIKKworICAgICAgICBDb3B5IHRo ZSBzaGFkb3cgdHJlZSBvZiBhbiBlbGVtZW50IChldmVuIG9uIGEgc2hhbGxvdyBjb3B5ISkuCisK KyAgICAgICAgVGVzdDogZmFzdC9kb20vc2hhZG93L2ltcG9ydC1zaGFkb3dyb290Lmh0bWwKKwor ICAgICAgICAqIGRvbS9FbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVsZW1lbnQ6OmNv cHlOb25BdHRyaWJ1dGVQcm9wZXJ0aWVzKToKKyAgICAgICAgKiBkb20vRWxlbWVudC5oOgorCiAy MDExLTA0LTIwICBLZW5uZXRoIFJ1c3NlbGwgIDxrYnJAZ29vZ2xlLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBKYW1lcyBSb2JpbnNvbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Rv bS9FbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAppbmRleCA2MGFl MmEwMjcxOGVmMDY1MjdhMGRjYzA5MDIxNmMyZGYwYjg1NmU5Li45YmE4NDhiYTNjN2NiMmU3OWQ5 N2E5M2IwZmM3ZTNiODZiZTU4YjYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxl bWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCkBAIC0yMTAsNiAr MjEwLDE2IEBAIFBhc3NSZWZQdHI8RWxlbWVudD4gRWxlbWVudDo6Y2xvbmVFbGVtZW50V2l0aG91 dEF0dHJpYnV0ZXNBbmRDaGlsZHJlbigpIGNvbnN0CiAgICAgcmV0dXJuIGRvY3VtZW50KCktPmNy ZWF0ZUVsZW1lbnQodGFnUU5hbWUoKSwgZmFsc2UpOwogfQogCit2b2lkIEVsZW1lbnQ6OmNvcHlO b25BdHRyaWJ1dGVQcm9wZXJ0aWVzKGNvbnN0IEVsZW1lbnQqIHNvdXJjZSkKK3sKKyAgICBDb250 YWluZXJOb2RlKiBzb3VyY2VTaGFkb3cgPSBzb3VyY2UtPnNoYWRvd1Jvb3QoKTsKKyAgICByZW1v dmVTaGFkb3dSb290KCk7CisgICAgaWYgKHNvdXJjZVNoYWRvdykgeworICAgICAgICBDb250YWlu ZXJOb2RlKiBjbG9uZWRTaGFkb3cgPSBlbnN1cmVTaGFkb3dSb290KCk7CisgICAgICAgIHNvdXJj ZVNoYWRvdy0+Y2xvbmVDaGlsZE5vZGVzKGNsb25lZFNoYWRvdyk7CisgICAgfQorfQorCiB2b2lk IEVsZW1lbnQ6OnJlbW92ZUF0dHJpYnV0ZShjb25zdCBRdWFsaWZpZWROYW1lJiBuYW1lLCBFeGNl cHRpb25Db2RlJiBlYykKIHsKICAgICBpZiAobV9hdHRyaWJ1dGVNYXApIHsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVu dC5oCmluZGV4IDBhZjZkOTdlZTQ0ZDk0MjE3MzU3ZGVhMGVhZjVkYmNkYTU0MTQzZGUuLjE1ZmQ3 ZTM3ZWQzNTVjMjMxYzlhZWZkN2Q4ZDk0MDY3ZDVmYmRkZjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2RvbS9FbGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuaApA QCAtMjIzLDcgKzIyMyw3IEBAIHB1YmxpYzoKICAgICB2b2lkIHNldEF0dHJpYnV0ZU1hcChQYXNz UmVmUHRyPE5hbWVkTm9kZU1hcD4sIEZyYWdtZW50U2NyaXB0aW5nUGVybWlzc2lvbiA9IEZyYWdt ZW50U2NyaXB0aW5nQWxsb3dlZCk7CiAgICAgTmFtZWROb2RlTWFwKiBhdHRyaWJ1dGVNYXAoKSBj b25zdCB7IHJldHVybiBtX2F0dHJpYnV0ZU1hcC5nZXQoKTsgfQogCi0gICAgdmlydHVhbCB2b2lk IGNvcHlOb25BdHRyaWJ1dGVQcm9wZXJ0aWVzKGNvbnN0IEVsZW1lbnQqIC8qc291cmNlKi8pIHsg fQorICAgIHZpcnR1YWwgdm9pZCBjb3B5Tm9uQXR0cmlidXRlUHJvcGVydGllcyhjb25zdCBFbGVt ZW50KiBzb3VyY2UpOwogCiAgICAgdmlydHVhbCB2b2lkIGF0dGFjaCgpOwogICAgIHZpcnR1YWwg dm9pZCBkZXRhY2goKTsK