58969 2011-04-20 00:25:02 -0700 [chromium] Fix artefacts in compositor HUD when resizing 2011-04-21 14:22:50 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 nduca nduca commit-queue enne jamesr nduca oldest_to_newest 389107 0 nduca 2011-04-20 00:25:02 -0700 [chromium] Fix artefacts in compositor HUD when resizing 389110 1 90321 nduca 2011-04-20 00:27:13 -0700 Created attachment 90321 Patch 389111 2 90321 jamesr 2011-04-20 00:39:25 -0700 Comment on attachment 90321 Patch Aha! I blame enne :P 389113 3 90321 jamesr 2011-04-20 00:40:16 -0700 Comment on attachment 90321 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90321&action=review > Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:988 > + m_headsUpDisplayProgram = adoptPtr(new CCHeadsUpDisplay::Program(m_context.get())); btw not to pick on you since you didn't do this but our Program impl really should have a static PassOwnPtr<> create() function and a private c'tor 390327 4 commit-queue 2011-04-21 14:19:17 -0700 The commit-queue encountered the following flaky tests while processing attachment 90321: http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com) The commit-queue is continuing to process your patch. 390333 5 90321 commit-queue 2011-04-21 14:22:47 -0700 Comment on attachment 90321 Patch Clearing flags on attachment: 90321 Committed r84546: <http://trac.webkit.org/changeset/84546> 390334 6 commit-queue 2011-04-21 14:22:50 -0700 All reviewed patches have been landed. Closing bug. 90321 2011-04-20 00:27:13 -0700 2011-04-21 14:22:46 -0700 Patch bug-58969-20110420002712.patch text/plain 6760 nduca U3VidmVyc2lvbiBSZXZpc2lvbjogODQyNjMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkOGIzZGEzNDgwNThlNjhh MGQ4OWYxZjhkNDgyZGM4ZDE3YTQ4ZGVkLi5lNDZmZTE0ZTdhYjU1NjhiYzRlYzBhYWE3NWEzOTRl OGNhZTQyZTM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEtMDQtMjAgIE5hdCBE dWNhICA8bmR1Y2FAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gRml4IGFydGVmYWN0cyBpbiBjb21wb3NpdG9y IEhVRCB3aGVuIHJlc2l6aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD01ODk2OQorCisgICAgICAgIEhVRCB3YXMgdXNpbmcgdGhlIHRpbGVyIHByb2dy YW0gYW5kIG5vdCBzZXR0aW5nIHRoZSB0ZXh0dXJlCisgICAgICAgIHRyYW5zZm9ybS4gVGhlIEhV RCB3b3VsZCB0aHVzIGRyYXcgd2l0aCBhIHRleHR1cmUgdHJhbnNmb3JtIGJhc2VkCisgICAgICAg IG9uIHRoZSBsYXN0IHRpbGUgZHJhd24sIGxlYWRpbmcgc29tZXRpbWVzIHRvIGRpc3RvcnRpb24u CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJlbmRlcmVyQ2hy b21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5ZXJSZW5kZXJlckNocm9taXVtOjppbml0 aWFsaXplU2hhcmVkT2JqZWN0cyk6CisgICAgICAgIChXZWJDb3JlOjpMYXllclJlbmRlcmVyQ2hy b21pdW06OmNsZWFudXBTaGFyZWRPYmplY3RzKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy9jaHJvbWl1bS9MYXllclJlbmRlcmVyQ2hyb21pdW0uaDoKKyAgICAgICAgKFdlYkNvcmU6Okxh eWVyUmVuZGVyZXJDaHJvbWl1bTo6aGVhZHNVcERpc3BsYXlQcm9ncmFtKToKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0hlYWRzVXBEaXNwbGF5LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkNDSGVhZHNVcERpc3BsYXk6OmRyYXcpOgorICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDSGVhZHNVcERpc3BsYXkuaDoKKwogMjAxMS0wNC0xOSAg QnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgQWRhbSBSb2Jlbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2Nocm9taXVtL0xheWVyUmVuZGVyZXJDaHJvbWl1bS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJlbmRlcmVyQ2hyb21pdW0uY3BwCmluZGV4 IDI3YTY3ZTkwMjg5NjU2N2MzNDkzYWZmNDk5YTc0Njk2NTVlNzAzYmYuLjg4N2Y2YjYxMTdlNjg5 NjBkYjZlNDg5ZWFkMmVmNTljOWQwZTIyNjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyUmVuZGVyZXJDaHJvbWl1bS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJSZW5kZXJlckNo cm9taXVtLmNwcApAQCAtOTg1LDYgKzk4NSw3IEBAIGJvb2wgTGF5ZXJSZW5kZXJlckNocm9taXVt Ojppbml0aWFsaXplU2hhcmVkT2JqZWN0cygpCiAKICAgICBtX3NoYXJlZEdlb21ldHJ5ID0gYWRv cHRQdHIobmV3IEdlb21ldHJ5QmluZGluZyhtX2NvbnRleHQuZ2V0KCkpKTsKICAgICBtX2JvcmRl clByb2dyYW0gPSBhZG9wdFB0cihuZXcgTGF5ZXJDaHJvbWl1bTo6Qm9yZGVyUHJvZ3JhbShtX2Nv bnRleHQuZ2V0KCkpKTsKKyAgICBtX2hlYWRzVXBEaXNwbGF5UHJvZ3JhbSA9IGFkb3B0UHRyKG5l dyBDQ0hlYWRzVXBEaXNwbGF5OjpQcm9ncmFtKG1fY29udGV4dC5nZXQoKSkpOwogICAgIG1fY2Fu dmFzTGF5ZXJQcm9ncmFtID0gYWRvcHRQdHIobmV3IENDQ2FudmFzTGF5ZXJJbXBsOjpQcm9ncmFt KG1fY29udGV4dC5nZXQoKSkpOwogICAgIG1fdmlkZW9MYXllclJHQkFQcm9ncmFtID0gYWRvcHRQ dHIobmV3IENDVmlkZW9MYXllckltcGw6OlJHQkFQcm9ncmFtKG1fY29udGV4dC5nZXQoKSkpOwog ICAgIG1fdmlkZW9MYXllcllVVlByb2dyYW0gPSBhZG9wdFB0cihuZXcgQ0NWaWRlb0xheWVySW1w bDo6WVVWUHJvZ3JhbShtX2NvbnRleHQuZ2V0KCkpKTsKQEAgLTk5NSw2ICs5OTYsNyBAQCBib29s IExheWVyUmVuZGVyZXJDaHJvbWl1bTo6aW5pdGlhbGl6ZVNoYXJlZE9iamVjdHMoKQogCiAgICAg aWYgKCFtX3NoYXJlZEdlb21ldHJ5LT5pbml0aWFsaXplZCgpIHx8ICFtX2JvcmRlclByb2dyYW0t PmluaXRpYWxpemVkKCkKICAgICAgICAgfHwgIW1fY2FudmFzTGF5ZXJQcm9ncmFtLT5pbml0aWFs aXplZCgpCisgICAgICAgIHx8ICFtX2hlYWRzVXBEaXNwbGF5UHJvZ3JhbS0+aW5pdGlhbGl6ZWQo KQogICAgICAgICB8fCAhbV92aWRlb0xheWVyUkdCQVByb2dyYW0tPmluaXRpYWxpemVkKCkgfHwg IW1fdmlkZW9MYXllcllVVlByb2dyYW0tPmluaXRpYWxpemVkKCkKICAgICAgICAgfHwgIW1fcGx1 Z2luTGF5ZXJQcm9ncmFtLT5pbml0aWFsaXplZCgpIHx8ICFtX3JlbmRlclN1cmZhY2VQcm9ncmFt LT5pbml0aWFsaXplZCgpCiAgICAgICAgIHx8ICFtX3JlbmRlclN1cmZhY2VNYXNrUHJvZ3JhbS0+ aW5pdGlhbGl6ZWQoKSB8fCAhbV90aWxlclByb2dyYW0tPmluaXRpYWxpemVkKCkpIHsKQEAgLTEw MTQsNiArMTAxNiw3IEBAIHZvaWQgTGF5ZXJSZW5kZXJlckNocm9taXVtOjpjbGVhbnVwU2hhcmVk T2JqZWN0cygpCiAgICAgbV9zaGFyZWRHZW9tZXRyeS5jbGVhcigpOwogICAgIG1fYm9yZGVyUHJv Z3JhbS5jbGVhcigpOwogICAgIG1fY2FudmFzTGF5ZXJQcm9ncmFtLmNsZWFyKCk7CisgICAgbV9o ZWFkc1VwRGlzcGxheVByb2dyYW0uY2xlYXIoKTsKICAgICBtX3ZpZGVvTGF5ZXJSR0JBUHJvZ3Jh bS5jbGVhcigpOwogICAgIG1fdmlkZW9MYXllcllVVlByb2dyYW0uY2xlYXIoKTsKICAgICBtX3Bs dWdpbkxheWVyUHJvZ3JhbS5jbGVhcigpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJSZW5kZXJlckNocm9taXVtLmggYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJlbmRlcmVyQ2hyb21pdW0u aAppbmRleCA4MTNlYjQ2ZTBiYWEzNjUxM2Q2MDc4ZGEyNWE0MjVkNDQ1YWViZWU5Li42ZjI2YzRh OGUyM2ZmNzc5NGNhMTJkZjBjZWVhOWZkOTAwOWYzMGZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJlbmRlcmVyQ2hyb21pdW0uaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJlbmRl cmVyQ2hyb21pdW0uaApAQCAtMTEwLDYgKzExMCw3IEBAIHB1YmxpYzoKIAogICAgIGNvbnN0IEdl b21ldHJ5QmluZGluZyogc2hhcmVkR2VvbWV0cnkoKSBjb25zdCB7IHJldHVybiBtX3NoYXJlZEdl b21ldHJ5LmdldCgpOyB9CiAgICAgY29uc3QgTGF5ZXJDaHJvbWl1bTo6Qm9yZGVyUHJvZ3JhbSog Ym9yZGVyUHJvZ3JhbSgpIGNvbnN0IHsgcmV0dXJuIG1fYm9yZGVyUHJvZ3JhbS5nZXQoKTsgfQor ICAgIGNvbnN0IENDSGVhZHNVcERpc3BsYXk6OlByb2dyYW0qIGhlYWRzVXBEaXNwbGF5UHJvZ3Jh bSgpIGNvbnN0IHsgcmV0dXJuIG1faGVhZHNVcERpc3BsYXlQcm9ncmFtLmdldCgpOyB9CiAgICAg Y29uc3QgUmVuZGVyU3VyZmFjZUNocm9taXVtOjpQcm9ncmFtKiByZW5kZXJTdXJmYWNlUHJvZ3Jh bSgpIGNvbnN0IHsgcmV0dXJuIG1fcmVuZGVyU3VyZmFjZVByb2dyYW0uZ2V0KCk7IH0KICAgICBj b25zdCBSZW5kZXJTdXJmYWNlQ2hyb21pdW06Ok1hc2tQcm9ncmFtKiByZW5kZXJTdXJmYWNlTWFz a1Byb2dyYW0oKSBjb25zdCB7IHJldHVybiBtX3JlbmRlclN1cmZhY2VNYXNrUHJvZ3JhbS5nZXQo KTsgfQogICAgIGNvbnN0IExheWVyVGlsZXJDaHJvbWl1bTo6UHJvZ3JhbSogdGlsZXJQcm9ncmFt KCkgY29uc3QgeyByZXR1cm4gbV90aWxlclByb2dyYW0uZ2V0KCk7IH0KQEAgLTIwNSw2ICsyMDYs NyBAQCBwcml2YXRlOgogICAgIC8vIHdlIGNhbm5vdCBzdG9yZSB0aGVzZSB2YWx1ZXMgaW4gc3Rh dGljIHZhcmlhYmxlcy4KICAgICBPd25QdHI8R2VvbWV0cnlCaW5kaW5nPiBtX3NoYXJlZEdlb21l dHJ5OwogICAgIE93blB0cjxMYXllckNocm9taXVtOjpCb3JkZXJQcm9ncmFtPiBtX2JvcmRlclBy b2dyYW07CisgICAgT3duUHRyPENDSGVhZHNVcERpc3BsYXk6OlByb2dyYW0+IG1faGVhZHNVcERp c3BsYXlQcm9ncmFtOwogICAgIE93blB0cjxSZW5kZXJTdXJmYWNlQ2hyb21pdW06OlByb2dyYW0+ IG1fcmVuZGVyU3VyZmFjZVByb2dyYW07CiAgICAgT3duUHRyPFJlbmRlclN1cmZhY2VDaHJvbWl1 bTo6TWFza1Byb2dyYW0+IG1fcmVuZGVyU3VyZmFjZU1hc2tQcm9ncmFtOwogICAgIE93blB0cjxM YXllclRpbGVyQ2hyb21pdW06OlByb2dyYW0+IG1fdGlsZXJQcm9ncmFtOwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NIZWFkc1VwRGlz cGxheS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9D Q0hlYWRzVXBEaXNwbGF5LmNwcAppbmRleCBkMjJiMDk4NjNmNTZkYWVmOTQ0MTY5YzZjODlkZGM2 ZmZkOTA3MzE5Li44M2M3ZGQ0Nzk1ZTJiMDdhZTE4YWVkNjEzMDJlYjFkMDQxNDE4ZjY2IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0hl YWRzVXBEaXNwbGF5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j aHJvbWl1bS9jYy9DQ0hlYWRzVXBEaXNwbGF5LmNwcApAQCAtMzIsNiArMzIsNyBAQAogI2luY2x1 ZGUgIkZvbnREZXNjcmlwdGlvbi5oIgogI2luY2x1ZGUgIkdyYXBoaWNzQ29udGV4dDNELmgiCiAj aW5jbHVkZSAiTGF5ZXJDaHJvbWl1bS5oIgorI2luY2x1ZGUgIkxheWVyUmVuZGVyZXJDaHJvbWl1 bS5oIgogI2luY2x1ZGUgIkxheWVyVGV4dHVyZS5oIgogI2luY2x1ZGUgIlRleHRSdW4uaCIKICNp bmNsdWRlICJUZXh0U3RyZWFtLmgiCkBAIC0xMDksNyArMTEwLDcgQEAgdm9pZCBDQ0hlYWRzVXBE aXNwbGF5OjpkcmF3KCkKICAgICB9CiAKICAgICAvLyBEcmF3IHRoZSBIVUQgb250byB0aGUgZGVm YXVsdCByZW5kZXIgc3VyZmFjZS4KLSAgICBjb25zdCBMYXllclRpbGVyQ2hyb21pdW06OlByb2dy YW0qIHByb2dyYW0gPSBtX2xheWVyUmVuZGVyZXItPnRpbGVyUHJvZ3JhbSgpOworICAgIGNvbnN0 IFByb2dyYW0qIHByb2dyYW0gPSBtX2xheWVyUmVuZGVyZXItPmhlYWRzVXBEaXNwbGF5UHJvZ3Jh bSgpOwogICAgIEFTU0VSVChwcm9ncmFtICYmIHByb2dyYW0tPmluaXRpYWxpemVkKCkpOwogICAg IEdMQyhjb250ZXh0LCBjb250ZXh0LT5hY3RpdmVUZXh0dXJlKEdyYXBoaWNzQ29udGV4dDNEOjpU RVhUVVJFMCkpOwogICAgIG1faHVkVGV4dHVyZS0+YmluZFRleHR1cmUoKTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDSGVhZHNVcERp c3BsYXkuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0ND SGVhZHNVcERpc3BsYXkuaAppbmRleCAwOWYxOThhYzE0NWQ3NzYzNGQxYjFmNTQzOWY3MTBkODQ2 ZTM3ZTI4Li5mYzY4ZjFkNjU0NDBkMTFjOGI1NzEyYWI1NTgwOWYzZWIzYWNhMzhlIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0hlYWRz VXBEaXNwbGF5LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21p dW0vY2MvQ0NIZWFkc1VwRGlzcGxheS5oCkBAIC0yOCwxMyArMjgsMTUgQEAKICNpZiBVU0UoQUND RUxFUkFURURfQ09NUE9TSVRJTkcpCiAKICNpbmNsdWRlICJGb250LmgiCi0jaW5jbHVkZSAiTGF5 ZXJSZW5kZXJlckNocm9taXVtLmgiCi0KKyNpbmNsdWRlICJQcm9ncmFtQmluZGluZy5oIgorI2lu Y2x1ZGUgIlNoYWRlckNocm9taXVtLmgiCiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogY2xhc3Mg R2VvbWV0cnlCaW5kaW5nOwogY2xhc3MgR3JhcGhpY3NDb250ZXh0M0Q7CitjbGFzcyBMYXllclJl bmRlcmVyQ2hyb21pdW07CitjbGFzcyBMYXllclRleHR1cmU7CiAKIC8vIENsYXNzIHRoYXQgaGFu ZGxlcyBkcmF3aW5nIG9mIGNvbXBvc2l0ZWQgcmVuZGVyIGxheWVycyB1c2luZyBHTC4KIGNsYXNz IENDSGVhZHNVcERpc3BsYXkgewpAQCAtNTgsNiArNjAsOCBAQCBwdWJsaWM6CiAgICAgYm9vbCBl bmFibGVkKCkgY29uc3QgeyByZXR1cm4gbV9zaG93UGxhdGZvcm1MYXllclRyZWUgfHwgbV9zaG93 RlBTQ291bnRlcjsgfQogICAgIHZvaWQgZHJhdygpOwogCisgICAgdHlwZWRlZiBQcm9ncmFtQmlu ZGluZzxWZXJ0ZXhTaGFkZXJQb3NUZXgsIEZyYWdtZW50U2hhZGVyQkdSQVRleEFscGhhPiBQcm9n cmFtOworCiBwcml2YXRlOgogICAgIGV4cGxpY2l0IENDSGVhZHNVcERpc3BsYXkoTGF5ZXJSZW5k ZXJlckNocm9taXVtKiBvd25lcik7CiAgICAgdm9pZCBkcmF3SHVkQ29udGVudHMoR3JhcGhpY3ND b250ZXh0KiwgY29uc3QgSW50U2l6ZSYgaHVkU2l6ZSk7Cg==