<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>58852</bug_id>
          
          <creation_ts>2011-04-18 16:33:47 -0700</creation_ts>
          <short_desc>[GTK] Add proxy support to GtkLauncher</short_desc>
          <delta_ts>2011-05-26 05:43:12 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Ryuan Choi">ryuan.choi</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>alex</cc>
    
    <cc>commit-queue</cc>
    
    <cc>gustavo</cc>
    
    <cc>kevin.cs.oh</cc>
    
    <cc>mrobinson</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>388161</commentid>
    <comment_count>0</comment_count>
    <who name="Ryuan Choi">ryuan.choi</who>
    <bug_when>2011-04-18 16:33:47 -0700</bug_when>
    <thetext>I recreate from Bug 55929.

Proxy support to Gtklauncher will help some developers behind proxy.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>388164</commentid>
    <comment_count>1</comment_count>
      <attachid>90117</attachid>
    <who name="Ryuan Choi">ryuan.choi</who>
    <bug_when>2011-04-18 16:36:53 -0700</bug_when>
    <thetext>Created attachment 90117
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>388166</commentid>
    <comment_count>2</comment_count>
    <who name="Ryuan Choi">ryuan.choi</who>
    <bug_when>2011-04-18 16:39:37 -0700</bug_when>
    <thetext>(In reply to comment #1)
&gt; Created an attachment (id=90117) [details]
&gt; Patch

I tried to use SoupProxyResolverDefault but it looks not available on libsoup 2.33.6.

IMO, g_object_set now is simple way for test browser.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>388221</commentid>
    <comment_count>3</comment_count>
      <attachid>90117</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2011-04-18 19:07:34 -0700</bug_when>
    <thetext>Comment on attachment 90117
Patch

Can&apos;t you just guard the code with an #ifdef so that when compiler with older versions of Soup, it&apos;s not seen. We generally develop against the latest stable version of the Gnome stack. Is there some particular version of libsoup that you require?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>390651</commentid>
    <comment_count>4</comment_count>
      <attachid>90675</attachid>
    <who name="Ryuan Choi">ryuan.choi</who>
    <bug_when>2011-04-22 00:19:59 -0700</bug_when>
    <thetext>Created attachment 90675
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>390654</commentid>
    <comment_count>5</comment_count>
    <who name="Ryuan Choi">ryuan.choi</who>
    <bug_when>2011-04-22 00:25:34 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; (From update of attachment 90117 [details])
&gt; Can&apos;t you just guard the code with an #ifdef so that when compiler with older versions of Soup, it&apos;s not seen. We generally develop against the latest stable version of the Gnome stack. Is there some particular version of libsoup that you require?

Sorry about late answer.
I tried to find checking libsoup version, but it looks not simple.

Instead, I checked SOUP_TYPE_PROXY_RESOLVER_DEFAULT.

And I changed my libsoup version, but previous patch works well for lower version of libsoup.
I update my patch for both SoupProxyResolverDefault and previous libsoup.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>390807</commentid>
    <comment_count>6</comment_count>
      <attachid>90675</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2011-04-22 09:06:59 -0700</bug_when>
    <thetext>Comment on attachment 90675
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90675&amp;action=review

Okay. This seems alright in the end.

&gt; Tools/ChangeLog:9
&gt; +        * GtkLauncher/main.c:
&gt; +        (main):

Please fill this out before landing.

&gt; Tools/GtkLauncher/main.c:245
&gt; +    const char *httpProxy = getenv(&quot;http_proxy&quot;);

I think it would be better to call g_getenv here instead.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>391676</commentid>
    <comment_count>7</comment_count>
      <attachid>90899</attachid>
    <who name="Ryuan Choi">ryuan.choi</who>
    <bug_when>2011-04-24 21:40:58 -0700</bug_when>
    <thetext>Created attachment 90899
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>391678</commentid>
    <comment_count>8</comment_count>
    <who name="Ryuan Choi">ryuan.choi</who>
    <bug_when>2011-04-24 21:44:07 -0700</bug_when>
    <thetext>(In reply to comment #6)
&gt; (From update of attachment 90675 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=90675&amp;action=review
&gt; 
&gt; Okay. This seems alright in the end.
&gt; 
&gt; &gt; Tools/ChangeLog:9
&gt; &gt; +        * GtkLauncher/main.c:
&gt; &gt; +        (main):
&gt; 
&gt; Please fill this out before landing.

added some comment.

&gt; 
&gt; &gt; Tools/GtkLauncher/main.c:245
&gt; &gt; +    const char *httpProxy = getenv(&quot;http_proxy&quot;);
&gt; 
&gt; I think it would be better to call g_getenv here instead.

Done.

Thank you for review.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>392671</commentid>
    <comment_count>9</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-04-26 13:56:29 -0700</bug_when>
    <thetext>The commit-queue encountered the following flaky tests while processing attachment 90899:

fast/loader/file-protocol-fragment.html bug 59488 (author: koivisto@iki.fi)
The commit-queue is continuing to process your patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>392673</commentid>
    <comment_count>10</comment_count>
      <attachid>90899</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-04-26 13:58:13 -0700</bug_when>
    <thetext>Comment on attachment 90899
Patch

Clearing flags on attachment: 90899

Committed r84949: &lt;http://trac.webkit.org/changeset/84949&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>392674</commentid>
    <comment_count>11</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-04-26 13:58:18 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>392707</commentid>
    <comment_count>12</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-04-26 14:21:53 -0700</bug_when>
    <thetext>The commit-queue encountered the following flaky tests while processing attachment 90899:

storage/domstorage/localstorage/storagetracker/storage-tracker-1-prepare.html bug 59494
storage/domstorage/localstorage/storagetracker/storage-tracker-2-create.html bug 59495
storage/domstorage/localstorage/storagetracker/storage-tracker-3-delete-all.html bug 59496
The commit-queue is continuing to process your patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>392870</commentid>
    <comment_count>13</comment_count>
    <who name="Alejandro G. Castro">alex</who>
    <bug_when>2011-04-26 15:47:38 -0700</bug_when>
    <thetext>Reverted r84949 for reason:

Broke GTK+ compilation

Committed r84965: &lt;http://trac.webkit.org/changeset/84965&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>393328</commentid>
    <comment_count>14</comment_count>
      <attachid>91227</attachid>
    <who name="Ryuan Choi">ryuan.choi</who>
    <bug_when>2011-04-26 21:41:17 -0700</bug_when>
    <thetext>Created attachment 91227
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>393331</commentid>
    <comment_count>15</comment_count>
    <who name="Ryuan Choi">ryuan.choi</who>
    <bug_when>2011-04-26 21:48:22 -0700</bug_when>
    <thetext>(In reply to comment #13)
&gt; Reverted r84949 for reason:
&gt; 
&gt; Broke GTK+ compilation
&gt; 
&gt; Committed r84965: &lt;http://trac.webkit.org/changeset/84965&gt;

I am sorry. I didn&apos;t see build break.
I update patch to solve it, although I couldn&apos;t reproduce it on my desktop.

Below is a message from http://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/13144/steps/compile-webkit/logs/stdio

/usr/bin/ld: Tools/GtkLauncher/Programs_GtkLauncher-main.o: undefined reference to symbol &apos;soup_session_add_feature_by_type&apos;
/usr/bin/ld: note: &apos;soup_session_add_feature_by_type&apos; is defined in DSO /usr/lib/libsoup-2.4.so.1 so try adding it to the linker command line
/usr/lib/libsoup-2.4.so.1: could not read symbols: Invalid operation</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>393460</commentid>
    <comment_count>16</comment_count>
      <attachid>91227</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-04-27 02:44:25 -0700</bug_when>
    <thetext>Comment on attachment 91227
Patch

Rejecting attachment 91227 from commit-queue.

Failed to run &quot;[&apos;./Tools/Scripts/webkit-patch&apos;, &apos;--status-host=queues.webkit.org&apos;, &apos;--bot-id=cr-jail-3&apos;, &apos;land-a...&quot; exit_code: 1

Last 500 characters of output:
autoinstalled/mechanize/_urllib2_fork.py&quot;, line 332, in _call_chain
    result = func(*args)
  File &quot;/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py&quot;, line 1170, in https_open
    return self.do_open(conn_factory, req)
  File &quot;/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py&quot;, line 1118, in do_open
    raise URLError(err)
urllib2.URLError: &lt;urlopen error [Errno 60] Operation timed out&gt;

Full output: http://queues.webkit.org/results/8508915</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>401748</commentid>
    <comment_count>17</comment_count>
    <who name="Ryuan Choi">ryuan.choi</who>
    <bug_when>2011-05-10 21:36:12 -0700</bug_when>
    <thetext>I think that this is already landed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>410132</commentid>
    <comment_count>18</comment_count>
    <who name="ChangSeok Oh">kevin.cs.oh</who>
    <bug_when>2011-05-25 19:32:03 -0700</bug_when>
    <thetext>I think there is an issue to use SOUP_TYPE_PROXY_RESOLVER_DEFAULT.
A crash is occured while running GtkLauncher, if I set a proxy using by xxx.pac file.
Please refer http://code.google.com/p/libproxy/issues/detail?id=153#makechanges
This issue is still there on Ubuntu 11.04.
If I disable SOUP_TYPE_PROXY_RESOLVER_DEFAULT, No problem.
And If I don&apos;t use .pac file to set proxy, No problem, too.

Actually, this issue might not be webkit&apos; one. But we need to track this issue and be careful to use .pac file to set proxy. :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>410367</commentid>
    <comment_count>19</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2011-05-26 05:43:12 -0700</bug_when>
    <thetext>(In reply to comment #18)
&gt; I think there is an issue to use SOUP_TYPE_PROXY_RESOLVER_DEFAULT.
&gt; A crash is occured while running GtkLauncher, if I set a proxy using by xxx.pac file.
&gt; Please refer http://code.google.com/p/libproxy/issues/detail?id=153#makechanges
&gt; This issue is still there on Ubuntu 11.04.
&gt; If I disable SOUP_TYPE_PROXY_RESOLVER_DEFAULT, No problem.
&gt; And If I don&apos;t use .pac file to set proxy, No problem, too.
&gt; 
&gt; Actually, this issue might not be webkit&apos; one. But we need to track this issue and be careful to use .pac file to set proxy. :)

Thanks for linking to the libproxy issue. That will be very helpful if people report the segfault.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>90117</attachid>
            <date>2011-04-18 16:36:53 -0700</date>
            <delta_ts>2011-04-22 00:19:50 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-58852-20110419083526.patch</filename>
            <type>text/plain</type>
            <size>1262</size>
            <attacher name="Ryuan Choi">ryuan.choi</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDg0MjA4KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg
KzEsMTUgQEAKKzIwMTEtMDQtMTggIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29t
PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtd
IEFkZCBwcm94eSBzdXBwb3J0IHRvIEd0a0xhdW5jaGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53
ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODg1MgorCisgICAgICAgIEFkZCBwcm94eSBzdXBw
b3J0IHRvIEd0a0xhdW5jaGVyIHVzaW5nIGVudmlyb25tZW50LgorCisgICAgICAgICogR3RrTGF1
bmNoZXIvbWFpbi5jOgorICAgICAgICAobWFpbik6CisKIDIwMTEtMDQtMTggIERpcmsgUHJhbmtl
ICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlk
ZWwuCkluZGV4OiBUb29scy9HdGtMYXVuY2hlci9tYWluLmMKPT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMv
R3RrTGF1bmNoZXIvbWFpbi5jCShyZXZpc2lvbiA4NDIwNCkKKysrIFRvb2xzL0d0a0xhdW5jaGVy
L21haW4uYwkod29ya2luZyBjb3B5KQpAQCAtMjM5LDYgKzIzOSwxMiBAQCBpbnQgbWFpbihpbnQg
YXJnYywgY2hhciogYXJndltdKQogICAgIGlmICghZ190aHJlYWRfc3VwcG9ydGVkKCkpCiAgICAg
ICAgIGdfdGhyZWFkX2luaXQoTlVMTCk7CiAKKyAgICBjb25zdCBjaGFyICpodHRwUHJveHkgPSBn
ZXRlbnYoImh0dHBfcHJveHkiKTsKKyAgICBpZiAoaHR0cFByb3h5KSB7CisgICAgICAgIFNvdXBV
UkkgKnByb3h5VXJpID0gc291cF91cmlfbmV3KGh0dHBQcm94eSk7CisgICAgICAgIGdfb2JqZWN0
X3NldCh3ZWJraXRfZ2V0X2RlZmF1bHRfc2Vzc2lvbigpLCBTT1VQX1NFU1NJT05fUFJPWFlfVVJJ
LCBwcm94eVVyaSwgTlVMTCk7CisgICAgICAgIHNvdXBfdXJpX2ZyZWUocHJveHlVcmkpOworICAg
IH0KICAgICBtYWluX3dpbmRvdyA9IGNyZWF0ZVdpbmRvdygmd2ViVmlldyk7CiAKICAgICBnY2hh
ciAqdXJpID0oZ2NoYXIqKShhcmdjID4gMSA/IGFyZ3ZbMV0gOiAiaHR0cDovL3d3dy5nb29nbGUu
Y29tLyIpOwo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>90675</attachid>
            <date>2011-04-22 00:19:59 -0700</date>
            <delta_ts>2011-04-24 21:40:49 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-58852-20110422161959.patch</filename>
            <type>text/plain</type>
            <size>1360</size>
            <attacher name="Ryuan Choi">ryuan.choi</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDg0NjA3KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg
KzEsMTMgQEAKKzIwMTEtMDQtMjIgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29t
PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtd
IEFkZCBwcm94eSBzdXBwb3J0IHRvIEd0a0xhdW5jaGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53
ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODg1MgorCisgICAgICAgICogR3RrTGF1bmNoZXIv
bWFpbi5jOgorICAgICAgICAobWFpbik6CisKIDIwMTEtMDQtMjEgIFRvbnkgQ2hhbmcgIDx0b255
QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBNaWhhaSBQYXJwYXJpdGEuCklu
ZGV4OiBUb29scy9HdGtMYXVuY2hlci9tYWluLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvR3RrTGF1
bmNoZXIvbWFpbi5jCShyZXZpc2lvbiA4NDYwNikKKysrIFRvb2xzL0d0a0xhdW5jaGVyL21haW4u
Ywkod29ya2luZyBjb3B5KQpAQCAtMjM5LDYgKzIzOSwxNyBAQCBpbnQgbWFpbihpbnQgYXJnYywg
Y2hhciogYXJndltdKQogICAgIGlmICghZ190aHJlYWRfc3VwcG9ydGVkKCkpCiAgICAgICAgIGdf
dGhyZWFkX2luaXQoTlVMTCk7CiAKKyNpZmRlZiBTT1VQX1RZUEVfUFJPWFlfUkVTT0xWRVJfREVG
QVVMVAorICAgIHNvdXBfc2Vzc2lvbl9hZGRfZmVhdHVyZV9ieV90eXBlKHdlYmtpdF9nZXRfZGVm
YXVsdF9zZXNzaW9uKCksIFNPVVBfVFlQRV9QUk9YWV9SRVNPTFZFUl9ERUZBVUxUKTsKKyNlbHNl
CisgICAgY29uc3QgY2hhciAqaHR0cFByb3h5ID0gZ2V0ZW52KCJodHRwX3Byb3h5Iik7CisgICAg
aWYgKGh0dHBQcm94eSkgeworICAgICAgICBTb3VwVVJJICpwcm94eVVyaSA9IHNvdXBfdXJpX25l
dyhodHRwUHJveHkpOworICAgICAgICBnX29iamVjdF9zZXQod2Via2l0X2dldF9kZWZhdWx0X3Nl
c3Npb24oKSwgU09VUF9TRVNTSU9OX1BST1hZX1VSSSwgcHJveHlVcmksIE5VTEwpOworICAgICAg
ICBzb3VwX3VyaV9mcmVlKHByb3h5VXJpKTsKKyAgICB9CisjZW5kaWYKKwogICAgIG1haW5fd2lu
ZG93ID0gY3JlYXRlV2luZG93KCZ3ZWJWaWV3KTsKIAogICAgIGdjaGFyICp1cmkgPShnY2hhciop
KGFyZ2MgPiAxID8gYXJndlsxXSA6ICJodHRwOi8vd3d3Lmdvb2dsZS5jb20vIik7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>90899</attachid>
            <date>2011-04-24 21:40:58 -0700</date>
            <delta_ts>2011-04-26 21:41:07 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-58852-20110425134055.patch</filename>
            <type>text/plain</type>
            <size>1486</size>
            <attacher name="Ryuan Choi">ryuan.choi</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDg0NzY0KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg
KzEsMTUgQEAKKzIwMTEtMDQtMjQgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29t
PgorCisgICAgICAgIFJldmlld2VkIGJ5IE1hcnRpbiBSb2JpbnNvbi4KKworICAgICAgICBbR1RL
XSBBZGQgcHJveHkgc3VwcG9ydCB0byBHdGtMYXVuY2hlcgorICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTg4NTIKKworICAgICAgICBBZGQgU09VUF9UWVBF
X1BST1hZX1JFU09MVkVSX0RFRkFVTFQgZmVhdHVyZSBvciBzZXQgU09VUF9TRVNTSU9OX1BST1hZ
X1VSSSBmb3IgZGV2ZWxvcGVycyBiZWhpbmQgcHJveHkuCisKKyAgICAgICAgKiBHdGtMYXVuY2hl
ci9tYWluLmM6CisgICAgICAgIChtYWluKToKKwogMjAxMS0wNC0yMyAgRG9taW5pYyBDb29uZXkg
IDxkb21pbmljY0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGltaXRyaSBH
bGF6a292LgpJbmRleDogVG9vbHMvR3RrTGF1bmNoZXIvbWFpbi5jCj09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRv
b2xzL0d0a0xhdW5jaGVyL21haW4uYwkocmV2aXNpb24gODQ3NjQpCisrKyBUb29scy9HdGtMYXVu
Y2hlci9tYWluLmMJKHdvcmtpbmcgY29weSkKQEAgLTIzOSw2ICsyMzksMTcgQEAgaW50IG1haW4o
aW50IGFyZ2MsIGNoYXIqIGFyZ3ZbXSkKICAgICBpZiAoIWdfdGhyZWFkX3N1cHBvcnRlZCgpKQog
ICAgICAgICBnX3RocmVhZF9pbml0KE5VTEwpOwogCisjaWZkZWYgU09VUF9UWVBFX1BST1hZX1JF
U09MVkVSX0RFRkFVTFQKKyAgICBzb3VwX3Nlc3Npb25fYWRkX2ZlYXR1cmVfYnlfdHlwZSh3ZWJr
aXRfZ2V0X2RlZmF1bHRfc2Vzc2lvbigpLCBTT1VQX1RZUEVfUFJPWFlfUkVTT0xWRVJfREVGQVVM
VCk7CisjZWxzZQorICAgIGNvbnN0IGNoYXIgKmh0dHBQcm94eSA9IGdfZ2V0ZW52KCJodHRwX3By
b3h5Iik7CisgICAgaWYgKGh0dHBQcm94eSkgeworICAgICAgICBTb3VwVVJJICpwcm94eVVyaSA9
IHNvdXBfdXJpX25ldyhodHRwUHJveHkpOworICAgICAgICBnX29iamVjdF9zZXQod2Via2l0X2dl
dF9kZWZhdWx0X3Nlc3Npb24oKSwgU09VUF9TRVNTSU9OX1BST1hZX1VSSSwgcHJveHlVcmksIE5V
TEwpOworICAgICAgICBzb3VwX3VyaV9mcmVlKHByb3h5VXJpKTsKKyAgICB9CisjZW5kaWYKKwog
ICAgIG1haW5fd2luZG93ID0gY3JlYXRlV2luZG93KCZ3ZWJWaWV3KTsKIAogICAgIGdjaGFyICp1
cmkgPShnY2hhciopKGFyZ2MgPiAxID8gYXJndlsxXSA6ICJodHRwOi8vd3d3Lmdvb2dsZS5jb20v
Iik7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>91227</attachid>
            <date>2011-04-26 21:41:17 -0700</date>
            <delta_ts>2011-05-10 21:36:57 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-58852-20110427134113.patch</filename>
            <type>text/plain</type>
            <size>1921</size>
            <attacher name="Ryuan Choi">ryuan.choi</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDg1MDExKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg
KzEsMTYgQEAKKzIwMTEtMDQtMjYgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29t
PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtd
IEFkZCBwcm94eSBzdXBwb3J0IHRvIEd0a0xhdW5jaGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53
ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODg1MgorCisgICAgICAgIEFkZCBTT1VQX1RZUEVf
UFJPWFlfUkVTT0xWRVJfREVGQVVMVCBmZWF0dXJlIG9yIHNldCBTT1VQX1NFU1NJT05fUFJPWFlf
VVJJIGZvciBkZXZlbG9wZXJzIGJlaGluZCBwcm94eS4KKworICAgICAgICAqIEdOVW1ha2VmaWxl
LmFtOgorICAgICAgICAqIEd0a0xhdW5jaGVyL21haW4uYzoKKyAgICAgICAgKG1haW4pOgorCiAy
MDExLTA0LTI2ICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CiAKICAgICAg
ICAgUmV2aWV3ZWQgYnkgQWRlbGUgUGV0ZXJzb24uCkluZGV4OiBUb29scy9HTlVtYWtlZmlsZS5h
bQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09Ci0tLSBUb29scy9HTlVtYWtlZmlsZS5hbQkocmV2aXNpb24gODUwMDQpCisr
KyBUb29scy9HTlVtYWtlZmlsZS5hbQkod29ya2luZyBjb3B5KQpAQCAtMjYsNiArMjYsNyBAQCBQ
cm9ncmFtc19HdGtMYXVuY2hlcl9MREFERCA9IFwKIAlsaWJ3ZWJraXRndGstQFdFQktJVEdUS19B
UElfTUFKT1JfVkVSU0lPTkAuQFdFQktJVEdUS19BUElfTUlOT1JfVkVSU0lPTkAubGEgXAogCSQo
R1RLX0xJQlMpIFwKIAkkKEdMSUJfTElCUykgXAorCSQoTElCU09VUF9MSUJTKSBcCiAJJChXSU5N
TV9MSUJTKQogCiBQcm9ncmFtc19HdGtMYXVuY2hlcl9MREZMQUdTID0gXApJbmRleDogVG9vbHMv
R3RrTGF1bmNoZXIvbWFpbi5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0d0a0xhdW5jaGVyL21haW4u
YwkocmV2aXNpb24gODUwMDQpCisrKyBUb29scy9HdGtMYXVuY2hlci9tYWluLmMJKHdvcmtpbmcg
Y29weSkKQEAgLTIzOSw2ICsyMzksMTcgQEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIqIGFyZ3Zb
XSkKICAgICBpZiAoIWdfdGhyZWFkX3N1cHBvcnRlZCgpKQogICAgICAgICBnX3RocmVhZF9pbml0
KE5VTEwpOwogCisjaWZkZWYgU09VUF9UWVBFX1BST1hZX1JFU09MVkVSX0RFRkFVTFQKKyAgICBz
b3VwX3Nlc3Npb25fYWRkX2ZlYXR1cmVfYnlfdHlwZSh3ZWJraXRfZ2V0X2RlZmF1bHRfc2Vzc2lv
bigpLCBTT1VQX1RZUEVfUFJPWFlfUkVTT0xWRVJfREVGQVVMVCk7CisjZWxzZQorICAgIGNvbnN0
IGNoYXIgKmh0dHBQcm94eSA9IGdfZ2V0ZW52KCJodHRwX3Byb3h5Iik7CisgICAgaWYgKGh0dHBQ
cm94eSkgeworICAgICAgICBTb3VwVVJJICpwcm94eVVyaSA9IHNvdXBfdXJpX25ldyhodHRwUHJv
eHkpOworICAgICAgICBnX29iamVjdF9zZXQod2Via2l0X2dldF9kZWZhdWx0X3Nlc3Npb24oKSwg
U09VUF9TRVNTSU9OX1BST1hZX1VSSSwgcHJveHlVcmksIE5VTEwpOworICAgICAgICBzb3VwX3Vy
aV9mcmVlKHByb3h5VXJpKTsKKyAgICB9CisjZW5kaWYKKwogICAgIG1haW5fd2luZG93ID0gY3Jl
YXRlV2luZG93KCZ3ZWJWaWV3KTsKIAogICAgIGdjaGFyICp1cmkgPShnY2hhciopKGFyZ2MgPiAx
ID8gYXJndlsxXSA6ICJodHRwOi8vd3d3Lmdvb2dsZS5jb20vIik7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>