58848 2011-04-18 16:08:03 -0700 [Qt] REGRESSION(84057): It made 4 API tests fail 2011-05-04 09:35:23 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Critical --- 59070 46968 1 ossy cmarcelo cmarcelo commit-queue kenneth kling luiz oldest_to_newest 388143 0 ossy 2011-04-18 16:08:03 -0700 FAIL! : tst_QWebPage::backActionUpdate() Compared values are not the same Actual (loadSpy.count()): 1 Expected (2): 2 Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(1453)] FAIL! : tst_QWebPage::errorPageExtensionInFrameset() Received a fatal error. Loc: [Unknown file(0)] FAIL! : tst_QWebFrame::horizontalScrollAfterBack() '(frame->scrollBarGeometry(Qt::Horizontal)).height()' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp(3152)] FAIL! : tst_QWebFrame::requestedUrl() Compared values are not the same Actual (spy.count()): 2 Expected (3): 3 Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp(2404)] 388146 1 ossy 2011-04-18 16:10:16 -0700 Hey men, you should have checked the buildbot after landing a patch. :-/ 389866 2 90499 cmarcelo 2011-04-20 23:21:52 -0700 Created attachment 90499 patch This patch should fix 3 tests failing. The requestedUrl() one is handled by bug 59070. 389874 3 90499 ossy 2011-04-20 23:36:58 -0700 Comment on attachment 90499 patch LGTM, r=me 389886 4 90499 commit-queue 2011-04-21 00:29:51 -0700 Comment on attachment 90499 patch Clearing flags on attachment: 90499 Committed r84475: <http://trac.webkit.org/changeset/84475> 389887 5 commit-queue 2011-04-21 00:29:56 -0700 All reviewed patches have been landed. Closing bug. 389888 6 cmarcelo 2011-04-21 00:35:25 -0700 Reopening since there is still a dependency bug opened to fix the remaining test case. 90499 2011-04-20 23:21:52 -0700 2011-04-21 00:29:51 -0700 patch 0001-Qt-REGRESSION-84057-It-made-4-API-tests-fail.patch text/plain 5364 cmarcelo RnJvbSBhYmVmODdmZDBiNjBmZTQ0OTc5M2YzYzRlY2I2MGYyMDcyYmFmZmY3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDYWlvIE1hcmNlbG8gZGUgT2xpdmVpcmEgRmlsaG8gPGNhaW8u b2xpdmVpcmFAb3BlbmJvc3NhLm9yZz4KRGF0ZTogVGh1LCAyMSBBcHIgMjAxMSAwMzoyMTowNyAt MDMwMApTdWJqZWN0OiBbUEFUQ0hdIFtRdF0gUkVHUkVTU0lPTig4NDA1Nyk6IEl0IG1hZGUgNCBB UEkgdGVzdHMgZmFpbAogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU4 ODQ4CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCkFmdGVyIE1JTUUgc25pZmZpbmcgc3Vw cG9ydCB3YXMgYWRkZWQsIHNvbWUgYXV0b3Rlc3RzIGFyZSBmYWlsaW5nIGJlY2F1c2UKdGhlIHNu aWZmZXIgZG9lc24ndCByZWNvZ25pemUgb3VyIEhUTUwgcGFnZXMuCgpUaGlzIGZpeGVzIHRzdF9R V2ViUGFnZTo6YmFja0FjdGlvblVwZGF0ZSgpLCB0c3RfUVdlYlBhZ2U6OmVycm9yUGFnZUV4dGVu c2lvbkluRnJhbWVzZXQoKQphbmQgdHN0X1FXZWJGcmFtZTo6aG9yaXpvbnRhbFNjcm9sbEFmdGVy QmFjaygpLgoKKiB0ZXN0cy9xd2ViZnJhbWUvcmVzb3VyY2VzL3Rlc3RpZnJhbWUuaHRtbDoKKiB0 ZXN0cy9xd2ViZnJhbWUvcmVzb3VyY2VzL3Rlc3RpZnJhbWUyLmh0bWw6ClJlbW92ZSBzcHVyaW91 cyA8L2h0bWw+IGluIGJlZ2lubmluZyBvZiB0aGUgZG9jdW1lbnQuCgoqIHRlc3RzL3F3ZWJwYWdl L3Jlc291cmNlcy9mcmFtZWRpbmRleC5odG1sOgoqIHRlc3RzL3F3ZWJwYWdlL3Jlc291cmNlcy9p bmRleC5odG1sOgpBZGQgPGh0bWw+IChhbmQgPC9odG1sPikgdGFncywgPGZyYW1lc2V0PiBpcyBu b3QgcmVjb2duaXplZCBieSB0aGUgc25pZmZlciBhcyBhCnBvc3NpYmxlIHN0YXJ0aW5nIHRhZyBm b3IgSFRNTCBkb2N1bWVudC4KCiogdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcDoKKHRz dF9RV2ViUGFnZTo6ZXJyb3JQYWdlRXh0ZW5zaW9uSW5GcmFtZXNldCk6ClZlcmlmeSBpZiB3ZSBk byBoYXZlIGEgbWFpbiBmcmFtZSBhbmQgdGhlIG1haW4gZnJhbWUgaGFzIHRoZSBjaGlsZHJlbiBm cmFtZXMgd2UKZXhwZWN0LiBUaGlzIHdpbGwgYXZvaWQgY3Jhc2hpbmcgaWYgZm9yIHNvbWUgcmVh c29uIGNoaWxkcmVuIGZyYW1lcyBhcmUgbm90CmxvYWRlZC4KLS0tCiBTb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMjggKysrKysrKysrKysrKysr KysrKysKIC4uLi9xdC90ZXN0cy9xd2ViZnJhbWUvcmVzb3VyY2VzL3Rlc3RpZnJhbWUuaHRtbCAg IHwgICAgMSAtCiAuLi4vcXQvdGVzdHMvcXdlYmZyYW1lL3Jlc291cmNlcy90ZXN0aWZyYW1lMi5o dG1sICB8ICAgIDEgLQogLi4uL3F0L3Rlc3RzL3F3ZWJwYWdlL3Jlc291cmNlcy9mcmFtZWRpbmRl eC5odG1sICAgfCAgICAyICsKIC4uLi9XZWJLaXQvcXQvdGVzdHMvcXdlYnBhZ2UvcmVzb3VyY2Vz L2luZGV4Lmh0bWwgIHwgICAgMiArCiBTb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3Rz dF9xd2VicGFnZS5jcHAgICB8ICAgIDEgKwogNiBmaWxlcyBjaGFuZ2VkLCAzMyBpbnNlcnRpb25z KCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdl TG9nIGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKaW5kZXggMDI1ODliNS4uZTM1OGZhNSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktp dC9xdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwzMSBAQAorMjAxMS0wNC0yMCAgQ2FpbyBNYXJjZWxv IGRlIE9saXZlaXJhIEZpbGhvICA8Y2Fpby5vbGl2ZWlyYUBvcGVuYm9zc2Eub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gUkVHUkVTU0lP Tig4NDA1Nyk6IEl0IG1hZGUgNCBBUEkgdGVzdHMgZmFpbAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTg4NDgKKworICAgICAgICBBZnRlciBNSU1FIHNu aWZmaW5nIHN1cHBvcnQgd2FzIGFkZGVkLCBzb21lIGF1dG90ZXN0cyBhcmUgZmFpbGluZyBiZWNh dXNlCisgICAgICAgIHRoZSBzbmlmZmVyIGRvZXNuJ3QgcmVjb2duaXplIG91ciBIVE1MIHBhZ2Vz LgorCisgICAgICAgIFRoaXMgZml4ZXMgdHN0X1FXZWJQYWdlOjpiYWNrQWN0aW9uVXBkYXRlKCks IHRzdF9RV2ViUGFnZTo6ZXJyb3JQYWdlRXh0ZW5zaW9uSW5GcmFtZXNldCgpCisgICAgICAgIGFu ZCB0c3RfUVdlYkZyYW1lOjpob3Jpem9udGFsU2Nyb2xsQWZ0ZXJCYWNrKCkuCisKKyAgICAgICAg KiB0ZXN0cy9xd2ViZnJhbWUvcmVzb3VyY2VzL3Rlc3RpZnJhbWUuaHRtbDoKKyAgICAgICAgKiB0 ZXN0cy9xd2ViZnJhbWUvcmVzb3VyY2VzL3Rlc3RpZnJhbWUyLmh0bWw6CisgICAgICAgIFJlbW92 ZSBzcHVyaW91cyA8L2h0bWw+IGluIGJlZ2lubmluZyBvZiB0aGUgZG9jdW1lbnQuCisKKyAgICAg ICAgKiB0ZXN0cy9xd2VicGFnZS9yZXNvdXJjZXMvZnJhbWVkaW5kZXguaHRtbDoKKyAgICAgICAg KiB0ZXN0cy9xd2VicGFnZS9yZXNvdXJjZXMvaW5kZXguaHRtbDoKKyAgICAgICAgQWRkIDxodG1s PiAoYW5kIDwvaHRtbD4pIHRhZ3MsIDxmcmFtZXNldD4gaXMgbm90IHJlY29nbml6ZWQgYnkgdGhl IHNuaWZmZXIgYXMgYQorICAgICAgICBwb3NzaWJsZSBzdGFydGluZyB0YWcgZm9yIEhUTUwgZG9j dW1lbnQuCisKKyAgICAgICAgKiB0ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3BwOgorICAg ICAgICAodHN0X1FXZWJQYWdlOjplcnJvclBhZ2VFeHRlbnNpb25JbkZyYW1lc2V0KToKKyAgICAg ICAgVmVyaWZ5IGlmIHdlIGRvIGhhdmUgYSBtYWluIGZyYW1lIGFuZCB0aGUgbWFpbiBmcmFtZSBo YXMgdGhlIGNoaWxkcmVuIGZyYW1lcyB3ZQorICAgICAgICBleHBlY3QuIFRoaXMgd2lsbCBhdm9p ZCBjcmFzaGluZyBpZiBmb3Igc29tZSByZWFzb24gY2hpbGRyZW4gZnJhbWVzIGFyZSBub3QKKyAg ICAgICAgbG9hZGVkLgorCiAyMDExLTA0LTIwICBCYWxhenMgS2VsZW1lbiAgPGtiYWxhenNAd2Vi a2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBDc2FiYSBPc3p0cm9nb27DoWMuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJmcmFtZS9yZXNvdXJjZXMvdGVzdGlm cmFtZS5odG1sIGIvU291cmNlL1dlYktpdC9xdC90ZXN0cy9xd2ViZnJhbWUvcmVzb3VyY2VzL3Rl c3RpZnJhbWUuaHRtbAppbmRleCAyMDNkM2QzLi5lZTBmNjRkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L3F0L3Rlc3RzL3F3ZWJmcmFtZS9yZXNvdXJjZXMvdGVzdGlmcmFtZS5odG1sCisrKyBi L1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcXdlYmZyYW1lL3Jlc291cmNlcy90ZXN0aWZyYW1lLmh0 bWwKQEAgLTEsNCArMSwzIEBACi08L2h0bWw+DQogPGh0bWw+DQogPGhlYWQ+DQogPHRpdGxlPjwv dGl0bGU+DQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9xdC90ZXN0cy9xd2ViZnJhbWUvcmVz b3VyY2VzL3Rlc3RpZnJhbWUyLmh0bWwgYi9Tb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJmcmFt ZS9yZXNvdXJjZXMvdGVzdGlmcmFtZTIuaHRtbAppbmRleCAwZDNhMjJmLi40ODNlOTRlIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJmcmFtZS9yZXNvdXJjZXMvdGVzdGlm cmFtZTIuaHRtbAorKysgYi9Tb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJmcmFtZS9yZXNvdXJj ZXMvdGVzdGlmcmFtZTIuaHRtbApAQCAtMSw0ICsxLDMgQEAKLTwvaHRtbD4NCiA8aHRtbD4NCiA8 aGVhZD4NCiA8dGl0bGU+PC90aXRsZT4NCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0L3Rl c3RzL3F3ZWJwYWdlL3Jlc291cmNlcy9mcmFtZWRpbmRleC5odG1sIGIvU291cmNlL1dlYktpdC9x dC90ZXN0cy9xd2VicGFnZS9yZXNvdXJjZXMvZnJhbWVkaW5kZXguaHRtbAppbmRleCA0NjVjNmYw Li5iZTQ1MDA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3Jl c291cmNlcy9mcmFtZWRpbmRleC5odG1sCisrKyBiL1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcXdl YnBhZ2UvcmVzb3VyY2VzL2ZyYW1lZGluZGV4Lmh0bWwKQEAgLTEsNCArMSw2IEBACis8aHRtbD4K IDxmcmFtZXNldCBjb2xzPSIyNSUsNzUlIj4KICAgIDxmcmFtZSBzcmM9ImZyYW1lX2MuaHRtbCIg bmFtZT0iZnJhbWVfYyI+CiAgICA8ZnJhbWUgc3JjPSJmcmFtZV9iLmh0bWwiIG5hbWU9ImZyYW1l X2IiPgogPC9mcmFtZXNldD4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQv dGVzdHMvcXdlYnBhZ2UvcmVzb3VyY2VzL2luZGV4Lmh0bWwgYi9Tb3VyY2UvV2ViS2l0L3F0L3Rl c3RzL3F3ZWJwYWdlL3Jlc291cmNlcy9pbmRleC5odG1sCmluZGV4IGM1M2FkMDkuLjYzOGRmMzYg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcXdlYnBhZ2UvcmVzb3VyY2VzL2lu ZGV4Lmh0bWwKKysrIGIvU291cmNlL1dlYktpdC9xdC90ZXN0cy9xd2VicGFnZS9yZXNvdXJjZXMv aW5kZXguaHRtbApAQCAtMSw0ICsxLDYgQEAKKzxodG1sPgogPGZyYW1lc2V0IGNvbHM9IjI1JSw3 NSUiPgogICAgPGZyYW1lIHNyYz0iZnJhbWVfYS5odG1sIiBuYW1lPSJmcmFtZV9hIj4KICAgIDxm cmFtZSBzcmM9ImZyYW1lX2IuaHRtbCIgbmFtZT0iZnJhbWVfYiI+CiA8L2ZyYW1lc2V0PgorPC9o dG1sPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9xdC90ZXN0cy9xd2VicGFnZS90c3RfcXdl YnBhZ2UuY3BwIGIvU291cmNlL1dlYktpdC9xdC90ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2Uu Y3BwCmluZGV4IDllMzMzN2IuLmY3NzlkNWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQv dGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L3F0L3Rl c3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAKQEAgLTI0MTIsNiArMjQxMiw3IEBAIHZvaWQg dHN0X1FXZWJQYWdlOjplcnJvclBhZ2VFeHRlbnNpb25JbkZyYW1lc2V0KCkKIAogICAgIFFTaWdu YWxTcHkgc3B5TG9hZEZpbmlzaGVkKG1fdmlldywgU0lHTkFMKGxvYWRGaW5pc2hlZChib29sKSkp OwogICAgIFFUUllfQ09NUEFSRShzcHlMb2FkRmluaXNoZWQuY291bnQoKSwgMSk7CisgICAgUUNP TVBBUkUocGFnZS0+bWFpbkZyYW1lKCktPmNoaWxkRnJhbWVzKCkuY291bnQoKSwgMik7CiAgICAg UUNPTVBBUkUocGFnZS0+bWFpbkZyYW1lKCktPmNoaWxkRnJhbWVzKClbMV0tPnRvUGxhaW5UZXh0 KCksIFFTdHJpbmcoImVycm9yIikpOwogCiAgICAgbV92aWV3LT5zZXRQYWdlKDApOwotLSAKMS43 LjQuNAoK