<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>58719</bug_id>
          
          <creation_ts>2011-04-15 18:21:04 -0700</creation_ts>
          <short_desc>Cancelling fullscreen doesn&apos;t properly reset internal state</short_desc>
          <delta_ts>2011-06-18 12:51:10 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Andrew Scherkus">scherkus</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>commit-queue</cc>
    
    <cc>darin</cc>
    
    <cc>eric</cc>
    
    <cc>jer.noble</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>387126</commentid>
    <comment_count>0</comment_count>
    <who name="Andrew Scherkus">scherkus</who>
    <bug_when>2011-04-15 18:21:04 -0700</bug_when>
    <thetext>Root problem is m_fullscreenElement remains non-null, which means webkitIsFullScreen() returns false but webkitCurrentFullScreenElement() returns the old (and I think detached!) element and a successive call to webkitCancelFullScreen() results in all sorts of bad stuff.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>387144</commentid>
    <comment_count>1</comment_count>
      <attachid>89899</attachid>
    <who name="Andrew Scherkus">scherkus</who>
    <bug_when>2011-04-15 18:26:42 -0700</bug_when>
    <thetext>Created attachment 89899
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>387336</commentid>
    <comment_count>2</comment_count>
      <attachid>89899</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-04-17 01:35:26 -0700</bug_when>
    <thetext>Comment on attachment 89899
Patch

I&apos;m impressed that this patch is almost all minus lines, but I don&apos;t understand how this code works well enough to review your patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>387377</commentid>
    <comment_count>3</comment_count>
    <who name="Andrew Scherkus">scherkus</who>
    <bug_when>2011-04-17 11:31:18 -0700</bug_when>
    <thetext>Sorry for combining clean-up with a bug fix :(

In essence the fix is a one-liner: the addition of &quot;m_fullScreenElement = 0&quot; to webkitDidExitFullScreen

Technically m_isFullScreen should have guarded against being able to re-cancel full screen (see Document::webkitCancelFullScreen), but because we only check m_fullScreenElement, we execute the cancel code again and Bad Things happen.

Instead of having both m_isFullScreen and m_fullScreenElement track whether Document is in full screen, it seems safer to rely on whether m_fullScreenElement set.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>387404</commentid>
    <comment_count>4</comment_count>
    <who name="Jer Noble">jer.noble</who>
    <bug_when>2011-04-17 13:39:42 -0700</bug_when>
    <thetext>Looks good to me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>387919</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-04-18 12:14:50 -0700</bug_when>
    <thetext>The commit-queue encountered the following flaky tests while processing attachment 89899:

animations/suspend-resume-animation.html bug 48161 (author: cmarrin@apple.com)
The commit-queue is continuing to process your patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>387941</commentid>
    <comment_count>6</comment_count>
      <attachid>89899</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-04-18 12:28:57 -0700</bug_when>
    <thetext>Comment on attachment 89899
Patch

Rejecting attachment 89899 from commit-queue.

Failed to run &quot;[&apos;./Tools/Scripts/webkit-patch&apos;, &apos;--status-host=queues.webkit.org&apos;, &apos;--bot-id=cr-jail-3&apos;, &apos;land-a...&quot; exit_code: 2

Last 500 characters of output:
lay your work on top of it...
Fast-forwarded master to refs/remotes/trunk.
Updating OpenSource
From git://git.webkit.org/WebKit
   e625813..122c5ca  master     -&gt; origin/master
	M	LayoutTests/platform/qt/Skipped
	M	LayoutTests/ChangeLog
	M	Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp
	M	Source/WebKit/qt/ChangeLog
r84168 = 122c5ca6e727a26fcffb5ef048533f56183e5a2e (refs/remotes/trunk)
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/trunk.

Full output: http://queues.webkit.org/results/8469061</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>387988</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-04-18 13:26:24 -0700</bug_when>
    <thetext>http://trac.webkit.org/changeset/84169 might have broken Qt Linux Release
The following tests are not passing:
fast/ruby/after-block-doesnt-crash.html
fast/ruby/after-table-doesnt-crash.html
fast/ruby/before-block-doesnt-crash.html
fast/ruby/before-table-doesnt-crash.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>388043</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-04-18 14:26:36 -0700</bug_when>
    <thetext>The commit-queue encountered the following flaky tests while processing attachment 89899:

http/tests/xmlhttprequest/re-login-async.html bug 51763 (author: ap@webkit.org)
The commit-queue is continuing to process your patch.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>89899</attachid>
            <date>2011-04-15 18:26:42 -0700</date>
            <delta_ts>2011-04-18 12:28:57 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-58719-20110415182640.patch</filename>
            <type>text/plain</type>
            <size>7597</size>
            <attacher name="Andrew Scherkus">scherkus</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogODM5ODUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n
ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBmNmJkZWQzMTgwNGQ0NzRkMDZmMjQ4
ZTJiODE5MmZkOTFkMTIzZDQzLi4xNTdiODE4NDJkN2U0YTFmZTAxOTJlNTJmODVkNTgzOTU1MWRl
NTlkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv
Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDQtMTUgIEFuZHJldyBTY2hlcmt1cyAg
PHNjaGVya3VzQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICBSZXNldCBmdWxsc2NyZWVuIGVsZW1lbnQgcmVmZXJlbmNlIHdoZW4g
bGVhdmluZyBmdWxsc2NyZWVuIG1vZGUgYW5kIHNvbWUgb3RoZXIgY2xlYW51cC4KKworICAgICAg
ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTg3MTkKKworICAgICAg
ICAqIGZ1bGxzY3JlZW4vZnVsbC1zY3JlZW4tY2FuY2VsLWV4cGVjdGVkLnR4dDogQWRkZWQuCisg
ICAgICAgICogZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1jYW5jZWwuaHRtbDogQWRkZWQuCisKIDIw
MTEtMDQtMTUgIFZzZXZvbG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CiAKICAgICAg
ICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Z1
bGxzY3JlZW4vZnVsbC1zY3JlZW4tY2FuY2VsLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Z1
bGxzY3JlZW4vZnVsbC1zY3JlZW4tY2FuY2VsLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEw
MDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5kYmEx
NTc0Y2RiZjJjZDMwOGNjMTRjMzliMmE2YzNlNDZmNThiZjlkCi0tLSAvZGV2L251bGwKKysrIGIv
TGF5b3V0VGVzdHMvZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1jYW5jZWwtZXhwZWN0ZWQudHh0CkBA
IC0wLDAgKzEsOCBAQAorRVZFTlQod2Via2l0ZnVsbHNjcmVlbmNoYW5nZSkKK0VYUEVDVEVEIChk
b2N1bWVudC53ZWJraXRJc0Z1bGxTY3JlZW4gPT0gJ3RydWUnKSBPSworRVhQRUNURUQgKGRvY3Vt
ZW50LndlYmtpdEN1cnJlbnRGdWxsU2NyZWVuRWxlbWVudCA9PSAnW29iamVjdCBIVE1MRWxlbWVu
dF0nKSBPSworRVZFTlQod2Via2l0ZnVsbHNjcmVlbmNoYW5nZSkKK0VYUEVDVEVEIChkb2N1bWVu
dC53ZWJraXRJc0Z1bGxTY3JlZW4gPT0gJ2ZhbHNlJykgT0sKK0VYUEVDVEVEIChkb2N1bWVudC53
ZWJraXRDdXJyZW50RnVsbFNjcmVlbkVsZW1lbnQgPT0gJ3VuZGVmaW5lZCcpIE9LCitFTkQgT0Yg
VEVTVAorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mdWxsc2NyZWVuL2Z1bGwtc2NyZWVuLWNh
bmNlbC5odG1sIGIvTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1jYW5jZWwuaHRt
bApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwLi5kNjcwYjE0YTViYTllZTMxNDRmOTQzMzM5ZDg0MDk2OTBmOTg5MjBlCi0t
LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1jYW5j
ZWwuaHRtbApAQCAtMCwwICsxLDQzIEBACis8Ym9keT4KKzxzY3JpcHQgc3JjPSJmdWxsLXNjcmVl
bi10ZXN0LmpzIj48L3NjcmlwdD4KKzxzcGFuPjwvc3Bhbj4KKzxzY3JpcHQ+CisgICAgLy8gQmFp
bCBvdXQgZWFybHkgaWYgdGhlIGZ1bGwgc2NyZWVuIEFQSSBpcyBub3QgZW5hYmxlZCBvciBpcyBt
aXNzaW5nOgorICAgIGlmIChFbGVtZW50LnByb3RvdHlwZS53ZWJraXRSZXF1ZXN0RnVsbFNjcmVl
biA9PSB1bmRlZmluZWQpIHsKKyAgICAgICAgbG9nUmVzdWx0KGZhbHNlLCAiRWxlbWVudC5wcm90
b3R5cGUud2Via2l0UmVxdWVzdEZ1bGxTY3JlZW4gPT0gdW5kZWZpbmVkIik7CisgICAgICAgIGVu
ZFRlc3QoKTsKKyAgICB9IGVsc2UgeworICAgICAgICB2YXIgY2FsbGJhY2s7CisgICAgICAgIHZh
ciBmdWxsc2NyZWVuQ2hhbmdlZCA9IGZ1bmN0aW9uKGV2ZW50KQorICAgICAgICB7CisgICAgICAg
ICAgICBpZiAoY2FsbGJhY2spCisgICAgICAgICAgICAgICAgY2FsbGJhY2soZXZlbnQpCisgICAg
ICAgIH07CisgICAgICAgIHdhaXRGb3JFdmVudChkb2N1bWVudCwgJ3dlYmtpdGZ1bGxzY3JlZW5j
aGFuZ2UnLCBmdWxsc2NyZWVuQ2hhbmdlZCk7CisKKyAgICAgICAgdmFyIHNwYW4gPSBkb2N1bWVu
dC5nZXRFbGVtZW50c0J5VGFnTmFtZSgnc3BhbicpWzBdOworCisgICAgICAgIHZhciBzcGFuRW50
ZXJlZEZ1bGxTY3JlZW4gPSBmdW5jdGlvbigpIHsKKyAgICAgICAgICAgIHRlc3RFeHBlY3RlZCgi
ZG9jdW1lbnQud2Via2l0SXNGdWxsU2NyZWVuIiwgdHJ1ZSk7CisgICAgICAgICAgICB0ZXN0RXhw
ZWN0ZWQoImRvY3VtZW50LndlYmtpdEN1cnJlbnRGdWxsU2NyZWVuRWxlbWVudCIsIHNwYW4pOwor
ICAgICAgICAgICAgY2FsbGJhY2sgPSBjYW5jZWxsZWRGdWxsU2NyZWVuOworICAgICAgICAgICAg
ZG9jdW1lbnQud2Via2l0Q2FuY2VsRnVsbFNjcmVlbigpOworICAgICAgICB9OworCisgICAgICAg
IHZhciBjYW5jZWxsZWRGdWxsU2NyZWVuID0gZnVuY3Rpb24oKSB7CisgICAgICAgICAgICB0ZXN0
RXhwZWN0ZWQoImRvY3VtZW50LndlYmtpdElzRnVsbFNjcmVlbiIsIGZhbHNlKTsKKyAgICAgICAg
ICAgIHRlc3RFeHBlY3RlZCgiZG9jdW1lbnQud2Via2l0Q3VycmVudEZ1bGxTY3JlZW5FbGVtZW50
IiwgdW5kZWZpbmVkKTsKKyAgICAgICAgICAgIGNhbGxiYWNrID0gZmFpbEZ1bGxTY3JlZW5UZXN0
OworICAgICAgICAgICAgZG9jdW1lbnQud2Via2l0Q2FuY2VsRnVsbFNjcmVlbigpOworICAgICAg
ICAgICAgc2V0VGltZW91dChlbmRUZXN0LCAwKTsKKyAgICAgICAgfTsKKworICAgICAgICB2YXIg
ZmFpbEZ1bGxTY3JlZW5UZXN0ID0gZnVuY3Rpb24oKSB7CisgICAgICAgICAgICBjb25zb2xlV3Jp
dGUoIlNob3VsZCBub3QgaGF2ZSByZWNlaXZlZCBhIHdlYmtpdGZ1bGxzY3JlZW5jaGFuZ2UgZXZl
bnQuIik7CisgICAgICAgICAgICBlbmRUZXN0KCk7CisgICAgICAgIH07CisKKyAgICAgICAgY2Fs
bGJhY2sgPSBzcGFuRW50ZXJlZEZ1bGxTY3JlZW47CisgICAgICAgIHJ1bldpdGhLZXlEb3duKGZ1
bmN0aW9uKCl7c3Bhbi53ZWJraXRSZXF1ZXN0RnVsbFNjcmVlbigpfSk7CisgICAgfQorPC9zY3Jp
cHQ+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKaW5kZXggNWQyNjg5ZjcyMjBiZDNiNWM2OGIxNGQ4NDlkYjYwMWI4YTQ0YWQ1
Mi4uOTkyYzMyNWNlN2QxMjgyYWQ3MzMyNWQ2NmRjODBmN2ExYjQ1OTI3OSAxMDA2NDQKLS0tIGEv
U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpA
QCAtMSwzICsxLDIyIEBACisyMDExLTA0LTE1ICBBbmRyZXcgU2NoZXJrdXMgIDxzY2hlcmt1c0Bj
aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg
ICAgICAgUmVzZXQgZnVsbHNjcmVlbiBlbGVtZW50IHJlZmVyZW5jZSB3aGVuIGxlYXZpbmcgZnVs
bHNjcmVlbiBtb2RlIGFuZCBzb21lIG90aGVyIGNsZWFudXAuCisKKyAgICAgICAgaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU4NzE5CisKKyAgICAgICAgVGVzdDogZnVs
bHNjcmVlbi9mdWxsLXNjcmVlbi1jYW5jZWwuaHRtbAorCisgICAgICAgICogZG9tL0RvY3VtZW50
LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50OjpEb2N1bWVudCk6IFJlbW92ZSBtX2lz
RnVsbHNjcmVlbi4KKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50Ojp3ZWJraXRXaWxsRW50ZXJG
dWxsU2NyZWVuRm9yRWxlbWVudCk6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6d2Via2l0
V2lsbEV4aXRGdWxsU2NyZWVuRm9yRWxlbWVudCk6IFJlbW92ZSBkdXBsaWNhdGUgY2FsbCB0byBz
ZXRBbmltYXRpbmcoKS4KKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50Ojp3ZWJraXREaWRFeGl0
RnVsbFNjcmVlbkZvckVsZW1lbnQpOiBSZXNldCBtX2Z1bGxTY3JlZW5FbGVtZW50IHJlZmVyZW5j
ZS4KKyAgICAgICAgKiBkb20vRG9jdW1lbnQuaDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50
Ojp3ZWJraXRJc0Z1bGxTY3JlZW4pOiBVc2UgbV9mdWxsU2NyZWVuRWxlbWVudCBpbnN0ZWFkIG9m
IG1faXNGdWxsc2NyZWVuLgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OndlYmtpdEZ1bGxT
Y3JlZW5LZXlib2FyZElucHV0QWxsb3dlZCk6IERpdHRvLgorCiAyMDExLTA0LTE1ICBTYW0gV2Vp
bmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFjaWVqIFN0YWNo
b3dpYWsuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwIGIvU291
cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAppbmRleCAxMGIyNzY2MThkZTBjZWJhZjk4MTAx
M2FhNjNlNjc3ZWU0ZDYyZGMwLi4zNTJiZWVjNzZmM2RkNGJkYWM4OWRjNjI0MzViYjQ2OGZkZjNl
NDI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKQEAgLTQyNSw3ICs0MjUsNiBAQCBEb2N1bWVu
dDo6RG9jdW1lbnQoRnJhbWUqIGZyYW1lLCBjb25zdCBLVVJMJiB1cmwsIGJvb2wgaXNYSFRNTCwg
Ym9vbCBpc0hUTUwpCiAgICAgLCBtX3dlYWtSZWZlcmVuY2UoRG9jdW1lbnRXZWFrUmVmZXJlbmNl
OjpjcmVhdGUodGhpcykpCiAgICAgLCBtX2lkQXR0cmlidXRlTmFtZShpZEF0dHIpCiAjaWYgRU5B
QkxFKEZVTExTQ1JFRU5fQVBJKQotICAgICwgbV9pc0Z1bGxTY3JlZW4oMCkKICAgICAsIG1fYXJl
S2V5c0VuYWJsZWRJbkZ1bGxTY3JlZW4oMCkKICAgICAsIG1fZnVsbFNjcmVlblJlbmRlcmVyKDAp
CiAgICAgLCBtX2Z1bGxTY3JlZW5DaGFuZ2VEZWxheVRpbWVyKHRoaXMsICZEb2N1bWVudDo6ZnVs
bFNjcmVlbkNoYW5nZURlbGF5VGltZXJGaXJlZCkKQEAgLTQ4MzksNyArNDgzOCw2IEBAIHZvaWQg
RG9jdW1lbnQ6OndlYmtpdFdpbGxFbnRlckZ1bGxTY3JlZW5Gb3JFbGVtZW50KEVsZW1lbnQqIGVs
ZW1lbnQpCiAgICAgQVNTRVJUKHBhZ2UoKSAmJiBwYWdlKCktPnNldHRpbmdzKCktPmZ1bGxTY3Jl
ZW5FbmFibGVkKCkpOwogCiAgICAgbV9mdWxsU2NyZWVuRWxlbWVudCA9IGVsZW1lbnQ7Ci0gICAg
bV9pc0Z1bGxTY3JlZW4gPSB0cnVlOwogICAgIAogICAgIGlmIChtX2Z1bGxTY3JlZW5FbGVtZW50
ICE9IGRvY3VtZW50RWxlbWVudCgpKQogICAgICAgICBtX2Z1bGxTY3JlZW5FbGVtZW50LT5kZXRh
Y2goKTsKQEAgLTQ4NzIsNyArNDg3MCw2IEBAIHZvaWQgRG9jdW1lbnQ6OndlYmtpdFdpbGxFeGl0
RnVsbFNjcmVlbkZvckVsZW1lbnQoRWxlbWVudCopCiB7CiAgICAgaWYgKG1fZnVsbFNjcmVlblJl
bmRlcmVyKSB7CiAgICAgICAgIG1fZnVsbFNjcmVlblJlbmRlcmVyLT5zZXRBbmltYXRpbmcodHJ1
ZSk7Ci0gICAgICAgIG1fZnVsbFNjcmVlblJlbmRlcmVyLT5zZXRBbmltYXRpbmcodHJ1ZSk7CiAj
aWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQogICAgICAgICB2aWV3KCktPnVwZGF0ZUNv
bXBvc2l0aW5nTGF5ZXJzKCk7CiAgICAgICAgIGlmIChtX2Z1bGxTY3JlZW5SZW5kZXJlci0+bGF5
ZXIoKS0+aXNDb21wb3NpdGVkKCkpCkBAIC00ODgzLDcgKzQ4ODAsNiBAQCB2b2lkIERvY3VtZW50
Ojp3ZWJraXRXaWxsRXhpdEZ1bGxTY3JlZW5Gb3JFbGVtZW50KEVsZW1lbnQqKQogCiB2b2lkIERv
Y3VtZW50Ojp3ZWJraXREaWRFeGl0RnVsbFNjcmVlbkZvckVsZW1lbnQoRWxlbWVudCopCiB7Ci0g
ICAgbV9pc0Z1bGxTY3JlZW4gPSBmYWxzZTsKICAgICBtX2FyZUtleXNFbmFibGVkSW5GdWxsU2Ny
ZWVuID0gZmFsc2U7CiAKICAgICBpZiAobV9mdWxsU2NyZWVuUmVuZGVyZXIpCkBAIC00ODkxLDcg
KzQ4ODcsOCBAQCB2b2lkIERvY3VtZW50Ojp3ZWJraXREaWRFeGl0RnVsbFNjcmVlbkZvckVsZW1l
bnQoRWxlbWVudCopCiAgICAgCiAgICAgaWYgKG1fZnVsbFNjcmVlbkVsZW1lbnQgIT0gZG9jdW1l
bnRFbGVtZW50KCkpCiAgICAgICAgIG1fZnVsbFNjcmVlbkVsZW1lbnQtPmRldGFjaCgpOwotICAg
IAorCisgICAgbV9mdWxsU2NyZWVuRWxlbWVudCA9IDA7CiAgICAgc2V0RnVsbFNjcmVlblJlbmRl
cmVyKDApOwogI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKICAgICBwYWdlKCktPmNo
cm9tZSgpLT5jbGllbnQoKS0+c2V0Um9vdEZ1bGxTY3JlZW5MYXllcigwKTsKZGlmZiAtLWdpdCBh
L1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3Vt
ZW50LmgKaW5kZXggZDMzYjA4YzE4YTU0MjIxOGM3MjFhMmMyMDgwZGI0NmE1NmZjOWJiZi4uOGM2
YTViNTVmYzBlYTZlMzE1NThiNGM0NWEzNzg3YzAzNzc5YmRiNSAxMDA2NDQKLS0tIGEvU291cmNl
L1dlYkNvcmUvZG9tL0RvY3VtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50
LmgKQEAgLTEwNTcsOCArMTA1Nyw4IEBAIHB1YmxpYzoKICAgICBjb25zdCBRdWFsaWZpZWROYW1l
JiBpZEF0dHJpYnV0ZU5hbWUoKSBjb25zdCB7IHJldHVybiBtX2lkQXR0cmlidXRlTmFtZTsgfQog
ICAgIAogI2lmIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkKLSAgICBib29sIHdlYmtpdElzRnVsbFNj
cmVlbigpIGNvbnN0IHsgcmV0dXJuIG1faXNGdWxsU2NyZWVuOyB9Ci0gICAgYm9vbCB3ZWJraXRG
dWxsU2NyZWVuS2V5Ym9hcmRJbnB1dEFsbG93ZWQoKSBjb25zdCB7IHJldHVybiBtX2lzRnVsbFNj
cmVlbiAmJiBtX2FyZUtleXNFbmFibGVkSW5GdWxsU2NyZWVuOyB9CisgICAgYm9vbCB3ZWJraXRJ
c0Z1bGxTY3JlZW4oKSBjb25zdCB7IHJldHVybiBtX2Z1bGxTY3JlZW5FbGVtZW50LmdldCgpOyB9
CisgICAgYm9vbCB3ZWJraXRGdWxsU2NyZWVuS2V5Ym9hcmRJbnB1dEFsbG93ZWQoKSBjb25zdCB7
IHJldHVybiBtX2Z1bGxTY3JlZW5FbGVtZW50LmdldCgpICYmIG1fYXJlS2V5c0VuYWJsZWRJbkZ1
bGxTY3JlZW47IH0KICAgICBFbGVtZW50KiB3ZWJraXRDdXJyZW50RnVsbFNjcmVlbkVsZW1lbnQo
KSBjb25zdCB7IHJldHVybiBtX2Z1bGxTY3JlZW5FbGVtZW50LmdldCgpOyB9CiAgICAgdm9pZCB3
ZWJraXRSZXF1ZXN0RnVsbFNjcmVlbkZvckVsZW1lbnQoRWxlbWVudCosIHVuc2lnbmVkIHNob3J0
IGZsYWdzKTsKICAgICB2b2lkIHdlYmtpdENhbmNlbEZ1bGxTY3JlZW4oKTsKQEAgLTEzODMsNyAr
MTM4Myw2IEBAIHByaXZhdGU6CiAgICAgUXVhbGlmaWVkTmFtZSBtX2lkQXR0cmlidXRlTmFtZTsK
ICAgICAKICNpZiBFTkFCTEUoRlVMTFNDUkVFTl9BUEkpCi0gICAgYm9vbCBtX2lzRnVsbFNjcmVl
bjsKICAgICBib29sIG1fYXJlS2V5c0VuYWJsZWRJbkZ1bGxTY3JlZW47CiAgICAgUmVmUHRyPEVs
ZW1lbnQ+IG1fZnVsbFNjcmVlbkVsZW1lbnQ7CiAgICAgUmVuZGVyRnVsbFNjcmVlbiogbV9mdWxs
U2NyZWVuUmVuZGVyZXI7Cg==
</data>
<flag name="review"
          id="82612"
          type_id="1"
          status="+"
          setter="eric"
    />
    <flag name="commit-queue"
          id="82765"
          type_id="3"
          status="-"
          setter="commit-queue"
    />
          </attachment>
      

    </bug>

</bugzilla>