<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>58582</bug_id>
          
          <creation_ts>2011-04-14 15:11:58 -0700</creation_ts>
          <short_desc>Expand the ntohs, ntohl, htons and htonl defines for OS(WINDOWS)</short_desc>
          <delta_ts>2011-04-15 19:15:34 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Windows XP</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Fridrich Strba">fridrich.strba</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>commit-queue</cc>
    
    <cc>eric</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>386091</commentid>
    <comment_count>0</comment_count>
    <who name="Fridrich Strba">fridrich.strba</who>
    <bug_when>2011-04-14 15:11:58 -0700</bug_when>
    <thetext>These defines need to be defined for Windows in general, since win32 API does not provide them</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>386094</commentid>
    <comment_count>1</comment_count>
      <attachid>89668</attachid>
    <who name="Fridrich Strba">fridrich.strba</who>
    <bug_when>2011-04-14 15:14:54 -0700</bug_when>
    <thetext>Created attachment 89668
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>386120</commentid>
    <comment_count>2</comment_count>
      <attachid>89668</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2011-04-14 15:43:15 -0700</bug_when>
    <thetext>Comment on attachment 89668
Patch

Seems reasonable. Once the EWS finishes, I&apos;ll r+ this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>387074</commentid>
    <comment_count>3</comment_count>
      <attachid>89668</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-04-15 17:26:52 -0700</bug_when>
    <thetext>Comment on attachment 89668
Patch

Clearing flags on attachment: 89668

Committed r84061: &lt;http://trac.webkit.org/changeset/84061&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>387075</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-04-15 17:26:56 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>387140</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-04-15 18:22:45 -0700</bug_when>
    <thetext>http://trac.webkit.org/changeset/84061 might have broken Leopard Intel Release (Build)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>387163</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-04-15 19:15:34 -0700</bug_when>
    <thetext>The commit-queue encountered the following flaky tests while processing attachment 89668:

http/tests/xmlhttprequest/basic-auth.html bug 51613 (author: ap@webkit.org)
The commit-queue is continuing to process your patch.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>89668</attachid>
            <date>2011-04-14 15:14:54 -0700</date>
            <delta_ts>2011-04-15 17:26:52 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-58582-20110415001452.patch</filename>
            <type>text/plain</type>
            <size>1351</size>
            <attacher name="Fridrich Strba">fridrich.strba</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzODk5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDQtMTQgIEZyaWRyaWNo
IFN0cmJhICA8ZnJpZHJpY2guc3RyYmFAYmx1ZXdpbi5jaD4KKworICAgICAgICBSZXZpZXdlZCBi
eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFeHBhbmQgdGhlIG50b2hzLCBudG9obCwgaHRv
bnMgYW5kIGh0b25sIGRlZmluZXMgZm9yIE9TKFdJTkRPV1MpCisgICAgICAgIFRoZXNlIGhhdmUg
dG8gYmUgZGVmaW5lZCBmb3IgV2luZG93cyBpbiBnZW5lcmFsLCBzaW5jZSB3aW4zMiBBUEkKKyAg
ICAgICAgZG9lcyBub3QgcHJvdmlkZSB0aGVtLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTg1ODIKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz
L1dPRkZGaWxlRm9ybWF0LmNwcDoKKwogMjAxMS0wNC0xNCAgQmV0aCBEYWtpbiAgPGJkYWtpbkBh
cHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gRnJhc2VyLgpJbmRleDogU291
cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvV09GRkZpbGVGb3JtYXQuY3BwCj09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1dPRkZGaWxlRm9ybWF0LmNw
cAkocmV2aXNpb24gODM4OTIpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9X
T0ZGRmlsZUZvcm1hdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQzLDcgKzQzLDcgQEAKICNkZWZp
bmUgbnRvaHMoeCkgc3RkX250b2hzKHgpCiAjZW5kaWYKIAotI2lmIFBMQVRGT1JNKFdJTikKKyNp
ZiBPUyhXSU5ET1dTKQogI2lmIENQVShCSUdfRU5ESUFOKQogI2RlZmluZSBudG9ocyh4KSAoKHVp
bnQxNl90KSh4KSkKICNkZWZpbmUgaHRvbnMoeCkgKCh1aW50MTZfdCkoeCkpCkBAIC02MSw3ICs2
MSw3IEBACiAgICAgICAgICAgICAgICAgICgoKHVpbnQzMl90KSh4KSAmIDB4MDAwMGZmMDApIDw8
ICA4KSB8ICgoKHVpbnQzMl90KSh4KSAmIDB4MDAwMDAwZmYpIDw8IDI0KSkpCiAjZGVmaW5lIGh0
b25sKHgpIG50b2hsKHgpCiAjZW5kaWYKLSNlbmRpZiAvLyBQTEFURk9STShXSU4pCisjZW5kaWYg
Ly8gT1MoV0lORE9XUykKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>