58576 2011-04-14 14:43:20 -0700 Evaluate PLATFORM(GTK) before OS(WINDOWS) 2011-04-15 18:22:35 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 fridrich.strba webkit-unassigned abarth commit-queue eric webkit.review.bot oldest_to_newest 386050 0 fridrich.strba 2011-04-14 14:43:20 -0700 This allow the Windows GTK build to chose the right branch before it is sucked by all-encompassing OS(WINDOWS) test 386052 1 89656 fridrich.strba 2011-04-14 14:46:00 -0700 Created attachment 89656 Patch 386114 2 89656 mrobinson 2011-04-14 15:37:53 -0700 Comment on attachment 89656 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89656&action=review > Source/WebCore/platform/FileSystem.h:-80 > -#if OS(WINDOWS) It might be better here to simply change this to #if OS(WINDOWS) && !PLATFORM(GTK) 386364 3 fridrich.strba 2011-04-14 21:43:42 -0700 (In reply to comment #2) > (From update of attachment 89656 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=89656&action=review > > > Source/WebCore/platform/FileSystem.h:-80 > > -#if OS(WINDOWS) > > It might be better here to simply change this to #if OS(WINDOWS) && !PLATFORM(GTK) In my opinion, moving the 3 lines is producing more readable code and correspond to what for instance QT port does, the evaluation of its platform comes before the windows evaluation. There is already enough of forest of ifdefs so that the stuff be even more offuscated :) 387064 4 commit-queue 2011-04-15 17:14:59 -0700 The commit-queue encountered the following flaky tests while processing attachment 89656: http/tests/xmlhttprequest/logout.html bug 52047 (author: ap@webkit.org) The commit-queue is continuing to process your patch. 387067 5 89656 commit-queue 2011-04-15 17:17:51 -0700 Comment on attachment 89656 Patch Clearing flags on attachment: 89656 Committed r84059: <http://trac.webkit.org/changeset/84059> 387068 6 commit-queue 2011-04-15 17:17:54 -0700 All reviewed patches have been landed. Closing bug. 387138 7 webkit.review.bot 2011-04-15 18:22:35 -0700 http://trac.webkit.org/changeset/84059 might have broken WinCairo Debug (Build) 89656 2011-04-14 14:46:00 -0700 2011-04-15 17:17:51 -0700 Patch bug-58576-20110414234558.patch text/plain 2185 fridrich.strba SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzODk1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDQtMTQgIEZyaWRyaWNo IFN0cmJhICA8ZnJpZHJpY2guc3RyYmFAYmx1ZXdpbi5jaD4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFdmFsdWF0ZSBQTEFURk9STShHVEspIGJlZm9y ZSB0aGUgYWxsLWVuY29tcGFzc2luZyBPUyhXSU5ET1dTKQorICAgICAgICB0ZXN0LiBUaGlzIGFs bG93cyBXaW5kb3dzIGJ1aWxkIG9mIFdlYktpdCBHVEsgdG8gY2hvc2UgdGhlIHJpZ2h0CisgICAg ICAgIHBhdGguCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01ODU3NgorCisgICAgICAgICogcGxhdGZvcm0vRmlsZVN5c3RlbS5oOgorCiAyMDExLTA0LTE0 ICBLZW5uZXRoIFJ1c3NlbGwgIDxrYnJAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBEaW1pdHJpIEdsYXprb3YuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9GaWxlU3lz dGVtLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vRmlsZVN5c3RlbS5o CShyZXZpc2lvbiA4Mzg5MikKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0ZpbGVTeXN0ZW0u aAkod29ya2luZyBjb3B5KQpAQCAtNzcsNyArNzcsOSBAQCB0eXBlZGVmIHN0cnVjdCBfR01vZHVs ZSBHTW9kdWxlOwogbmFtZXNwYWNlIFdlYkNvcmUgewogCiAvLyBQbGF0Zm9ybU1vZHVsZQotI2lm IE9TKFdJTkRPV1MpCisjaWYgUExBVEZPUk0oR1RLKQordHlwZWRlZiBHTW9kdWxlKiBQbGF0Zm9y bU1vZHVsZTsKKyNlbGlmIE9TKFdJTkRPV1MpCiB0eXBlZGVmIEhNT0RVTEUgUGxhdGZvcm1Nb2R1 bGU7CiAjZWxpZiBQTEFURk9STShRVCkKICNpZiBkZWZpbmVkKFFfV1NfTUFDKQpAQCAtODcsOCAr ODksNiBAQCB0eXBlZGVmIFFMaWJyYXJ5KiBQbGF0Zm9ybU1vZHVsZTsKICNlbHNlCiB0eXBlZGVm IHZvaWQqIFBsYXRmb3JtTW9kdWxlOwogI2VuZGlmCi0jZWxpZiBQTEFURk9STShHVEspCi10eXBl ZGVmIEdNb2R1bGUqIFBsYXRmb3JtTW9kdWxlOwogI2VsaWYgVVNFKENGKQogdHlwZWRlZiBDRkJ1 bmRsZVJlZiBQbGF0Zm9ybU1vZHVsZTsKICNlbHNlCkBAIC0xMjIsNiArMTIyLDkgQEAgdHlwZWRl ZiB1bnNpZ25lZCBQbGF0Zm9ybU1vZHVsZVZlcnNpb247CiAjaWYgUExBVEZPUk0oUVQpCiB0eXBl ZGVmIFFGaWxlKiBQbGF0Zm9ybUZpbGVIYW5kbGU7CiBjb25zdCBQbGF0Zm9ybUZpbGVIYW5kbGUg aW52YWxpZFBsYXRmb3JtRmlsZUhhbmRsZSA9IDA7CisjZWxpZiBQTEFURk9STShHVEspCit0eXBl ZGVmIEdGaWxlSU9TdHJlYW0qIFBsYXRmb3JtRmlsZUhhbmRsZTsKK2NvbnN0IFBsYXRmb3JtRmls ZUhhbmRsZSBpbnZhbGlkUGxhdGZvcm1GaWxlSGFuZGxlID0gMDsKICNlbGlmIE9TKFdJTkRPV1Mp CiB0eXBlZGVmIEhBTkRMRSBQbGF0Zm9ybUZpbGVIYW5kbGU7CiAvLyBGSVhNRTogLTEgaXMgSU5W QUxJRF9IQU5ETEVfVkFMVUUsIGRlZmluZWQgaW4gPHdpbmJhc2UuaD4uIENocm9taXVtIHRyaWVz IHRvCkBAIC0xMzAsOSArMTMzLDYgQEAgY29uc3QgUGxhdGZvcm1GaWxlSGFuZGxlIGludmFsaWRQ bGF0Zm9ybQogI2VsaWYgUExBVEZPUk0oQlJFV01QKQogdHlwZWRlZiBJRmlsZSogUGxhdGZvcm1G aWxlSGFuZGxlOwogY29uc3QgUGxhdGZvcm1GaWxlSGFuZGxlIGludmFsaWRQbGF0Zm9ybUZpbGVI YW5kbGUgPSAwOwotI2VsaWYgUExBVEZPUk0oR1RLKQotdHlwZWRlZiBHRmlsZUlPU3RyZWFtKiBQ bGF0Zm9ybUZpbGVIYW5kbGU7Ci1jb25zdCBQbGF0Zm9ybUZpbGVIYW5kbGUgaW52YWxpZFBsYXRm b3JtRmlsZUhhbmRsZSA9IDA7CiAjZWxpZiBQTEFURk9STShXWCkKIHR5cGVkZWYgd3hGaWxlKiBQ bGF0Zm9ybUZpbGVIYW5kbGU7CiBjb25zdCBQbGF0Zm9ybUZpbGVIYW5kbGUgaW52YWxpZFBsYXRm b3JtRmlsZUhhbmRsZSA9IDA7Cg==