58507 2011-04-13 19:31:09 -0700 Add GTest unit-testing framework to WebKit 2011-04-15 18:18:06 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 21010 58509 0 dslomov webkit-unassigned dslomov levin mrowe timothy oldest_to_newest 385463 0 dslomov 2011-04-13 19:31:09 -0700 Add GTest to Source/ThirdParty, create examples of its use. 385466 1 89519 dslomov 2011-04-13 20:03:07 -0700 Created attachment 89519 Adding gtest to Source/ThirdParty + sample test case 385468 2 89519 dslomov 2011-04-13 20:05:50 -0700 Comment on attachment 89519 Adding gtest to Source/ThirdParty + sample test case Breaking up into two separate patches. 385475 3 89521 dslomov 2011-04-13 20:28:30 -0700 Created attachment 89521 Adding GTest framework to Source/ThirdParty 385478 4 89522 dslomov 2011-04-13 20:36:58 -0700 Created attachment 89522 Adding GTest to Source/ThirdParty 385514 5 89522 levin 2011-04-13 22:16:16 -0700 Comment on attachment 89522 Adding GTest to Source/ThirdParty Based on the status of ews, I suspect this patch is too big for the commit queue. 385987 6 levin 2011-04-14 13:13:30 -0700 Committed as http://trac.webkit.org/changeset/83815 386792 7 timothy 2011-04-15 11:55:29 -0700 The GTest targets have errors on systems that don't have $(DEVELOPER_SDK_DIR)/MacOSX10.4u.sdk. It should not have an SDK and use the current system. 387101 8 mrowe 2011-04-15 17:57:15 -0700 Can someone expand on how we arrived at using gtest? There appears to have been zero discussion of this and the rather large and complicated library was simply checked in to the source tree. 89519 2011-04-13 20:03:07 -0700 2011-04-13 20:36:58 -0700 Adding gtest to Source/ThirdParty + sample test case adding-gtest.patch text/plain 0 dslomov 89521 2011-04-13 20:28:30 -0700 2011-04-13 20:36:58 -0700 Adding GTest framework to Source/ThirdParty adding-gtest.patch text/plain 0 dslomov 89522 2011-04-13 20:36:58 -0700 2011-04-13 22:16:16 -0700 Adding GTest to Source/ThirdParty adding-gtest.patch text/plain 0 dslomov