58467 2011-04-13 12:06:53 -0700 IndexedDB createIndex should fail if options arg is invalid 2012-02-07 14:18:49 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P3 Normal --- 58471 0 pilgrim girard dgrogan fishd girard hans jsbell pilgrim tony webkit.review.bot oldest_to_newest 385115 0 pilgrim 2011-04-13 12:06:53 -0700 Two possible ways the options argument can be invalid: it's not a JavaScript object, or the object contains attributes other than keyPath and autoIncrement. In each case, Mozilla throws but WebKit does not. Attaching tests for each case. 385116 1 89426 pilgrim 2011-04-13 12:07:20 -0700 Created attachment 89426 test case #1: options arg is not an object 385118 2 89427 pilgrim 2011-04-13 12:07:45 -0700 Created attachment 89427 test case #2: options arg contains unknown attributes 385135 3 pilgrim 2011-04-13 12:22:26 -0700 Apologies, my original comment was slightly incorrect. The valid attributes for the options argument are unique and multirow. The test cases still properly demonstrate the problem of not throwing on unknown attributes. 484250 4 jsbell 2011-10-14 13:46:18 -0700 Test case #2 is no longer valid - IndexedDB spec has changed to use the (new) WebIDL dictionary type for the options object, which ignores unknown attributes - http://dev.w3.org/2006/webapi/WebIDL/#es-dictionary Test case #1 is still valid; in Chrome 15 I can pass a string as the options argument and no exception is thrown. Per WebIDL: "If Type(V) is not Object, then throw a TypeError." 550998 5 125846 girard 2012-02-07 08:14:04 -0800 Created attachment 125846 Patch 551009 6 125846 jsbell 2012-02-07 08:26:58 -0800 Comment on attachment 125846 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125846&action=review Test changes LGTM > LayoutTests/ChangeLog:6 > + https://bugs.webkit.org/show_bug.cgi?id=58467 Nit: Keep the specific URL under the bug subject, have the comment lines in a separate paragraph. Otherwise the commit queue may get confused. 551095 7 125846 tony 2012-02-07 10:22:36 -0800 Comment on attachment 125846 Patch As Joshua mentions, the bug URL should be directly below the bug title. See the other ChangeLog entries as an example. 551114 8 125875 girard 2012-02-07 10:40:07 -0800 Created attachment 125875 Patch 551117 9 girard 2012-02-07 10:41:38 -0800 (In reply to comment #7) > (From update of attachment 125846 [details]) > As Joshua mentions, the bug URL should be directly below the bug title. See the other ChangeLog entries as an example. Thanks. Fixed in this patch. 551224 10 125875 webkit.review.bot 2012-02-07 12:13:53 -0800 Comment on attachment 125875 Patch Rejecting attachment 125875 from commit-queue. New failing tests: perf/array-reverse.html Full output: http://queues.webkit.org/results/11459034 551387 11 125875 webkit.review.bot 2012-02-07 14:18:44 -0800 Comment on attachment 125875 Patch Clearing flags on attachment: 125875 Committed r106991: <http://trac.webkit.org/changeset/106991> 551388 12 webkit.review.bot 2012-02-07 14:18:49 -0800 All reviewed patches have been landed. Closing bug. 89426 2011-04-13 12:07:20 -0700 2011-04-13 12:07:20 -0700 test case #1: options arg is not an object create-index-bad-options.html text/html 1789 pilgrim PCFET0NUWVBFIGh0bWw+CjwhLS0KICBvcmlnaW5hbCB0ZXN0OiBodHRwOi8vbXhyLm1vemlsbGEu b3JnL21vemlsbGEyLjAvc291cmNlL2RvbS9pbmRleGVkREIvdGVzdC90ZXN0X2NyZWF0ZV9pbmRl eC5odG1sCiAgbGljZW5zZSBvZiBvcmlnaW5hbCB0ZXN0OgogICAgIiBBbnkgY29weXJpZ2h0IGlz IGRlZGljYXRlZCB0byB0aGUgUHVibGljIERvbWFpbi4KICAgICAgaHR0cDovL2NyZWF0aXZlY29t bW9ucy5vcmcvcHVibGljZG9tYWluL3plcm8vMS4wLyAiCi0tPgo8aHRtbD4KPGhlYWQ+CjxsaW5r IHJlbD0ic3R5bGVzaGVldCIgaHJlZj0iLi4vLi4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVz dC1zdHlsZS5jc3MiPgo8c2NyaXB0IHNyYz0iLi4vLi4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMt dGVzdC1wcmUuanMiPjwvc2NyaXB0Pgo8c2NyaXB0IHNyYz0iLi4vLi4vLi4vZmFzdC9qcy9yZXNv dXJjZXMvanMtdGVzdC1wb3N0LWZ1bmN0aW9uLmpzIj48L3NjcmlwdD4KPHNjcmlwdCBzcmM9Ii4u L3Jlc291cmNlcy9zaGFyZWQuanMiPjwvc2NyaXB0Pgo8L2hlYWQ+Cjxib2R5Pgo8cCBpZD0iZGVz Y3JpcHRpb24iPjwvcD4KPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+CjxzY3JpcHQ+CgpkZXNjcmlw dGlvbigiVGVzdCBJbmRleGVkREIncyBjcmVhdGluZyBpbmRleCB3aXRoIGJhZCBvcHRpb25zIik7 CmlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCiAgICBsYXlvdXRUZXN0Q29udHJvbGxl ci53YWl0VW50aWxEb25lKCk7CgpmdW5jdGlvbiB0ZXN0KCkKewogICAgc2hvdWxkQmVUcnVlKCIn d2Via2l0SW5kZXhlZERCJyBpbiB3aW5kb3ciKTsKICAgIHNob3VsZEJlRmFsc2UoIndlYmtpdElu ZGV4ZWREQiA9PSBudWxsIik7CgogICAgbmFtZSA9IHdpbmRvdy5sb2NhdGlvbi5wYXRobmFtZTsK ICAgIGRlc2NyaXB0aW9uID0gIk15IFRlc3QgRGF0YWJhc2UiOwogICAgcmVxdWVzdCA9IGV2YWxB bmRMb2coIndlYmtpdEluZGV4ZWREQi5vcGVuKG5hbWUsIGRlc2NyaXB0aW9uKSIpOwogICAgcmVx dWVzdC5vbnN1Y2Nlc3MgPSBvcGVuU3VjY2VzczsKICAgIHJlcXVlc3Qub25lcnJvciA9IHVuZXhw ZWN0ZWRFcnJvckNhbGxiYWNrOwp9CgpmdW5jdGlvbiBvcGVuU3VjY2VzcygpCnsKICAgIGRlYnVn KCJvcGVuU3VjY2VzcygpOiIpOwogICAgZGIgPSBldmFsQW5kTG9nKCJkYiA9IGV2ZW50LnRhcmdl dC5yZXN1bHQiKTsKCiAgICByZXF1ZXN0ID0gZXZhbEFuZExvZygicmVxdWVzdCA9IGRiLnNldFZl cnNpb24oJ3ZlcnNpb24gMScpIik7CiAgICByZXF1ZXN0Lm9uc3VjY2VzcyA9IGNsZWFuRGF0YWJh c2U7CiAgICByZXF1ZXN0Lm9uZXJyb3IgPSB1bmV4cGVjdGVkRXJyb3JDYWxsYmFjazsKfQoKZnVu Y3Rpb24gY2xlYW5EYXRhYmFzZSgpCnsKICAgIGRlYnVnKCJjbGVhbkRhdGFiYXNlKCk6Iik7CiAg ICBkZWxldGVBbGxPYmplY3RTdG9yZXMoZGIpOwoKICAgIG9iamVjdFN0b3JlID0gZXZhbEFuZExv Zygib2JqZWN0U3RvcmUgPSBkYi5jcmVhdGVPYmplY3RTdG9yZSgnYScsIHsga2V5UGF0aDogJ2lk JywgYXV0b0luY3JlbWVudDogdHJ1ZSB9KTsiKTsKCiAgICBpbmRleCA9IGV2YWxBbmRFeHBlY3RF eGNlcHRpb24oImluZGV4ID0gb2JqZWN0U3RvcmUuY3JlYXRlSW5kZXgoJ2ZvbycsICdiYXInLCAx MCk7IiwgIndlYmtpdElEQkRhdGFiYXNlRXhjZXB0aW9uLkNPTlNUUkFJTlRfRVJSIik7CgogICAg ZG9uZSgpOwp9Cgp2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsKCnRlc3QoKTsKCjwvc2Ny aXB0Pgo8L2JvZHk+CjwvaHRtbD4KCg== 89427 2011-04-13 12:07:45 -0700 2011-04-13 12:07:45 -0700 test case #2: options arg contains unknown attributes create-index-bad-options-2.html text/html 1798 pilgrim PCFET0NUWVBFIGh0bWw+CjwhLS0KICBvcmlnaW5hbCB0ZXN0OiBodHRwOi8vbXhyLm1vemlsbGEu b3JnL21vemlsbGEyLjAvc291cmNlL2RvbS9pbmRleGVkREIvdGVzdC90ZXN0X2NyZWF0ZV9pbmRl eC5odG1sCiAgbGljZW5zZSBvZiBvcmlnaW5hbCB0ZXN0OgogICAgIiBBbnkgY29weXJpZ2h0IGlz IGRlZGljYXRlZCB0byB0aGUgUHVibGljIERvbWFpbi4KICAgICAgaHR0cDovL2NyZWF0aXZlY29t bW9ucy5vcmcvcHVibGljZG9tYWluL3plcm8vMS4wLyAiCi0tPgo8aHRtbD4KPGhlYWQ+CjxsaW5r IHJlbD0ic3R5bGVzaGVldCIgaHJlZj0iLi4vLi4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVz dC1zdHlsZS5jc3MiPgo8c2NyaXB0IHNyYz0iLi4vLi4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMt dGVzdC1wcmUuanMiPjwvc2NyaXB0Pgo8c2NyaXB0IHNyYz0iLi4vLi4vLi4vZmFzdC9qcy9yZXNv dXJjZXMvanMtdGVzdC1wb3N0LWZ1bmN0aW9uLmpzIj48L3NjcmlwdD4KPHNjcmlwdCBzcmM9Ii4u L3Jlc291cmNlcy9zaGFyZWQuanMiPjwvc2NyaXB0Pgo8L2hlYWQ+Cjxib2R5Pgo8cCBpZD0iZGVz Y3JpcHRpb24iPjwvcD4KPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+CjxzY3JpcHQ+CgpkZXNjcmlw dGlvbigiVGVzdCBJbmRleGVkREIncyBjcmVhdGluZyBpbmRleCB3aXRoIGJhZCBvcHRpb25zIik7 CmlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCiAgICBsYXlvdXRUZXN0Q29udHJvbGxl ci53YWl0VW50aWxEb25lKCk7CgpmdW5jdGlvbiB0ZXN0KCkKewogICAgc2hvdWxkQmVUcnVlKCIn d2Via2l0SW5kZXhlZERCJyBpbiB3aW5kb3ciKTsKICAgIHNob3VsZEJlRmFsc2UoIndlYmtpdElu ZGV4ZWREQiA9PSBudWxsIik7CgogICAgbmFtZSA9IHdpbmRvdy5sb2NhdGlvbi5wYXRobmFtZTsK ICAgIGRlc2NyaXB0aW9uID0gIk15IFRlc3QgRGF0YWJhc2UiOwogICAgcmVxdWVzdCA9IGV2YWxB bmRMb2coIndlYmtpdEluZGV4ZWREQi5vcGVuKG5hbWUsIGRlc2NyaXB0aW9uKSIpOwogICAgcmVx dWVzdC5vbnN1Y2Nlc3MgPSBvcGVuU3VjY2VzczsKICAgIHJlcXVlc3Qub25lcnJvciA9IHVuZXhw ZWN0ZWRFcnJvckNhbGxiYWNrOwp9CgpmdW5jdGlvbiBvcGVuU3VjY2VzcygpCnsKICAgIGRlYnVn KCJvcGVuU3VjY2VzcygpOiIpOwogICAgZGIgPSBldmFsQW5kTG9nKCJkYiA9IGV2ZW50LnRhcmdl dC5yZXN1bHQiKTsKCiAgICByZXF1ZXN0ID0gZXZhbEFuZExvZygicmVxdWVzdCA9IGRiLnNldFZl cnNpb24oJ3ZlcnNpb24gMScpIik7CiAgICByZXF1ZXN0Lm9uc3VjY2VzcyA9IGNsZWFuRGF0YWJh c2U7CiAgICByZXF1ZXN0Lm9uZXJyb3IgPSB1bmV4cGVjdGVkRXJyb3JDYWxsYmFjazsKfQoKZnVu Y3Rpb24gY2xlYW5EYXRhYmFzZSgpCnsKICAgIGRlYnVnKCJjbGVhbkRhdGFiYXNlKCk6Iik7CiAg ICBkZWxldGVBbGxPYmplY3RTdG9yZXMoZGIpOwoKICAgIG9iamVjdFN0b3JlID0gZXZhbEFuZExv Zygib2JqZWN0U3RvcmUgPSBkYi5jcmVhdGVPYmplY3RTdG9yZSgnYScsIHsga2V5UGF0aDogJ2lk JywgYXV0b0luY3JlbWVudDogdHJ1ZSB9KTsiKTsKCiAgICBpbmRleCA9IGV2YWxBbmRFeHBlY3RF eGNlcHRpb24oImluZGV4ID0gb2JqZWN0U3RvcmUuY3JlYXRlSW5kZXgoJ2ZvbycsICdiYXInLCB7 IGZvbzogJycgfSk7IiwgIndlYmtpdElEQkRhdGFiYXNlRXhjZXB0aW9uLkNPTlNUUkFJTlRfRVJS Iik7CgogICAgZG9uZSgpOwp9Cgp2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsKCnRlc3Qo KTsKCjwvc2NyaXB0Pgo8L2JvZHk+CjwvaHRtbD4KCg== 125846 2012-02-07 08:14:04 -0800 2012-02-07 10:40:02 -0800 Patch bug-58467-20120207111403.patch text/plain 4308 girard U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2ODg5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggODM0ZDhiMDlmZDJhNjUzN2Q2ZmRj ZTg5ZWU5M2I0YWQ4ZGRmMzRiMC4uZTdhYmNjYmE5MzRmNzA4NDhhMzZkYTM5OWI4NDQ4YzZhZTll NzU4MCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAyLTA3ICBFdWdlbmUgR2lyYXJkICA8 Z2lyYXJkQGNocm9taXVtLm9yZz4KKworICAgICAgICBJbmRleGVkREIgY3JlYXRlSW5kZXggc2hv dWxkIGZhaWwgaWYgb3B0aW9ucyBhcmcgaXMgaW52YWxpZAorICAgICAgICBUaGlzIHRpY2tldCB3 YXMgZml4ZWQgYXMgcGFydCBvZiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NTg0NzEKKyAgICAgICAgQWRkaW5nIHVuaXQgdGVzdHMgdG8gdmVyaWZ5IGNvcnJlY3Qgb3Bl cmF0aW9uLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NTg0NjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IHN0b3JhZ2UvaW5kZXhlZGRiL2luZGV4LWJhc2ljcy1leHBlY3RlZC50eHQ6CisgICAgICAgICog c3RvcmFnZS9pbmRleGVkZGIvaW5kZXgtYmFzaWNzLXdvcmtlcnMtZXhwZWN0ZWQudHh0OgorICAg ICAgICAqIHN0b3JhZ2UvaW5kZXhlZGRiL3Jlc291cmNlcy9pbmRleC1iYXNpY3MuanM6CisgICAg ICAgIChkZWxldGVFeGlzdGluZyk6CisKIDIwMTItMDItMDYgIERhdmlkIEdyb2dhbiAgPGRncm9n YW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFBvcnQgc29tZSBpbmRleGVkZGIgbGF5b3V0IHRl c3RzIHRvIHdvcmtlcnMuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRk Yi9pbmRleC1iYXNpY3MtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVk ZGIvaW5kZXgtYmFzaWNzLWV4cGVjdGVkLnR4dAppbmRleCA5ODUzYTIwZWNkMjMxNzk2NDJlZDll MDJhYzEyNWEwZjg4MDdlODRiLi4wYTg1MTRmYWZkMmU1ZGU2ZjBjM2MwNzhjNzljNWE4OWE0ZjY1 NDk0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9pbmRleC1iYXNp Y3MtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL2luZGV4 LWJhc2ljcy1leHBlY3RlZC50eHQKQEAgLTE0LDYgKzE0LDE0IEBAIGRiLmNyZWF0ZU9iamVjdFN0 b3JlKCdzdG9yZU5hbWUnLCBudWxsKQogc3RvcmUuY3JlYXRlSW5kZXgoJ2luZGV4TmFtZScsICd4 JykKIHN0b3JlLmNyZWF0ZUluZGV4KCdpbmRleE5hbWUyJywgJ3knLCB7dW5pcXVlOiBmYWxzZX0p CiBzdG9yZS5jcmVhdGVJbmRleCgnekluZGV4JywgJ3onLCB7dW5pcXVlOiB0cnVlfSkKK1BBU1Mg aW5kZXhPYmplY3QyLnVuaXF1ZSBpcyBmYWxzZQorUEFTUyBpbmRleE9iamVjdDMudW5pcXVlIGlz IHRydWUKK0V4cGVjdGluZyBUeXBlRXJyb3IgZXhjZXB0aW9uIGZyb20gc3RvcmUuY3JlYXRlSW5k ZXgoJ2ZhaWx1cmVJbmRleCcsICd6enonLCB0cnVlKQorUEFTUyBFeGNlcHRpb24gd2FzIHRocm93 bi4KK1BBU1Mgc3RvcmUuY3JlYXRlSW5kZXgoJ2ZhaWx1cmVJbmRleCcsICd6enonLCB0cnVlKSB0 aHJldyBUeXBlRXJyb3I6IE5vdCBhbiBvYmplY3QuCitFeHBlY3RpbmcgVHlwZUVycm9yIGV4Y2Vw dGlvbiBmcm9tIHN0b3JlLmNyZWF0ZUluZGV4KCdmYWlsdXJlSW5kZXgnLCAnenp6JywgJ3N0cmlu ZycpCitQQVNTIEV4Y2VwdGlvbiB3YXMgdGhyb3duLgorUEFTUyBzdG9yZS5jcmVhdGVJbmRleCgn ZmFpbHVyZUluZGV4JywgJ3p6eicsICdzdHJpbmcnKSB0aHJldyBUeXBlRXJyb3I6IE5vdCBhbiBv YmplY3QuCiBQQVNTICduYW1lJyBpbiBpbmRleE9iamVjdCBpcyB0cnVlCiBQQVNTIGluZGV4T2Jq ZWN0Lm5hbWUgaXMgImluZGV4TmFtZSIKIFBBU1MgJ29iamVjdFN0b3JlJyBpbiBpbmRleE9iamVj dCBpcyB0cnVlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9pbmRl eC1iYXNpY3Mtd29ya2Vycy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4 ZWRkYi9pbmRleC1iYXNpY3Mtd29ya2Vycy1leHBlY3RlZC50eHQKaW5kZXggMjIwMmUwZWUyNzkx YmE0ZWVlMWY3MTI4ZTg3Y2VlNGMyYWZhOWFmYi4uMTU5YjM5NTk5YzI0YzU3NjU0NTI5MzlhOTFi NTE2MWQzMDdlYzUxNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIv aW5kZXgtYmFzaWNzLXdvcmtlcnMtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL3N0b3Jh Z2UvaW5kZXhlZGRiL2luZGV4LWJhc2ljcy13b3JrZXJzLWV4cGVjdGVkLnR4dApAQCAtMTUsNiAr MTUsMTQgQEAgUEFTUyBbV29ya2VyXSB0cmFucyAhPT0gbnVsbCBpcyB0cnVlCiBbV29ya2VyXSBz dG9yZS5jcmVhdGVJbmRleCgnaW5kZXhOYW1lJywgJ3gnKQogW1dvcmtlcl0gc3RvcmUuY3JlYXRl SW5kZXgoJ2luZGV4TmFtZTInLCAneScsIHt1bmlxdWU6IGZhbHNlfSkKIFtXb3JrZXJdIHN0b3Jl LmNyZWF0ZUluZGV4KCd6SW5kZXgnLCAneicsIHt1bmlxdWU6IHRydWV9KQorUEFTUyBbV29ya2Vy XSBpbmRleE9iamVjdDIudW5pcXVlIGlzIGZhbHNlCitQQVNTIFtXb3JrZXJdIGluZGV4T2JqZWN0 My51bmlxdWUgaXMgdHJ1ZQorW1dvcmtlcl0gRXhwZWN0aW5nIFR5cGVFcnJvciBleGNlcHRpb24g ZnJvbSBzdG9yZS5jcmVhdGVJbmRleCgnZmFpbHVyZUluZGV4JywgJ3p6eicsIHRydWUpCitQQVNT IFtXb3JrZXJdIEV4Y2VwdGlvbiB3YXMgdGhyb3duLgorUEFTUyBbV29ya2VyXSBzdG9yZS5jcmVh dGVJbmRleCgnZmFpbHVyZUluZGV4JywgJ3p6eicsIHRydWUpIHRocmV3IFR5cGVFcnJvcjogTm90 IGFuIG9iamVjdC4KK1tXb3JrZXJdIEV4cGVjdGluZyBUeXBlRXJyb3IgZXhjZXB0aW9uIGZyb20g c3RvcmUuY3JlYXRlSW5kZXgoJ2ZhaWx1cmVJbmRleCcsICd6enonLCAnc3RyaW5nJykKK1BBU1Mg W1dvcmtlcl0gRXhjZXB0aW9uIHdhcyB0aHJvd24uCitQQVNTIFtXb3JrZXJdIHN0b3JlLmNyZWF0 ZUluZGV4KCdmYWlsdXJlSW5kZXgnLCAnenp6JywgJ3N0cmluZycpIHRocmV3IFR5cGVFcnJvcjog Tm90IGFuIG9iamVjdC4KIFBBU1MgW1dvcmtlcl0gJ25hbWUnIGluIGluZGV4T2JqZWN0IGlzIHRy dWUKIFBBU1MgW1dvcmtlcl0gaW5kZXhPYmplY3QubmFtZSBpcyAiaW5kZXhOYW1lIgogUEFTUyBb V29ya2VyXSAnb2JqZWN0U3RvcmUnIGluIGluZGV4T2JqZWN0IGlzIHRydWUKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL3Jlc291cmNlcy9pbmRleC1iYXNpY3MuanMg Yi9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9yZXNvdXJjZXMvaW5kZXgtYmFzaWNzLmpz CmluZGV4IGMyZGVjNjYwNjQyMzViNWQ1NjE1M2I4YzdiZWM0Yjc1NzhhZDUzYzYuLjAxZDU5NWEz YjllNDQxMTc1NWRmNGJhODkyNGEzNjJmNzE2NWEyOTcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L3N0b3JhZ2UvaW5kZXhlZGRiL3Jlc291cmNlcy9pbmRleC1iYXNpY3MuanMKKysrIGIvTGF5b3V0 VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvcmVzb3VyY2VzL2luZGV4LWJhc2ljcy5qcwpAQCAtMzcs NiArMzcsMTAgQEAgZnVuY3Rpb24gZGVsZXRlRXhpc3RpbmcoZXZ0KQogICAgIHNlbGYuaW5kZXhP YmplY3QgPSBldmFsQW5kTG9nKCJzdG9yZS5jcmVhdGVJbmRleCgnaW5kZXhOYW1lJywgJ3gnKSIp OwogICAgIHNlbGYuaW5kZXhPYmplY3QyID0gZXZhbEFuZExvZygic3RvcmUuY3JlYXRlSW5kZXgo J2luZGV4TmFtZTInLCAneScsIHt1bmlxdWU6IGZhbHNlfSkiKTsKICAgICBzZWxmLmluZGV4T2Jq ZWN0MyA9IGV2YWxBbmRMb2coInN0b3JlLmNyZWF0ZUluZGV4KCd6SW5kZXgnLCAneicsIHt1bmlx dWU6IHRydWV9KSIpOworICAgIHNob3VsZEJlRmFsc2UoImluZGV4T2JqZWN0Mi51bmlxdWUiKTsK KyAgICBzaG91bGRCZVRydWUoImluZGV4T2JqZWN0My51bmlxdWUiKTsKKyAgICBldmFsQW5kRXhw ZWN0RXhjZXB0aW9uQ2xhc3MoInN0b3JlLmNyZWF0ZUluZGV4KCdmYWlsdXJlSW5kZXgnLCAnenp6 JywgdHJ1ZSkiLCAiVHlwZUVycm9yIik7CisgICAgZXZhbEFuZEV4cGVjdEV4Y2VwdGlvbkNsYXNz KCJzdG9yZS5jcmVhdGVJbmRleCgnZmFpbHVyZUluZGV4JywgJ3p6eicsICdzdHJpbmcnKSIsICJU eXBlRXJyb3IiKTsKICAgICBhZGREYXRhKCk7CiB9CiAK 125875 2012-02-07 10:40:07 -0800 2012-02-07 14:18:44 -0800 Patch bug-58467-20120207134006.patch text/plain 4310 girard U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2ODg5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggODM0ZDhiMDlmZDJhNjUzN2Q2ZmRj ZTg5ZWU5M2I0YWQ4ZGRmMzRiMC4uZjhjNjAzY2Q0Mzk0MDI5ZGE4NmIxMmVkMWYyMzk2ODMxYjVl MTRkZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAyLTA3ICBFdWdlbmUgR2lyYXJkICA8 Z2lyYXJkQGNocm9taXVtLm9yZz4KKworICAgICAgICBJbmRleGVkREIgY3JlYXRlSW5kZXggc2hv dWxkIGZhaWwgaWYgb3B0aW9ucyBhcmcgaXMgaW52YWxpZAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTg0NjcKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHRpY2tldCB3YXMgZml4ZWQgYXMgcGFydCBv ZiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTg0NzEKKyAgICAgICAg QWRkaW5nIHVuaXQgdGVzdHMgdG8gdmVyaWZ5IGNvcnJlY3Qgb3BlcmF0aW9uLgorCisgICAgICAg ICogc3RvcmFnZS9pbmRleGVkZGIvaW5kZXgtYmFzaWNzLWV4cGVjdGVkLnR4dDoKKyAgICAgICAg KiBzdG9yYWdlL2luZGV4ZWRkYi9pbmRleC1iYXNpY3Mtd29ya2Vycy1leHBlY3RlZC50eHQ6Cisg ICAgICAgICogc3RvcmFnZS9pbmRleGVkZGIvcmVzb3VyY2VzL2luZGV4LWJhc2ljcy5qczoKKyAg ICAgICAgKGRlbGV0ZUV4aXN0aW5nKToKKwogMjAxMi0wMi0wNiAgRGF2aWQgR3JvZ2FuICA8ZGdy b2dhbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUG9ydCBzb21lIGluZGV4ZWRkYiBsYXlvdXQg dGVzdHMgdG8gd29ya2Vycy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhl ZGRiL2luZGV4LWJhc2ljcy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4 ZWRkYi9pbmRleC1iYXNpY3MtZXhwZWN0ZWQudHh0CmluZGV4IDk4NTNhMjBlY2QyMzE3OTY0MmVk OWUwMmFjMTI1YTBmODgwN2U4NGIuLjBhODUxNGZhZmQyZTVkZTZmMGMzYzA3OGM3OWM1YTg5YTRm NjU0OTQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL2luZGV4LWJh c2ljcy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvaW5k ZXgtYmFzaWNzLWV4cGVjdGVkLnR4dApAQCAtMTQsNiArMTQsMTQgQEAgZGIuY3JlYXRlT2JqZWN0 U3RvcmUoJ3N0b3JlTmFtZScsIG51bGwpCiBzdG9yZS5jcmVhdGVJbmRleCgnaW5kZXhOYW1lJywg J3gnKQogc3RvcmUuY3JlYXRlSW5kZXgoJ2luZGV4TmFtZTInLCAneScsIHt1bmlxdWU6IGZhbHNl fSkKIHN0b3JlLmNyZWF0ZUluZGV4KCd6SW5kZXgnLCAneicsIHt1bmlxdWU6IHRydWV9KQorUEFT UyBpbmRleE9iamVjdDIudW5pcXVlIGlzIGZhbHNlCitQQVNTIGluZGV4T2JqZWN0My51bmlxdWUg aXMgdHJ1ZQorRXhwZWN0aW5nIFR5cGVFcnJvciBleGNlcHRpb24gZnJvbSBzdG9yZS5jcmVhdGVJ bmRleCgnZmFpbHVyZUluZGV4JywgJ3p6eicsIHRydWUpCitQQVNTIEV4Y2VwdGlvbiB3YXMgdGhy b3duLgorUEFTUyBzdG9yZS5jcmVhdGVJbmRleCgnZmFpbHVyZUluZGV4JywgJ3p6eicsIHRydWUp IHRocmV3IFR5cGVFcnJvcjogTm90IGFuIG9iamVjdC4KK0V4cGVjdGluZyBUeXBlRXJyb3IgZXhj ZXB0aW9uIGZyb20gc3RvcmUuY3JlYXRlSW5kZXgoJ2ZhaWx1cmVJbmRleCcsICd6enonLCAnc3Ry aW5nJykKK1BBU1MgRXhjZXB0aW9uIHdhcyB0aHJvd24uCitQQVNTIHN0b3JlLmNyZWF0ZUluZGV4 KCdmYWlsdXJlSW5kZXgnLCAnenp6JywgJ3N0cmluZycpIHRocmV3IFR5cGVFcnJvcjogTm90IGFu IG9iamVjdC4KIFBBU1MgJ25hbWUnIGluIGluZGV4T2JqZWN0IGlzIHRydWUKIFBBU1MgaW5kZXhP YmplY3QubmFtZSBpcyAiaW5kZXhOYW1lIgogUEFTUyAnb2JqZWN0U3RvcmUnIGluIGluZGV4T2Jq ZWN0IGlzIHRydWUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL2lu ZGV4LWJhc2ljcy13b3JrZXJzLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5k ZXhlZGRiL2luZGV4LWJhc2ljcy13b3JrZXJzLWV4cGVjdGVkLnR4dAppbmRleCAyMjAyZTBlZTI3 OTFiYTRlZWUxZjcxMjhlODdjZWU0YzJhZmE5YWZiLi4xNTliMzk1OTljMjRjNTc2NTQ1MjkzOWE5 MWI1MTYxZDMwN2VjNTE2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRk Yi9pbmRleC1iYXNpY3Mtd29ya2Vycy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvc3Rv cmFnZS9pbmRleGVkZGIvaW5kZXgtYmFzaWNzLXdvcmtlcnMtZXhwZWN0ZWQudHh0CkBAIC0xNSw2 ICsxNSwxNCBAQCBQQVNTIFtXb3JrZXJdIHRyYW5zICE9PSBudWxsIGlzIHRydWUKIFtXb3JrZXJd IHN0b3JlLmNyZWF0ZUluZGV4KCdpbmRleE5hbWUnLCAneCcpCiBbV29ya2VyXSBzdG9yZS5jcmVh dGVJbmRleCgnaW5kZXhOYW1lMicsICd5Jywge3VuaXF1ZTogZmFsc2V9KQogW1dvcmtlcl0gc3Rv cmUuY3JlYXRlSW5kZXgoJ3pJbmRleCcsICd6Jywge3VuaXF1ZTogdHJ1ZX0pCitQQVNTIFtXb3Jr ZXJdIGluZGV4T2JqZWN0Mi51bmlxdWUgaXMgZmFsc2UKK1BBU1MgW1dvcmtlcl0gaW5kZXhPYmpl Y3QzLnVuaXF1ZSBpcyB0cnVlCitbV29ya2VyXSBFeHBlY3RpbmcgVHlwZUVycm9yIGV4Y2VwdGlv biBmcm9tIHN0b3JlLmNyZWF0ZUluZGV4KCdmYWlsdXJlSW5kZXgnLCAnenp6JywgdHJ1ZSkKK1BB U1MgW1dvcmtlcl0gRXhjZXB0aW9uIHdhcyB0aHJvd24uCitQQVNTIFtXb3JrZXJdIHN0b3JlLmNy ZWF0ZUluZGV4KCdmYWlsdXJlSW5kZXgnLCAnenp6JywgdHJ1ZSkgdGhyZXcgVHlwZUVycm9yOiBO b3QgYW4gb2JqZWN0LgorW1dvcmtlcl0gRXhwZWN0aW5nIFR5cGVFcnJvciBleGNlcHRpb24gZnJv bSBzdG9yZS5jcmVhdGVJbmRleCgnZmFpbHVyZUluZGV4JywgJ3p6eicsICdzdHJpbmcnKQorUEFT UyBbV29ya2VyXSBFeGNlcHRpb24gd2FzIHRocm93bi4KK1BBU1MgW1dvcmtlcl0gc3RvcmUuY3Jl YXRlSW5kZXgoJ2ZhaWx1cmVJbmRleCcsICd6enonLCAnc3RyaW5nJykgdGhyZXcgVHlwZUVycm9y OiBOb3QgYW4gb2JqZWN0LgogUEFTUyBbV29ya2VyXSAnbmFtZScgaW4gaW5kZXhPYmplY3QgaXMg dHJ1ZQogUEFTUyBbV29ya2VyXSBpbmRleE9iamVjdC5uYW1lIGlzICJpbmRleE5hbWUiCiBQQVNT IFtXb3JrZXJdICdvYmplY3RTdG9yZScgaW4gaW5kZXhPYmplY3QgaXMgdHJ1ZQpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvcmVzb3VyY2VzL2luZGV4LWJhc2ljcy5q cyBiL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL3Jlc291cmNlcy9pbmRleC1iYXNpY3Mu anMKaW5kZXggYzJkZWM2NjA2NDIzNWI1ZDU2MTUzYjhjN2JlYzRiNzU3OGFkNTNjNi4uMDFkNTk1 YTNiOWU0NDExNzU1ZGY0YmE4OTI0YTM2MmY3MTY1YTI5NyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvc3RvcmFnZS9pbmRleGVkZGIvcmVzb3VyY2VzL2luZGV4LWJhc2ljcy5qcworKysgYi9MYXlv dXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9yZXNvdXJjZXMvaW5kZXgtYmFzaWNzLmpzCkBAIC0z Nyw2ICszNywxMCBAQCBmdW5jdGlvbiBkZWxldGVFeGlzdGluZyhldnQpCiAgICAgc2VsZi5pbmRl eE9iamVjdCA9IGV2YWxBbmRMb2coInN0b3JlLmNyZWF0ZUluZGV4KCdpbmRleE5hbWUnLCAneCcp Iik7CiAgICAgc2VsZi5pbmRleE9iamVjdDIgPSBldmFsQW5kTG9nKCJzdG9yZS5jcmVhdGVJbmRl eCgnaW5kZXhOYW1lMicsICd5Jywge3VuaXF1ZTogZmFsc2V9KSIpOwogICAgIHNlbGYuaW5kZXhP YmplY3QzID0gZXZhbEFuZExvZygic3RvcmUuY3JlYXRlSW5kZXgoJ3pJbmRleCcsICd6Jywge3Vu aXF1ZTogdHJ1ZX0pIik7CisgICAgc2hvdWxkQmVGYWxzZSgiaW5kZXhPYmplY3QyLnVuaXF1ZSIp OworICAgIHNob3VsZEJlVHJ1ZSgiaW5kZXhPYmplY3QzLnVuaXF1ZSIpOworICAgIGV2YWxBbmRF eHBlY3RFeGNlcHRpb25DbGFzcygic3RvcmUuY3JlYXRlSW5kZXgoJ2ZhaWx1cmVJbmRleCcsICd6 enonLCB0cnVlKSIsICJUeXBlRXJyb3IiKTsKKyAgICBldmFsQW5kRXhwZWN0RXhjZXB0aW9uQ2xh c3MoInN0b3JlLmNyZWF0ZUluZGV4KCdmYWlsdXJlSW5kZXgnLCAnenp6JywgJ3N0cmluZycpIiwg IlR5cGVFcnJvciIpOwogICAgIGFkZERhdGEoKTsKIH0KIAo=