58459 2011-04-13 11:09:20 -0700 Exclude webkitGetUserMedia from the navigator-detached-no-crash test 2012-09-19 07:18:29 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 56586 56459 0 leandrogracia leandrogracia jianli steveblock oldest_to_newest 385017 0 leandrogracia 2011-04-13 11:09:20 -0700 Exclude the webkitGetUserMedia method from the test until it is supported by most platforms. Once this happens, the expected behaviour for this method is to throw an exception when invoked with no arguments. 385023 1 89408 leandrogracia 2011-04-13 11:15:15 -0700 Created attachment 89408 Patch 385036 2 89408 jianli 2011-04-13 11:25:30 -0700 Comment on attachment 89408 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89408&action=review > LayoutTests/fast/dom/navigator-detached-no-crash.html:56 > + if (p != 'webkitGetUserMedia') { // Don't include the Media Stream API functions until most platforms have support. Can you combine this logic with the existing check for "geolocation" into some common check? Maybe you can keep an excluding list and check this list in for loop. 385053 3 89412 leandrogracia 2011-04-13 11:35:32 -0700 Created attachment 89412 Patch 385054 4 89408 leandrogracia 2011-04-13 11:35:52 -0700 Comment on attachment 89408 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89408&action=review >> LayoutTests/fast/dom/navigator-detached-no-crash.html:56 >> + if (p != 'webkitGetUserMedia') { // Don't include the Media Stream API functions until most platforms have support. > > Can you combine this logic with the existing check for "geolocation" into some common check? Maybe you can keep an excluding list and check this list in for loop. Fixed. 385065 5 89412 jianli 2011-04-13 11:41:46 -0700 Comment on attachment 89412 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89412&action=review > LayoutTests/fast/dom/navigator-detached-no-crash.html:55 > + if (p != 'geolocation' && p != 'webkitGetUserMedia') { // Don't include Geolocation or the Media Stream API functions until most platforms have support. Better to use early return, like: if (p == 'geolocation' || p == 'webkitGetUserMedia') //... continue; ... 385069 6 89417 leandrogracia 2011-04-13 11:45:18 -0700 Created attachment 89417 Patch 385071 7 89412 leandrogracia 2011-04-13 11:45:34 -0700 Comment on attachment 89412 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89412&action=review >> LayoutTests/fast/dom/navigator-detached-no-crash.html:55 >> + if (p != 'geolocation' && p != 'webkitGetUserMedia') { // Don't include Geolocation or the Media Stream API functions until most platforms have support. > > Better to use early return, like: > if (p == 'geolocation' || p == 'webkitGetUserMedia') //... > continue; > ... Fixed. 385121 8 jianli 2011-04-13 12:09:28 -0700 Committed as https://trac.webkit.org/changeset/83754. 89408 2011-04-13 11:15:15 -0700 2011-04-13 11:35:52 -0700 Patch bug-58459-20110413191513.patch text/plain 2047 leandrogracia U3VidmVyc2lvbiBSZXZpc2lvbjogODM3NDkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAwNWI5ZTZlYWYzZjIzNmE5NmM1Yjgx MGNiZDRkNjZiOWY4MGI2OGQwLi5hNjE2ZmZjMGFlYmM0MGY2ZTViN2FhMDI0MTNhZmQ4MmI2NmEz ZjcxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDQtMTMgIExlYW5kcm8gR3JhY2lhIEdp bCAgPGxlYW5kcm9ncmFjaWFAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEV4Y2x1ZGUgd2Via2l0R2V0VXNlck1lZGlhIGZyb20g dGhlIG5hdmlnYXRvci1kZXRhY2hlZC1uby1jcmFzaCB0ZXN0LgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTg0NTkKKworICAgICAgICBFeGNsdWRlIHRo ZSBNZWRpYVN0cmVhbSBBUEkgbWV0aG9kcyBmcm9tIHRoZSB0ZXN0IHVudGlsIHRoZSBmZWF0dXJl CisgICAgICAgIGlzIHN1cHBvcnRlZCBieSBtb3N0IHBsYXRmb3Jtcy4KKworICAgICAgICAqIGZh c3QvZG9tL25hdmlnYXRvci1kZXRhY2hlZC1uby1jcmFzaC5odG1sOgorCiAyMDExLTA0LTEyICBQ YXZlbCBQb2Rpdmlsb3YgIDxwb2Rpdmlsb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IFBhdmVsIEZlbGRtYW4uCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9u YXZpZ2F0b3ItZGV0YWNoZWQtbm8tY3Jhc2guaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL25h dmlnYXRvci1kZXRhY2hlZC1uby1jcmFzaC5odG1sCmluZGV4IDlhMTcwNmEyYTNkMTBmZGU2Y2Zm MGVhNjY2ZWFjOTI0OTI5NWNkOWQuLmE4Y2VlNDNkOTBjNDVlNjhhMWVjMjk0YWU0NDJlNjc5M2Vi ZmYyZDEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL25hdmlnYXRvci1kZXRhY2hl ZC1uby1jcmFzaC5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL25hdmlnYXRvci1kZXRh Y2hlZC1uby1jcmFzaC5odG1sCkBAIC01MywxMyArNTMsMTUgQEAgZnVuY3Rpb24gY2hlY2tfbmF2 aWdhdG9yKCkgewogICB2YXIgc3RyaW5ncyA9IFsgXTsKICAgZm9yIChwIGluIG9sZF9uYXYpIHsK ICAgICBpZiAodHlwZW9mIG9sZF9uYXZbcF0gPT0gJ2Z1bmN0aW9uJykgewotICAgICAgdHJ5IHsK LSAgICAgICAgdmFyIHYgPSBvbGRfbmF2W3BdKCk7Ci0gICAgICAgIC8vIG5vIGNyYXNoLCBpdCBp cyBvawotICAgICAgICBzdHJpbmdzLnB1c2goIm5hdmlnYXRvci4iK3ArIigpIGlzIE9LIik7Ci0g ICAgICB9IGNhdGNoKGVycikgewotICAgICAgICAvLyBuYXZpZ2F0b3IucmVnaXN0ZXJYWFggd2ls bCB0aHJvdyBvbiBpbnZhbGlkIGlucHV0LgotICAgICAgICBzdHJpbmdzLnB1c2goIm5hdmlnYXRv ci4iK3ArIigpIHRocmV3IGVyciAiK2Vycik7CisgICAgICBpZiAocCAhPSAnd2Via2l0R2V0VXNl ck1lZGlhJykgeyAvLyBEb24ndCBpbmNsdWRlIHRoZSBNZWRpYSBTdHJlYW0gQVBJIGZ1bmN0aW9u cyB1bnRpbCBtb3N0IHBsYXRmb3JtcyBoYXZlIHN1cHBvcnQuCisgICAgICAgIHRyeSB7CisgICAg ICAgICAgdmFyIHYgPSBvbGRfbmF2W3BdKCk7CisgICAgICAgICAgLy8gbm8gY3Jhc2gsIGl0IGlz IG9rCisgICAgICAgICAgc3RyaW5ncy5wdXNoKCJuYXZpZ2F0b3IuIitwKyIoKSBpcyBPSyIpOwor ICAgICAgICB9IGNhdGNoKGVycikgeworICAgICAgICAgIC8vIG5hdmlnYXRvci5yZWdpc3RlclhY WCB3aWxsIHRocm93IG9uIGludmFsaWQgaW5wdXQuCisgICAgICAgICAgc3RyaW5ncy5wdXNoKCJu YXZpZ2F0b3IuIitwKyIoKSB0aHJldyBlcnIgIitlcnIpOworICAgICAgICB9CiAgICAgICB9CiAg ICAgfSBlbHNlIHsKICAgICAgIGlmIChwICE9ICJnZW9sb2NhdGlvbiIpIHsgLy8gRG9uJ3QgaW5j bHVkZSBnZW9sb2NhdGlvbiB1bnRpbCBtb3N0IHBsYXRmb3JtcyBoYXZlIHN1cHBvcnQuCg== 89412 2011-04-13 11:35:32 -0700 2011-04-13 11:45:34 -0700 Patch bug-58459-20110413193530.patch text/plain 2292 leandrogracia U3VidmVyc2lvbiBSZXZpc2lvbjogODM3NDkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAwNWI5ZTZlYWYzZjIzNmE5NmM1Yjgx MGNiZDRkNjZiOWY4MGI2OGQwLi5hNjE2ZmZjMGFlYmM0MGY2ZTViN2FhMDI0MTNhZmQ4MmI2NmEz ZjcxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDQtMTMgIExlYW5kcm8gR3JhY2lhIEdp bCAgPGxlYW5kcm9ncmFjaWFAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEV4Y2x1ZGUgd2Via2l0R2V0VXNlck1lZGlhIGZyb20g dGhlIG5hdmlnYXRvci1kZXRhY2hlZC1uby1jcmFzaCB0ZXN0LgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTg0NTkKKworICAgICAgICBFeGNsdWRlIHRo ZSBNZWRpYVN0cmVhbSBBUEkgbWV0aG9kcyBmcm9tIHRoZSB0ZXN0IHVudGlsIHRoZSBmZWF0dXJl CisgICAgICAgIGlzIHN1cHBvcnRlZCBieSBtb3N0IHBsYXRmb3Jtcy4KKworICAgICAgICAqIGZh c3QvZG9tL25hdmlnYXRvci1kZXRhY2hlZC1uby1jcmFzaC5odG1sOgorCiAyMDExLTA0LTEyICBQ YXZlbCBQb2Rpdmlsb3YgIDxwb2Rpdmlsb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IFBhdmVsIEZlbGRtYW4uCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9u YXZpZ2F0b3ItZGV0YWNoZWQtbm8tY3Jhc2guaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL25h dmlnYXRvci1kZXRhY2hlZC1uby1jcmFzaC5odG1sCmluZGV4IDlhMTcwNmEyYTNkMTBmZGU2Y2Zm MGVhNjY2ZWFjOTI0OTI5NWNkOWQuLjE1MzMwOGNkMGNhYzUzMzU1ZmYwZjAyYWRlZDdhN2ZlM2Q5 ODZiNGIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL25hdmlnYXRvci1kZXRhY2hl ZC1uby1jcmFzaC5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL25hdmlnYXRvci1kZXRh Y2hlZC1uby1jcmFzaC5odG1sCkBAIC01MiwxNyArNTIsMTcgQEAgZnVuY3Rpb24gY2hlY2tfbmF2 aWdhdG9yX2FuZF9kb25lKCkgewogZnVuY3Rpb24gY2hlY2tfbmF2aWdhdG9yKCkgewogICB2YXIg c3RyaW5ncyA9IFsgXTsKICAgZm9yIChwIGluIG9sZF9uYXYpIHsKLSAgICBpZiAodHlwZW9mIG9s ZF9uYXZbcF0gPT0gJ2Z1bmN0aW9uJykgewotICAgICAgdHJ5IHsKLSAgICAgICAgdmFyIHYgPSBv bGRfbmF2W3BdKCk7Ci0gICAgICAgIC8vIG5vIGNyYXNoLCBpdCBpcyBvawotICAgICAgICBzdHJp bmdzLnB1c2goIm5hdmlnYXRvci4iK3ArIigpIGlzIE9LIik7Ci0gICAgICB9IGNhdGNoKGVycikg ewotICAgICAgICAvLyBuYXZpZ2F0b3IucmVnaXN0ZXJYWFggd2lsbCB0aHJvdyBvbiBpbnZhbGlk IGlucHV0LgotICAgICAgICBzdHJpbmdzLnB1c2goIm5hdmlnYXRvci4iK3ArIigpIHRocmV3IGVy ciAiK2Vycik7Ci0gICAgICB9Ci0gICAgfSBlbHNlIHsKLSAgICAgIGlmIChwICE9ICJnZW9sb2Nh dGlvbiIpIHsgLy8gRG9uJ3QgaW5jbHVkZSBnZW9sb2NhdGlvbiB1bnRpbCBtb3N0IHBsYXRmb3Jt cyBoYXZlIHN1cHBvcnQuCisgICAgaWYgKHAgIT0gJ2dlb2xvY2F0aW9uJyAmJiBwICE9ICd3ZWJr aXRHZXRVc2VyTWVkaWEnKSB7IC8vIERvbid0IGluY2x1ZGUgR2VvbG9jYXRpb24gb3IgdGhlIE1l ZGlhIFN0cmVhbSBBUEkgZnVuY3Rpb25zIHVudGlsIG1vc3QgcGxhdGZvcm1zIGhhdmUgc3VwcG9y dC4KKyAgICAgIGlmICh0eXBlb2Ygb2xkX25hdltwXSA9PSAnZnVuY3Rpb24nKSB7CisgICAgICAg IHRyeSB7CisgICAgICAgICAgdmFyIHYgPSBvbGRfbmF2W3BdKCk7CisgICAgICAgICAgLy8gbm8g Y3Jhc2gsIGl0IGlzIG9rCisgICAgICAgICAgc3RyaW5ncy5wdXNoKCJuYXZpZ2F0b3IuIitwKyIo KSBpcyBPSyIpOworICAgICAgICB9IGNhdGNoKGVycikgeworICAgICAgICAgIC8vIG5hdmlnYXRv ci5yZWdpc3RlclhYWCB3aWxsIHRocm93IG9uIGludmFsaWQgaW5wdXQuCisgICAgICAgICAgc3Ry aW5ncy5wdXNoKCJuYXZpZ2F0b3IuIitwKyIoKSB0aHJldyBlcnIgIitlcnIpOworICAgICAgICB9 CisgICAgICB9IGVsc2UgewogICAgICAgICB2YXIgdiA9IG9sZF9uYXZbcF07CiAgICAgICAgIC8v IG5vIGNyYXNoLCBpdCBpcyBvay4KICAgICAgICAgc3RyaW5ncy5wdXNoKCJuYXZpZ2F0b3IuIitw KyIgaXMgT0siKTsK 89417 2011-04-13 11:45:18 -0700 2011-04-13 12:08:24 -0700 Patch bug-58459-20110413194516.patch text/plain 1976 leandrogracia U3VidmVyc2lvbiBSZXZpc2lvbjogODM3NTAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAwNWI5ZTZlYWYzZjIzNmE5NmM1Yjgx MGNiZDRkNjZiOWY4MGI2OGQwLi5hNjE2ZmZjMGFlYmM0MGY2ZTViN2FhMDI0MTNhZmQ4MmI2NmEz ZjcxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDQtMTMgIExlYW5kcm8gR3JhY2lhIEdp bCAgPGxlYW5kcm9ncmFjaWFAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEV4Y2x1ZGUgd2Via2l0R2V0VXNlck1lZGlhIGZyb20g dGhlIG5hdmlnYXRvci1kZXRhY2hlZC1uby1jcmFzaCB0ZXN0LgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTg0NTkKKworICAgICAgICBFeGNsdWRlIHRo ZSBNZWRpYVN0cmVhbSBBUEkgbWV0aG9kcyBmcm9tIHRoZSB0ZXN0IHVudGlsIHRoZSBmZWF0dXJl CisgICAgICAgIGlzIHN1cHBvcnRlZCBieSBtb3N0IHBsYXRmb3Jtcy4KKworICAgICAgICAqIGZh c3QvZG9tL25hdmlnYXRvci1kZXRhY2hlZC1uby1jcmFzaC5odG1sOgorCiAyMDExLTA0LTEyICBQ YXZlbCBQb2Rpdmlsb3YgIDxwb2Rpdmlsb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IFBhdmVsIEZlbGRtYW4uCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9u YXZpZ2F0b3ItZGV0YWNoZWQtbm8tY3Jhc2guaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL25h dmlnYXRvci1kZXRhY2hlZC1uby1jcmFzaC5odG1sCmluZGV4IDlhMTcwNmEyYTNkMTBmZGU2Y2Zm MGVhNjY2ZWFjOTI0OTI5NWNkOWQuLjIwYjFiNmIzOTc3ODA2NjFiNzI3OWNiMTgzNDg2NmY2Mjc5 NzQxNDcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL25hdmlnYXRvci1kZXRhY2hl ZC1uby1jcmFzaC5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL25hdmlnYXRvci1kZXRh Y2hlZC1uby1jcmFzaC5odG1sCkBAIC01Miw2ICs1Miw5IEBAIGZ1bmN0aW9uIGNoZWNrX25hdmln YXRvcl9hbmRfZG9uZSgpIHsKIGZ1bmN0aW9uIGNoZWNrX25hdmlnYXRvcigpIHsKICAgdmFyIHN0 cmluZ3MgPSBbIF07CiAgIGZvciAocCBpbiBvbGRfbmF2KSB7CisgICAgaWYgKHAgPT0gJ2dlb2xv Y2F0aW9uJyB8fCBwID09ICd3ZWJraXRHZXRVc2VyTWVkaWEnKSAvLyBEb24ndCBpbmNsdWRlIEdl b2xvY2F0aW9uIG9yIHRoZSBNZWRpYSBTdHJlYW0gQVBJIGZ1bmN0aW9ucyB1bnRpbCBtb3N0IHBs YXRmb3JtcyBoYXZlIHN1cHBvcnQuCisgICAgICBjb250aW51ZTsKKwogICAgIGlmICh0eXBlb2Yg b2xkX25hdltwXSA9PSAnZnVuY3Rpb24nKSB7CiAgICAgICB0cnkgewogICAgICAgICB2YXIgdiA9 IG9sZF9uYXZbcF0oKTsKQEAgLTYyLDExICs2NSw5IEBAIGZ1bmN0aW9uIGNoZWNrX25hdmlnYXRv cigpIHsKICAgICAgICAgc3RyaW5ncy5wdXNoKCJuYXZpZ2F0b3IuIitwKyIoKSB0aHJldyBlcnIg IitlcnIpOwogICAgICAgfQogICAgIH0gZWxzZSB7Ci0gICAgICBpZiAocCAhPSAiZ2VvbG9jYXRp b24iKSB7IC8vIERvbid0IGluY2x1ZGUgZ2VvbG9jYXRpb24gdW50aWwgbW9zdCBwbGF0Zm9ybXMg aGF2ZSBzdXBwb3J0LgotICAgICAgICB2YXIgdiA9IG9sZF9uYXZbcF07Ci0gICAgICAgIC8vIG5v IGNyYXNoLCBpdCBpcyBvay4KLSAgICAgICAgc3RyaW5ncy5wdXNoKCJuYXZpZ2F0b3IuIitwKyIg aXMgT0siKTsKLSAgICAgIH0KKyAgICAgIHZhciB2ID0gb2xkX25hdltwXTsKKyAgICAgIC8vIG5v IGNyYXNoLCBpdCBpcyBvay4KKyAgICAgIHN0cmluZ3MucHVzaCgibmF2aWdhdG9yLiIrcCsiIGlz IE9LIik7CiAgICAgfQogICB9CiAgIHN0cmluZ3Muc29ydCgpOwo=