58341 2011-04-12 10:13:43 -0700 Improve media controls state management code by using CSS selectors 2014-10-22 10:31:41 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC OS X 10.5 NEW P2 Normal --- 58342 58345 1 dglazkov webkit-unassigned eric.carlson sjl oldest_to_newest 384094 0 dglazkov 2011-04-12 10:13:43 -0700 Today, the code in media controls explicitly sets inline styles on specific controls to hide or show them. This can be completely eliminated if we instead manipulate state using DOM attributes. For example, if a network error occurs, we can set "disabled" attribute on the timeline control, and then specify in mediaControls.css: video::-webkit-media-controls-timeline:disabled { display: none; } Unfortunately, this is not immediately possible due to a restriction on how CSS selectors can be combined: the pseudo-element selector must always be the last one. Otherwise, the selector is deemed invalid. Hyatt suggested that we relax this requirement, much the same way we relaxed it to allow scrollbar styling.