58289 2011-04-11 17:01:59 -0700 On Solaris 10 with SS12 compiler, TCMalloc_PageHeap::runScavengerThread(void* context) is expected to return a value 2011-04-11 22:40:30 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Other RESOLVED FIXED P2 Normal --- 0 bentaylor.solx86 webkit-unassigned commit-queue webkit.review.bot oldest_to_newest 383688 0 bentaylor.solx86 2011-04-11 17:01:59 -0700 wtf/FastMalloc.cpp fails to compile on Solaris 10 with SS12 C++ compiler with the following error: "wtf/FastMalloc.cpp", line 1502: Error: "static WTF::TCMalloc_PageHeap::runScavengerThread(void*)" is expected to return a value. 383737 1 89138 bentaylor.solx86 2011-04-11 18:18:56 -0700 Created attachment 89138 Patch to fix compile issue with Solaris 10 and Studio 12 CC, this code expects to return a value. Patch to fix the compile issue on Solaris 10 with Sun Studio 12 CC 383739 2 webkit.review.bot 2011-04-11 18:21:30 -0700 Attachment 89138 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/wtf/FastMalloc.cpp:1623: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 383747 3 89141 bentaylor.solx86 2011-04-11 18:31:39 -0700 Created attachment 89141 Updated patch that fixes the currently broken white space issue. Note to self. Simple fixes - run check-webkit-style. Missed the 2-space indent originally in the source. 383787 4 89150 bentaylor.solx86 2011-04-11 20:23:48 -0700 Created attachment 89150 Updated patch that fixes the currently broken white space issue, and trailing ) Fixed now. 383795 5 89152 bentaylor.solx86 2011-04-11 20:48:46 -0700 Created attachment 89152 patch that fixes the issues, and passes check-webkit-style locally This should do it. 383813 6 89152 ap 2011-04-11 22:04:28 -0700 Comment on attachment 89152 patch that fixes the issues, and passes check-webkit-style locally Honestly, I don't understand why we don't just always have this "return 0". +#if (COMPILER(MSVC) || COMPILER(SUNCC)) Unneeded parentheses here. 383823 7 commit-queue 2011-04-11 22:38:04 -0700 The commit-queue encountered the following flaky tests while processing attachment 89152: java/lc3/JavaObject/JavaObjectToInt-002-n.html bug 58299 (author: ap@webkit.org) The commit-queue is continuing to process your patch. 383825 8 89152 commit-queue 2011-04-11 22:40:23 -0700 Comment on attachment 89152 patch that fixes the issues, and passes check-webkit-style locally Clearing flags on attachment: 89152 Committed r83557: <http://trac.webkit.org/changeset/83557> 383826 9 commit-queue 2011-04-11 22:40:30 -0700 All reviewed patches have been landed. Closing bug. 89138 2011-04-11 18:18:56 -0700 2011-04-11 18:31:39 -0700 Patch to fix compile issue with Solaris 10 and Studio 12 CC, this code expects to return a value. webkit-bug-58289-Solaris-10-compile-fix.diff text/plain 1406 bentaylor.solx86 SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODM1MzkpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTEtMDQtMTEgIEJlbiBUYXlsb3IgIDxiZW50YXlsb3Iuc29seDg2QGdtYWlsLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTgyODkKKworICAgICAgICBGaXggY29tcGls YXRpb24gb24gU29sYXJpcy9TdHVkaW8gMTIgQysrIGluIHd0Zi9GYXN0TWFsbG9jLmNwcCwKKyAg ICAgICAgV1RGOjpUQ01hbGxvY19QYWdlSGVhcDo6cnVuU2NhdmVuZ2VyVGhyZWFkKHZvaWQqKSBl eHBlY3RlZCB0byByZXR1cm4gYSB2YWx1ZS4KKworICAgICAgICAqIHd0Zi9GYXN0TWFsbG9jLmNw cDoKKyAgICAgICAgKFdURjo6VENNYWxsb2NfUGFnZUhlYXA6OnJ1blNjYXZlbmdlclRocmVhZCk6 CisKIDIwMTEtMDQtMTEgIE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNvbT4KIAogICAgICAgICBG aXggdGhlIGJ1aWxkLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9GYXN0TWFsbG9j LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0Zhc3RNYWxsb2Mu Y3BwCShyZXZpc2lvbiA4MzM3MikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvRmFzdE1h bGxvYy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE2MTksOCArMTYxOSw4IEBAIHZvaWQgVENNYWxs b2NfUGFnZUhlYXA6OmluaXRpYWxpemVTY2F2ZW4KIHZvaWQqIFRDTWFsbG9jX1BhZ2VIZWFwOjpy dW5TY2F2ZW5nZXJUaHJlYWQodm9pZCogY29udGV4dCkKIHsKICAgc3RhdGljX2Nhc3Q8VENNYWxs b2NfUGFnZUhlYXAqPihjb250ZXh0KS0+c2NhdmVuZ2VyVGhyZWFkKCk7Ci0jaWYgQ09NUElMRVIo TVNWQykKLSAgLy8gV2l0aG91dCB0aGlzLCBWaXN1YWwgU3R1ZGlvIHdpbGwgY29tcGxhaW4gdGhh dCB0aGlzIG1ldGhvZCBkb2VzIG5vdCByZXR1cm4gYSB2YWx1ZS4KKyNpZiAoQ09NUElMRVIoTVNW QykgfHwgQ09NUElMRVIoU1VOQ0MpKQorICAvLyBXaXRob3V0IHRoaXMsIFZpc3VhbCBTdHVkaW8g YW5kIFN1biBTdHVkaW8gd2lsbCBjb21wbGFpbiB0aGF0IHRoaXMgbWV0aG9kIGRvZXMgbm90IHJl dHVybiBhIHZhbHVlLgogICByZXR1cm4gMDsKICNlbmRpZgogfQo= 89141 2011-04-11 18:31:39 -0700 2011-04-11 20:23:48 -0700 Updated patch that fixes the currently broken white space issue. webkit-bug-58289-Solaris-10-compile-fix.diff text/plain 1440 bentaylor.solx86 SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODM1MzkpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTEtMDQtMTEgIEJlbiBUYXlsb3IgIDxiZW50YXlsb3Iuc29seDg2QGdtYWlsLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTgyODkKKworICAgICAgICBGaXggY29tcGls YXRpb24gb24gU29sYXJpcy9TdHVkaW8gMTIgQysrIGluIHd0Zi9GYXN0TWFsbG9jLmNwcCwKKyAg ICAgICAgV1RGOjpUQ01hbGxvY19QYWdlSGVhcDo6cnVuU2NhdmVuZ2VyVGhyZWFkKHZvaWQqKSBl eHBlY3RlZCB0byByZXR1cm4gYSB2YWx1ZS4KKworICAgICAgICAqIHd0Zi9GYXN0TWFsbG9jLmNw cDoKKyAgICAgICAgKFdURjo6VENNYWxsb2NfUGFnZUhlYXA6OnJ1blNjYXZlbmdlclRocmVhZCk6 CisKIDIwMTEtMDQtMTEgIE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNvbT4KIAogICAgICAgICBG aXggdGhlIGJ1aWxkLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9GYXN0TWFsbG9j LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0Zhc3RNYWxsb2Mu Y3BwCShyZXZpc2lvbiA4MzM3MikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvRmFzdE1h bGxvYy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE2MTgsMTAgKzE2MTgsMTAgQEAKCiB2b2lkKiBU Q01hbGxvY19QYWdlSGVhcDo6cnVuU2NhdmVuZ2VyVGhyZWFkKHZvaWQqIGNvbnRleHQpCiB7Ci0g IHN0YXRpY19jYXN0PFRDTWFsbG9jX1BhZ2VIZWFwKj4oY29udGV4dCktPnNjYXZlbmdlclRocmVh ZCgpOwotI2lmIENPTVBJTEVSKE1TVkMpCi0gIC8vIFdpdGhvdXQgdGhpcywgVmlzdWFsIFN0dWRp byB3aWxsIGNvbXBsYWluIHRoYXQgdGhpcyBtZXRob2QgZG9lcyBub3QgcmV0dXJuIGEgdmFsdWUu Ci0gIHJldHVybiAwOworICAgIHN0YXRpY19jYXN0PFRDTWFsbG9jX1BhZ2VIZWFwKj4oY29udGV4 dCktPnNjYXZlbmdlclRocmVhZCgpOworI2lmIChDT01QSUxFUihNU1ZDKSB8fCBDT01QSUxFUihT VU5DQykKKyAgICAvLyBXaXRob3V0IHRoaXMsIFZpc3VhbCBTdHVkaW8gYW5kIFN1biBTdHVkaW8g d2lsbCBjb21wbGFpbiB0aGF0IHRoaXMgbWV0aG9kIGRvZXMgbm90IHJldHVybiBhIHZhbHVlLgor ICAgIHJldHVybiAwOwoK 89150 2011-04-11 20:23:48 -0700 2011-04-11 20:48:46 -0700 Updated patch that fixes the currently broken white space issue, and trailing ) webkit-bug-58289-Solaris-10-compile-fix.diff text/plain 1441 bentaylor.solx86 SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODM1MzkpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTEtMDQtMTEgIEJlbiBUYXlsb3IgIDxiZW50YXlsb3Iuc29seDg2QGdtYWlsLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTgyODkKKworICAgICAgICBGaXggY29tcGls YXRpb24gb24gU29sYXJpcy9TdHVkaW8gMTIgQysrIGluIHd0Zi9GYXN0TWFsbG9jLmNwcCwKKyAg ICAgICAgV1RGOjpUQ01hbGxvY19QYWdlSGVhcDo6cnVuU2NhdmVuZ2VyVGhyZWFkKHZvaWQqKSBl eHBlY3RlZCB0byByZXR1cm4gYSB2YWx1ZS4KKworICAgICAgICAqIHd0Zi9GYXN0TWFsbG9jLmNw cDoKKyAgICAgICAgKFdURjo6VENNYWxsb2NfUGFnZUhlYXA6OnJ1blNjYXZlbmdlclRocmVhZCk6 CisKIDIwMTEtMDQtMTEgIE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNvbT4KIAogICAgICAgICBG aXggdGhlIGJ1aWxkLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9GYXN0TWFsbG9j LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0Zhc3RNYWxsb2Mu Y3BwCShyZXZpc2lvbiA4MzM3MikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvRmFzdE1h bGxvYy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE2MTgsMTAgKzE2MTgsMTAgQEAKCiB2b2lkKiBU Q01hbGxvY19QYWdlSGVhcDo6cnVuU2NhdmVuZ2VyVGhyZWFkKHZvaWQqIGNvbnRleHQpCiB7Ci0g IHN0YXRpY19jYXN0PFRDTWFsbG9jX1BhZ2VIZWFwKj4oY29udGV4dCktPnNjYXZlbmdlclRocmVh ZCgpOwotI2lmIENPTVBJTEVSKE1TVkMpCi0gIC8vIFdpdGhvdXQgdGhpcywgVmlzdWFsIFN0dWRp byB3aWxsIGNvbXBsYWluIHRoYXQgdGhpcyBtZXRob2QgZG9lcyBub3QgcmV0dXJuIGEgdmFsdWUu Ci0gIHJldHVybiAwOworICAgIHN0YXRpY19jYXN0PFRDTWFsbG9jX1BhZ2VIZWFwKj4oY29udGV4 dCktPnNjYXZlbmdlclRocmVhZCgpOworI2lmIChDT01QSUxFUihNU1ZDKSB8fCBDT01QSUxFUihT VU5DQykpCisgICAgLy8gV2l0aG91dCB0aGlzLCBWaXN1YWwgU3R1ZGlvIGFuZCBTdW4gU3R1ZGlv IHdpbGwgY29tcGxhaW4gdGhhdCB0aGlzIG1ldGhvZCBkb2VzIG5vdCByZXR1cm4gYSB2YWx1ZS4K KyAgICByZXR1cm4gMDsKCg== 89152 2011-04-11 20:48:46 -0700 2011-04-11 22:40:23 -0700 patch that fixes the issues, and passes check-webkit-style locally webkit-bug-58289-Solaris-10-compile-fix.diff text/plain 1495 bentaylor.solx86 SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODM1MzkpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTEtMDQtMTEgIEJlbiBUYXlsb3IgIDxiZW50YXlsb3Iuc29seDg2QGdtYWlsLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTgyODkKKworICAgICAgICBGaXggY29tcGls YXRpb24gb24gU29sYXJpcy9TdHVkaW8gMTIgQysrIGluIHd0Zi9GYXN0TWFsbG9jLmNwcCwKKyAg ICAgICAgV1RGOjpUQ01hbGxvY19QYWdlSGVhcDo6cnVuU2NhdmVuZ2VyVGhyZWFkKHZvaWQqKSBl eHBlY3RlZCB0byByZXR1cm4gYSB2YWx1ZS4KKworICAgICAgICAqIHd0Zi9GYXN0TWFsbG9jLmNw cDoKKyAgICAgICAgKFdURjo6VENNYWxsb2NfUGFnZUhlYXA6OnJ1blNjYXZlbmdlclRocmVhZCk6 CisKIDIwMTEtMDQtMTEgIE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNvbT4KIAogICAgICAgICBG aXggdGhlIGJ1aWxkLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9GYXN0TWFsbG9j LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0Zhc3RNYWxsb2Mu Y3BwCShyZXZpc2lvbiA4MzM3MikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvRmFzdE1h bGxvYy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE2MTgsMTAgKzE2MTgsMTAgQEAgdm9pZCBUQ01h bGxvY19QYWdlSGVhcDo6aW5pdGlhbGl6ZVNjYXZlbgogCiB2b2lkKiBUQ01hbGxvY19QYWdlSGVh cDo6cnVuU2NhdmVuZ2VyVGhyZWFkKHZvaWQqIGNvbnRleHQpCiB7Ci0gIHN0YXRpY19jYXN0PFRD TWFsbG9jX1BhZ2VIZWFwKj4oY29udGV4dCktPnNjYXZlbmdlclRocmVhZCgpOwotI2lmIENPTVBJ TEVSKE1TVkMpCi0gIC8vIFdpdGhvdXQgdGhpcywgVmlzdWFsIFN0dWRpbyB3aWxsIGNvbXBsYWlu IHRoYXQgdGhpcyBtZXRob2QgZG9lcyBub3QgcmV0dXJuIGEgdmFsdWUuCi0gIHJldHVybiAwOwor ICAgIHN0YXRpY19jYXN0PFRDTWFsbG9jX1BhZ2VIZWFwKj4oY29udGV4dCktPnNjYXZlbmdlclRo cmVhZCgpOworI2lmIChDT01QSUxFUihNU1ZDKSB8fCBDT01QSUxFUihTVU5DQykpCisgICAgLy8g V2l0aG91dCB0aGlzLCBWaXN1YWwgU3R1ZGlvIGFuZCBTdW4gU3R1ZGlvIHdpbGwgY29tcGxhaW4g dGhhdCB0aGlzIG1ldGhvZCBkb2VzIG5vdCByZXR1cm4gYSB2YWx1ZS4KKyAgICByZXR1cm4gMDsK ICNlbmRpZgogfQogCg==