58204 2011-04-10 09:34:10 -0700 REGRESSION(r83397): Most GTK media controls are hidden when no valid source is specified 2011-04-11 09:33:02 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 53020 1 dglazkov dglazkov alex commit-queue eric.carlson mrobinson pnormand oldest_to_newest 382895 0 dglazkov 2011-04-10 09:34:10 -0700 http://build.webkit.org/results/GTK%20Linux%2032-bit%20Release/r83398%20(12578)/media/video-empty-source-pretty-diff.html Fixing... 382938 1 88959 dglazkov 2011-04-10 14:59:49 -0700 Created attachment 88959 Patch 382941 2 eric.carlson 2011-04-10 15:19:31 -0700 I would r+ this, but I think it would be good to get buy-off from one of the GTK developers because it changes their <video> controller UI. 383114 3 pnormand 2011-04-11 05:28:24 -0700 Sorry I rebaselined the tests involved in this issue :( See http://trac.webkit.org/changeset/83431 I tested that patch locally and reverted my rebaseline (locally too). It seems that anyway the tests would need a rebaseline: --- /tmp/layout-test-results/media/video-no-audio-expected.txt 2011-04-11 14:27:13.000000000 +0200 +++ /tmp/layout-test-results/media/video-no-audio-actual.txt 2011-04-11 14:27:13.000000000 +0200 @@ -15,14 +15,15 @@ layer at (8,43) size 352x288 scrollHeight 298 RenderFlexibleBox (positioned) {DIV} at (0,0) size 352x288 RenderButton {INPUT} at (0,268) size 20x20 - RenderFlexibleBox {DIV} at (20,268) size 272x20 [border: (1px solid #FFFFFF33) none (1px solid #FFFFFF33)] + RenderFlexibleBox {DIV} at (20,268) size 252x20 [border: (1px solid #FFFFFF33) none (1px solid #FFFFFF33)] RenderBlock (anonymous) at (1,0) size 65x30 RenderFlexibleBox {DIV} at (0,0) size 65x30 RenderBlock (anonymous) at (5,5) size 55x20 RenderText {#text} at (0,0) size 55x12 text run at (0,0) width 55: "00:00 / 00:09" - RenderSlider {INPUT} at (66,0) size 205x20 + RenderSlider {INPUT} at (66,0) size 185x20 RenderBlock {DIV} at (2,4) size 12x12 + RenderButton {INPUT} at (272,268) size 20x20 RenderButton {INPUT} at (292,268) size 20x20 RenderButton {INPUT} at (312,268) size 20x20 RenderButton {INPUT} at (332,268) size 20x20 383186 4 88959 mrobinson 2011-04-11 08:51:11 -0700 Comment on attachment 88959 Patch Looks fine to me. 383216 5 88959 commit-queue 2011-04-11 09:32:56 -0700 Comment on attachment 88959 Patch Clearing flags on attachment: 88959 Committed r83445: <http://trac.webkit.org/changeset/83445> 383217 6 commit-queue 2011-04-11 09:33:02 -0700 All reviewed patches have been landed. Closing bug. 88959 2011-04-10 14:59:49 -0700 2011-04-11 09:32:56 -0700 Patch bug-58204-20110410145948.patch text/plain 1654 dglazkov U3VidmVyc2lvbiBSZXZpc2lvbjogODM0MDQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0ZDAzOTZhNzU5NzE2MmIx ZDhlYjM4ZTc0MDg4OTAyZDNhN2Q5MDBjLi5lMjlkZjY1NDE3M2NkOTkyMGJkZjYxMjBiYzdiNDg5 MzkzNjUxNGQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDQtMTAgIERpbWl0 cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSRUdSRVNTSU9OKHI4MzM5Nyk6IE1vc3QgR1RL IG1lZGlhIGNvbnRyb2xzIGFyZSBoaWRkZW4gd2hlbiBubyB2YWxpZCBzb3VyY2UgaXMgc3BlY2lm aWVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODIw NAorCisgICAgICAgIENvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGsuaDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1l R3RrOjpoYXNPd25EaXNhYmxlZFN0YXRlSGFuZGxpbmdGb3IpOiBMZXQgR1RLIGhhbmRsZQorICAg ICAgICAgICAgdGhlIHRoZSBzdGF0ZSBvZiBtZWRpYSBjb250cm9scy4KKwogMjAxMS0wNC0xMCAg UGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmll d2VkIGJ1aWxkIGZpeCBmb3IgIUVOQUJMRShYU0xUKSBhZnRlciByODI1NjIuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGsuaCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0ay5oCmluZGV4IDE5MWEzNGJhN2NmNDFh MDkwMzI2MjAxYzZjZTk5OWY5MjA2MWQxNjIuLjA5ZWIxZGY1ZTg1OWJhOGE3OGE2NTEwMzA3ZDU0 MWJiNTNlMTEwZTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5k ZXJUaGVtZUd0ay5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5kZXJUaGVt ZUd0ay5oCkBAIC0xNDcsNiArMTQ3LDcgQEAgcHJvdGVjdGVkOgogICAgIHZvaWQgaW5pdE1lZGlh Q29sb3JzKCk7CiAgICAgdm9pZCBpbml0TWVkaWFCdXR0b25zKCk7CiAgICAgdm9pZCBhZGp1c3RN ZWRpYVNsaWRlclRodW1iU2l6ZShSZW5kZXJPYmplY3QqKSBjb25zdDsKKyAgICB2aXJ0dWFsIGJv b2wgaGFzT3duRGlzYWJsZWRTdGF0ZUhhbmRsaW5nRm9yKENvbnRyb2xQYXJ0KSBjb25zdCB7IHJl dHVybiB0cnVlOyB9CiAgICAgdmlydHVhbCBib29sIHBhaW50TWVkaWFGdWxsc2NyZWVuQnV0dG9u KFJlbmRlck9iamVjdCosIGNvbnN0IFBhaW50SW5mbyYsIGNvbnN0IEludFJlY3QmKTsKICAgICB2 aXJ0dWFsIGJvb2wgcGFpbnRNZWRpYVBsYXlCdXR0b24oUmVuZGVyT2JqZWN0KiwgY29uc3QgUGFp bnRJbmZvJiwgY29uc3QgSW50UmVjdCYpOwogICAgIHZpcnR1YWwgYm9vbCBwYWludE1lZGlhTXV0 ZUJ1dHRvbihSZW5kZXJPYmplY3QqLCBjb25zdCBQYWludEluZm8mLCBjb25zdCBJbnRSZWN0Jik7 Cg==